Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/curl/config.m4 ext/curl/config.w32 ext/curl/curl.dsp ext/curl/interface.c ext/curl/package.xml ext/curl/php_curl.h ext/curl/share.c
Doh ! For once it's not the ZTS which broke :p I reverted the commit until I come up with a clean solution for both ZTS and non-ZTS Thanks On 24 November 2011 01:45, Antony Dovgal wrote: > On 11/24/2011 02:20 AM, Pierrick Charron wrote: >> >> pierrick Wed, 23 Nov 2011 22:20:28 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=319729 >> >> Log: >> Implemented FR #55540, added functions curl_share_init(), >> curl_share_setopt() and curl_share_close(). > > This patch breaks non-ZTS build of trunk: > > /local/qa/HEAD_non-ZTS/ext/curl/php_curl.h:157:2: error: expected > specifier-qualifier-list before ‘MUTEX_T’ > /local/qa/HEAD_non-ZTS/ext/curl/interface.c: In function ‘_php_curl_setopt’: > /local/qa/HEAD_non-ZTS/ext/curl/interface.c:2449:8: warning: ‘return’ with > no value, in function returning non-void > make: *** [ext/curl/interface.lo] Error 1 > > -- > Wbr, > Antony Dovgal > --- > http://pinba.org - realtime profiling for PHP > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/curl/config.m4 ext/curl/config.w32 ext/curl/curl.dsp ext/curl/interface.c ext/curl/package.xml ext/curl/php_curl.h ext/curl/share.c
On 11/24/2011 02:20 AM, Pierrick Charron wrote: pierrick Wed, 23 Nov 2011 22:20:28 + Revision: http://svn.php.net/viewvc?view=revision&revision=319729 Log: Implemented FR #55540, added functions curl_share_init(), curl_share_setopt() and curl_share_close(). This patch breaks non-ZTS build of trunk: /local/qa/HEAD_non-ZTS/ext/curl/php_curl.h:157:2: error: expected specifier-qualifier-list before ‘MUTEX_T’ /local/qa/HEAD_non-ZTS/ext/curl/interface.c: In function ‘_php_curl_setopt’: /local/qa/HEAD_non-ZTS/ext/curl/interface.c:2449:8: warning: ‘return’ with no value, in function returning non-void make: *** [ext/curl/interface.lo] Error 1 -- Wbr, Antony Dovgal --- http://pinba.org - realtime profiling for PHP -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/curl/config.m4 ext/curl/config.w32 ext/curl/curl.dsp ext/curl/interface.c ext/curl/package.xml ext/curl/php_curl.h ext/curl/share.c
I will. I'm still working on few things on the curl ext and once it will be done i'll take some time to document everything :) Pierrick On 23 November 2011 18:30, Pierre Joye wrote: > hi Pierrick! > > Don't forget the UPGRADING guide :) > > Cheers, > > On Wed, Nov 23, 2011 at 11:20 PM, Pierrick Charron wrote: >> pierrick Wed, 23 Nov 2011 22:20:28 + >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=319729 >> >> Log: >> Implemented FR #55540, added functions curl_share_init(), >> curl_share_setopt() and curl_share_close(). >> >> Bug: https://bugs.php.net/55540 (Assigned) no curl_share? nice... >> >> Changed paths: >> U php/php-src/trunk/NEWS >> U php/php-src/trunk/ext/curl/config.m4 >> U php/php-src/trunk/ext/curl/config.w32 >> U php/php-src/trunk/ext/curl/curl.dsp >> U php/php-src/trunk/ext/curl/interface.c >> U php/php-src/trunk/ext/curl/package.xml >> U php/php-src/trunk/ext/curl/php_curl.h >> A php/php-src/trunk/ext/curl/share.c >> >> >> -- >> PHP CVS Mailing List (http://www.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> > > > > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | http://www.libgd.org > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-CVS] svn: /php/php-src/trunk/ NEWS ext/curl/config.m4 ext/curl/config.w32 ext/curl/curl.dsp ext/curl/interface.c ext/curl/package.xml ext/curl/php_curl.h ext/curl/share.c
hi Pierrick! Don't forget the UPGRADING guide :) Cheers, On Wed, Nov 23, 2011 at 11:20 PM, Pierrick Charron wrote: > pierrick Wed, 23 Nov 2011 22:20:28 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=319729 > > Log: > Implemented FR #55540, added functions curl_share_init(), curl_share_setopt() > and curl_share_close(). > > Bug: https://bugs.php.net/55540 (Assigned) no curl_share? nice... > > Changed paths: > U php/php-src/trunk/NEWS > U php/php-src/trunk/ext/curl/config.m4 > U php/php-src/trunk/ext/curl/config.w32 > U php/php-src/trunk/ext/curl/curl.dsp > U php/php-src/trunk/ext/curl/interface.c > U php/php-src/trunk/ext/curl/package.xml > U php/php-src/trunk/ext/curl/php_curl.h > A php/php-src/trunk/ext/curl/share.c > > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
