Re: [PHP-CVS] svn: /php/php-src/trunk/Zend/ zend_compile.c zend_opcode.c

2010-05-02 Thread Derick Rethans
On Sun, 2 May 2010, Stefan Marr wrote: > On 02 May 2010, at 19:12, Derick Rethans wrote: > > Is there a reason why you named this to something with a _ at the start? > > AFAIK we've never done this, and instead prefer php_ (or in this case, > > zend_ ) > > I have named all internal helper functi

Re: [PHP-CVS] svn: /php/php-src/trunk/Zend/ zend_compile.c zend_opcode.c

2010-05-02 Thread Stefan Marr
Hi Derick: On 02 May 2010, at 19:12, Derick Rethans wrote: > Is there a reason why you named this to something with a _ at the start? > AFAIK we've never done this, and instead prefer php_ (or in this case, > zend_ ) I have named all internal helper functions this way in the traits related code.

Re: [PHP-CVS] svn: /php/php-src/trunk/Zend/ zend_compile.c zend_opcode.c

2010-05-02 Thread Derick Rethans
On Sun, 2 May 2010, Stefan Marr wrote: > gron Sun, 02 May 2010 16:32:25 + > > Revision: http://svn.php.net/viewvc?view=revision&revision=298877 > > Log: > Refactored part of the Traits implementation. > # - renamed php_runkit_function_copy_ctor to _duplica