Re: [PHP-DEV] [PATCH] .phps support for Apache 2

2002-10-06 Thread Ilia A.
On October 6, 2002 04:15 pm, Andi Gutmans wrote: > ctx->r->handler[strlen("application/x-httpd-php")] > > Is this actually the way it's supposed to work? (based on the length)? > Unless there's something I'm missing I'd prefer to see an strcmp() here. It > might be a bit slower but it's definitely

Re: [PHP-DEV] [PATCH] .phps support for Apache 2

2002-10-06 Thread Andi Gutmans
ctx->r->handler[strlen("application/x-httpd-php")] Is this actually the way it's supposed to work? (based on the length)? Unless there's something I'm missing I'd prefer to see an strcmp() here. It might be a bit slower but it's definitely more robust for future changes. Andi At 12:06 PM 10/4

Re: [PHP-DEV] [PATCH] .phps support for Apache 2

2002-10-05 Thread Aaron Bannert
On Sat, Oct 05, 2002 at 09:33:08AM -0400, Ilia A. wrote: > > I think Zeev is going to re-implement phps soon. > > It supposed to be much like normal php script internally. > > ATM this is not the case, when Zeev does make the change it is likely it'll be > after 4.3 is released. Until such a cha

Re: [PHP-DEV] [PATCH] .phps support for Apache 2

2002-10-05 Thread Ilia A.
On October 5, 2002 01:07 pm, Zeev Suraski wrote: > At 16:33 05/10/2002, Ilia A. wrote: > >ATM this is not the case, when Zeev does make the change it is likely > >it'll be > >after 4.3 is released. Until such a change is made there is really no need > > to restrict the functionality of Apache 2 IM

Re: [PHP-DEV] [PATCH] .phps support for Apache 2

2002-10-05 Thread Zeev Suraski
At 16:33 05/10/2002, Ilia A. wrote: >ATM this is not the case, when Zeev does make the change it is likely >it'll be >after 4.3 is released. Until such a change is made there is really no need to >restrict the functionality of Apache 2 IMHO. I actually think it's better not to introduce new .php

Re: [PHP-DEV] [PATCH] .phps support for Apache 2

2002-10-05 Thread Derick Rethans
On Sat, 5 Oct 2002, Ilia A. wrote: > On October 5, 2002 06:15 am, Yasuo Ohgaki wrote: > > Edin Kadribasic wrote: > > > On Friday 04 October 2002 18:06, Ilia A. wrote: > > >>The attached patch adds .phps file support for Apache 2, allowing Apache > > >> 2 users to show prettified source of their s

Re: [PHP-DEV] [PATCH] .phps support for Apache 2

2002-10-05 Thread Ilia A.
On October 5, 2002 06:15 am, Yasuo Ohgaki wrote: > Edin Kadribasic wrote: > > On Friday 04 October 2002 18:06, Ilia A. wrote: > >>The attached patch adds .phps file support for Apache 2, allowing Apache > >> 2 users to show prettified source of their scripts, just like their > >> Apache 1 counterp

Re: [PHP-DEV] [PATCH] .phps support for Apache 2

2002-10-05 Thread Yasuo Ohgaki
Edin Kadribasic wrote: > On Friday 04 October 2002 18:06, Ilia A. wrote: > >>The attached patch adds .phps file support for Apache 2, allowing Apache 2 >>users to show prettified source of their scripts, just like their Apache 1 >>counterparts can. >> >>It is a fairly simple patch, that adds just

Re: [PHP-DEV] [PATCH] .phps support for Apache 2

2002-10-04 Thread Edin Kadribasic
On Friday 04 October 2002 18:06, Ilia A. wrote: > The attached patch adds .phps file support for Apache 2, allowing Apache 2 > users to show prettified source of their scripts, just like their Apache 1 > counterparts can. > > It is a fairly simple patch, that adds just 2 cmp overhead for this > fu

[PHP-DEV] [PATCH] .phps support for Apache 2

2002-10-04 Thread Ilia A.
The attached patch adds .phps file support for Apache 2, allowing Apache 2 users to show prettified source of their scripts, just like their Apache 1 counterparts can. It is a fairly simple patch, that adds just 2 cmp overhead for this functionality, so its not too bad imho. Please review the