Re: [PHP-DEV] [patch] krsort() ext/standard/array.c

2001-12-12 Thread Zak Greant
On December 12, 2001 07:33 am, Andrei Zmievski wrote: > On Wed, 12 Dec 2001, Sterling Hughes wrote: > > And those functions would be? :) Are you talking about > > regularly used functions such as strlen(), etc.? > > Functions like count(), for example, that people tend to use in a > loop unnec

Re: [PHP-DEV] [patch] krsort() ext/standard/array.c

2001-12-12 Thread Markus Fischer
On Wed, Dec 12, 2001 at 12:44:21PM -0600, Andrei Zmievski wrote : > On Wed, 12 Dec 2001, Zak Greant wrote: > > I will start doing this (taking into account Andrei's constraints) > > > > Also, is there a good source of documentation on > > zend_parse_parameters(), or should I run throught

Re: [PHP-DEV] [patch] krsort() ext/standard/array.c

2001-12-12 Thread Andrei Zmievski
On Wed, 12 Dec 2001, Zak Greant wrote: > I will start doing this (taking into account Andrei's constraints) > > Also, is there a good source of documentation on > zend_parse_parameters(), or should I run throught the dev messages > and create some. README.PARAMETER_PARSING_API -Andrei

Re: [PHP-DEV] [patch] krsort() ext/standard/array.c

2001-12-12 Thread Zak Greant
On December 12, 2001 03:54 am, Sterling Hughes wrote: [...] > Sure, commit it... But please don't send a patch for every proto > change, we'll yell out you fine if you commit something bad... ;) C'mon - the list needs the extra traffic to appear active. :) To commit to the source code

Re: [PHP-DEV] [patch] krsort() ext/standard/array.c

2001-12-12 Thread Andrei Zmievski
On Wed, 12 Dec 2001, Sterling Hughes wrote: > And those functions would be? :) Are you talking about regularly used > functions such as strlen(), etc.? Functions like count(), for example, that people tend to use in a loop unnecessarily. > I agree that zend_basic_functions.c should r

Re: [PHP-DEV] [patch] krsort() ext/standard/array.c

2001-12-12 Thread Sterling Hughes
> On Wed, 12 Dec 2001, Sterling Hughes wrote: > > Sure, commit it... But please don't send a patch for every proto > > change, we'll yell out you fine if you commit something bad... ;) > > > > Btw, yes, if you wouldn't mind zend_parse_parameters() conversion > > would be great, it

Re: [PHP-DEV] [patch] krsort() ext/standard/array.c

2001-12-12 Thread Andrei Zmievski
On Wed, 12 Dec 2001, Sterling Hughes wrote: > Sure, commit it... But please don't send a patch for every proto > change, we'll yell out you fine if you commit something bad... ;) > > Btw, yes, if you wouldn't mind zend_parse_parameters() conversion > would be great, its probably a

Re: [PHP-DEV] [patch] krsort() ext/standard/array.c

2001-12-12 Thread Sterling Hughes
> Hello All, > > After reviewing Christian Dickmann's list of functions with broken > prototypes, I have started making corrections where needed. > > Given that I am not sure that everyone will agree that these changes > are needed (or that I will make the changes properly FTM), I am > starti

Re: [PHP-DEV] [patch] krsort() ext/standard/array.c

2001-12-11 Thread Markus Fischer
On Tue, Dec 11, 2001 at 10:12:02PM -0700, Zak Greant wrote : > > Also, when touching up functions, is there any significant advantage > to migrating them to zend_parse_parameters? Automatic type conversion and less code and unified error messages. Less code btw. it is also cleaner

Re: [PHP-DEV] [patch] krsort() ext/standard/array.c

2001-12-11 Thread Zak Greant
Also, when touching up functions, is there any significant advantage to migrating them to zend_parse_parameters? On December 11, 2001 06:53 pm, I wrote: > Hello All, > > After reviewing Christian Dickmann's list of functions with broken > prototypes, I have started making corrections where

[PHP-DEV] [patch] krsort() ext/standard/array.c

2001-12-11 Thread Zak Greant
Hello All, After reviewing Christian Dickmann's list of functions with broken prototypes, I have started making corrections where needed. Given that I am not sure that everyone will agree that these changes are needed (or that I will make the changes properly FTM), I am starting slowly. :) T