Re[3]: [PHP-DEV] OpenSSL in PHP

On 19/09/02, "Arkadiusz Goralski" <[EMAIL PROTECTED]> wrote: > WF> I don't want to sound pedantic about this, but you mentioned that > WF> you submitted this 2 months ago; I don't recall seeing it, and can't > WF> find your mail in my email archives - if it had been addressed directly > WF> to me

Re[2]: [PHP-DEV] OpenSSL in PHP

Hi Wez, WF> I don't want to sound pedantic about this, but you mentioned that WF> you submitted this 2 months ago; I don't recall seeing it, and can't WF> find your mail in my email archives - if it had been addressed directly WF> to me then it would have been noticed and dealt with sooner. It w

Re: [PHP-DEV] OpenSSL in PHP

Thanks for the patch :-) Aside from the signature change for openssl_pkcs7_verify (add the new args to the end of the proto), it looks ok to be merged for 4.3. I know that openssl.c isn't the best example of the coding standards (and that this is largely due to me!), but please try and stick to

Re: [PHP-DEV] OpenSSL in PHP

Hello again, some more comments: @@ -1951,11 +2196,14 @@ char * filename; long filename_len; char * extracerts = NULL; long extracerts_len; char * signersfilename = NULL; long signersfilename_len; + char *contfile=NULL; long contfile_len; + int informat = FORM

Re: [PHP-DEV] OpenSSL in PHP

On Thu, 19 Sep 2002 [EMAIL PROTECTED] wrote: > hmm, I still see this in the patch @ > ftp://ftp.certum.pl/pub/PHP/php-4.2.3-openssl.diff.gz : ... > Am I checking the wrong patch? Yeah, this is for end-user ;) CVS version is php-cvs-openssl.diff.gz -- Wojtek Ślusarczyk -- PHP Develo

Re: [PHP-DEV] OpenSSL in PHP

On Thu, 19 Sep 2002, Wojtek Slusarczyk wrote: > On Thu, 19 Sep 2002 [EMAIL PROTECTED] wrote: > > > if (foo) { > > more_stuff(); > > } else { > > other_stuff(); > > } > > Both patches are changed to reflect code-style. They are on our ftp site. > regards, hmm, I still see this in the patch @

Re: [PHP-DEV] OpenSSL in PHP

On Thu, 19 Sep 2002 [EMAIL PROTECTED] wrote: > if (foo) { > more_stuff(); > } else { > other_stuff(); > } Both patches are changed to reflect code-style. They are on our ftp site. regards, -- Wojtek Ślusarczyk -- PHP Development Mailing List To unsubscribe, visit: http

Re: [PHP-DEV] OpenSSL in PHP

Hello, I had a look at the patch back then and I can remember me asking to change something with the bracing style. The PHP source uses (almost everywhere): if (foo) { more_stuff(); } else { other_stuff(); } Can you please change your patch according to this style? regards, Derick On Thu,

[PHP-DEV] OpenSSL in PHP

Hi, PKCS#7 handling functions are still buggy in 4.2.3 and current CVS version. Two months ago we have submitted a 'filling' against PHP-CVS and 4.2.2 version. So, current version of patch against 4.2.3 is available at ftp://ftp.certum.pl/pub/PHP/php-4.2.3-openssl.diff.gz New fun