Re: [PHP-DEV] highlight_file modification

I'm still wondering about that weird little "bug" in the parser that causes a newline to be added/returned at the end of the last line. It's really making the line numbers look stupid when you have no blank like after the end of the script. 22: ?> 23: I do understand your issues with i18n not

Re: [PHP-DEV] highlight_file modification

Hm, actually... I have gotten everything working *except* there is one weird little thing that happens with indenting for some token types because of the way that I have my output ordered. The reason for this is because I cannot (don't want to) call zend_html_puts() with an additional argume

Re: [PHP-DEV] highlight_file modification

What buffer and encoding stuff are you talking about?! show_source() is an FALIAS to highlight_file() which calls zend_highlight(). phps files via apache call zend_highlight(). Where are you going with this? Devon Yasuo Ohgaki wrote: >>> phps may not work under Apache 1.3.x also. >>> Any addi

Re: [PHP-DEV] highlight_file modification

[EMAIL PROTECTED] wrote: > On Thu, 12 Sep 2002, Yasuo Ohgaki wrote: > > >>Tom Sommer wrote: >> >>>"Devon O'Dell" <[EMAIL PROTECTED]> wrote in >>>[EMAIL PROTECTED]">news:[EMAIL PROTECTED]... >>> >>> Maybe, but then we're assuming Apache ;) >>> >>> >>>.phps does not work on IIS >>> >> >>phps m

Re: [PHP-DEV] highlight_file modification

Tables work a *lot* better for aligning the text. Otherwise, how many spaces are you going to pad line numbers with? 6? No matter how rediculous it seems, I know a person with a 1 million+ line script (though I have absolutely no clue what it does). IMHO, tables just allow for much better o

Re: [PHP-DEV] highlight_file modification

idea. I'm about to head to work, and I'll draft up kind of a list of what I've got done. Devon Original Message: - From: [EMAIL PROTECTED] Date: Thu, 12 Sep 2002 07:52:21 +0200 (CEST) To: [EMAIL PROTECTED], [EMAIL PROTECTED] Subject: Re: [PHP-DEV] highlight_file modi

Re: [PHP-DEV] highlight_file modification

On Thu, 12 Sep 2002, Tom Sommer wrote: > > "Edin Kadribasic" <[EMAIL PROTECTED]> wrote in > [EMAIL PROTECTED]">news:[EMAIL PROTECTED]... > > Did I miss something here? I don't remember us reaching agreement about > > adding another config option. > > He still has the right to make a patch if he

Re: [PHP-DEV] highlight_file modification

On Thu, 12 Sep 2002, Yasuo Ohgaki wrote: > Tom Sommer wrote: > > "Devon O'Dell" <[EMAIL PROTECTED]> wrote in > > [EMAIL PROTECTED]">news:[EMAIL PROTECTED]... > > > >>Maybe, but then we're assuming Apache ;) > > > > > > .phps does not work on IIS > > > > phps may not work under Apache 1.3.x a

Re: [PHP-DEV] highlight_file modification

Tom Sommer wrote: > "Devon O'Dell" <[EMAIL PROTECTED]> wrote in > [EMAIL PROTECTED]">news:[EMAIL PROTECTED]... > >>Maybe, but then we're assuming Apache ;) > > > .phps does not work on IIS > phps may not work under Apache 1.3.x also. Any addition to phps does not worth the effort. People sho

Re: [PHP-DEV] highlight_file modification

May I suggest that for .phps you just turn line numbers on all the time, unless someone can come up with a reason not to enable them better than "that's the way its always been." Backwards compatibility is good when it affects how a program runs, but in this case I just don't see a reason not t

Re: [PHP-DEV] highlight_file modification

> http://www.dapond.net/code/bleh.html > > This still doesn't implement the .phps?linenumbers (since that's gonna have > to do with the server module/cgi binary code) and also since nobody's (yet) > given input as to what variable name would be sufficient. at least SG(request_info).query_string c

Re: [PHP-DEV] highlight_file modification

Edin Kadribasic wrote: > On Wed, 11 Sep 2002 13:47:56 +0200 > "Devon O'Dell" <[EMAIL PROTECTED]> wrote: > >>Hey, >> >>I don't know if this has been brought up before (you can smack me, I >>know that's the 3rd time I've said this), but something I (and others) >> >>thought would be cool is line n

Re: [PHP-DEV] highlight_file modification

4 -0400 To: [EMAIL PROTECTED], [EMAIL PROTECTED] Subject: Re: [PHP-DEV] highlight_file modification Hehe, it's just a local patch, I don't have CVS commit access, and I wouldn't commit it now anyway if I did since there hasn't been any formal discussion about it. I've just

Re: [PHP-DEV] highlight_file modification

chievements, not intentions to stay in any one place with this. Thus, the reason I was asking how I should do it :) Devon Original Message: - From: Tom Sommer [EMAIL PROTECTED] Date: Thu, 12 Sep 2002 00:34:39 +0200 To: [EMAIL PROTECTED] Subject: Re: [PHP-DEV] highlight_file mo

Re: [PHP-DEV] highlight_file modification

"Edin Kadribasic" <[EMAIL PROTECTED]> wrote in [EMAIL PROTECTED]">news:[EMAIL PROTECTED]... > Did I miss something here? I don't remember us reaching agreement about > adding another config option. He still has the right to make a patch if he wants to. Currently the way to go is to make the outp

Re: [PHP-DEV] highlight_file modification

"[EMAIL PROTECTED]" <[EMAIL PROTECTED]> wrote [EMAIL PROTECTED]">news:[EMAIL PROTECTED]... >Output from show_source using the current patch can be found at > > http://www.dapond.net/code/bleh.html Don't use tables.. use HTML spaces instead, like the current show_source -- * Tom Sommer * http://

Re: [PHP-DEV] highlight_file modification

before I release the patch. So far, I think it's looking pretty good if you ask me :). Devon Original Message: - From: Dan Hardiker [EMAIL PROTECTED] Date: Wed, 11 Sep 2002 21:36:40 +0100 (BST) To: [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED] Subject: Re: [PHP-DEV]

Re: [PHP-DEV] highlight_file modification

[EMAIL PROTECTED] wrote: > Right now I'm going through all this mess and trying to get it so that > it's actually an XHTML 1.1 compliant output. Right now, there's no > guarantee that it's even HTML [insert version here] compliant. > > All the ini configuration is set. I will set the ini defaul

Re: [PHP-DEV] highlight_file modification

>> If you can think of an alternative way to enable / disable the >> modifications suggested other than using a php.ini entry... ;) > [...] > > wouldn't it be better to let the viewer decide, if line numbers should > appear or not. This wouldn't break BC and also would not be needed to > be enab

Re: [PHP-DEV] highlight_file modification

ind me cleaning up stuff :). Devon Original Message: - From: Sascha Cunz [EMAIL PROTECTED] Date: Wed, 11 Sep 2002 22:27:31 +0200 To: [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED] Subject: Re: [PHP-DEV] highlight_file modification hi [...] > I believe the defau

Re: [PHP-DEV] highlight_file modification

hi [...] > I believe the default should be its current behaviour (for backward > compatability, and to prevent unexpected change)... but I do think there > should be an ini option so that .phps files can have this functionality. [...] +1 on that. [...] > Having line numbers on a .phps file would

Re: [PHP-DEV] highlight_file modification

> The feature should be implemented in PHP, but not active by default. It > should be controlled by php.ini and this value should be overwrited by > the optional parameter in the functions.. how's that? I think it should be switched on by default, if possible, because it is only going to help sup

Re: [PHP-DEV] highlight_file modification

Le Mercredi 11 Septembre 2002 14:05, Dan Hardiker a écrit : > [..] > > > something I (and others) thought would be cool is line numbering > > for highlight_file (aka show_source). > > [..] > > > Devon > +1 from me -- PHP Development Mailing List To unsubscribe, visit: http:

Re: [PHP-DEV] highlight_file modification

"Devon O'Dell" <[EMAIL PROTECTED]> wrote in [EMAIL PROTECTED]">news:[EMAIL PROTECTED]... > Maybe, but then we're assuming Apache ;) .phps does not work on IIS Maybe it should be an INI option, but the default should be off (for backward compatability). I totally agree that this would kick ass (

Re: [PHP-DEV] highlight_file modification

Maybe, but then we're assuming Apache ;) Devon Hartmut Holzgraefe wrote: > Devon O'Dell wrote: > >> ... there isn't another way to set it for a phps (unless you create >> an ini setting). > > > what about > > application/x-httpd-php-source-with-line-numbers > > ? ;) -- PHP Development Ma

Re: [PHP-DEV] highlight_file modification

Devon O'Dell wrote: > ... there isn't another way > to set it for a phps (unless you create an ini setting). what about application/x-httpd-php-source-with-line-numbers ? ;) -- Six Offene Systeme GmbH http://www.six.de/ i.A. Hartmut Holzgraefe Email: [EMAIL PROTECTED] Tel.: +49-711-9

Re: [PHP-DEV] highlight_file modification

>> The other option is just making it work with line numbering >> regardless. This won't break any scripts, just make them have line >> numbers instead. > > This is not a good idea, many may find line-numbers useless in some > cases/scripts... > I agree that it would be an great idea to make it an

Re: [PHP-DEV] highlight_file modification

It applies also to .phps files, where enabled. Devon Tom Sommer wrote: >"Devon O'Dell" <[EMAIL PROTECTED]> wrote in >[EMAIL PROTECTED]">news:[EMAIL PROTECTED]... > > > >>The other option is just making it work with line numbering regardless. >>This won't break any scripts, just make them have

Re: [PHP-DEV] highlight_file modification

"Devon O'Dell" <[EMAIL PROTECTED]> wrote in [EMAIL PROTECTED]">news:[EMAIL PROTECTED]... > The other option is just making it work with line numbering regardless. > This won't break any scripts, just make them have line numbers instead. This is not a good idea, many may find line-numbers useless

Re: [PHP-DEV] highlight_file modification

Rewriting the function so that it had an optional parameter for line numbering (or not line numbering) would also reduce the file size of the patch. I agree this may be a better approach for highlight_file; however, .phps files use this same function... there isn't another way to set it for a

Re: [PHP-DEV] highlight_file modification

On Wed, 11 Sep 2002, Edin Kadribasic wrote: > Please let's not add an ini setting for every little thing. It makes > writing portable scripts very difficult. > > I think that it would be preferrable to add an optional parameter to the > exisiting function, or make a new function. +1, I'd go for

RE: [PHP-DEV] highlight_file modification

+1 For me for a new parameter Jean-François Bustarret [EMAIL PROTECTED] -Message d'origine- De : Edin Kadribasic [mailto:[EMAIL PROTECTED]] Envoyé : mercredi 11 septembre 2002 14:39 À : Devon O'Dell Cc : [EMAIL PROTECTED] Objet : Re: [PHP-DEV] highlight_file modification

Re: [PHP-DEV] highlight_file modification

At 14:35 11.09.2002, Alan Knowles wrote: >I know it's a bit of a radical suggestion, but would depreciating >highlight_string in favour of a pear package using the tokenizer not be a >better approach. > >is there any reason to keep this in C? Highliting is a feature from the parser and the php

Re: [PHP-DEV] highlight_file modification

On Wed, 11 Sep 2002 13:47:56 +0200 "Devon O'Dell" <[EMAIL PROTECTED]> wrote: > Hey, > > I don't know if this has been brought up before (you can smack me, I > know that's the 3rd time I've said this), but something I (and others) > > thought would be cool is line numbering for highlight_file (a

Re: [PHP-DEV] highlight_file modification

I know it's a bit of a radical suggestion, but would depreciating highlight_string in favour of a pear package using the tokenizer not be a better approach. is there any reason to keep this in C? Anyway, just throwing a few stones into the water Regards Alan Devon O'Dell wrote: > Hey, >

Re: [PHP-DEV] highlight_file modification

[..] > something I (and others) thought would be cool is line numbering > for highlight_file (aka show_source). [..] > Devon +1 from me Line numbering on show_source output is always useful! Especially when in a chat room your debugging someone elses code and you have to refer to "that if statem

Re: [PHP-DEV] highlight_file modification

At 13:47 11.09.2002, Devon O'Dell wrote: >Hey, > >I don't know if this has been brought up before (you can smack me, I know >that's the 3rd time I've said this), but something I (and others) thought >would be cool is line numbering for highlight_file (aka show_source). However i like this idea.

[PHP-DEV] highlight_file modification

Hey, I don't know if this has been brought up before (you can smack me, I know that's the 3rd time I've said this), but something I (and others) thought would be cool is line numbering for highlight_file (aka show_source). I've made modifications so that this feature is settable from php.ini