Re: [PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] Re: [PHP-QA] PHP 4.0.5 Release Candidate testing

2001-04-02 Thread Anil Madhavapeddy
Andi Gutmans wrote: > I suggest you merge this into 4.0.5 because it seems to me > that otherwise output buffering will be quite a mess without > it. It would be a shame to release 4.0.5 without it. Ok, done. > Your fix looks OK but I'd like to hear the opinion of someone > else who is more fami

[PHP-DEV] RE: [PHP-QA] PHP 4.0.5 Release Candidate testing

2001-04-02 Thread Andi Gutmans
At 03:18 PM 4/2/2001 +0100, James Moore wrote: > > > 1. The function array_flip($array) puts one extra zero byte at > > the end of > > > each element in the return array thus making the result non binary safe. > > > > I've just fixed it in CVS. > >How critical is this? does it need to also be in 4

[PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] Re: [PHP-QA] PHP 4.0.5 Release Candidate testing

2001-04-02 Thread Andi Gutmans
At 05:37 PM 4/2/2001 +0100, Anil Madhavapeddy wrote: >Andi Gutmans wrote: > > > Does anyone else have any critical bug fixes > > which need to be in 4.0.5? (I mean critical ones and not > > huge patches). > >Zeev's output buffering fix hasn't been committed yet; it's a one-line >change, and it mak

[PHP-DEV] RE: [PHP-QA] Re: [PHP-DEV] Re: [PHP-QA] PHP 4.0.5 Release Candidate testing

2001-04-02 Thread James Moore
> Zeev's output buffering fix hasn't been committed yet; it's a one-line > change, and it makes the transparent output compression stuff work. MFH it then and we can get 4.0.5 out the door ;) James -- PHP Development Mailing List To unsubscribe, e-mail: [EMAIL PROTECTED]

[PHP-DEV] Re: [PHP-QA] Re: [PHP-DEV] Re: [PHP-QA] PHP 4.0.5 Release Candidate testing

2001-04-02 Thread Anil Madhavapeddy
Andi Gutmans wrote: > Does anyone else have any critical bug fixes > which need to be in 4.0.5? (I mean critical ones and not > huge patches). Zeev's output buffering fix hasn't been committed yet; it's a one-line change, and it makes the transparent output compression stuff work. Does anyone h

Re: [PHP-DEV] Re: [PHP-QA] PHP 4.0.5 Release Candidate testing

2001-04-02 Thread Andi Gutmans
Thanks! Does anyone else have any critical bug fixes which need to be in 4.0.5? (I mean critical ones and not huge patches). Andi At 11:17 AM 4/2/2001 -0500, Andrei Zmievski wrote: >It's done. > >On Mon, 02 Apr 2001, Andi Gutmans wrote: > > Andrei, > > > > Can you please merge this to 4.0.5. I

Re: [PHP-DEV] Re: [PHP-QA] PHP 4.0.5 Release Candidate testing

2001-04-02 Thread Andrei Zmievski
It's done. On Mon, 02 Apr 2001, Andi Gutmans wrote: > Andrei, > > Can you please merge this to 4.0.5. I think it should be in and we better > release a final RC6. > I think it's better to have another quick RC (I can roll it today or > tomorrow) before we get 4.0.5 out of the door. > Andi -

Re: [PHP-DEV] Re: [PHP-QA] PHP 4.0.5 Release Candidate testing

2001-04-02 Thread Andi Gutmans
Andrei, Can you please merge this to 4.0.5. I think it should be in and we better release a final RC6. I think it's better to have another quick RC (I can roll it today or tomorrow) before we get 4.0.5 out of the door. Andi At 08:25 AM 4/2/2001 -0500, Andrei Zmievski wrote: >On Mon, 02 Apr 200

[PHP-DEV] RE: [PHP-QA] PHP 4.0.5 Release Candidate testing

2001-04-02 Thread James Moore
> > 1. The function array_flip($array) puts one extra zero byte at > the end of > > each element in the return array thus making the result non binary safe. > > I've just fixed it in CVS. How critical is this? does it need to also be in 4.0.5 (sorry Zeev ;)) James -- PHP Development Mailing L

[PHP-DEV] Re: [PHP-QA] PHP 4.0.5 Release Candidate testing

2001-04-02 Thread Alexander Feldman
On Mon, 2 Apr 2001, Andrei Zmievski wrote: > On Mon, 02 Apr 2001, Alexander Feldman wrote: > Hi, > > These are the > results and questions from some tests I run yesterday on the > last > 4.0.5 release candidate. Note that all differences are from PHP > > 4.0.4pl1. > > 1. The function array_flip($

[PHP-DEV] Re: [PHP-QA] PHP 4.0.5 Release Candidate testing

2001-04-02 Thread Andrei Zmievski
On Mon, 02 Apr 2001, Alexander Feldman wrote: > Hi, > > These are the results and questions from some tests I run yesterday on the > last 4.0.5 release candidate. Note that all differences are from PHP > 4.0.4pl1. > > 1. The function array_flip($array) puts one extra zero byte at the end of > ea

[PHP-DEV] RE: [PHP-QA] PHP 4.0.5 Release Candidate testing

2001-04-02 Thread Karl Austin
The nl2br() change shouldn't have a big effect as all browsers should be able to understand , if it were then most browsers would choke on it (Except IE). Karl Austin KDA Web Services -Original Message- From: Alexander Feldman [mailto:[EMAIL PROTECTED]] Sent: 02 April 2001 10:00 To: [E