Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/mbstring/tests 027.inc027.phpt
Moriyoshi Koizumi wrote: Hi, I'm for Derick's option. Can I begin repacking each case to the single files now? The only advantage putting everything in phpt is is we can take a look at whole thing in one file. Don't we have multiple windows or buffers? It's too little advantage compare to have 2 files. IMO, including script file give us more freedom to write/execute test script. It's not efficient creating normal script file when there is problem in phpt. Anyway, if you volunteer to change it, go ahead. (Please don't for pgsql tests :) Please rename 001.phpt to something meaningful. I just followed existing test script naming convention and I don't like it, too. ;) -- Yasuo Ohgaki Moriyoshi Yasuo Ohgaki [EMAIL PROTECTED] wrote: Derick Rethans wrote: Yes, works fine here: (even with * instead of 025.*) Thing has been changed ;) I hope it's documented somewhere. -- Yasuo Ohgaki -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/mbstring/tests 027.inc027.phpt
On Tue, 22 Oct 2002, Yasuo Ohgaki wrote: Moriyoshi Koizumi wrote: Hi, I'm for Derick's option. Can I begin repacking each case to the single files now? IMO, including script file give us more freedom to write/execute test script. It's not efficient creating normal script file when there is problem in phpt. Anyway, if you volunteer to change it, go ahead. (Please don't for pgsql tests :) tests may fail because of bugs in include, if you check functions you should rely as less possible on others, including include. Please rename 001.phpt to something meaningful. I just followed existing test script naming convention and I don't like it, too. I agree with this though. Derick -- --- Derick Rethans http://derickrethans.nl/ JDI Media Solutions --[ if you hold a unix shell to your ear, do you hear the c? ]- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/mbstring/tests 027.inc027.phpt
Melvyn Sopacua wrote: At 22:00 10/21/2002 +0900, Yasuo Ohgaki wrote: Derick Rethans wrote: Yes, works fine here: (even with * instead of 025.*) Thing has been changed ;) I hope it's documented somewhere. Here's the docs: http://news.php.net/article.php?group=php.cvsarticle=14780 It's not called documentation, but CVS log, isn't it :) -- Yasuo Ohgaki -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/mbstring/tests 027.inc027.phpt
On Tue, 22 Oct 2002, Moriyoshi Koizumi wrote: I'm for Derick's option. Can I begin repacking each case to the single files now? please :) Derick Yasuo Ohgaki [EMAIL PROTECTED] wrote: Derick Rethans wrote: Yes, works fine here: (even with * instead of 025.*) Thing has been changed ;) I hope it's documented somewhere. -- Yasuo Ohgaki -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php -- --- Derick Rethans http://derickrethans.nl/ JDI Media Solutions --[ if you hold a unix shell to your ear, do you hear the c? ]- -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/mbstring/tests 027.inc027.phpt
The only advantage putting everything in phpt is is we can take a look at whole thing in one file. Don't we have multiple windows or buffers? It's too little advantage compare to have 2 files. First I looked at your style, I think it was somewhat cool, because then I wasn't able to run a single test with a cgi binary (before CLI era) IMO, including script file give us more freedom to write/execute test script. It's not efficient creating normal script file when there is problem in phpt. Anyway, if you volunteer to change it, go ahead. (Please don't for pgsql tests :) I'm never for the unreasonable standarlization. We've been working on a voluntary basis, and each style should be respected, unless it only causes increasing entropy aka inefficiency. I mean in some cases consistency is no longer the first thing, and then yours doesn't look like such a obstacle for me. Please rename 001.phpt to something meaningful. I just followed existing test script naming convention and I don't like it, too. ;) Is good thing, though. Moriyoshi -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/mbstring/tests 027.inc027.phpt
Melvyn Sopacua wrote: However - it depends on include and relative path issues to work as expected. The problem is very frustrating, isn't? What's the plan for it? -- Yasuo Ohgaki -- PHP Development Mailing List http://www.php.net/ To unsubscribe, visit: http://www.php.net/unsub.php
Re: [PHP-DEV] Re: [PHP-CVS] cvs: php4 /ext/mbstring/tests 027.inc027.phpt
Other option is create .php files from phpt file always.
It was useful when there is .php file is created when
error occurred. (Current run-tests.php does not create the
.php files, though)
If .php files is always created and left after running
run-tests.php, all needs are covered. It's a trivial change
to run-tests.php.
We may better to use some strange extension to avoid
unwanted over writes. .src may be a good choice.
Comments?
--
Yasuo Ohgaki
Moriyoshi Koizumi wrote:
echo ?php while(--\$argc=0){\$f=\$argv[\$argc];echo \\$f\n\;\
\$b=preg_replace(\
'/\\?php\\s+include\\(\\s*[\\\']([^\\\']+)[\\\']\\s*\\);\\s*\\?/e',\
'file_get_contents(\\$1\)',\file_get_contents(\$f));\
\$p=fopen(\$f,'w');fwrite(\$p,\$b);fclose(\$p);}? \
| sapi/cli/php -- ext/mbstring/tests/*.phpt
done (a bit dirty).
Moriyoshi
Moriyoshi Koizumi [EMAIL PROTECTED] wrote:
Hi,
I'm for Derick's option. Can I begin repacking each case to the single
files now?
Moriyoshi
Yasuo Ohgaki [EMAIL PROTECTED] wrote:
Derick Rethans wrote:
Yes, works fine here:
(even with * instead of 025.*)
Thing has been changed ;)
I hope it's documented somewhere.
--
Yasuo Ohgaki
--
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php
--
PHP Development Mailing List http://www.php.net/
To unsubscribe, visit: http://www.php.net/unsub.php
