Re: AW: [PHP-DEV] 4.1 Declaration Case Persistance

2001-05-10 Thread Jani Taskinen

On Wed, 9 May 2001, Sterling Hughes wrote:

On Thu, 10 May 2001, Jani Taskinen wrote:
 This is just because some developers don't like to follow the guidelines.
 As, I quote, it woulnd't be fun anymore or you can't force anyone.

Hrrmmm.. Which guidelines would those be?  And no, you can't force anyone,

This one.. (from CODING_STANDARDS):

8---
Naming Conventions
--

[1] Function names for user-level functions should be enclosed with in
the PHP_FUNCTION() macro. They should be in lowercase, with words
8---

And yes, you can force anyone. If they don't follow the guidelines set,
their CVS access can as easily be taken from them as it was given..
This is same as if someone intentionally breaks some parts of the code.

if you see something you don't like however, your welcome to change it,
and if its generally a good change, then it will be included in the code.

So..you think that if you are lazy and don't wanna follow these loose
guidelines a bit and use your own intendation and naming convention
someone else has to come after and clean up your mess?! Yeah, right.

This isn't like at your home where your mom cleans up your room.
Here you really have to do it yourself. :-p

I've gone ahead and changed them all to lower case...  If its a bad change
I'm expecting people to bitch.

Anyone good with regexps could create a script which could be used
to at least find these..or even convert them to lower case ?

 another question: according to the CODING_STANDARDS file every function
 should be lowercase, but how about exported classes ? is there a guidline
 for this ?

 See above.


There is no standard in the CODING_STANDARDS file.

So why does it even exist?

--Jani



-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




Re: AW: [PHP-DEV] 4.1 Declaration Case Persistance

2001-05-10 Thread Sterling Hughes

On Thu, 10 May 2001, Jani Taskinen wrote:

 On Wed, 9 May 2001, Sterling Hughes wrote:

 On Thu, 10 May 2001, Jani Taskinen wrote:
  This is just because some developers don't like to follow the guidelines.
  As, I quote, it woulnd't be fun anymore or you can't force anyone.
 
 Hrrmmm.. Which guidelines would those be?  And no, you can't force anyone,

 This one.. (from CODING_STANDARDS):

 8---
 Naming Conventions
 --

 [1] Function names for user-level functions should be enclosed with in
 the PHP_FUNCTION() macro. They should be in lowercase, with words
 8---

 And yes, you can force anyone. If they don't follow the guidelines set,
 their CVS access can as easily be taken from them as it was given..
 This is same as if someone intentionally breaks some parts of the code.


How is this helpful?  By removing CVS access your taking one person away
who could possibly solve the problem.  And your still not forcing them to
do anything.  If I was a new developer and someone removed my CVS access
because I goofed up, or my code didn't conform to the CODING_STANDARDS
file, I would most likely not contribute again, and would not be happy
with the PHP development team.  If we send people away its usually not
their loss, but rather ours (exceptions can be made for a few people,
*cough* Jon Ribbens *cough* ;)

 if you see something you don't like however, your welcome to change it,
 and if its generally a good change, then it will be included in the code.

 So..you think that if you are lazy and don't wanna follow these loose
 guidelines a bit and use your own intendation and naming convention
 someone else has to come after and clean up your mess?! Yeah, right.


If someone has a problem with the way I or someone else codes, they're
more than welcome to fix it themselves.  While in a perfect world all
files and pieces of work would fit into PHP perfectly, that isn't so.
There's no reason to look down upon good pieces of code, because the
identation doesn't match the PHP standard, or they don't name things
according to the standard.  If its really that big a problem, ask the
developer to fix it, and if they don't want too, fix it yourself (I mean
yourself in the general sense), or leave it alone.

 This isn't like at your home where your mom cleans up your room.
 Here you really have to do it yourself. :-p


That was only in Italy :)  And damn that was great, I got three fresh
cooked meals a day too, as well as all my laundry done, a, but I
digress.

 I've gone ahead and changed them all to lower case...  If its a bad change
 I'm expecting people to bitch.

 Anyone good with regexps could create a script which could be used
 to at least find these..or even convert them to lower case ?


I think the com extension was the last remnants, grep could easily
handle this...

  another question: according to the CODING_STANDARDS file every function
  should be lowercase, but how about exported classes ? is there a guidline
  for this ?
 
  See above.
 
 
 There is no standard in the CODING_STANDARDS file.

 So why does it even exist?


Maybe you mis-understood me.   I mean there is no written standard for the
naming of classes in the CODING_STANDARDS file, not that the
CODING_STANDARDS file is not to be followed (or changed if a part of it is
objectionable ;)

-Sterling


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




Re: AW: [PHP-DEV] 4.1 Declaration Case Persistance

2001-05-10 Thread Zeev Suraski

At 06:46 10/5/2001, Harald Radi wrote:
looking forward to getting php case sensitive i'm just wondering that
function names are exported mixed case in the com extension.
e.g. there's a COM_load() and a com_set(), is there a special reason for
this (zeev) ?

There's no special reason, and it's going to be fixed ifwhen we switch to 
case sensitivity (right now the declaration doesn't really matter).  At any 
rate, to match the standards file, I'll fix it to be lowercase.

another question: according to the CODING_STANDARDS file every function
should be lowercase, but how about exported classes ? is there a guidline
for this ?


No guidelines yet.  I'm sure we'll work on them when it becomes relevant.

Zeev


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




Re: AW: [PHP-DEV] 4.1 Declaration Case Persistance

2001-05-10 Thread Harald Radi



Sterling Hughes [EMAIL PROTECTED] schrieb im Newsbeitrag
news:[EMAIL PROTECTED]...
 On Thu, 10 May 2001, Jani Taskinen wrote:

  On Wed, 9 May 2001, Sterling Hughes wrote:
 
  On Thu, 10 May 2001, Jani Taskinen wrote:
   This is just because some developers don't like to follow the
guidelines.
   As, I quote, it woulnd't be fun anymore or you can't force
anyone.
  
  Hrrmmm.. Which guidelines would those be?  And no, you can't force
anyone,
 
  This one.. (from CODING_STANDARDS):
 
  8---
  Naming Conventions
  --
 
  [1] Function names for user-level functions should be enclosed with in
  the PHP_FUNCTION() macro. They should be in lowercase, with words
  8---


yea, but i wasn't talking about functions, i was talking about classes (in
particular
the com, dotnet and variant class). i couldn't find a guidline how to name
classes,
attributes or methods.

there is even no guidline in the PEAR CODING_STANDARDS file, but they use a
more c++ like
convention:

CLASS-lowerUpperUpper();

should this be adopted to have an uniform convetion ? any other ideas ?

and at least, how should they be documented in the php documentation (i
posted a mail 2 days
ago, but without response) ? afaik there is only a function/function
tag, but no
class/class, member/member, method/method,
constructor/constructor, etc. tags.

any suggestions ?

 
  And yes, you can force anyone. If they don't follow the guidelines set,
  their CVS access can as easily be taken from them as it was given..
  This is same as if someone intentionally breaks some parts of the code.
 
i didn't want to blame someone, the reason i asked was, that the com
extension
was originaly done by zeev, so i thought there was a reason for the naming.



-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




Re: AW: [PHP-DEV] 4.1 Declaration Case Persistance

2001-05-09 Thread Jani Taskinen

On Thu, 10 May 2001, Harald Radi wrote:

looking forward to getting php case sensitive i'm just wondering that

Me too.

function names are exported mixed case in the com extension.
e.g. there's a COM_load() and a com_set(), is there a special reason for
this (zeev) ?

This is just because some developers don't like to follow the guidelines.
As, I quote, it woulnd't be fun anymore or you can't force anyone.

another question: according to the CODING_STANDARDS file every function
should be lowercase, but how about exported classes ? is there a guidline
for this ?

See above.

--Jani



harald.

 -Ursprüngliche Nachricht-
 Von: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]Im Auftrag
 von Chuck Hagenbuch
 Gesendet: Freitag, 04. Mai 2001 21:10
 An: [EMAIL PROTECTED]
 Betreff: Re: [PHP-DEV] 4.1  Declaration Case Persistance


 Quoting Colin Viebrock [EMAIL PROTECTED]:

  One problem with case sensitivity (perhaps) is that it may make some
  scripts non-portable.

 That's a problem with it being an option, yes. I'd vote for just
 making php
 case sensitive, period.

 -chuck

 --
 must... find... acorns... *thud*

 --
 PHP Development Mailing List http://www.php.net/
 To unsubscribe, e-mail: [EMAIL PROTECTED]
 For additional commands, e-mail: [EMAIL PROTECTED]
 To contact the list administrators, e-mail: [EMAIL PROTECTED]







--
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]




Re: AW: [PHP-DEV] 4.1 Declaration Case Persistance

2001-05-09 Thread Sterling Hughes

On Thu, 10 May 2001, Jani Taskinen wrote:

 On Thu, 10 May 2001, Harald Radi wrote:

 looking forward to getting php case sensitive i'm just wondering that

 Me too.

 function names are exported mixed case in the com extension.
 e.g. there's a COM_load() and a com_set(), is there a special reason for
 this (zeev) ?

 This is just because some developers don't like to follow the guidelines.
 As, I quote, it woulnd't be fun anymore or you can't force anyone.


Hrrmmm.. Which guidelines would those be?  And no, you can't force anyone,
if you see something you don't like however, your welcome to change it,
and if its generally a good change, then it will be included in the code.

I've gone ahead and changed them all to lower case...  If its a bad change
I'm expecting people to bitch.

 another question: according to the CODING_STANDARDS file every function
 should be lowercase, but how about exported classes ? is there a guidline
 for this ?

 See above.


There is no standard in the CODING_STANDARDS file.

-Sterling


-- 
PHP Development Mailing List http://www.php.net/
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]