Ditto.
I have no conceptual issues with Jeroen's patch, but I would have
preferred a "please review on the branch" before comitting to HEAD.
I like Zeev's suggestions. Is someone already on it, or should I get
started? ;)
Jeroen, I was waiting for you tell us the branch was stable before I
bega
Rasmus Lerdorf wrote:
> When he merged his branch into the HEAD branch everyone suddenly
> noticed because everyone keeps track of the HEAD branch.
That's the point, I think. I for one expected Jeroen to post a
message like "I'm done with my rewrite, have a look at the
branch", or somethi
> the rest of you, STOP MOANING.
> either moan _BEFORE_ the commit OR give him CONSTRUCTIVE feedback OR shut
> up.
>
> i thought the whole php-dev-group was mature.
> guess i was wrong.
It has more to do with lack of attentiveness than maturity. Jeroen was
playing with code in a branch and nobod
i'm not even close to being a phpdeveloper, so i should really shut up.
but i won't.
i read the interesting stuff on php-dev (!bugs that is) and i find this
rand-story quite childish.
jeroen, you've done everything one would expect someone committing something
new/changing to do.
the rest of