Re: [PHP-DEV] NSAPI patch / CVS access

[Andi Gutmans]

At 10:29 AM 3/2/2001 -0600, Andrew Johnson wrote:
>Andi Gutmans wrote:
> >
> > I just reviewed the patch quickly. Are you sure that using MALLOC() for the
> > SG(request_info) variables is OK?
>
>I think so.  php4_execute() contains
> nsapi_request_ctor(NSLS_C SLS_CC);
> retval = nsapi_module_main(NSLS_C SLS_CC);
> nsapi_request_dtor(NSLS_C SLS_CC);
>where the _ctor routine does the MALLOC()s and _dtor the FREE()s.

OK I just wanted to make sure that you guys checked this.


>(Appologies for my last unnecessary email Andi, I usually work through my
>email serially...).

Happens to me all the time :)

Andi


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Re: [PHP-DEV] NSAPI patch / CVS access

[Andrew Johnson]

Andi Gutmans wrote:
> 
> I just reviewed the patch quickly. Are you sure that using MALLOC() for the
> SG(request_info) variables is OK?

I think so.  php4_execute() contains
nsapi_request_ctor(NSLS_C SLS_CC);
retval = nsapi_module_main(NSLS_C SLS_CC);
nsapi_request_dtor(NSLS_C SLS_CC);
where the _ctor routine does the MALLOC()s and _dtor the FREE()s.

(Appologies for my last unnecessary email Andi, I usually work through my
email serially...).

- Andrew
-- 
Every great idea appears crazy to start with.

-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Re: [PHP-DEV] NSAPI patch / CVS access

[Andi Gutmans]

I just reviewed the patch quickly. Are you sure that using MALLOC() for the 
SG(request_info) variables is OK?
Are these all variables which are supposed to be freed by the SAPI module? 
(I think they are but I don't have time to double check this). If the SAPI 
module is in charge then it's OK but if it's PHP (SAPI.c) then it probably 
isn't.

Andi

At 01:26 PM 3/2/2001 +0100, Whitehead Anthony wrote:
>Hiyas,
>
>I just tried to commit the attached patch to the NSAPI module but it seems my
>CVS write
>access has expired ;)
>
>Here attached is the patch for NSAPI from Andrew Johnson, I've tested it on
>several UNIX
>platforms and adjusted it slightly to allow patching of the latest CVS 
>version.
>
>If someone wants to commit this for us, or re-enable my CVS account I'd be
>happy.
>
>-Anthony Whitehead
>Central Data Services
>Swedish Social Security Ministry
>
>--
>PHP Development Mailing List 
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]
>To contact the list administrators, e-mail: [EMAIL PROTECTED]


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Re: [PHP-DEV] NSAPI patch / CVS access

[Andi Gutmans]

I commited your patch.

Andi

At 01:26 PM 3/2/2001 +0100, Whitehead Anthony wrote:
>Hiyas,
>
>I just tried to commit the attached patch to the NSAPI module but it seems my
>CVS write
>access has expired ;)
>
>Here attached is the patch for NSAPI from Andrew Johnson, I've tested it on
>several UNIX
>platforms and adjusted it slightly to allow patching of the latest CVS 
>version.
>
>If someone wants to commit this for us, or re-enable my CVS account I'd be
>happy.
>
>-Anthony Whitehead
>Central Data Services
>Swedish Social Security Ministry
>
>--
>PHP Development Mailing List 
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]
>To contact the list administrators, e-mail: [EMAIL PROTECTED]


-- 
PHP Development Mailing List 
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]