Re: [PHP-DEV] a FIXME in head.c

2001-07-22 Thread Markus Fischer
On Sat, Jul 21, 2001 at 06:52:59PM +0300, Zeev Suraski wrote : > At 18:48 21/07/2001, Rasmus Lerdorf wrote: > >And just for kicks I looked up who wrote that comment: > > > >Mon Mar 16 06:41:11 1998 UTC (40 months ago) by jaakko > > > >That's a long time for a FIXME comment to survive! ;) > > We

Re: [PHP-DEV] a FIXME in head.c

2001-07-21 Thread Zeev Suraski
At 18:48 21/07/2001, Rasmus Lerdorf wrote: >And just for kicks I looked up who wrote that comment: > >Mon Mar 16 06:41:11 1998 UTC (40 months ago) by jaakko > >That's a long time for a FIXME comment to survive! ;) We'll get 'em all, eventually :) Zeev -- PHP Development Mailing List

Re: [PHP-DEV] a FIXME in head.c

2001-07-21 Thread Rasmus Lerdorf
> In the implementation of setcookie(), there's a FIXME line reading: > /* FIXME: XXX: this is not binary data safe */ > > I don't see how this can be binary safe, as we're creating a header line, > which cannot contain NULLs anyway. I think this comment should be removed, > but I want to see if