Re: [PHP] Re: Function size

2012-06-03 Thread Tony Marston
"Tim Streater" wrote in message news:d0.7c.45755.25a3b...@pb1.pair.com... On 03 Jun 2012 at 10:02, Tony Marston wrote: "tamouse mailing lists" wrote in message news:cahuc_t__sw-_yhrw4n4uqr-fa46+cebunzgehboaatrafla...@mail.gmail.com... There is a point: if you are unfamiliar with code, wa

Re: [PHP] Re: Function size

2012-06-03 Thread Tim Streater
On 03 Jun 2012 at 10:02, Tony Marston wrote: > "tamouse mailing lists" wrote in message > news:cahuc_t__sw-_yhrw4n4uqr-fa46+cebunzgehboaatrafla...@mail.gmail.com... >> There is a point: if you are unfamiliar with code, wading through >> screens and screens of a function to find things like blo

Re: [PHP] Re: Function size

2012-06-03 Thread Tony Marston
"tamouse mailing lists" wrote in message news:cahuc_t__sw-_yhrw4n4uqr-fa46+cebunzgehboaatrafla...@mail.gmail.com... On Tue, May 29, 2012 at 2:52 AM, Tony Marston wrote: On May 21, 2012, at 8:32 PM, tamouse mailing lists wrote: A rule of thumb is no more than 50 lines per function, most much

Re: [PHP] Re: Function size

2012-05-31 Thread tamouse mailing lists
On Tue, May 29, 2012 at 2:52 AM, Tony Marston wrote: > On May 21, 2012, at 8:32 PM, tamouse mailing lists wrote: >>  A rule of thumb is no more than 50 lines per >> function, most much less. Back in the day when we didn't have nifty >> gui screens and an 24 line terminals (yay green on black!), if

RE: [PHP] Re: Function size

2012-05-30 Thread admin
-Original Message- From: Paul M Foster [mailto:pa...@quillandmouse.com] Sent: Wednesday, May 30, 2012 10:54 AM To: php-general@lists.php.net Subject: Re: [PHP] Re: Function size On Wed, May 30, 2012 at 04:31:12PM +0200, Sebastian Krebs wrote: [snip] > > If the functions were

Re: [PHP] Re: Function size

2012-05-30 Thread Paul M Foster
On Wed, May 30, 2012 at 04:31:12PM +0200, Sebastian Krebs wrote: [snip] > > If the functions were named properly you don't have to follow every > execution path to the deepest deep. Or do you reading PHPs C-source, just > because a wild "substr()" appeared? When you see a method "loadFromFile()

RE: [PHP] Re: Function size

2012-05-30 Thread Steven Staples
> Paul, > > Are you stating here that compression is a bad thing? > > That means you consider this nice: > > if ( action == A ) > { > doA(); > } > else if (action == B ) > { > doB(); > } > else > { > doC(); > } > > Or perhaps flooded with comments that merely say the same as the cod

Re: [PHP] Re: Function size

2012-05-30 Thread Paul M Foster
On Tue, May 29, 2012 at 11:40:25PM +0200, Matijn Woudt wrote: [snip] > On Tue, May 29, 2012 at 11:06 PM, Paul M Foster > wrote: [snip] > > > > I think a lot of coders try to be kewler than the next 18 guys who are > > gonna have to look at the code, so they use a lot of "compression" > > tech

Re: [PHP] Re: Function size

2012-05-30 Thread Sebastian Krebs
Hi, Just want to throw my 2 cent in :) 2012/5/30 Tony Marston > > "Ashley Sheridan" wrote in message > news:1338326229.2616.31.camel@localhost.localdomain... > > On Tue, 2012-05-29 at 17:06 -0400, Paul M Foster wrote: > > > >> On Tue, May 29, 2012 at 08:52:46AM +0100, Tony Marston wrote: > >>

Re: [PHP] Re: Function size

2012-05-30 Thread Tony Marston
"Ashley Sheridan" wrote in message news:1338326229.2616.31.camel@localhost.localdomain... > On Tue, 2012-05-29 at 17:06 -0400, Paul M Foster wrote: > >> On Tue, May 29, 2012 at 08:52:46AM +0100, Tony Marston wrote: >> >> > On May 21, 2012, at 8:32 PM, tamouse mailing lists wrote: >> > > A rule

Re: [PHP] Re: Function size

2012-05-29 Thread Matijn Woudt
On Tue, May 29, 2012 at 11:06 PM, Paul M Foster wrote: > OMG in alpha order?! At best, I might group them together by function > type, with some comment notation in the file. But not alpha order. I > prefer not to have "forward declares" in my files, so I generally > arrange functions so that thos

Re: [PHP] Re: Function size

2012-05-29 Thread Ashley Sheridan
On Tue, 2012-05-29 at 17:06 -0400, Paul M Foster wrote: > On Tue, May 29, 2012 at 08:52:46AM +0100, Tony Marston wrote: > > > On May 21, 2012, at 8:32 PM, tamouse mailing lists wrote: > > > A rule of thumb is no more than 50 lines per > > > function, most much less. Back in the day when we didn'

Re: [PHP] Re: Function size

2012-05-29 Thread Paul M Foster
On Tue, May 29, 2012 at 08:52:46AM +0100, Tony Marston wrote: > On May 21, 2012, at 8:32 PM, tamouse mailing lists wrote: > > A rule of thumb is no more than 50 lines per > > function, most much less. Back in the day when we didn't have nifty > > gui screens and an 24 line terminals (yay green on

Re: [PHP] Re: Function size

2012-05-24 Thread Ashley Sheridan
On Thu, 2012-05-24 at 15:48 -0500, tamouse mailing lists wrote: > On May 23, 2012 9:14 AM, "Tedd Sperling" wrote: > > > > Hi gang: > > > > On May 21, 2012, at 8:32 PM, tamouse mailing lists wrote: > > > A rule of thumb is no more than 50 lines per > > > function, most much less. Back in the day