Re: [PHP-I18N] is_string()

2006-03-17 Thread Andrei Zmievski
I find that confusing too. Given the commit log, it is even more confusing: - Updated is_string(): If Unicode semantics is turned on, return "true" for Unicode strings only. If Unicode semantics is turned off, return "true" for native strings only. It makes is_string basically useles

Re: [PHP-I18N] is_string()

2006-03-17 Thread M. Sokolewicz
Pierre wrote: On Wed, 15 Mar 2006 12:26:53 -0800 [EMAIL PROTECTED] (Andrei Zmievski) wrote: I guess I can live with this. It's just a little strange that we have only 2 string types, but 3 casts.. I find that confusing too. Given the commit log, it is even more confusing: - Updated is_stri

Re: [PHP-I18N] is_string()

2006-03-17 Thread Pierre
On Wed, 15 Mar 2006 12:26:53 -0800 [EMAIL PROTECTED] (Andrei Zmievski) wrote: > I guess I can live with this. It's just a little strange that we have > only 2 string types, but 3 casts.. I find that confusing too. Given the commit log, it is even more confusing: - Updated is_string(): If Uni

Re: [PHP-I18N] is_string()

2006-03-15 Thread Andrei Zmievski
I guess I can live with this. It's just a little strange that we have only 2 string types, but 3 casts.. I would also say we need to allow automatic upconversion on binary/unicode concatenation and comparison using runtime encoding. We should also restrict binary string literals to contain ASC

RE: [PHP-I18N] is_string()

2006-03-15 Thread Dmitry Stogov
s Boerger'; 'Unicode Mailinglist' > Subject: RE: [PHP-I18N] is_string() > > > On Wed, 15 Mar 2006, Dmitry Stogov wrote: > > > In case of "> is_string(): Z_TYPE_P() == IS_STRING || > Z_TYPE_P() == > > IS_UNICODE", > > is_string() wi

RE: [PHP-I18N] is_string()

2006-03-15 Thread Derick Rethans
On Wed, 15 Mar 2006, Dmitry Stogov wrote: > In case of "> is_string(): Z_TYPE_P() == IS_STRING || Z_TYPE_P() == > IS_UNICODE", > is_string() will return TRUE for binary data in unicode mode. > > It should be: > is_string(): Z_TYPE_P() == (UG(unicode)?IS_UNICODE:IS_STRING) > > is_binary() and i

RE: [PHP-I18N] is_string()

2006-03-15 Thread Dmitry Stogov
t; -Original Message- > From: Marcus Boerger [mailto:[EMAIL PROTECTED] > Sent: Wednesday, March 15, 2006 1:48 PM > To: Derick Rethans > Cc: Unicode Mailinglist > Subject: Re: [PHP-I18N] is_string() > > > Hello Derick, > > Wednesday, March 15, 2006, 10:24:37 AM

Re: [PHP-I18N] is_string()

2006-03-15 Thread Marcus Boerger
Hello Derick, Wednesday, March 15, 2006, 10:24:37 AM, you wrote: > Hello! > The past few days I've been trying to get some of our code to run on PHP > 6 with unicode semantics turned on to be able to provide some > benchmarking. Ofcourse I found some BC breaking behavior, where the > followin

[PHP-I18N] is_string()

2006-03-15 Thread Derick Rethans
Hello! The past few days I've been trying to get some of our code to run on PHP 6 with unicode semantics turned on to be able to provide some benchmarking. Ofcourse I found some BC breaking behavior, where the following one is bringing the largest WTF factor: [EMAIL PROTECTED