Re: [PHPTAL] DOM parser
Hello, Sorry for the response delay. At some point, I saw I was in the middle of a big really big refactoring, and I'm afraid it is very related to the framework I use. However I would like to make some observations about my findings. Apart from the DOM parser, one of the things I pursued was to replace constants by configuration, and remove code that was automatically executed during file inclusion. E.g., namespaces are registered if PHPTAL is configured for that, and then it registers only what is set in config - and by default config has the built-in namespaces :). I'd like to elaborate these a bit more as suggestions for PHPTAL, but first I have to dig back what I've done. Then, I'll try to extract the DOM parser into a pure PHPTAL installation, because mine is *too* changed now :(. regards, rodrigo moraes ___ PHPTAL mailing list PHPTAL@lists.motion-twin.com http://lists.motion-twin.com/mailman/listinfo/phptal
Re: [PHPTAL] DOM parser
How are the progress on this going? Do you have a blog / SVN repos somewhere, so that we can help with testing? Thank you for your time and efforts, Werner Rodrigo Moraes wrote: Hello, I've been working on a (big) refactoring of PHPTAL to use on my system and decided to try to use native PHP DOM to parse templates. So I tried and things are going well: 122/122 tests, 0 seconds 16 fail, 11 todo, 0 skip, 95 pass Which is quite a good result for a beginning. :) I'll work now to make all tests pass, but I feel that the biggest part is done. Anyone interested to take a look at it? Laurent, many thanks for this awesome library. :) -- rodrigo ___ PHPTAL mailing list PHPTAL@lists.motion-twin.com http://lists.motion-twin.com/mailman/listinfo/phptal ___ PHPTAL mailing list PHPTAL@lists.motion-twin.com http://lists.motion-twin.com/mailman/listinfo/phptal
Re: [PHPTAL] DOM parser
Okay. I'm all for moving to DOM, makes the whole thing more lightweight. I must say, I just last week thought about doing just the same thing ;) Great work. Count me in on testing and stuff. Laurent, what do you think, can we move this forward for a potential v2? Am 01.11.2007 um 14:54 schrieb Rodrigo Moraes: On 11/1/07, David Zülke wrote: Sounds cool. Is it faster, too? That could be a good base for PHPTAL2 ;) Hm, haven't benchmarked it yet (have to finish it first), but I bet it would be some times faster, for obvious reasons. Not that this is big a problem because templates are compiled, but it makes parsing faster at least and removes some code from the library scope (and adds a series of new DOM problems :P). As soon as I run some benchmarks, I'll send the numbers. -- rodrigo ___ PHPTAL mailing list PHPTAL@lists.motion-twin.com http://lists.motion-twin.com/mailman/listinfo/phptal ___ PHPTAL mailing list PHPTAL@lists.motion-twin.com http://lists.motion-twin.com/mailman/listinfo/phptal
Re: [PHPTAL] DOM parser
On 11/1/07, David Zülke wrote: > Sounds cool. Is it faster, too? That could be a good base for PHPTAL2 ;) Hm, haven't benchmarked it yet (have to finish it first), but I bet it would be some times faster, for obvious reasons. Not that this is big a problem because templates are compiled, but it makes parsing faster at least and removes some code from the library scope (and adds a series of new DOM problems :P). As soon as I run some benchmarks, I'll send the numbers. -- rodrigo ___ PHPTAL mailing list PHPTAL@lists.motion-twin.com http://lists.motion-twin.com/mailman/listinfo/phptal
Re: [PHPTAL] DOM parser
Sounds cool. Is it faster, too? That could be a good base for PHPTAL2 ;) - David Am 01.11.2007 um 14:40 schrieb Rodrigo Moraes: Hello, I've been working on a (big) refactoring of PHPTAL to use on my system and decided to try to use native PHP DOM to parse templates. So I tried and things are going well: 122/122 tests, 0 seconds 16 fail, 11 todo, 0 skip, 95 pass Which is quite a good result for a beginning. :) I'll work now to make all tests pass, but I feel that the biggest part is done. Anyone interested to take a look at it? Laurent, many thanks for this awesome library. :) -- rodrigo ___ PHPTAL mailing list PHPTAL@lists.motion-twin.com http://lists.motion-twin.com/mailman/listinfo/phptal ___ PHPTAL mailing list PHPTAL@lists.motion-twin.com http://lists.motion-twin.com/mailman/listinfo/phptal
[PHPTAL] DOM parser
Hello, I've been working on a (big) refactoring of PHPTAL to use on my system and decided to try to use native PHP DOM to parse templates. So I tried and things are going well: 122/122 tests, 0 seconds 16 fail, 11 todo, 0 skip, 95 pass Which is quite a good result for a beginning. :) I'll work now to make all tests pass, but I feel that the biggest part is done. Anyone interested to take a look at it? Laurent, many thanks for this awesome library. :) -- rodrigo ___ PHPTAL mailing list PHPTAL@lists.motion-twin.com http://lists.motion-twin.com/mailman/listinfo/phptal
