[piccolo2d-dev] Re: Any objections to me adding Cobertura coverage report to the Maven Build?
now it's me who can't follow. Cobertura? You don't mean such a thing: http://files.getdropbox.com/u/965005/piccolo2d.java/site-stage/piccolo2d-core/cobertura/index.html - do You? That's part of the mvn build ever since. M --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Re: Any objections to me adding Cobertura coverage report to the Maven Build?
I do mean such a thing. I'm not used to having the parent's pom file split into a subdirecty. My bad. Thanks. On Jul 16, 5:54 am, Marcus Rohrmoser mr0...@mro.name wrote: now it's me who can't follow. Cobertura? You don't mean such a thing:http://files.getdropbox.com/u/965005/piccolo2d.java/site-stage/piccol... - do You? That's part of the mvn build ever since. M --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Re: Any objections to me adding Cobertura coverage report to the Maven Build?
Am 16.07.2009 um 13:41 schrieb allain: I do mean such a thing. I'm not used to having the parent's pom file split into a subdirecty. My bad. Thanks. BTW: I really like the growing green in there. You're a gifted gardener ;-) --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] [piccolo2d commit] r477 - Made cobertura plugin output xml format as well as generating an html report
Author: allain.lalonde
Date: Thu Jul 16 05:16:01 2009
New Revision: 477
Modified:
piccolo2d.java/trunk/parent/pom.xml
Log:
Made cobertura plugin output xml format as well as generating an html report
Modified: piccolo2d.java/trunk/parent/pom.xml
==
--- piccolo2d.java/trunk/parent/pom.xml (original)
+++ piccolo2d.java/trunk/parent/pom.xml Thu Jul 16 05:16:01 2009
@@ -16,12 +16,15 @@
httpbasehttp://www.piccolo2d.org/java/httpbase
httpsitebase${httpbase}/site/httpsitebase
!-- ftpbaseftp://jcurl.org/ftpbase
- ftpsitebase${ftpbase}/site/ftpsitebase --
+ ftpsitebase${ftpbase}/site/ftpsitebase
+--
scpbase
- !-- @TODO Will, is there ssh access to the website?
Required for
artifact upload. --
+ !-- @TODO Will, is there ssh access to the website?
Required for
artifact upload.
+--
/scpbase
scpsitebase
- !-- @TODO Will, is there ssh access to the website?
Required for maven
site upload. --
+ !-- @TODO Will, is there ssh access to the website?
Required for maven
site upload.
+--
/scpsitebase
/properties
url${httpsitebase}/${pom.artifactId}/${pom.version}/url
@@ -88,7 +91,8 @@
groupIdorg.apache.maven.wagon/groupId
artifactIdwagon-ftp/artifactId
/extension
- /extensions --
+ /extensions
+--
plugins
plugin
artifactIdmaven-compiler-plugin/artifactId
@@ -114,6 +118,12 @@
plugin
groupIdorg.codehaus.mojo/groupId
artifactIdcobertura-maven-plugin/artifactId
+ configuration
+ formats
+ formatxml/format
+ formathtml/format
+ /formats
+ /configuration
executions
execution
goals
--~--~-~--~~~---~--~~
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
-~--~~~~--~~--~--~---
[piccolo2d-dev] [piccolo2d commit] r479 - Issue 53. Removing Test Code that can't be run in Headless mode
Author: allain.lalonde
Date: Thu Jul 16 08:22:57 2009
New Revision: 479
Removed:
piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/PFrameTest.java
Modified:
piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/pswing/PSwingTest.java
Log:
Issue 53. Removing Test Code that can't be run in Headless mode
Modified:
piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/pswing/PSwingTest.java
==
---
piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/pswing/PSwingTest.java
(original)
+++
piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/pswing/PSwingTest.java
Thu Jul 16 08:22:57 2009
@@ -35,27 +35,17 @@
import java.awt.image.BufferedImage;
import java.io.IOException;
-import javax.swing.JButton;
import javax.swing.JPanel;
import javax.swing.RepaintManager;
import junit.framework.TestCase;
-import edu.umd.cs.piccolox.PFrame;
/**
* JUnit test class to exercise PSwing bugfixes.
*
* @author Stephen Chin
*/
-public class PSwingTest extends TestCase {
-
-public void testPSwing() {
-PSwing pSwing = new PSwing(new JButton(test));
-PFrame frame = new PFrame();
-frame.getCanvas().getLayer().addChild(pSwing);
-frame.setVisible(true);
-}
-
+public class PSwingTest extends TestCase {
public void setUp() {
RepaintManager.setCurrentManager(new PSwingRepaintManager());
}
--~--~-~--~~~---~--~~
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
-~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 97 in piccolo2d: TestPSwing.java and TestPSwingFull.java Should be moved
Updates: Status: Fixed Comment #2 on issue 97 by allain.lalonde: TestPSwing.java and TestPSwingFull.java Should be moved http://code.google.com/p/piccolo2d/issues/detail?id=97 Fixed in r478; moved them to examples project and renamed them PSwingExample1 and 2. Not the best names, but short of calling them MegaPSwingExample and UberCoolHyperMageNetPSwingExample, they'll have to do. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 96 in piccolo2d: More consistent handling of NonInvertible transforms in PCamera
Comment #1 on issue 96 by allain.lalonde: More consistent handling of NonInvertible transforms in PCamera http://code.google.com/p/piccolo2d/issues/detail?id=96 I'll take no response as agreement since this seems to be something that few care enough about to answer about. I'll wait a little longer and then make the changes if there's not response. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 90 in piccolo2d: Binary incompatible change from 1.2.1 in PInputEvent
Comment #3 on issue 90 by allain.lalonde: Binary incompatible change from 1.2.1 in PInputEvent http://code.google.com/p/piccolo2d/issues/detail?id=90 Almost seems like we're trying to force two different kinds of things into one. Seems like there could be two subclasses PPickPathInputEvent event and PCameraInputEvent since there are methods that assume you have a PPickpath, like getPickedNode and lots of return (getPath() == null)? inputSource : getPath().get... thoughts? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 94 in piccolo2d: PLayer should do nothing when removing a camera that isn't attached
Comment #2 on issue 94 by allain.lalonde: PLayer should do nothing when removing a camera that isn't attached http://code.google.com/p/piccolo2d/issues/detail?id=94 Since there's no answer I'll assume that's agreement or apathy. So, I'll give it a little longer and make the change. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] [piccolo2d commit] r480 - Simplifying getInverseTransform and making it not call printStackTrace() since it was hand...
Author: allain.lalonde
Date: Thu Jul 16 11:28:35 2009
New Revision: 480
Modified:
piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/PNode.java
Log:
Simplifying getInverseTransform and making it not call printStackTrace()
since it was handling that case anyway. Issue #96 may make this a
non-issue anyway.
Modified:
piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/PNode.java
==
--- piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/PNode.java
(original)
+++ piccolo2d.java/trunk/core/src/main/java/edu/umd/cs/piccolo/PNode.java
Thu Jul 16 11:28:35 2009
@@ -2131,15 +2131,13 @@
if (transform == null) {
return new PAffineTransform();
}
-else {
-try {
-return new PAffineTransform(transform.createInverse());
-}
-catch (NoninvertibleTransformException e) {
-e.printStackTrace();
-}
-return null;
+
+try {
+return new PAffineTransform(transform.createInverse());
}
+catch (NoninvertibleTransformException e) {
+return null;
+}
}
/**
--~--~-~--~~~---~--~~
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
-~--~~~~--~~--~--~---
[piccolo2d-dev] Re: What's with all the paramStrings?
super.toString().replaceAll(.*\\., ) is used to strip away package names from the default toString implementation. 2009/7/15 Samuel Robert Reid re...@colorado.edu I don't see any advantage of the way toString is factored into a paramString part, and I've never used paramString directly in any of my piccolo2d client code, so I'd be okay with this getting refactored . Also, what's the reason for the: String result = super.toString().replaceAll(.*\\., ); in the first line of the PNode.toString? Sam Reid allain wrote: Most of the comments on them sound exactly like what toString is designed for. toString() should only ever be used for providing a better debug output on an object. --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] What's up with new PBounds(Point2D, double, double)
Here's the definition:
public PBounds(Point2D aCenterPoint, double insetX, double insetY)
{
this(aCenterPoint.getX(), aCenterPoint.getY(), 0, 0);
inset(insetX, insetY);
}
The only place it's called from from within the framework is:
public PPickPath pick(double x, double y, double halo) {
PBounds b = new PBounds(new Point2D.Double(x, y), -halo, -
halo);
...
What the hell is that?
If you pass it, what I consider pretty reasonable values of new PBounds
(new Point2D.Double(), 10, 10);
I'd expect to get a square with -10, -10 as its top left and a width/
height of 20, what you get instead is a square located at 10, 10 with
a width/height of -20.
Uh... maybe this should be written to guarantee a positive width,
height, which would remove the requirement to negate the insets every
time you want to use this constructor.
Thoughts?
--~--~-~--~~~---~--~~
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
-~--~~~~--~~--~--~---
[piccolo2d-dev] [piccolo2d commit] r481 - Issue 69 ; adding render quality parameter
Author: heuermh
Date: Thu Jul 16 13:05:41 2009
New Revision: 481
Modified:
piccolo2d.java/trunk/extras/src/main/java/edu/umd/cs/piccolox/POffscreenCanvas.java
piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/POffscreenCanvasTest.java
Log:
Issue 69 ; adding render quality parameter
Modified:
piccolo2d.java/trunk/extras/src/main/java/edu/umd/cs/piccolox/POffscreenCanvas.java
==
---
piccolo2d.java/trunk/extras/src/main/java/edu/umd/cs/piccolox/POffscreenCanvas.java
(original)
+++
piccolo2d.java/trunk/extras/src/main/java/edu/umd/cs/piccolox/POffscreenCanvas.java
Thu Jul 16 13:05:41 2009
@@ -49,6 +49,12 @@
/** Camera for this offscreen canvas. */
private PCamera camera;
+/** Render quality. */
+private int renderQuality = DEFAULT_RENDER_QUALITY;
+
+/** Default render quality,
codePPaintContext.HIGH_QUALITY_RENDERING/code. */
+static final int DEFAULT_RENDER_QUALITY =
PPaintContext.HIGH_QUALITY_RENDERING;
+
/**
* Create a new offscreen canvas the specified width and height.
@@ -78,7 +84,7 @@
throw new IllegalArgumentException(graphics must not be
null);
}
PPaintContext paintContext = new PPaintContext(graphics);
-
paintContext.setRenderQuality(PPaintContext.HIGH_QUALITY_RENDERING);
+paintContext.setRenderQuality(renderQuality);
camera.fullPaint(paintContext);
}
@@ -105,6 +111,31 @@
*/
public PCamera getCamera() {
return camera;
+}
+
+/**
+ * Set the render quality hint for this offscreen canvas to
coderenderQuality/code.
+ *
+ * @param renderQuality render quality hint, must be one of
codePPaintContext.HIGH_QUALITY_RENDERING/code
+ *or codePPaintContext.LOW_QUALITY_RENDERING/code
+ */
+public void setRenderQuality(final int renderQuality) {
+if ((renderQuality == PPaintContext.HIGH_QUALITY_RENDERING)
+|| (renderQuality == PPaintContext.LOW_QUALITY_RENDERING))
{
+this.renderQuality = renderQuality;
+} else {
+throw new IllegalArgumentException(renderQuality must be one
of PPaintContext.HIGH_QUALITY_RENDERING
++ or PPaintContext.LOW_QUALITY_RENDERING, was +
renderQuality);
+}
+}
+
+/**
+ * Return the render quality hint for this offscreen canvas.
+ *
+ * @return the render quality hint for this offscreen canvas
+ */
+public int getRenderQuality() {
+return renderQuality;
}
/*...@inheritdoc} */
Modified:
piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/POffscreenCanvasTest.java
==
---
piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/POffscreenCanvasTest.java
(original)
+++
piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/POffscreenCanvasTest.java
Thu Jul 16 13:05:41 2009
@@ -37,8 +37,7 @@
import edu.umd.cs.piccolo.PCamera;
import edu.umd.cs.piccolo.nodes.PPath;
-
-import edu.umd.cs.piccolo.util.PBounds;
+import edu.umd.cs.piccolo.util.PPaintContext;
import junit.framework.TestCase;
@@ -58,21 +57,21 @@
assertNotNull(canvas3);
try {
-POffscreenCanvas canvas = new POffscreenCanvas(-1, 100);
+new POffscreenCanvas(-1, 100);
fail(ctr(-1, 100) expected IllegalArgumentException);
}
catch (IllegalArgumentException e) {
// expected
}
try {
-POffscreenCanvas canvas = new POffscreenCanvas(100, -1);
+new POffscreenCanvas(100, -1);
fail(ctr(100, -1) expected IllegalArgumentException);
}
catch (IllegalArgumentException e) {
// expected
}
try {
-POffscreenCanvas canvas = new POffscreenCanvas(-1, -1);
+new POffscreenCanvas(-1, -1);
fail(ctr(-1, -1) expected IllegalArgumentException);
}
catch (IllegalArgumentException e) {
@@ -135,6 +134,22 @@
POffscreenCanvas canvas = new POffscreenCanvas(100, 200);
canvas.render(null);
fail(render(null) expected IllegalArgumentException);
+}
+catch (IllegalArgumentException e) {
+// expected
+}
+}
+
+public void testRenderQuality() {
+POffscreenCanvas canvas = new POffscreenCanvas(100, 200);
+assertEquals(POffscreenCanvas.DEFAULT_RENDER_QUALITY,
canvas.getRenderQuality());
+canvas.setRenderQuality(PPaintContext.HIGH_QUALITY_RENDERING);
+assertEquals(PPaintContext.HIGH_QUALITY_RENDERING,
canvas.getRenderQuality());
+canvas.setRenderQuality(PPaintContext.LOW_QUALITY_RENDERING);
+assertEquals(PPaintContext.LOW_QUALITY_RENDERING,
[piccolo2d-dev] [piccolo2d commit] r482 - Issue 74 ; adding unit test for PSwingRepaintManager
Author: heuermh
Date: Thu Jul 16 14:06:09 2009
New Revision: 482
Added:
piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/pswing/PSwingRepaintManagerTest.java
Log:
Issue 74 ; adding unit test for PSwingRepaintManager
Added:
piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/pswing/PSwingRepaintManagerTest.java
==
--- (empty file)
+++
piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/pswing/PSwingRepaintManagerTest.java
Thu Jul 16 14:06:09 2009
@@ -0,0 +1,174 @@
+/*
+ * Copyright (c) 2008-2009, Piccolo2D project, http://piccolo2d.org
+ * Copyright (c) 1998-2008, University of Maryland
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
modification, are permitted provided
+ * that the following conditions are met:
+ *
+ * Redistributions of source code must retain the above copyright notice,
this list of conditions
+ * and the following disclaimer.
+ *
+ * Redistributions in binary form must reproduce the above copyright
notice, this list of conditions
+ * and the following disclaimer in the documentation and/or other
materials provided with the
+ * distribution.
+ *
+ * None of the name of the University of Maryland, the name of the
Piccolo2D project, or the names of its
+ * contributors may be used to endorse or promote products derived from
this software without specific
+ * prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS AS
IS AND ANY EXPRESS OR IMPLIED
+ * WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
MERCHANTABILITY AND FITNESS FOR A
+ * PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
OWNER OR CONTRIBUTORS BE LIABLE FOR
+ * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
CONTRACT, STRICT LIABILITY, OR
+ * TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
USE OF THIS SOFTWARE, EVEN IF
+ * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+package edu.umd.cs.piccolox.pswing;
+
+import java.awt.Canvas;
+import java.awt.Component;
+
+import javax.swing.JComponent;
+import javax.swing.JPanel;
+import javax.swing.RepaintManager;
+
+import junit.framework.TestCase;
+
+/**
+ * Unit test for PSwingRepaintManager.
+ */
+public class PSwingRepaintManagerTest extends TestCase {
+
+public void testConstructor() {
+PSwingRepaintManager repaintManager = new PSwingRepaintManager();
+assertNotNull(repaintManager);
+}
+
+public void testCurrentManager() {
+RepaintManager currentManager =
RepaintManager.currentManager(null);
+assertNotNull(currentManager);
+assertFalse(currentManager instanceof PSwingRepaintManager);
+
+Component awtComponent = new Canvas();
+currentManager = RepaintManager.currentManager(awtComponent);
+assertNotNull(currentManager);
+assertFalse(currentManager instanceof PSwingRepaintManager);
+
+JComponent swingComponent = new JPanel();
+currentManager = RepaintManager.currentManager(swingComponent);
+assertNotNull(currentManager);
+assertFalse(currentManager instanceof PSwingRepaintManager);
+
+PSwingCanvas pswingCanvas = new PSwingCanvas();
+currentManager = RepaintManager.currentManager(pswingCanvas);
+assertNotNull(currentManager);
+assertTrue(currentManager instanceof PSwingRepaintManager);
+
+// once a PSwingCanvas has been instantiated,
+// PSwingRepaintManager replaces RepaintManager everwhere
+currentManager = RepaintManager.currentManager(awtComponent);
+assertTrue(currentManager instanceof PSwingRepaintManager);
+
+currentManager = RepaintManager.currentManager(swingComponent);
+assertTrue(currentManager instanceof PSwingRepaintManager);
+
+currentManager = RepaintManager.currentManager(pswingCanvas);
+assertTrue(currentManager instanceof PSwingRepaintManager);
+}
+
+public void testLockRepaint() {
+PSwingCanvas canvas = new PSwingCanvas();
+RepaintManager currentManager =
RepaintManager.currentManager(canvas);
+assertNotNull(currentManager);
+assertTrue(currentManager instanceof PSwingRepaintManager);
+
+PSwingRepaintManager repaintManager = (PSwingRepaintManager)
currentManager;
+// TODO: should lockRepaint allow null?
+repaintManager.lockRepaint(null);
+repaintManager.lockRepaint(canvas);
+}
+
+public void testUnlockRepaint() {
+PSwingCanvas canvas = new PSwingCanvas();
+RepaintManager currentManager =
[piccolo2d-dev] Issue 98 in piccolo2d: Refactor edu.umd.cs.piccolo.pswingexamples and ...swtexamples to examples.pswing and examples.swt
Status: New Owner: Labels: Type-Enhancement Priority-Low Effort-Low Toolkit-Piccolo2D.Java OpSys-All Component-Examples Milestone-1.3 New issue 98 by heuermh: Refactor edu.umd.cs.piccolo.pswingexamples and ...swtexamples to examples.pswing and examples.swt http://code.google.com/p/piccolo2d/issues/detail?id=98 Packages edu.umd.cs.piccolo.pswingexamples edu.umd.cs.piccolo.swtexamples should be refactored to edu.umd.cs.piccolo.examples.pswing edu.umd.cs.piccolo.examples.swt to match the package structure in core and extras. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] isEmpty in PBounds
Is it just me or does isEmpty seem to act more like a dirty flag than as a statement about a bounds emptiness? --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] [piccolo2d commit] r483 - Issue 74 ; some assertions fail when test case is run as part of a test suite
Author: heuermh
Date: Thu Jul 16 14:21:22 2009
New Revision: 483
Modified:
piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/pswing/PSwingRepaintManagerTest.java
Log:
Issue 74 ; some assertions fail when test case is run as part of a test
suite
Modified:
piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/pswing/PSwingRepaintManagerTest.java
==
---
piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/pswing/PSwingRepaintManagerTest.java
(original)
+++
piccolo2d.java/trunk/extras/src/test/java/edu/umd/cs/piccolox/pswing/PSwingRepaintManagerTest.java
Thu Jul 16 14:21:22 2009
@@ -50,17 +50,20 @@
public void testCurrentManager() {
RepaintManager currentManager =
RepaintManager.currentManager(null);
assertNotNull(currentManager);
-assertFalse(currentManager instanceof PSwingRepaintManager);
+// TODO: this assertion is true when running this test case in
isolation
+//but since PSwingCanvas may have been instantiated elsewhere
in the test suite
+//may not be true when running this test case as part of a
test suite
+//assertFalse(currentManager instanceof PSwingRepaintManager);
Component awtComponent = new Canvas();
currentManager = RepaintManager.currentManager(awtComponent);
assertNotNull(currentManager);
-assertFalse(currentManager instanceof PSwingRepaintManager);
+//assertFalse(currentManager instanceof PSwingRepaintManager);
JComponent swingComponent = new JPanel();
currentManager = RepaintManager.currentManager(swingComponent);
assertNotNull(currentManager);
-assertFalse(currentManager instanceof PSwingRepaintManager);
+//assertFalse(currentManager instanceof PSwingRepaintManager);
PSwingCanvas pswingCanvas = new PSwingCanvas();
currentManager = RepaintManager.currentManager(pswingCanvas);
--~--~-~--~~~---~--~~
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
-~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 98 in piccolo2d: Refactor edu.umd.cs.piccolo.pswingexamples and ...swtexamples to examples.pswing and examples.swt
Comment #1 on issue 98 by allain.lalonde: Refactor edu.umd.cs.piccolo.pswingexamples and ...swtexamples to examples.pswing and examples.swt http://code.google.com/p/piccolo2d/issues/detail?id=98 I agree, shall I do it? -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 98 in piccolo2d: Refactor edu.umd.cs.piccolo.pswingexamples and ...swtexamples to examples.pswing and examples.swt
Updates: Status: Accepted Owner: allain.lalonde Comment #2 on issue 98 by heuermh: Refactor edu.umd.cs.piccolo.pswingexamples and ...swtexamples to examples.pswing and examples.swt http://code.google.com/p/piccolo2d/issues/detail?id=98 (No comment was entered for this change.) -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
