[piccolo2d-dev] Issue 89 in piccolo2d: Low Test Coverage of PNode
Updates: Status: Verified Labels: Type-Enhancement Priority-Medium Effort-Medium Toolkit-Piccolo2D.Java OpSys-All Component-Core Milestone-1.3 Comment #4 on issue 89 by heuermh: Low Test Coverage of PNode http://code.google.com/p/piccolo2d/issues/detail?id=89 Test coverage has been improved via several other commits. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 89 in piccolo2d: Low Test Coverage of PNode
Comment #3 on issue 89 by heuermh: Low Test Coverage of PNode http://code.google.com/p/piccolo2d/issues/detail?id=89 Portions of this patch should be reconsidered, as a binary incompatible change has been made: $ clirr.sh -o piccolo2d-core-1.3-SNAPSHOT-r446.jar -n piccolo2d-core-1.3-SNAPSHOT-r447.jar ERROR: 7006: edu.umd.cs.piccolo.PNode: Return type of method 'public edu.umd.cs.piccolo.activities.PInterpolatingActivity animateToColor(jav a.awt.Color, long)' has been changed to edu.umd.cs.piccolo.activities.PColorActivity INFO: 7011: edu.umd.cs.piccolo.PNode: Method 'public edu.umd.cs.piccolo.activities.PActivity animateToRelativePosition(java.awt.geom.Point2D , java.awt.geom.Point2D, java.awt.geom.Rectangle2D, int)' has been added INFO: 7007: edu.umd.cs.piccolo.PNode: Method 'public void position(java.awt.geom.Point2D, java.awt.geom.Point2D, java.awt.geom.Rectangle2D, int)' has been deprecated -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 89 in piccolo2d: Low Test Coverage of PNode
Updates: Status: Fixed Cc: allain.lalonde Comment #2 on issue 89 by allain.lalonde: Low Test Coverage of PNode http://code.google.com/p/piccolo2d/issues/detail?id=89 I've committed the changes offered in the patch. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 89 in piccolo2d: Low Test Coverage of PNode
Comment #1 on issue 89 by allain.lalonde: Low Test Coverage of PNode http://code.google.com/p/piccolo2d/issues/detail?id=89 There are 2 commented tests in there that I believe should pass but don't. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
[piccolo2d-dev] Issue 89 in piccolo2d: Low Test Coverage of PNode
Status: New Owner: New issue 89 by allain.lalonde: Low Test Coverage of PNode http://code.google.com/p/piccolo2d/issues/detail?id=89 When I started running some code metrics on PNode, I found that it had a instruction coverage (as opposed to line coverage) of 45.6%. A scary number considering PNode is the core to the entire library :|. No to say that it hasn't performed exceptionally well regardless, but just that in this particular way, some improvement (which I'm more than happy to do could be made). Attached you will find a patch that bumps the instruction coverage up to 90.1% and adds 100 (hopefully quality) unit tests on top of the existing 11. A couple minor changes were needed to get the number as high as it is, and some more drastic changes will be needed to get it higher (I think). Those changes are found in issue 86, but I've kept position so that I didn't break the previous interface. I've marked position as @deprecated though. Let me know what you think. Attachments: pnode-tests.diff 47.2 KB -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~-~--~~~---~--~~ Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en -~--~~~~--~~--~--~---
