[piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
Updates: Status: Verified Comment #17 on issue 173 by atdi...@gmail.com: Slow repaint of PSwing components when zooming (from 1.2 to 1.3) http://code.google.com/p/piccolo2d/issues/detail?id=173 (No comment was entered for this change.) -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
Updates: Owner: atdi...@gmail.com Comment #16 on issue 173 by atdi...@gmail.com: Slow repaint of PSwing components when zooming (from 1.2 to 1.3) http://code.google.com/p/piccolo2d/issues/detail?id=173 (No comment was entered for this change.) -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
Comment #15 on issue 173 by atdi...@gmail.com: Slow repaint of PSwing components when zooming (from 1.2 to 1.3) http://code.google.com/p/piccolo2d/issues/detail?id=173 Committed revision 1125 (trunk). -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
Comment #14 on issue 173 by atdi...@gmail.com: Slow repaint of PSwing components when zooming (from 1.2 to 1.3) http://code.google.com/p/piccolo2d/issues/detail?id=173 Committed revision 1124 (branch). -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
Updates: Status: Fixed Comment #13 on issue 173 by atdi...@gmail.com: Slow repaint of PSwing components when zooming (from 1.2 to 1.3) http://code.google.com/p/piccolo2d/issues/detail?id=173 Ok, fix is in for both branch and trunk. Please verify. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
Comment #12 on issue 173 by atdi...@gmail.com: Slow repaint of PSwing components when zooming (from 1.2 to 1.3) http://code.google.com/p/piccolo2d/issues/detail?id=173 Committed revision 1123. (trunk commit) -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
Comment #11 on issue 173 by atdi...@gmail.com: Slow repaint of PSwing components when zooming (from 1.2 to 1.3) http://code.google.com/p/piccolo2d/issues/detail?id=173 Committed revision 1122. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
Comment #10 on issue 173 by atdi...@gmail.com: Slow repaint of PSwing components when zooming (from 1.2 to 1.3) http://code.google.com/p/piccolo2d/issues/detail?id=173 Unless there come any comments to contrary, I'm going to look into making the buffering of Swing components configurable, with the default being no buffering. I'm going to target fixing this for the 1.3.1 release, unless there is higher interest in getting the release out asap. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
Re: [piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
Sam Reid wrote: > I don't recall all the issues regarding direct vs buffered: were there > problems knowing when the buffered image should be repainted, or do we > have the same problem when it comes to direct rendering? > > Here's the ticket about the fuzziness problem (perhaps this is what > you called "fidelity"?): > http://code.google.com/p/piccolo2d/issues/detail?id=83 > > I saw this thread, but I'm not sure any of it is directly related to > the question at hand: > http://www.mail-archive.com/piccolo2d-dev@googlegroups.com/msg00200.html > > My recommendation is to make "direct" the default. > > What about using a Piccolo container to perform the buffering instead > of making it a PSwing specific feature, something like: > > addChild(new PNodeCache(new PSwing(mySwingComponent))); There is a PNodeCache in extras already, would that class work for this use case? michael -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
I don't recall all the issues regarding direct vs buffered: were there problems knowing when the buffered image should be repainted, or do we have the same problem when it comes to direct rendering? Here's the ticket about the fuzziness problem (perhaps this is what you called "fidelity"?): http://code.google.com/p/piccolo2d/issues/detail?id=83 I saw this thread, but I'm not sure any of it is directly related to the question at hand: http://www.mail-archive.com/piccolo2d-dev@googlegroups.com/msg00200.html My recommendation is to make "direct" the default. What about using a Piccolo container to perform the buffering instead of making it a PSwing specific feature, something like: addChild(new PNodeCache(new PSwing(mySwingComponent))); Sam -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
My vote would be to make it configurable between "direct" and "buffered" rendering. The default should probably be consistent with the original behavior (ie, buffered) for backward compatibility. Our applications don't use zooming, and fidelity is important to us, so we would typically use "direct". All of that said... I don't recall if fidelity was the only issue that direct rendering solved. I'll discuss with my colleagues to see if any of them have a better memory. Chris On Mar 5, 3:36 pm, piccol...@googlecode.com wrote: > Comment #5 on issue 173 by atdi...@gmail.com: Slow repaint of PSwing > components when zooming (from 1.2 to > 1.3)http://code.google.com/p/piccolo2d/issues/detail?id=173 > > Before Issue 82, PSwing would render to a buffer and then render that > buffer to the Graphics2D. The result would be that the buffer would undergo > the applied transforms. > > Issue 82 changed this so that the Swing component rendered directly to the > (transformed) Graphics2D. It turns out the painting a JComponent with > transform applied is much more expensive than painting the buffer. > > Of course you lose fidelity when translating the buffered version (see > picture.) > > Should we restore the buffered approach? Should we make this configurable? > > Attachments: > 2v3.jpg 30.6 KB -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
Comment #9 on issue 173 by atdi...@gmail.com: Slow repaint of PSwing components when zooming (from 1.2 to 1.3) http://code.google.com/p/piccolo2d/issues/detail?id=173 Sorry - it was Issue 83, r467. I'm using PSwingExample and notice a clear degradation from release-1.2 when zooming. For more concrete performance numbers, I hacked PSwing.paint() with the old buffering behavior. On my machine, with the buffering, I see paint() consistently take < 1 millis. Without the buffering I see > 150ms consistently. I've attached a patch to PSwing that can be applied to release-1.3 so you can see the behavior. The patch is NOT intended as a fix or for promotion. It constructs a buffer every time and doesn't do any of the optimizations that v1.2 did. Attachments: PSwing-buffer-demo.patch 2.7 KB -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
Comment #8 on issue 173 by heue...@gmail.com: Slow repaint of PSwing components when zooming (from 1.2 to 1.3) http://code.google.com/p/piccolo2d/issues/detail?id=173 Are you sure it was Issue 82? r458 doesn't appear to change the way PSwing renders. Also, what are you using to compare performance? I don't use PSwing myself, so I usually just check that the PSwing examples look reasonable. If you have a test class or benchmark, please attach it here. I can run it on 32 & 64 bit OpenJDK on linux and Mac OSX to compare. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
Comment #7 on issue 173 by atdi...@gmail.com: Slow repaint of PSwing components when zooming (from 1.2 to 1.3) http://code.google.com/p/piccolo2d/issues/detail?id=173 So testing on Windows Vista, the paint performance is much better. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
Comment #6 on issue 173 by atdi...@gmail.com: Slow repaint of PSwing components when zooming (from 1.2 to 1.3) http://code.google.com/p/piccolo2d/issues/detail?id=173 When I say "much more expensive", I've only tested this behavior on Mac, so I'm not sure if other platforms suffer the same severe degradation. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
Comment #5 on issue 173 by atdi...@gmail.com: Slow repaint of PSwing components when zooming (from 1.2 to 1.3) http://code.google.com/p/piccolo2d/issues/detail?id=173 Before Issue 82, PSwing would render to a buffer and then render that buffer to the Graphics2D. The result would be that the buffer would undergo the applied transforms. Issue 82 changed this so that the Swing component rendered directly to the (transformed) Graphics2D. It turns out the painting a JComponent with transform applied is much more expensive than painting the buffer. Of course you lose fidelity when translating the buffered version (see picture.) Should we restore the buffered approach? Should we make this configurable? Attachments: 2v3.jpg 30.6 KB -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
Updates: Status: Accepted Labels: Type-Defect Priority-Medium OpSys-OSX Effort-Medium Component-Extras Milestone-1.3.1 Comment #4 on issue 173 by heue...@gmail.com: Slow repaint of PSwing components when zooming (from 1.2 to 1.3) http://code.google.com/p/piccolo2d/issues/detail?id=173 Possibly related to Issue 154. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
Comment #2 on issue 173 by mikkelrj: Slow repaint of PSwing components when zooming (from 1.2 to 1.3) http://code.google.com/p/piccolo2d/issues/detail?id=173 Good call, I hadn't checked with the 1.2.1 release. However, I just did and for me that works like the 1.2 release, that is, much smoother updating that with 1.3. I use an Intel-based Mac with jdk 1.5. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en To unsubscribe, reply using "remove me" as the subject.
[piccolo2d-dev] Re: Issue 173 in piccolo2d: Slow repaint of PSwing components when zooming (from 1.2 to 1.3)
Comment #1 on issue 173 by heue...@gmail.com: Slow repaint of PSwing components when zooming (from 1.2 to 1.3) http://code.google.com/p/piccolo2d/issues/detail?id=173 I believe there were also some PSwing changes in 1.2 to 1.2.1, have you tried comparing with that version? I have noticed that PSwing in 1.3 is slow on Mac OSX PowerPC with jdk 1.5, I just don't remember it being fast in earlier versions. I will confirm. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en To unsubscribe, reply using "remove me" as the subject.
