[piccolo2d-dev] Re: Issue 206 in piccolo2d: SWTGraphics2D keeps invalid caches
Updates: Status: Verified Comment #13 on issue 206 by atdi...@gmail.com: SWTGraphics2D keeps invalid caches http://code.google.com/p/piccolo2d/issues/detail?id=206 (No comment was entered for this change.) -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 206 in piccolo2d: SWTGraphics2D keeps invalid caches
Updates: Status: Fixed Comment #12 on issue 206 by heue...@gmail.com: SWTGraphics2D keeps invalid caches http://code.google.com/p/piccolo2d/issues/detail?id=206 Thanks, I do see the problem now if I run the test in isolation. Commits look good, marking as Fixed. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 206 in piccolo2d: SWTGraphics2D keeps invalid caches
Comment #11 on issue 206 by atdi...@gmail.com: SWTGraphics2D keeps invalid caches http://code.google.com/p/piccolo2d/issues/detail?id=206 Ok, disregard my comment about not having commit access. I've commited patch to release-1.3: "Committed revision 1106." This commit also includes a slight change to the swt pom.xml to allow Mac OS developers to run the SWT unit tests (which, on Macs require JVM argument -XstartOnFirstThread.) I've also commited this slight pom change to trunk: "Committed revision 1105." -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 206 in piccolo2d: SWTGraphics2D keeps invalid caches
Comment #10 on issue 206 by atdi...@gmail.com: SWTGraphics2D keeps invalid caches http://code.google.com/p/piccolo2d/issues/detail?id=206 Actually, doesn't look like I have commit access: svn commit -m "Issue 206; apply patch and unit test to clear swt resource caches" svn: Commit failed (details follow): svn: Server sent unexpected return value (405 Method Not Allowed) in response to MKACTIVITY request... -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 206 in piccolo2d: SWTGraphics2D keeps invalid caches
Comment #9 on issue 206 by atdi...@gmail.com: SWTGraphics2D keeps invalid caches http://code.google.com/p/piccolo2d/issues/detail?id=206 Oops, sweet = suite. Lol. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 206 in piccolo2d: SWTGraphics2D keeps invalid caches
Comment #8 on issue 206 by atdi...@gmail.com: SWTGraphics2D keeps invalid caches http://code.google.com/p/piccolo2d/issues/detail?id=206 I am able to reproduce this in release-1.3 and trunk (pre-patch) if I run the test in solitude: mvn test -Dtest=SWTGraphics2DTest I noticed that if I run the full swt test suite in trunk, the SWTGraphics2DTest runs first, but if I run the sweet in branch, it runs last. Since this defect is sensitive to reference counting via SWTGraphics2D.decrementGCCount(), I believe the other tests are not leaving SWTGraphics2D.CACHE_COUNT == 0, and therefore no resources are getting disposed when SWTGraphics2DTest runs--and consequently the test is succeeding. Michael, I'll go ahead and apply the fix to release-1.3.1 now. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 206 in piccolo2d: SWTGraphics2D keeps invalid caches
Comment #7 on issue 206 by heue...@gmail.com: SWTGraphics2D keeps invalid caches http://code.google.com/p/piccolo2d/issues/detail?id=206 I'm still not seeing the unit test fail on branches/release-1.3 or on tags/release-1.3 on x86 linux with jdk $ java -version java version "1.6.0_20" OpenJDK Runtime Environment (IcedTea6 1.9.5) (6b20-1.9.5-0ubuntu1~10.04.1) OpenJDK Client VM (build 19.0-b09, mixed mode, sharing) and swt versions 3.3.0-v3346 (the minimum of the version range specified in pom.xml) through 3.6.1. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 206 in piccolo2d: SWTGraphics2D keeps invalid caches
Comment #6 on issue 206 by heue...@gmail.com: SWTGraphics2D keeps invalid caches http://code.google.com/p/piccolo2d/issues/detail?id=206 Applying patch to svn trunk $ svn commit -m "applying patch and unit test from Issue 206 to clear caches" . Sendingswt/src/main/java/org/piccolo2d/extras/swt/SWTGraphics2D.java Adding swt/src/test/java/org/piccolo2d/extras/swt/SWTGraphics2DTest.java Transmitting file data .. Committed revision 1104. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 206 in piccolo2d: SWTGraphics2D keeps invalid caches
Comment #5 on issue 206 by akurta...@gmail.com: SWTGraphics2D keeps invalid caches http://code.google.com/p/piccolo2d/issues/detail?id=206 I should have said that I'm testing on linux only. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 206 in piccolo2d: SWTGraphics2D keeps invalid caches
Comment #4 on issue 206 by heue...@gmail.com: SWTGraphics2D keeps invalid caches http://code.google.com/p/piccolo2d/issues/detail?id=206 ok, thanks. I'll try updating swt to 3.6.1. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 206 in piccolo2d: SWTGraphics2D keeps invalid caches
Comment #3 on issue 206 by akurta...@gmail.com: SWTGraphics2D keeps invalid caches http://code.google.com/p/piccolo2d/issues/detail?id=206 It definetely fails for me when using swt 3.6.1 and binary 1.3 release -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 206 in piccolo2d: SWTGraphics2D keeps invalid caches
Comment #2 on issue 206 by heue...@gmail.com: SWTGraphics2D keeps invalid caches http://code.google.com/p/piccolo2d/issues/detail?id=206 The unit test only fails for me on svn trunk $ mvn test [INFO] Scanning for projects... [INFO] [INFO] [INFO] Building Piccolo2D SWT 2.0-SNAPSHOT [INFO] ... --- T E S T S --- Running org.piccolo2d.extras.swt.SWTGraphics2DTest Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.438 sec <<< FAILURE! Running org.piccolo2d.extras.swt.PSWTHandleTest Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec Running org.piccolo2d.extras.swt.PSWTPathTest Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.015 sec Running org.piccolo2d.extras.swt.PSWTCanvasTest Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec Running org.piccolo2d.extras.swt.PSWTBoundsHandleTest Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec Running org.piccolo2d.extras.swt.PSWTImageTest Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec Running org.piccolo2d.extras.swt.PSWTTextTest Tests run: 14, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 0 sec <<< FAILURE! Results : Tests in error: testCacheCleanup(org.piccolo2d.extras.swt.SWTGraphics2DTest) testConstructorRemembersTextValue(org.piccolo2d.extras.swt.PSWTTextTest) testTextPersistsTrainingAndInternalNewlines(org.piccolo2d.extras.swt.PSWTTextTest) testShrinkingFontShrinksBounds(org.piccolo2d.extras.swt.PSWTTextTest) testTranslatingDoesntAffectSize(org.piccolo2d.extras.swt.PSWTTextTest) Tests run: 39, Failures: 0, Errors: 5, Skipped: 0 [INFO] [INFO] BUILD FAILURE [INFO] [INFO] Total time: 2.453s [INFO] Finished at: Thu Feb 03 13:36:22 CST 2011 [INFO] Final Memory: 6M/495M [INFO] not on the 1.3 release branch $ mvn test [INFO] Scanning for projects... [INFO] [INFO] [INFO] Building Piccolo2D SWT 1.4-SNAPSHOT [INFO] ... --- T E S T S --- Running edu.umd.cs.piccolox.swt.PSWTTextTest Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.375 sec Running edu.umd.cs.piccolox.swt.PSWTHandleTest Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec Running edu.umd.cs.piccolox.swt.PSWTImageTest Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.078 sec Running edu.umd.cs.piccolox.swt.PSWTBoundsHandleTest Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec Running edu.umd.cs.piccolox.swt.PSWTPathTest Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec Running edu.umd.cs.piccolox.swt.SWTGraphics2DTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.016 sec Running edu.umd.cs.piccolox.swt.PSWTCanvasTest Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec Results : Tests run: 39, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 2.438s [INFO] Finished at: Thu Feb 03 13:37:04 CST 2011 [INFO] Final Memory: 6M/495M [INFO] This is on windows with SWT version 3.5.1. -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
[piccolo2d-dev] Re: Issue 206 in piccolo2d: SWTGraphics2D keeps invalid caches
Updates: Labels: Type-Defect Priority-Critical Component-SWT Milestone-1.3.1 Toolkit-Piccolo2D.Java Comment #1 on issue 206 by akurta...@gmail.com: SWTGraphics2D keeps invalid caches http://code.google.com/p/piccolo2d/issues/detail?id=206 (No comment was entered for this change.) -- Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
