[piccolo2d-dev] Re: Issue 89 in piccolo2d: Low Test Coverage of PNode

2009-07-12 Thread Michael Heuer

Hello Allain,

No problem, it's just animateToColor that causes an error.
PColorActivity does have useful methods

Color getDestinationColor()
void setDestinationColor(Color)

so perhaps the javadoc should mention that it is safe to cast the
return value from PInterpolatingActivity to PColorActivity?

As you may see from

http://code.google.com/p/piccolo2d/issues/detail?id=90

we don't regularly run clirr either.  :)

   michael


On Sun, Jul 12, 2009 at 9:45 PM, allain wrote:
>
> Ok, I'll change them back until it's decided how to proceed. I'll be
> running clirr from now on. Thanks, and sorry.
>
> On Jul 12, 10:31 pm, codesite-nore...@google.com wrote:
>> Comment #3 on issue 89 by heuermh: Low Test Coverage of 
>> PNodehttp://code.google.com/p/piccolo2d/issues/detail?id=89
>>
>> Portions of this patch should be reconsidered, as a binary incompatible
>> change has
>> been made:
>>
>> $ clirr.sh -o piccolo2d-core-1.3-SNAPSHOT-r446.jar -n
>> piccolo2d-core-1.3-SNAPSHOT-r447.jar
>> ERROR: 7006: edu.umd.cs.piccolo.PNode: Return type of method 'public
>> edu.umd.cs.piccolo.activities.PInterpolatingActivity animateToColor(jav
>> a.awt.Color, long)' has been changed to
>> edu.umd.cs.piccolo.activities.PColorActivity
>> INFO: 7011: edu.umd.cs.piccolo.PNode: Method 'public
>> edu.umd.cs.piccolo.activities.PActivity
>> animateToRelativePosition(java.awt.geom.Point2D
>> , java.awt.geom.Point2D, java.awt.geom.Rectangle2D, int)' has been added
>> INFO: 7007: edu.umd.cs.piccolo.PNode: Method 'public void
>> position(java.awt.geom.Point2D, java.awt.geom.Point2D,
>> java.awt.geom.Rectangle2D,
>> int)' has been deprecated
>>
>> --
>> You received this message because you are listed in the owner
>> or CC fields of this issue, or because you starred this issue.
>> You may adjust your issue notification preferences 
>> at:http://code.google.com/hosting/settings
> >
>

--~--~-~--~~~---~--~~
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
-~--~~~~--~~--~--~---



[piccolo2d-dev] Re: Issue 89 in piccolo2d: Low Test Coverage of PNode

2009-07-12 Thread allain

Ok, I'll change them back until it's decided how to proceed. I'll be
running clirr from now on. Thanks, and sorry.

On Jul 12, 10:31 pm, codesite-nore...@google.com wrote:
> Comment #3 on issue 89 by heuermh: Low Test Coverage of 
> PNodehttp://code.google.com/p/piccolo2d/issues/detail?id=89
>
> Portions of this patch should be reconsidered, as a binary incompatible  
> change has
> been made:
>
> $ clirr.sh -o piccolo2d-core-1.3-SNAPSHOT-r446.jar -n
> piccolo2d-core-1.3-SNAPSHOT-r447.jar
> ERROR: 7006: edu.umd.cs.piccolo.PNode: Return type of method 'public
> edu.umd.cs.piccolo.activities.PInterpolatingActivity animateToColor(jav
> a.awt.Color, long)' has been changed to  
> edu.umd.cs.piccolo.activities.PColorActivity
> INFO: 7011: edu.umd.cs.piccolo.PNode: Method 'public
> edu.umd.cs.piccolo.activities.PActivity  
> animateToRelativePosition(java.awt.geom.Point2D
> , java.awt.geom.Point2D, java.awt.geom.Rectangle2D, int)' has been added
> INFO: 7007: edu.umd.cs.piccolo.PNode: Method 'public void
> position(java.awt.geom.Point2D, java.awt.geom.Point2D,  
> java.awt.geom.Rectangle2D,
> int)' has been deprecated
>
> --
> You received this message because you are listed in the owner
> or CC fields of this issue, or because you starred this issue.
> You may adjust your issue notification preferences 
> at:http://code.google.com/hosting/settings
--~--~-~--~~~---~--~~
Piccolo2D Developers Group: http://groups.google.com/group/piccolo2d-dev?hl=en
-~--~~~~--~~--~--~---