[jira] Updated: (PIG-1059) FINDBUGS: remaining Bad practice + Multithreaded correctness Warning

2010-03-24 Thread Alan Gates (JIRA) 

 [ 
https://issues.apache.org/jira/browse/PIG-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Gates updated PIG-1059:


Fix Version/s: 0.6.0

> FINDBUGS: remaining Bad practice + Multithreaded correctness Warning
> 
>
> Key: PIG-1059
> URL: https://issues.apache.org/jira/browse/PIG-1059
> Project: Pig
>  Issue Type: Improvement
>Reporter: Olga Natkovich
>Assignee: Olga Natkovich
> Fix For: 0.6.0
>
> Attachments: PIG-1059.patch
>
>
> ISInconsistent synchronization of 
> org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.hodConfDir; 
> locked 66% of time
> ISInconsistent synchronization of 
> org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.hodProcess; 
> locked 80% of time
> ISInconsistent synchronization of 
> org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.remoteHodConfDir;
>  locked 88% of time
> ISInconsistent synchronization of 
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POStream.initialized;
>  locked 50% of time
> UG
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.getAggregate()
>  is unsynchronized, 
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.setAggregate(boolean)
>  is synchronized
> UG
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.getReporter()
>  is unsynchronized, 
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.setReporter(Reporter)
>  is synchronized
> BCEquals method for org.apache.pig.builtin.PigStorage assumes the 
> argument is of type PigStorage
> BCEquals method for 
> org.apache.pig.impl.streaming.StreamingCommand$HandleSpec assumes the 
> argument is of type StreamingCommand$HandleSpec
> DPorg.apache.pig.data.BagFactory.getInstance() creates a 
> java.net.URLClassLoader classloader, which should be performed within a 
> doPrivileged block
> DPorg.apache.pig.data.TupleFactory.getInstance() creates a 
> java.net.URLClassLoader classloader, which should be performed within a 
> doPrivileged block
> DPorg.apache.pig.impl.PigContext.createCl(String) creates a 
> java.net.URLClassLoader classloader, which should be performed within a 
> doPrivileged block
> DPorg.apache.pig.impl.util.JarManager.createCl(String, PigContext) 
> creates a java.net.URLClassLoader classloader, which should be performed 
> within a doPrivileged block
> Eqorg.apache.pig.data.DistinctDataBag$DistinctDataBagIterator$TContainer 
> defines compareTo(DistinctDataBag$DistinctDataBagIterator$TContainer) and 
> uses Object.equals()
> Eqorg.apache.pig.data.SingleTupleBag defines compareTo(Object) and uses 
> Object.equals()
> Eqorg.apache.pig.data.SortedDataBag$SortedDataBagIterator$PQContainer 
> defines compareTo(SortedDataBag$SortedDataBagIterator$PQContainer) and uses 
> Object.equals()
> Eqorg.apache.pig.data.TargetedTuple defines compareTo(Object) and uses 
> Object.equals()
> HE
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.plans.PhysicalPlan
>  defines equals and uses Object.hashCode()
> HE
> org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POCogroup$groupComparator
>  defines equals and uses Object.hashCode()
> HEorg.apache.pig.builtin.BinaryStorage defines equals and uses 
> Object.hashCode()
> HEorg.apache.pig.builtin.BinStorage defines equals and uses 
> Object.hashCode()
> HEorg.apache.pig.builtin.PigStorage defines equals and uses 
> Object.hashCode()
> HEorg.apache.pig.data.InternalSortedBag$DefaultComparator defines equals 
> and uses Object.hashCode()
> HEorg.apache.pig.data.NonSpillableDataBag defines equals and uses 
> Object.hashCode()
> HEorg.apache.pig.data.SortedDataBag$DefaultComparator defines equals and 
> uses Object.hashCode()
> HEorg.apache.pig.impl.streaming.StreamingCommand$HandleSpec defines 
> equals and uses Object.hashCode()
> Nm
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PhyPlanSetter.visitSplit(POSplit)
>  doesn't override method in superclass because parameter type 
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POSplit
>  doesn't match superclass parameter type 
> org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POSplit
> Nm
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PhyPlanSetter.visitSplit(POSplit)
>  doesn't override method in superclass because parameter type 
> org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POSplit
>  doesn't match superclass parameter type 
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POSplit
> RV
> or

[jira] Updated: (PIG-1059) FINDBUGS: remaining Bad practice + Multithreaded correctness Warning

2009-10-29 Thread Olga Natkovich (JIRA) 

 [ 
https://issues.apache.org/jira/browse/PIG-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olga Natkovich updated PIG-1059:


Resolution: Fixed
Status: Resolved  (was: Patch Available)

patch committed

> FINDBUGS: remaining Bad practice + Multithreaded correctness Warning
> 
>
> Key: PIG-1059
> URL: https://issues.apache.org/jira/browse/PIG-1059
> Project: Pig
>  Issue Type: Improvement
>Reporter: Olga Natkovich
>Assignee: Olga Natkovich
> Attachments: PIG-1059.patch
>
>
> ISInconsistent synchronization of 
> org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.hodConfDir; 
> locked 66% of time
> ISInconsistent synchronization of 
> org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.hodProcess; 
> locked 80% of time
> ISInconsistent synchronization of 
> org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.remoteHodConfDir;
>  locked 88% of time
> ISInconsistent synchronization of 
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POStream.initialized;
>  locked 50% of time
> UG
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.getAggregate()
>  is unsynchronized, 
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.setAggregate(boolean)
>  is synchronized
> UG
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.getReporter()
>  is unsynchronized, 
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.setReporter(Reporter)
>  is synchronized
> BCEquals method for org.apache.pig.builtin.PigStorage assumes the 
> argument is of type PigStorage
> BCEquals method for 
> org.apache.pig.impl.streaming.StreamingCommand$HandleSpec assumes the 
> argument is of type StreamingCommand$HandleSpec
> DPorg.apache.pig.data.BagFactory.getInstance() creates a 
> java.net.URLClassLoader classloader, which should be performed within a 
> doPrivileged block
> DPorg.apache.pig.data.TupleFactory.getInstance() creates a 
> java.net.URLClassLoader classloader, which should be performed within a 
> doPrivileged block
> DPorg.apache.pig.impl.PigContext.createCl(String) creates a 
> java.net.URLClassLoader classloader, which should be performed within a 
> doPrivileged block
> DPorg.apache.pig.impl.util.JarManager.createCl(String, PigContext) 
> creates a java.net.URLClassLoader classloader, which should be performed 
> within a doPrivileged block
> Eqorg.apache.pig.data.DistinctDataBag$DistinctDataBagIterator$TContainer 
> defines compareTo(DistinctDataBag$DistinctDataBagIterator$TContainer) and 
> uses Object.equals()
> Eqorg.apache.pig.data.SingleTupleBag defines compareTo(Object) and uses 
> Object.equals()
> Eqorg.apache.pig.data.SortedDataBag$SortedDataBagIterator$PQContainer 
> defines compareTo(SortedDataBag$SortedDataBagIterator$PQContainer) and uses 
> Object.equals()
> Eqorg.apache.pig.data.TargetedTuple defines compareTo(Object) and uses 
> Object.equals()
> HE
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.plans.PhysicalPlan
>  defines equals and uses Object.hashCode()
> HE
> org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POCogroup$groupComparator
>  defines equals and uses Object.hashCode()
> HEorg.apache.pig.builtin.BinaryStorage defines equals and uses 
> Object.hashCode()
> HEorg.apache.pig.builtin.BinStorage defines equals and uses 
> Object.hashCode()
> HEorg.apache.pig.builtin.PigStorage defines equals and uses 
> Object.hashCode()
> HEorg.apache.pig.data.InternalSortedBag$DefaultComparator defines equals 
> and uses Object.hashCode()
> HEorg.apache.pig.data.NonSpillableDataBag defines equals and uses 
> Object.hashCode()
> HEorg.apache.pig.data.SortedDataBag$DefaultComparator defines equals and 
> uses Object.hashCode()
> HEorg.apache.pig.impl.streaming.StreamingCommand$HandleSpec defines 
> equals and uses Object.hashCode()
> Nm
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PhyPlanSetter.visitSplit(POSplit)
>  doesn't override method in superclass because parameter type 
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POSplit
>  doesn't match superclass parameter type 
> org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POSplit
> Nm
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PhyPlanSetter.visitSplit(POSplit)
>  doesn't override method in superclass because parameter type 
> org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POSplit
>  doesn't match superclass parameter type 
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.r

[jira] Updated: (PIG-1059) FINDBUGS: remaining Bad practice + Multithreaded correctness Warning

2009-10-29 Thread Olga Natkovich (JIRA) 

 [ 
https://issues.apache.org/jira/browse/PIG-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olga Natkovich updated PIG-1059:


Attachment: PIG-1059.patch

> FINDBUGS: remaining Bad practice + Multithreaded correctness Warning
> 
>
> Key: PIG-1059
> URL: https://issues.apache.org/jira/browse/PIG-1059
> Project: Pig
>  Issue Type: Improvement
>Reporter: Olga Natkovich
>Assignee: Olga Natkovich
> Attachments: PIG-1059.patch
>
>
> ISInconsistent synchronization of 
> org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.hodConfDir; 
> locked 66% of time
> ISInconsistent synchronization of 
> org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.hodProcess; 
> locked 80% of time
> ISInconsistent synchronization of 
> org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.remoteHodConfDir;
>  locked 88% of time
> ISInconsistent synchronization of 
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POStream.initialized;
>  locked 50% of time
> UG
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.getAggregate()
>  is unsynchronized, 
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.setAggregate(boolean)
>  is synchronized
> UG
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.getReporter()
>  is unsynchronized, 
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.setReporter(Reporter)
>  is synchronized
> BCEquals method for org.apache.pig.builtin.PigStorage assumes the 
> argument is of type PigStorage
> BCEquals method for 
> org.apache.pig.impl.streaming.StreamingCommand$HandleSpec assumes the 
> argument is of type StreamingCommand$HandleSpec
> DPorg.apache.pig.data.BagFactory.getInstance() creates a 
> java.net.URLClassLoader classloader, which should be performed within a 
> doPrivileged block
> DPorg.apache.pig.data.TupleFactory.getInstance() creates a 
> java.net.URLClassLoader classloader, which should be performed within a 
> doPrivileged block
> DPorg.apache.pig.impl.PigContext.createCl(String) creates a 
> java.net.URLClassLoader classloader, which should be performed within a 
> doPrivileged block
> DPorg.apache.pig.impl.util.JarManager.createCl(String, PigContext) 
> creates a java.net.URLClassLoader classloader, which should be performed 
> within a doPrivileged block
> Eqorg.apache.pig.data.DistinctDataBag$DistinctDataBagIterator$TContainer 
> defines compareTo(DistinctDataBag$DistinctDataBagIterator$TContainer) and 
> uses Object.equals()
> Eqorg.apache.pig.data.SingleTupleBag defines compareTo(Object) and uses 
> Object.equals()
> Eqorg.apache.pig.data.SortedDataBag$SortedDataBagIterator$PQContainer 
> defines compareTo(SortedDataBag$SortedDataBagIterator$PQContainer) and uses 
> Object.equals()
> Eqorg.apache.pig.data.TargetedTuple defines compareTo(Object) and uses 
> Object.equals()
> HE
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.plans.PhysicalPlan
>  defines equals and uses Object.hashCode()
> HE
> org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POCogroup$groupComparator
>  defines equals and uses Object.hashCode()
> HEorg.apache.pig.builtin.BinaryStorage defines equals and uses 
> Object.hashCode()
> HEorg.apache.pig.builtin.BinStorage defines equals and uses 
> Object.hashCode()
> HEorg.apache.pig.builtin.PigStorage defines equals and uses 
> Object.hashCode()
> HEorg.apache.pig.data.InternalSortedBag$DefaultComparator defines equals 
> and uses Object.hashCode()
> HEorg.apache.pig.data.NonSpillableDataBag defines equals and uses 
> Object.hashCode()
> HEorg.apache.pig.data.SortedDataBag$DefaultComparator defines equals and 
> uses Object.hashCode()
> HEorg.apache.pig.impl.streaming.StreamingCommand$HandleSpec defines 
> equals and uses Object.hashCode()
> Nm
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PhyPlanSetter.visitSplit(POSplit)
>  doesn't override method in superclass because parameter type 
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POSplit
>  doesn't match superclass parameter type 
> org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POSplit
> Nm
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PhyPlanSetter.visitSplit(POSplit)
>  doesn't override method in superclass because parameter type 
> org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POSplit
>  doesn't match superclass parameter type 
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POSplit
> RV
> org.apache.pig.back

[jira] Updated: (PIG-1059) FINDBUGS: remaining Bad practice + Multithreaded correctness Warning

2009-10-29 Thread Olga Natkovich (JIRA) 

 [ 
https://issues.apache.org/jira/browse/PIG-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olga Natkovich updated PIG-1059:


Status: Patch Available  (was: Open)

> FINDBUGS: remaining Bad practice + Multithreaded correctness Warning
> 
>
> Key: PIG-1059
> URL: https://issues.apache.org/jira/browse/PIG-1059
> Project: Pig
>  Issue Type: Improvement
>Reporter: Olga Natkovich
>Assignee: Olga Natkovich
> Attachments: PIG-1059.patch
>
>
> ISInconsistent synchronization of 
> org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.hodConfDir; 
> locked 66% of time
> ISInconsistent synchronization of 
> org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.hodProcess; 
> locked 80% of time
> ISInconsistent synchronization of 
> org.apache.pig.backend.hadoop.executionengine.HExecutionEngine.remoteHodConfDir;
>  locked 88% of time
> ISInconsistent synchronization of 
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POStream.initialized;
>  locked 50% of time
> UG
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.getAggregate()
>  is unsynchronized, 
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.setAggregate(boolean)
>  is synchronized
> UG
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.getReporter()
>  is unsynchronized, 
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigHadoopLogger.setReporter(Reporter)
>  is synchronized
> BCEquals method for org.apache.pig.builtin.PigStorage assumes the 
> argument is of type PigStorage
> BCEquals method for 
> org.apache.pig.impl.streaming.StreamingCommand$HandleSpec assumes the 
> argument is of type StreamingCommand$HandleSpec
> DPorg.apache.pig.data.BagFactory.getInstance() creates a 
> java.net.URLClassLoader classloader, which should be performed within a 
> doPrivileged block
> DPorg.apache.pig.data.TupleFactory.getInstance() creates a 
> java.net.URLClassLoader classloader, which should be performed within a 
> doPrivileged block
> DPorg.apache.pig.impl.PigContext.createCl(String) creates a 
> java.net.URLClassLoader classloader, which should be performed within a 
> doPrivileged block
> DPorg.apache.pig.impl.util.JarManager.createCl(String, PigContext) 
> creates a java.net.URLClassLoader classloader, which should be performed 
> within a doPrivileged block
> Eqorg.apache.pig.data.DistinctDataBag$DistinctDataBagIterator$TContainer 
> defines compareTo(DistinctDataBag$DistinctDataBagIterator$TContainer) and 
> uses Object.equals()
> Eqorg.apache.pig.data.SingleTupleBag defines compareTo(Object) and uses 
> Object.equals()
> Eqorg.apache.pig.data.SortedDataBag$SortedDataBagIterator$PQContainer 
> defines compareTo(SortedDataBag$SortedDataBagIterator$PQContainer) and uses 
> Object.equals()
> Eqorg.apache.pig.data.TargetedTuple defines compareTo(Object) and uses 
> Object.equals()
> HE
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.plans.PhysicalPlan
>  defines equals and uses Object.hashCode()
> HE
> org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POCogroup$groupComparator
>  defines equals and uses Object.hashCode()
> HEorg.apache.pig.builtin.BinaryStorage defines equals and uses 
> Object.hashCode()
> HEorg.apache.pig.builtin.BinStorage defines equals and uses 
> Object.hashCode()
> HEorg.apache.pig.builtin.PigStorage defines equals and uses 
> Object.hashCode()
> HEorg.apache.pig.data.InternalSortedBag$DefaultComparator defines equals 
> and uses Object.hashCode()
> HEorg.apache.pig.data.NonSpillableDataBag defines equals and uses 
> Object.hashCode()
> HEorg.apache.pig.data.SortedDataBag$DefaultComparator defines equals and 
> uses Object.hashCode()
> HEorg.apache.pig.impl.streaming.StreamingCommand$HandleSpec defines 
> equals and uses Object.hashCode()
> Nm
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PhyPlanSetter.visitSplit(POSplit)
>  doesn't override method in superclass because parameter type 
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POSplit
>  doesn't match superclass parameter type 
> org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POSplit
> Nm
> org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PhyPlanSetter.visitSplit(POSplit)
>  doesn't override method in superclass because parameter type 
> org.apache.pig.backend.local.executionengine.physicalLayer.relationalOperators.POSplit
>  doesn't match superclass parameter type 
> org.apache.pig.backend.hadoop.executionengine.physicalLayer.relationalOperators.POSplit
> RV
> org.apach