Re: [Piglit] [PATCH] arb_xfb3: Fix draw_using_invalid_stream_index test

2014-11-18 Thread Chris Forbes
Bump. Currently, this test does nothing useful due to the broken GS. On Sat, Oct 18, 2014 at 9:11 PM, Chris Forbes wrote: > - The GS declared no input layout so failed to compile. Apparently > nVIDIA's implementation is sloppy about this. > - The shaders were compiled and then never actually us

Re: [Piglit] [PATCH V2 2/2] arb_arrays_of_arrays: geometry shader tests

2014-11-18 Thread Chris Forbes
This patch is: Reviewed-by: Chris Forbes On Wed, Nov 19, 2014 at 5:06 PM, Timothy Arceri wrote: > V2: Added Nvidia results to commit message > > Test results are from the following hardware/driver combination: > > AMD Radeon HD 6670 - Catalyst 13.251 OpenGL 4.3 > Nvidia Geforce GTX 570 - 340.24

[Piglit] [PATCH V2 2/2] arb_arrays_of_arrays: geometry shader tests

2014-11-18 Thread Timothy Arceri
V2: Added Nvidia results to commit message Test results are from the following hardware/driver combination: AMD Radeon HD 6670 - Catalyst 13.251 OpenGL 4.3 Nvidia Geforce GTX 570 - 340.24 OpenGL 4.4 The Nvidia results do not always mean what they are intended to (e.g. passing for the wrong reaso

[Piglit] [PATCH V2 1/2] glsl-1.10: extend to test arrays of arrays

2014-11-18 Thread Timothy Arceri
Extends the varying packing tests to support testing arrays of arrays V2: renamed variables from 'inner' that should have been 'outer' Signed-off-by: Timothy Arceri --- tests/all.py | 2 +- .../glsl-1.10/execution/varying-packing/simple.c | 158

Re: [Piglit] [PATCH v2] Remove ARB_timer_query / EXT_timer_query from quick.py

2014-11-18 Thread Mark Janes
Ilia Mirkin writes: > FWIW, on nv50 and nvc0, EXT_timer_query time-elapsed and > ARB_timer_query query GL_TIMESTAMP reliably fail, and the rest > reliably pass. I don't remember ever seeing inconsistent behaviour. > FWIW I don't really know what these extensions do, or what the tests > check for,

Re: [Piglit] [PATCH] Remove spec.EXT_timer_query.time-elapsed from quick.py

2014-11-18 Thread Eric Anholt
Mark Janes writes: > spec.EXT_timer_query.time-elapsed fails intermittently, causing > confusion for developers running quick.py to find regressions. This > test has always been intermittent, and people generally know to ignore > it when it fails. If you drop it from quick.py, it means develope

Re: [Piglit] [PATCH 5/6] ARB_pipeline_statistics_query (geom): basic test

2014-11-18 Thread Jose Fonseca
Ben, Emil, Thanks for confirming this. (It's quite hard to keep in mind what's supported or on on MSVC!) Patch sounds great as is then. Jose On 18/11/14 19:04, Ben Widawsky wrote: On Tue, Nov 18, 2014 at 06:25:59PM +, Jose Fonseca wrote: You're sure? I thought that MSVC 2013 only had

Re: [Piglit] [PATCH 5/6] ARB_pipeline_statistics_query (geom): basic test

2014-11-18 Thread Emil Velikov
On 18/11/14 18:25, Jose Fonseca wrote: > You're sure? I thought that MSVC 2013 only had _library_ support for C99, but > I confess I haven't tested.. > Note that I've mentioned named/designated initialisers rather than the whole C99. And yes building executables with named initializers works. Ch

Re: [Piglit] [PATCH 5/6] ARB_pipeline_statistics_query (geom): basic test

2014-11-18 Thread Ben Widawsky
On Tue, Nov 18, 2014 at 06:25:59PM +, Jose Fonseca wrote: > You're sure? I thought that MSVC 2013 only had _library_ support for C99, but > I confess I haven't tested.. > > > Jose Oops. Didn't see this since my mail wasn't actually in a to, or cc. I responded to Brian's mail with the best I

Re: [Piglit] [PATCH 5/6] ARB_pipeline_statistics_query (geom): basic test

2014-11-18 Thread Ben Widawsky
On Tue, Nov 18, 2014 at 08:14:05AM -0700, Brian Paul wrote: > On 11/17/2014 05:00 PM, Ben Widawsky wrote: > >Signed-off-by: Ben Widawsky > >--- > > .../spec/arb_pipeline_statistics/CMakeLists.gl.txt | 2 + > > .../arb_pipeline_statistics/pipeline_stats_geom.c | 146 > > + >

Re: [Piglit] [PATCH v2] Remove ARB_timer_query / EXT_timer_query from quick.py

2014-11-18 Thread Dylan Baker
I'm not an authority on the subject, but for what it's worth you have my rb. Reviewed-by: Dylan Baker On Tuesday, November 18, 2014 10:39:26 AM Mark Janes wrote: > EXT_timer_query and ARB_timer_query tests fail intermittently, causing > confusion for developers running quick.py to find regressio

Re: [Piglit] [PATCH v2] Remove ARB_timer_query / EXT_timer_query from quick.py

2014-11-18 Thread Ilia Mirkin
On Tue, Nov 18, 2014 at 1:39 PM, Mark Janes wrote: > EXT_timer_query and ARB_timer_query tests fail intermittently, causing > confusion for developers running quick.py to find regressions. These > tests have always been intermittent, and people generally know to > ignore them when they fail. > >

[Piglit] [PATCH v2] Remove ARB_timer_query / EXT_timer_query from quick.py

2014-11-18 Thread Mark Janes
EXT_timer_query and ARB_timer_query tests fail intermittently, causing confusion for developers running quick.py to find regressions. These tests have always been intermittent, and people generally know to ignore them when they fail. However, if everyone ignores a test, there is no point in runni

Re: [Piglit] [PATCH 5/6] ARB_pipeline_statistics_query (geom): basic test

2014-11-18 Thread Jose Fonseca
You're sure? I thought that MSVC 2013 only had _library_ support for C99, but I confess I haven't tested.. Jose From: Piglit on behalf of Emil Velikov Sent: 18 November 2014 17:17 To: Brian Paul; piglit@lists.freedesktop.org Cc: emil.l.veli...@gmail.c

Re: [Piglit] [PATCH 5/6] ARB_pipeline_statistics_query (geom): basic test

2014-11-18 Thread Emil Velikov
On 18/11/14 15:14, Brian Paul wrote: > On 11/17/2014 05:00 PM, Ben Widawsky wrote: >> Signed-off-by: Ben Widawsky [snip] >> +static struct query queries[] = { >> +{ >> + .query = GL_GEOMETRY_SHADER_INVOCATIONS, >> + .name = "GL_GEOMETRY_SHADER_INVOCATIONS", >> + .expected = NUM_PRI

Re: [Piglit] [PATCH 5/6] ARB_pipeline_statistics_query (geom): basic test

2014-11-18 Thread Brian Paul
On 11/17/2014 05:00 PM, Ben Widawsky wrote: Signed-off-by: Ben Widawsky --- .../spec/arb_pipeline_statistics/CMakeLists.gl.txt | 2 + .../arb_pipeline_statistics/pipeline_stats_geom.c | 146 + tests/spec/arb_pipeline_statistics/pipestat_help.c | 3 +- 3 files change