[Piglit] [PATCH 01/10] grouptools.py: Add a module specifically for working with group strings

2014-12-04 Thread Dylan Baker
This module is largely just posixpath (sometimes the functions are renamed), with a couple of unique functions, which are basically wrappers around posixpath functions with some special exceptions. Having and using the module presents the advantage of being able to change the implementation, includ

[Piglit] [PATCH 09/10] oclconform.py: use grouptools module

2014-12-04 Thread Dylan Baker
Signed-off-by: Dylan Baker --- framework/test/oclconform.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/framework/test/oclconform.py b/framework/test/oclconform.py index 9d8bcaf..bed0f2f 100644 --- a/framework/test/oclconform.py +++ b/framework/test/oclconform.py @@

[Piglit] [PATCH 08/10] oglconform.py: Use grouptools instead of os.path

2014-12-04 Thread Dylan Baker
Signed-off-by: Dylan Baker --- tests/oglconform.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/oglconform.py b/tests/oglconform.py index 79a4f25..436247c 100644 --- a/tests/oglconform.py +++ b/tests/oglconform.py @@ -25,8 +25,8 @@ import os import re import sys

[Piglit] [PATCH 02/10] summary.py: use grouptools instead of os.path

2014-12-04 Thread Dylan Baker
Using grouptools helps to lower confusion about what's a group and what's a path. Signed-off-by: Dylan Baker --- framework/summary.py | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/framework/summary.py b/framework/summary.py index f4fd80d..0202f3e 1

[Piglit] [PATCH 07/10] xts.py: USe grouptools module and os.path appropriately

2014-12-04 Thread Dylan Baker
use grouptools when working with groups, and os.path only when working with actual directory paths. Signed-off-by: Dylan Baker --- tests/xts.py | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/tests/xts.py b/tests/xts.py index df6c443..0661558 100644 ---

[Piglit] [PATCH 04/10] glsl_parser_test.py: use grouptools

2014-12-04 Thread Dylan Baker
Signed-off-by: Dylan Baker --- framework/test/glsl_parser_test.py | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/framework/test/glsl_parser_test.py b/framework/test/glsl_parser_test.py index 2c4..d7aebd4 100644 --- a/framework/test/glsl_parser_test.py +++ b/framew

[Piglit] [PATCH 06/10] igt.py: Use grouptools

2014-12-04 Thread Dylan Baker
Signed-off-by: Dylan Baker --- tests/igt.py | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/tests/igt.py b/tests/igt.py index 83a99a9..9c08f57 100644 --- a/tests/igt.py +++ b/tests/igt.py @@ -26,13 +26,8 @@ import os import re import sys import subprocess

[Piglit] [PATCH 03/10] profile.py: use grouptools

2014-12-04 Thread Dylan Baker
--- framework/profile.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/framework/profile.py b/framework/profile.py index d3aba73..270da1c 100644 --- a/framework/profile.py +++ b/framework/profile.py @@ -36,6 +36,7 @@ import importlib from framework.dmesg import get_dmesg

[Piglit] [PATCH 10/10] opencv.py: use grouptools module

2014-12-04 Thread Dylan Baker
Signed-off-by: Dylan Baker --- framework/test/opencv.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/framework/test/opencv.py b/framework/test/opencv.py index 4a8a9a7..eee8079 100644 --- a/framework/test/opencv.py +++ b/framework/test/opencv.py @@ -26,8 +26,10 @@ from __

[Piglit] Add module specifically for working with group strings

2014-12-04 Thread Dylan Baker
One of the most confusing things about piglit is the use of posixpath for working with group strings. This is obviously convenient since piglit uses '/' separated groups, but leads to problems. The first problem is that sometimes os.path gets used when posixpath should be used, which works on Linu

[Piglit] [PATCH 05/10] junit.py: Use grouptools instead of posixpath

2014-12-04 Thread Dylan Baker
This makes it clear that we're working with groups and not paths. Signed-off-by: Dylan Baker --- framework/backends/junit.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/framework/backends/junit.py b/framework/backends/junit.py index 3647601..1f902d2 100644 --- a/fr

Re: [Piglit] [PATCH 1/2 V2] arb_arrays_of_arrays: linker tests

2014-12-04 Thread Chris Forbes
Both patches are: Reviewed-by: Chris Forbes On Fri, Dec 5, 2014 at 10:35 AM, Timothy Arceri wrote: > V2: add alternate version of unsized-mismatch test and fix > comment describing negitive test as a positive test > > Test results: > > AMD Radeon HD 6670 - Catalyst 13.251 OpenGL 4.3 > > vs-to-f

Re: [Piglit] [PATCH V2] glsl-1.20: test implicitly sized arrays match explicitly sized arrays across the same stage

2014-12-04 Thread Chris Forbes
Reviewed-by: Chris Forbes On Fri, Dec 5, 2014 at 10:18 AM, Timothy Arceri wrote: > V2: Add Catalyst test results > > Test results: > > AMD Radeon HD 6670 - Catalyst 13.251 OpenGL 4.3 > > intrastage-unsized-array-mismatch.shader_test > AMD: pass > > intrastage-unsized-array-mismatch2.shader_test

Re: [Piglit] [PATCH] tests lists: Fix cpu/gpu test lists

2014-12-04 Thread Kenneth Graunke
On Thursday, December 04, 2014 01:52:37 PM Dylan Baker wrote: > For some reason that isn't recorded ARB_fragment_program and > ARB_vertex_program were being removed form gpu.py and thus added in > cpu.py, which is incorrect, these tests are actually rendering on the > GPU, and therefore cannot be i

[Piglit] [PATCH] tests lists: Fix cpu/gpu test lists

2014-12-04 Thread Dylan Baker
For some reason that isn't recorded ARB_fragment_program and ARB_vertex_program were being removed form gpu.py and thus added in cpu.py, which is incorrect, these tests are actually rendering on the GPU, and therefore cannot be included in cpu.py but should be in gpu.py Signed-off-by: Dylan Baker

[Piglit] [PATCH 1/2 V2] arb_arrays_of_arrays: linker tests

2014-12-04 Thread Timothy Arceri
V2: add alternate version of unsized-mismatch test and fix comment describing negitive test as a positive test Test results: AMD Radeon HD 6670 - Catalyst 13.251 OpenGL 4.3 vs-to-fs-dimension-size-mismatch.shader_test AMD: crash vs-to-fs-dimensions-mismatch.shader_test AMD: crash vs-to-fs-inte

[Piglit] [PATCH 2/2] arb_arrays_of_arrays: linker intrastage tests

2014-12-04 Thread Timothy Arceri
Test results: AMD Radeon HD 6670 - Catalyst 13.251 OpenGL 4.3 intrastage-dimension-size-mismatch.shader_test AMD: pass intrastage-interface-field.shader_test AMD: pass intrastage-interface.shader_test AMD: pass intrastage-struct-field.shader_test AMD: pass intrastage-struct.shader_test AMD: p

[Piglit] [PATCH V2] glsl-1.20: test implicitly sized arrays match explicitly sized arrays across the same stage

2014-12-04 Thread Timothy Arceri
V2: Add Catalyst test results Test results: AMD Radeon HD 6670 - Catalyst 13.251 OpenGL 4.3 intrastage-unsized-array-mismatch.shader_test AMD: pass intrastage-unsized-array-mismatch2.shader_test AMD: pass intrastage-unsized-array.shader_test AMD: fail intrastage-unsized-array2.shader_test AMD

Re: [Piglit] [PATCH] arb_shader_image_load_store: compiler tests for memory qualifiers

2014-12-04 Thread Jordan Justen
On 2014-12-04 02:33:06, Francisco Jerez wrote: > Jordan Justen writes: > > > Signed-off-by: Jordan Justen > > Cc: Francisco Jerez > > --- > > Francisco, > > > > Question for your image-load-store branch: > > > > Should we parse the memory qualifiers separately from > > storage_qualifier? > > >

[Piglit] [PATCH v2 23/24] arb_shader_image_load_store: Import image unit and uniform state tracking tests.

2014-12-04 Thread Francisco Jerez
Test the image unit and image uniform binding commands and then check that the state query APIs return the expected values for all bound image units. --- tests/all.py | 1 + .../arb_shader_image_load_store/CMakeLists.gl.txt | 1 + tests/spec/arb_shader_im

[Piglit] [PATCH v2 21/24] arb_shader_image_load_store: Import built-in semantics tests.

2014-12-04 Thread Francisco Jerez
Test that image built-in functions do what they are supposed to do by comparing their results with a simulation run on the CPU with similar inputs. The test is repeated for all built-ins, shader stages, formats and texture targets either sequentially or combinatorially depending on the --quick fla

[Piglit] [PATCH v2 19/24] arb_shader_image_load_store: Import memory access qualifier test.

2014-12-04 Thread Francisco Jerez
Test that no changes are observed when an optional image qualifier is omitted (e.g. access qualifiers may be omitted, format qualifiers may be omitted when the "writeonly" qualifier is present), and test several combinations of binding access modes and access qualifiers. --- tests/all.py

[Piglit] [PATCH v2 09/24] arb_shader_image_load_store: Import dead fragments test.

2014-12-04 Thread Francisco Jerez
Test that image stores and atomics have no effect when called from fragment shader invocations that aren't covered by a primitive or have been discarded. --- tests/all.py | 1 + .../arb_shader_image_load_store/CMakeLists.gl.txt | 1 + .../arb_shader_image

[Piglit] [PATCH v2 03/24] arb_shader_image_load_store: Add common image metadata.

2014-12-04 Thread Francisco Jerez
Define helper data structures and functions to query several kinds of information for any supported image format, target or shader stage, like the matching pixel transfer type and format for a given image format, GLSL type information, error tolerance, maximum supported dimensions and samples for a

[Piglit] [PATCH v2 05/24] arb_shader_image_load_store: Add misc. image manipulation code and hook up to the build system.

2014-12-04 Thread Francisco Jerez
--- tests/all.py | 5 + tests/spec/CMakeLists.txt | 1 + .../arb_shader_image_load_store/CMakeLists.gl.txt | 15 + .../arb_shader_image_load_store/CMakeLists.txt | 1 + tests/spec/arb_shader_image_load_store/common.c| 6

[Piglit] [PATCH v2 07/24] arb_shader_image_load_store: Import image format bitcasting test.

2014-12-04 Thread Francisco Jerez
The ARB_shader_image_load_store extension allows the reinterpretation of the binary contents of an existing image as an image of a different compatible format. The resulting values should be predictable and are defined in terms of the usual GL pixel transfer operations. v2: Actually bind the imag

[Piglit] [PATCH v2 17/24] arb_shader_image_load_store: Import test for the maximum texture size.

2014-12-04 Thread Francisco Jerez
Test that images work as expected up to the maximum texture dimensions reported by the implementation for each target. The test is carried out one dimension at a time to avoid creating huge textures (a 16Kx16K RGBA32F texture is already 4GB), but this is not always possible because e.g. both dimen

[Piglit] [PATCH v2 18/24] arb_shader_image_load_store: Import minimum maximum test.

2014-12-04 Thread Francisco Jerez
--- tests/all.py | 1 + .../arb_shader_image_load_store/CMakeLists.gl.txt | 1 + tests/spec/arb_shader_image_load_store/minmax.c| 76 ++ 3 files changed, 78 insertions(+) create mode 100644 tests/spec/arb_shader_image_load_store/min

[Piglit] [PATCH v2 11/24] arb_shader_image_load_store: Import host memory barrier tests.

2014-12-04 Thread Francisco Jerez
Add tests for the glMemoryBarrier() API which provides a way to serialize shader memory transactions issued by previous drawing commands with respect to subsequent GL commands. --- tests/all.py |1 + tests/quick.py |

[Piglit] [PATCH v2 10/24] arb_shader_image_load_store: Import early_fragment_tests test.

2014-12-04 Thread Francisco Jerez
The extension defines an input layout qualifier that allows the application to force early fragment tests for a specified shader program. This has several consequences that are verified by this test, including that the fragment shader is guaranteed not to be executed if the depth test fails, that

[Piglit] [PATCH v2 24/24] arb_shader_image_load_store: Import test for atomics with unused result.

2014-12-04 Thread Francisco Jerez
Test all image atomic built-in functions without using their return value to make sure that they aren't optimized out by the compiler accidentally and because some implementations may use different hardware instructions for the same atomic operation depending on whether the return value of the buil

[Piglit] [PATCH v2 15/24] arb_shader_image_load_store: Import test for mipmap level binding.

2014-12-04 Thread Francisco Jerez
Test that image loads and stores land in the correct mipmap level of the texture when a level other than the first is bound to an image unit. --- tests/all.py | 1 + .../arb_shader_image_load_store/CMakeLists.gl.txt | 1 + tests/spec/arb_shader_image_load

[Piglit] [PATCH v2 13/24] arb_shader_image_load_store: Import invalid and undefined image access tests.

2014-12-04 Thread Francisco Jerez
Test a number of cases like reading or writing outside the limits of the image that the spec defines as being invalid either return zero or have no effect depending on the specific built-in. In addition test that other cases that according to the spec cause undefined results don't lead to program

[Piglit] [PATCH v2 14/24] arb_shader_image_load_store: Import tests for layered and unlayered binding.

2014-12-04 Thread Francisco Jerez
Test binding of individual layers from a layered texture and the simultaneous binding of all layers (layered binding). For textures targets that don't have multiple layers we just test that the layered and unlayered binding modes have no effect as required by the spec. --- tests/all.py

[Piglit] [PATCH v2 06/24] arb_shader_image_load_store: Import atomicity image built-in tests.

2014-12-04 Thread Francisco Jerez
Import a number of tests intended to check if the read-modify-write built-in functions defined by the spec are carried out atomically. --- tests/all.py | 1 + .../arb_shader_image_load_store/CMakeLists.gl.txt | 2 + tests/spec/arb_shader_image_load_store/

[Piglit] [PATCH v2 02/24] util/shader: Define "nothrow" variant of piglit_compile_shader_text().

2014-12-04 Thread Francisco Jerez
Define a variant of piglit_compile_shader_text() that doesn't call piglit_report_result() on failure killing the program, which is quite annoying for tests that expect a compilation to fail and for tests that are structured in a number of subtests, because a single sub-test failing to compile a sha

[Piglit] [PATCH v2 22/24] arb_shader_image_load_store: Import shader memory barrier tests.

2014-12-04 Thread Francisco Jerez
Test the relative ordering of memory transactions before and after a call to the memoryBarrier() GLSL built-in. --- tests/all.py | 1 + tests/quick.py | 1 + .../arb_shader_image_load_store/CMakeLists.gl.txt | 1 + ..

[Piglit] [PATCH v2 20/24] arb_shader_image_load_store: Import image aliasing test.

2014-12-04 Thread Francisco Jerez
Test if the implementation is incorrectly assuming that different image uniforms point to disjoint locations in memory, which could lead to incorrect code transformations and break valid GLSL programs. --- tests/all.py | 1 + .../arb_shader_image_load_store/

[Piglit] [PATCH v2 12/24] arb_shader_image_load_store: Import image array indexing test.

2014-12-04 Thread Francisco Jerez
Test that indexing of image arrays using dynamically uniform expressions works as expected. --- tests/all.py | 1 + .../arb_shader_image_load_store/CMakeLists.gl.txt | 1 + tests/spec/arb_shader_image_load_store/indexing.c | 172 + 3

[Piglit] [PATCH v2 16/24] arb_shader_image_load_store: Import tests for the maximum of supported images.

2014-12-04 Thread Francisco Jerez
Test that the limits of supported image units (GL_MAX_IMAGE_UNITS), per-shader image uniforms (GL_MAX_*_IMAGE_UNIFORMS), and combined image uniforms (GL_MAX_COMBINED_IMAGE_UNIFORMS) are true by setting up a GL pipeline that reaches some of the limits and checking that it renders as expected. --- t

[Piglit] [PATCH v2 04/24] arb_shader_image_load_store: Import grid execution helpers.

2014-12-04 Thread Francisco Jerez
Define helper functions that are able to run a piece of GLSL code on an arbitrary shader stage (as of now VS, TCS, TES, GS, FS and CS are supported) for a given execution size. This makes every shader stage expose a consistent interface that looks like a sort of primitive two-dimensional compute g

[Piglit] [PATCH v2 08/24] arb_shader_image_load_store: Import memory coherency test.

2014-12-04 Thread Francisco Jerez
Test the cache coherency of images declared as "coherent" or "volatile" when accessed from different combinations of dependent shader stages. --- tests/all.py | 1 + tests/quick.py | 2 + .../arb_shader_image_load_store/

[Piglit] [PATCH v2 01/24] util/shader: Handle compute shaders in shader_name().

2014-12-04 Thread Francisco Jerez
--- tests/util/piglit-shader.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/util/piglit-shader.c b/tests/util/piglit-shader.c index 0980fa9..e8fe9c4 100644 --- a/tests/util/piglit-shader.c +++ b/tests/util/piglit-shader.c @@ -109,6 +109,8 @@ shader_name(GLenum target) return

Re: [Piglit] [PATCH] arb_shader_image_load_store: basic imageStore using a uniform

2014-12-04 Thread Francisco Jerez
Jordan Justen writes: > Signed-off-by: Jordan Justen > Cc: Francisco Jerez > --- > Francisco, > > I was looking at your image-load-store branch. I noticed using > imageStore directly from a uniform results in: > > brw_ir_svec4.h:94: brw::array_reg brw::half(const brw::array_reg&, > unsigned in

Re: [Piglit] [PATCH] arb_shader_image_load_store: compiler tests for memory qualifiers

2014-12-04 Thread Francisco Jerez
Jordan Justen writes: > Signed-off-by: Jordan Justen > Cc: Francisco Jerez > --- > Francisco, > > Question for your image-load-store branch: > > Should we parse the memory qualifiers separately from > storage_qualifier? > Yes, I've had something like that lying around in my private branch for