Re: [Piglit] [PATCH] winsys-framework Default to showing window

On 09/11/15 05:19, Dave Airlie wrote: On 21 August 2015 at 22:08, Marek Olšák wrote: Hi Alex, The tests which don't specifically test the behavior of the default framebuffer should use -fbo. I think this is done by marking a test as "concurrent" in all.py. A lot of tests

Re: [Piglit] [PATCH] winsys-framework Default to showing window

Hi Alex, You're right on the theory, but your patch seems to have an issue (read on). On 2015-08-13 19:49, agoins wrote: winsys-framework incorrectly assumed that it will always have ownership of the pixels in its own buffers. If using the default framebuffer (i.e., when Piglit is not

[Piglit] [PATCH 1/2] arb_gpu_shader_fp64: fix wrong use of GLSL version

piglit_require_GLSL_version() requires an integer as parameter, not a float. This fixes an implicit conversion spotted by Clang. Signed-off-by: Samuel Pitoiset --- .../arb_gpu_shader_fp64/execution/double-gettransformfeedbackvarying.c | 2 +- 1 file changed, 1

Re: [Piglit] [PATCH] arb_get_texture_sub_image: Remove unused allocations.

On 11/17/2015 01:07 AM, Vinson Lee wrote: These allocations are never used and are also leaked when later allocations are assigned to the same pointers. Fixes Coverity "resource leak" defects. Signed-off-by: Vinson Lee ---

[Piglit] [PATCH] arb_separate_shader_objects: test mixed explicit and non-explicit locations

This tests a bug in Mesa where explicit locations are not taken into account when assigning varying locations which results in two inputs/outputs being given the same location. Test results: Nvidia GeForce 840M - NVIDIA 352.41: pass i965 - Mesa 11.1-dev: fail Cc: Ian Romanick

Re: [Piglit] [PATCH 1/2] arb_gpu_shader_fp64: fix wrong use of GLSL version

On 11/18/2015 12:30 AM, Samuel Pitoiset wrote: On 11/17/2015 09:37 PM, Dylan Baker wrote: On Tue, Nov 17, 2015 at 04:25:53PM +0100, Samuel Pitoiset wrote: piglit_require_GLSL_version() requires an integer as parameter, not a float. This fixes an implicit conversion spotted by Clang.

Re: [Piglit] [PATCH v2] winsys-framework Default to showing window

Thanks :) Reviewed by: Arthur Huillet On Tue, 17 Nov 2015 11:33:31 -0800 Alex Goins wrote: > From: agoins > > winsys-framework incorrectly assumed that it will always have ownership of the > pixels in its own buffers. If using the

Re: [Piglit] [PATCH 1/2] arb_gpu_shader_fp64: fix wrong use of GLSL version

> Ilia just told me that it's not the same permission for mesa and piglit. > Can someone give me access to push or do I need to create a ticket on > bugs.freedesktop like for mesa? > Daniel Stone is the right person I think. I can push the patch in the meantime. signature.asc Description: PGP

Re: [Piglit] [PATCH 1/2] arb_gpu_shader_fp64: fix wrong use of GLSL version

On Tue, Nov 17, 2015 at 04:49:37PM -0800, Dylan Baker wrote: > > Ilia just told me that it's not the same permission for mesa and piglit. > > Can someone give me access to push or do I need to create a ticket on > > bugs.freedesktop like for mesa? > > > > Daniel Stone is the right person I

[Piglit] [PATCH] arb_get_texture_sub_image: Remove unused allocations.

These allocations are never used and are also leaked when later allocations are assigned to the same pointers. Fixes Coverity "resource leak" defects. Signed-off-by: Vinson Lee --- tests/spec/arb_get_texture_sub_image/getcompressed.c | 5 ++--- 1 file changed, 2

[Piglit] [PATCH] sso: Check piglit_link_check_status return value.

Fixes Coverity "unchecked return value" defect. Signed-off-by: Vinson Lee --- tests/spec/arb_separate_shader_objects/active-sampler-conflict.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Piglit] [PATCH 1/2] arb_gpu_shader_fp64: fix wrong use of GLSL version

On 11/18/2015 01:55 AM, Dylan Baker wrote: On Tue, Nov 17, 2015 at 04:49:37PM -0800, Dylan Baker wrote: Ilia just told me that it's not the same permission for mesa and piglit. Can someone give me access to push or do I need to create a ticket on bugs.freedesktop like for mesa? Daniel

Re: [Piglit] [PATCH] winsys-framework Default to showing window

Woops, yeah, typo. Sure enough, the first one should be false. -Original Message- From: Arthur Huillet [mailto:arthur.huil...@free.fr] Sent: Tuesday, November 17, 2015 3:10 AM To: Alexander Goins Cc: piglit@lists.freedesktop.org; Arthur Huillet Subject: Re: [Piglit] [PATCH]

Re: [Piglit] [PATCH 1/2] arb_gpu_shader_fp64: fix wrong use of GLSL version

On 18 November 2015 at 01:25, Samuel Pitoiset wrote: > piglit_require_GLSL_version() requires an integer as parameter, not a float. > This fixes an implicit conversion spotted by Clang. > > Signed-off-by: Samuel Pitoiset Reviewed-by: Dave

Re: [Piglit] [PATCH v2] winsys-framework Default to showing window

On 18 November 2015 at 05:49, Arthur Huillet wrote: > Thanks :) > > Reviewed by: Arthur Huillet Reviewed-by: Dave Airlie > > On Tue, 17 Nov 2015 11:33:31 -0800 > Alex Goins wrote: > >> From: agoins

Re: [Piglit] [PATCH 1/2] arb_gpu_shader_fp64: fix wrong use of GLSL version

On Tue, Nov 17, 2015 at 04:25:53PM +0100, Samuel Pitoiset wrote: > piglit_require_GLSL_version() requires an integer as parameter, not a float. > This fixes an implicit conversion spotted by Clang. > > Signed-off-by: Samuel Pitoiset > --- >

[Piglit] [PATCH v2] winsys-framework Default to showing window

From: agoins winsys-framework incorrectly assumed that it will always have ownership of the pixels in its own buffers. If using the default framebuffer (i.e., when Piglit is not running in FBO mode,) ownership will not be acquired unless the window is mapped. While this is

Re: [Piglit] [PATCH 2/2] arb_compute_shader: fix too many arguments in call to 'confirm_size'

Both patches Reviewed-by: Timothy Arceri ___ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH] arb_separate_shader_objects: fix geometry shader test

From: Timothy Arceri Inputs to geometry shaders must be an array. --- .../arb_separate_shader_objects/compiler/1.50/layout-location.geom | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git