[Piglit] [PATCH] tests: fix ext_shader_samples_identical ES 3.1 vert test

2016-09-01 Thread Dylan Baker
This test is currently completely broken. It uses names defined in GL_OES_texture_storage_multisample_2d_array without adding a #extension directive or a config requirement. It also doesn't declare precision. Signed-off-by: Dylan Baker cc: i...@freedesktop.org ---

Re: [Piglit] [PATCH 1/5] gl-1.0: Move scissor tests here.

2016-09-01 Thread Brian Paul
Series LGTM. Thanks. Reviewed-by: Brian Paul On 09/01/2016 12:44 PM, Matt Turner wrote: --- tests/all.py | 16 tests/general/CMakeLists.gl.txt| 8

Re: [Piglit] [PATCH 1/5] gl-1.0: Move scissor tests here.

2016-09-01 Thread Dylan Baker
Quoting Dylan Baker (2016-09-01 12:03:35) > > Maybe it's also a good time to evaluate whether these actually need to > be run serially? > Or maybe I should read all the patches before I send comments. signature.asc Description: signature ___ Piglit

Re: [Piglit] [PATCH 1/5] gl-1.0: Move scissor tests here.

2016-09-01 Thread Dylan Baker
Quoting Matt Turner (2016-09-01 11:44:48) > --- > tests/all.py | 16 > tests/general/CMakeLists.gl.txt| 8 > tests/spec/gl-1.0/CMakeLists.gl.txt| 8 > tests/{general =>

[Piglit] [PATCH v2 5/5] unittests: don't require totals section in schema

2016-09-01 Thread Dylan Baker
We generate this on the fly if it's not there and add it. Signed-off-by: Dylan Baker --- unittests/framework/backends/schema/piglit-8.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/unittests/framework/backends/schema/piglit-8.json

[Piglit] [PATCH v2 4/5] unittests: Fix JSON schema test to pass time_elapsed

2016-09-01 Thread Dylan Baker
Signed-off-by: Dylan Baker --- unittests/framework/backends/test_json.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/unittests/framework/backends/test_json.py b/unittests/framework/backends/test_json.py index e6574a6..0c49aff 100644 ---

[Piglit] [PATCH v2 3/5] tox: add a streams target.

2016-09-01 Thread Dylan Baker
Also enables the target in travis and appveyor. Signed-off-by: Dylan Baker --- .travis.yml | 8 appveyor.yml | 8 tox.ini | 3 ++- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/.travis.yml b/.travis.yml index 5c3bf08..97a97a7

[Piglit] [PATCH v2 2/5] framework: Add support for jsonstreams

2016-09-01 Thread Dylan Baker
This commit adds support in the json backend for using an external library that I wrote called jsonstreams. It's a pretty self-explanatory library, and for piglit has several advantages. First, I've measured a consistent 10-15 second speed up for running the quick profile. Second, it *vastly*

[Piglit] [PATCH v2 1/5] unittests: Fix shared data for backends.

2016-09-01 Thread Dylan Baker
It turns out that the backends coincidently put certain fields in, but the new jsonstreams backend does not automatically add these fields, it must be passed them. (This is the behavior of piglit when not testing). Signed-off-by: Dylan Baker ---

[Piglit] [PATCH v2 0/5] Add support for JSON backend to use a streaming writer

2016-09-01 Thread Dylan Baker
This series adds support for using jsonstreams, which is a package I wrote for writing JSON documents using a streaming API. The goal is to reduce the memory usage of piglit, especially while writing out the final result file. This is a purely optional dependency, and those with fast machines

[Piglit] [PATCH 5/5] gl-1.0: Add a scissored depth clear test that uses negative x, y.

2016-09-01 Thread Matt Turner
Exposes a bug in i965, fixed by i965: fix noop_scissor range issue on width/height --- tests/all.py | 1 + tests/spec/gl-1.0/CMakeLists.gl.txt| 1 + .../spec/gl-1.0/scissor-depth-clear-negative-xy.c | 89 ++ 3

[Piglit] [PATCH 3/5] gl-1.0: Call piglit_ortho_projection from piglit_init.

2016-09-01 Thread Matt Turner
In some cases we called it from piglit_display, and in others we had it open-coded in a reshape function. --- tests/spec/gl-1.0/scissor-bitmap.c| 2 +- tests/spec/gl-1.0/scissor-clear.c | 17 + tests/spec/gl-1.0/scissor-copypixels.c| 3 +--

[Piglit] [PATCH 2/5] gl-1.0: Remove @file names.

2016-09-01 Thread Matt Turner
Some were wrong, and Pekka noted that we can simply leave them out and Doxygen will do the right thing. --- tests/spec/gl-1.0/scissor-bitmap.c| 2 +- tests/spec/gl-1.0/scissor-clear.c | 2 +- tests/spec/gl-1.0/scissor-copypixels.c| 2 +- tests/spec/gl-1.0/scissor-depth-clear.c

[Piglit] [PATCH 1/5] gl-1.0: Move scissor tests here.

2016-09-01 Thread Matt Turner
--- tests/all.py | 16 tests/general/CMakeLists.gl.txt| 8 tests/spec/gl-1.0/CMakeLists.gl.txt| 8 tests/{general => spec/gl-1.0}/scissor-bitmap.c| 0 tests/{general

[Piglit] [PATCH 4/5] gl-1.0: Run scissor tests concurrently.

2016-09-01 Thread Matt Turner
--- tests/all.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/all.py b/tests/all.py index 276f5a8..a57256f 100644 --- a/tests/all.py +++ b/tests/all.py @@ -963,14 +963,14 @@ with profile.group_manager( g(['gl-1.0-logicop'])

Re: [Piglit] [PATCH 1/2] general: Correct some @file names.

2016-09-01 Thread Matt Turner
On Thu, Sep 1, 2016 at 12:01 AM, Pekka Paalanen wrote: > On Wed, 31 Aug 2016 13:05:31 -0700 > Matt Turner wrote: > >> --- >> tests/general/scissor-depth-clear.c | 2 +- >> tests/general/scissor-many.c| 2 +- >> 2 files changed, 2 insertions(+), 2

Re: [Piglit] [PATCH] summary/csv: Fix elapsed time output

2016-09-01 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Adam Jackson (2016-09-01 07:26:45) > "" isn't an > especially useful thing to print in the output. > > Signed-off-by: Adam Jackson > --- > framework/programs/summary.py | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3)

2016-09-01 Thread Emil Velikov
On 1 September 2016 at 15:44, Adam Jackson wrote: > On Thu, 2016-09-01 at 15:36 +0100, Emil Velikov wrote: > >> Did you have the chance to respin the EGL device patches for mesa or >> shall I ? > > I have a work-in-progress branch to port it to the drmDevice API here: > >

Re: [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3)

2016-09-01 Thread Adam Jackson
On Thu, 2016-09-01 at 15:36 +0100, Emil Velikov wrote: > Did you have the chance to respin the EGL device patches for mesa or > shall I ? I have a work-in-progress branch to port it to the drmDevice API here: https://cgit.freedesktop.org/~ajax/mesa/log/?h=egl-ext-device I don't remember how

Re: [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3)

2016-09-01 Thread Emil Velikov
On 31 August 2016 at 19:39, Adam Jackson wrote: > v2: > - Cover more error paths, also look up QueryDeviceAttrib (Eric Anholt) > - Fetch function pointers before EGL initialized (Mathias Fröhlich) > > v3: > - Use piglit_check_egl_error and PFN* typedefs, fix NOT_INITIALIZED test

[Piglit] [PATCH] summary/csv: Fix elapsed time output

2016-09-01 Thread Adam Jackson
"" isn't an especially useful thing to print in the output. Signed-off-by: Adam Jackson --- framework/programs/summary.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/programs/summary.py b/framework/programs/summary.py index c297a7b..e400d9a

Re: [Piglit] [PATCH 2/2] egl: Add sanity test for EGL_EXT_device_enumeration (v3)

2016-09-01 Thread Adam Jackson
On Thu, 2016-09-01 at 07:21 +0200, Mathias Fröhlich wrote: > I do share the concern with the stack corruption with Eric. > Anyhow, its very unlikely, so both get my: >   > Reviewed-by: Mathias Fröhlich Fixed this up to clamp the number of devices (and warn if so), and

Re: [Piglit] [PATCH 2/2] xts: Remove large_blend_src.

2016-09-01 Thread Adam Jackson
On Wed, 2016-08-31 at 16:40 -0700, Eric Anholt wrote: > This is a test that I wrote a long time ago but never pushed.  Remove > it until I can fix it up and land it. Series is: Reviewed-by: Adam Jackson - ajax ___ Piglit mailing list

[Piglit] [PATCH v2] cl: Initialize errNo on invalid image type.

2016-09-01 Thread Vinson Lee
Fixes sometimes-uninitialized warning. piglit-util-cl.c:1052:13: warning: variable 'errNo' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] } else if (desc->image_type == CL_MEM_OBJECT_IMAGE3D) {

Re: [Piglit] [PATCH 1/2] general: Correct some @file names.

2016-09-01 Thread Pekka Paalanen
On Wed, 31 Aug 2016 13:05:31 -0700 Matt Turner wrote: > --- > tests/general/scissor-depth-clear.c | 2 +- > tests/general/scissor-many.c| 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tests/general/scissor-depth-clear.c >