[Piglit] [PATCH] framework: Fix FastSkipMixin version comparisons

2016-09-02 Thread Dylan Baker
Currently the FastSkipMixin assumes that versions will always be a minimum required version, and nothing else. This is mostly true of piglit tests, but isn't always true. Sometimes tests specify that they need a version greater-or-equal, and a few have less-than or less-than-equal. This patch

[Piglit] [Bug 97577] Device override incorrectly skips tests

2016-09-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97577 --- Comment #2 from Dylan Baker --- There is the possiblility that there is somethign with piglit's fast skip actually. We fixed a bug in the python shader_runner layer a bit ago in 892f6e44723eda8d, and I noticed that

[Piglit] [Bug 97577] Device override incorrectly skips tests

2016-09-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97577 --- Comment #1 from Ilia Mirkin --- This is actually not a piglit issue - it's an issue with how the intel driver does feature enablement. A bunch of features depend on various kernel features, and so the driver does a

[Piglit] [Bug 97577] New: Device override incorrectly skips tests

2016-09-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97577 Bug ID: 97577 Summary: Device override incorrectly skips tests Product: piglit Version: unspecified Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3)

2016-09-02 Thread Emil Velikov
On 2 September 2016 at 07:15, Mathias Fröhlich wrote: > > Great! > > One question that I cannot forsee from your branch: > > The EGL_EXT_device_enumeration spec says > > > > [...] All implementations must support > > at least one device. > > [...] > > > > Which means

Re: [Piglit] [PATCH] tests: fix ext_shader_samples_identical ES 3.1 vert test

2016-09-02 Thread Alejandro Piñeiro
Reviewed-by: Alejandro Piñeiro On 02/09/16 02:36, Dylan Baker wrote: > This test is currently completely broken. It uses names defined in > GL_OES_texture_storage_multisample_2d_array without adding a #extension > directive or a config requirement. It also doesn't declare

Re: [Piglit] [PATCH 2/5] gl-1.0: Remove @file names.

2016-09-02 Thread Pekka Paalanen
On Thu, 1 Sep 2016 11:44:49 -0700 Matt Turner wrote: > Some were wrong, and Pekka noted that we can simply leave them out and > Doxygen will do the right thing. > --- > tests/spec/gl-1.0/scissor-bitmap.c| 2 +- > tests/spec/gl-1.0/scissor-clear.c | 2 +- >

Re: [Piglit] [PATCH 2/2] egl: Add sanity test for EGL_EXT_device_enumeration (v3)

2016-09-02 Thread Mathias Fröhlich
Hi, On Thursday, 1 September 2016 09:54:05 CEST Adam Jackson wrote: > On Thu, 2016-09-01 at 07:21 +0200, Mathias Fröhlich wrote: > > > I do share the concern with the stack corruption with Eric. > > Anyhow, its very unlikely, so both get my: > > > > Reviewed-by: Mathias Fröhlich

Re: [Piglit] [PATCH 1/2] egl: Add sanity test for EGL_EXT_device_query (v3)

2016-09-02 Thread Mathias Fröhlich
Hi, On Thursday, 1 September 2016 10:44:08 CEST Adam Jackson wrote: > On Thu, 2016-09-01 at 15:36 +0100, Emil Velikov wrote: > > > Did you have the chance to respin the EGL device patches for mesa or > > shall I ? > > I have a work-in-progress branch to port it to the drmDevice API here: > >