Re: [Piglit] [PATCH] egl-nok-swap-region: Fix build against new eglext.h

2016-09-07 Thread Adam Jackson
On Thu, 2016-09-08 at 03:42 +0100, Emil Velikov wrote: > > On 7 September 2016 at 21:50, Adam Jackson wrote: > > index 075df97..6512b6b 100644 > > --- a/tests/egl/egl-nok-swap-region.c > > +++ b/tests/egl/egl-nok-swap-region.c > > @@ -28,6 +28,7 @@ > >   * Test

Re: [Piglit] [PATCH] egl-nok-swap-region: Fix build against new eglext.h

2016-09-07 Thread Emil Velikov
On 7 September 2016 at 21:50, Adam Jackson wrote: > New eglext.h has the typedef corrected to end in PROC like everything > else. Rename the old string to the new when building against old > headers. > > Signed-off-by: Adam Jackson > --- >

Re: [Piglit] Newbie question: command to run tests that passed before?

2016-09-07 Thread Rob Clark
On Wed, Sep 7, 2016 at 6:59 PM, Dan Kegel wrote: > Hi! > I'd like to use piglit as a regression test for my opengl test rigs. > My plan is to run piglit a few times on each OS/card combo I need to support, > get a list of tests that reliably pass on each platform, and then >

Re: [Piglit] [PATCH] egl-nok-swap-region: Fix build against new eglext.h

2016-09-07 Thread Eric Anholt
Adam Jackson writes: > New eglext.h has the typedef corrected to end in PROC like everything > else. Rename the old string to the new when building against old > headers. Nice solution. Reviewed-by: Eric Anholt signature.asc Description: PGP signature

Re: [Piglit] Newbie question: command to run tests that passed before?

2016-09-07 Thread Dylan Baker
Quoting Dylan Baker (2016-09-07 16:23:43) > Quoting Dan Kegel (2016-09-07 15:59:21) > > Hi! > > I'd like to use piglit as a regression test for my opengl test rigs. > > My plan is to run piglit a few times on each OS/card combo I need to > > support, > > get a list of tests that reliably pass on

Re: [Piglit] Newbie question: command to run tests that passed before?

2016-09-07 Thread Dylan Baker
Quoting Mark Janes (2016-09-07 16:24:11) > Piglit converts "known failing" tests to a "skip" status. This is only true of the JUnit backend. I've never bothered to get that working with the default JSON backend. Its on my list of things to do, just not very high up on that list. Dylan

Re: [Piglit] Newbie question: command to run tests that passed before?

2016-09-07 Thread Dylan Baker
Quoting Dan Kegel (2016-09-07 16:10:46) > Hrm. A solution that involved Jenkins would be way overkill. > I'm just looking for the little core idiom for running just the > test of tests that passed in the, um, past. > > Maybe that's not the way people do it? Does everyone just compare > logs

Re: [Piglit] Newbie question: command to run tests that passed before?

2016-09-07 Thread Mark Janes
Dan Kegel writes: > Hrm. A solution that involved Jenkins would be way overkill. > I'm just looking for the little core idiom for running just the > test of tests that passed in the, um, past. Even if you don't want to set up a CI with jenkins, you can refer to the automation

Re: [Piglit] Newbie question: command to run tests that passed before?

2016-09-07 Thread Dylan Baker
Quoting Dan Kegel (2016-09-07 15:59:21) > Hi! > I'd like to use piglit as a regression test for my opengl test rigs. > My plan is to run piglit a few times on each OS/card combo I need to support, > get a list of tests that reliably pass on each platform, and then > forevermore run just those

Re: [Piglit] Newbie question: command to run tests that passed before?

2016-09-07 Thread Dan Kegel
Hrm. A solution that involved Jenkins would be way overkill. I'm just looking for the little core idiom for running just the test of tests that passed in the, um, past. Maybe that's not the way people do it? Does everyone just compare logs against old logs? Thanks, and say hi to Ethyl for me.

Re: [Piglit] Newbie question: command to run tests that passed before?

2016-09-07 Thread Ilia Mirkin
[+janesma] Mark has set up a CI system at Intel, and I'm fairly sure did a writeup about it and shared code, but I can't for the life of me remember the details. Maybe a few Guinesses ago, but definitely not now... hopefully he can share. [It involves Jenkins.] -ilia On Wed, Sep 7, 2016 at

[Piglit] Newbie question: command to run tests that passed before?

2016-09-07 Thread Dan Kegel
Hi! I'd like to use piglit as a regression test for my opengl test rigs. My plan is to run piglit a few times on each OS/card combo I need to support, get a list of tests that reliably pass on each platform, and then forevermore run just those tests. I know about the -t and -x options, and the

Re: [Piglit] [PATCH 0/3] Misc. EGLDevice test fixes

2016-09-07 Thread Adam Jackson
On Wed, 2016-09-07 at 13:27 -0700, James Jones wrote: > I found a few test issues and errors when running the new > egl_ext_device_query and egl_ext_device_enumeration tests.  With > these patches, both tests pass on the binary NVIDIA drivers. Pushed, thanks. - ajax

[Piglit] [PATCH] egl-nok-swap-region: Fix build against new eglext.h

2016-09-07 Thread Adam Jackson
New eglext.h has the typedef corrected to end in PROC like everything else. Rename the old string to the new when building against old headers. Signed-off-by: Adam Jackson --- tests/egl/egl-nok-swap-region.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[Piglit] [PATCH 3/3] egl: eglQueryDeviceStringEXT() takes an EGLDevice

2016-09-07 Thread James Jones
The first parameter of eglQueryDeviceStringEXT() is an EGLDevice, not an EGLDisplay. Signed-off-by: James Jones --- tests/egl/spec/egl_ext_device_query/egl_ext_device_query.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Piglit] [PATCH 1/3] egl: Check for EGL_EXT_device_base

2016-09-07 Thread James Jones
EGL_EXT_device_base is equivalent to EGL_EXT_device_query && EGL_EXT_device_enumeration Signed-off-by: James Jones --- .../spec/egl_ext_device_enumeration/egl_ext_device_enumeration.c | 8 +--- tests/egl/spec/egl_ext_device_query/egl_ext_device_query.c| 6 --

[Piglit] [PATCH 0/3] Misc. EGLDevice test fixes

2016-09-07 Thread James Jones
I found a few test issues and errors when running the new egl_ext_device_query and egl_ext_device_enumeration tests. With these patches, both tests pass on the binary NVIDIA drivers. James Jones (3): egl: Check for EGL_EXT_device_base egl: eglQueryDevicesEXT returns EGL_TRUE on success

[Piglit] [PATCH 2/3] egl: eglQueryDevicesEXT returns EGL_TRUE on success

2016-09-07 Thread James Jones
This is the case even when is NULL or < . The only error conditions mentioned in the spec are for being NULL, or <= 0 when != NULL. Signed-off-by: James Jones --- tests/egl/spec/egl_ext_device_enumeration/egl_ext_device_enumeration.c | 2 +- 1 file changed, 1

Re: [Piglit] [RFC] Trying to fix dmabuf/yuv tests

2016-09-07 Thread Rob Clark
On Wed, Sep 7, 2016 at 3:07 PM, Emil Velikov wrote: > On Tuesday, 6 September 2016, Rob Clark wrote: >> >> On Tue, Sep 6, 2016 at 4:04 PM, Kristian Høgsberg >> wrote: > > >> >> > If we have the gbm eglimage path, why do we keep

Re: [Piglit] [RFC] Trying to fix dmabuf/yuv tests

2016-09-07 Thread Emil Velikov
On Tuesday, 6 September 2016, Rob Clark wrote: > On Tue, Sep 6, 2016 at 4:04 PM, Kristian Høgsberg > wrote: > > > If we have the gbm eglimage path, why do we keep the intel specific code > around? > > only plausible reason I could come

[Piglit] [PATCH] dmabuf: fix YUV tests for drivers other than intel

2016-09-07 Thread Rob Clark
Ok, so the basic problem with the YUV tests is that they currently completely ignore driver/hw pitch requirements, since the code that allocates the buffer doesn't know the pixel format, only the 'cpp'. The yuv test creates a small 4x4 yuv eglimage. If, say, the hardware requires the pitch to be

[Piglit] [Crucible] [PATCH] func.miptree: Set appropriate usage flags for given test case

2016-09-07 Thread Nanley Chery
Enables some test cases to run instead of skipping (e.g. all stencil tests). Signed-off-by: Nanley Chery --- src/tests/func/miptree/miptree.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/src/tests/func/miptree/miptree.c

Re: [Piglit] [RFC] Trying to fix dmabuf/yuv tests

2016-09-07 Thread Rob Clark
On Tue, Sep 6, 2016 at 4:53 PM, Kristian Høgsberg wrote: > On Tue, Sep 6, 2016 at 1:32 PM, Rob Clark wrote: >> On Tue, Sep 6, 2016 at 4:23 PM, Rob Clark wrote: > @@ -212,28 +247,65 @@ piglit_gbm_buf_create(unsigned w, unsigned

[Piglit] [PATCH] arb_texture_view/rendering-formats: test glClear(1, 1, 1, 1) w/ texture views

2016-09-07 Thread Marek Olšák
From: Marek Olšák needed to exercise radeonsi codepaths --- tests/spec/arb_texture_view/rendering-formats.c | 570 +++- 1 file changed, 559 insertions(+), 11 deletions(-) diff --git a/tests/spec/arb_texture_view/rendering-formats.c