Re: [Piglit] [PATCH 0/15] Add support for shader_runner to run more than one test per process

2016-09-10 Thread Dylan Baker
On Sat, Sep 10, 2016, at 06:56, Marek Olšák wrote: > Thanks a lot of doing this!! > > BTW, --no-process-isolation is not a valid parameter. Yeah, I decided to change the parameter after I ran the benchmarks, when I was writing documentation and proper commit messages. I realized that I'd

Re: [Piglit] [PATCH 2/2] dmabuf: fix small typo in error message

2016-09-10 Thread Rob Clark
On Sat, Sep 10, 2016 at 11:40 AM, Ilia Mirkin wrote: > On Sat, Sep 10, 2016 at 11:32 AM, Rob Clark wrote: >> Signed-off-by: Rob Clark >> Reviewed-by: Eric Anholt >> --- >>

Re: [Piglit] [PATCH 2/2] dmabuf: fix small typo in error message

2016-09-10 Thread Ilia Mirkin
On Sat, Sep 10, 2016 at 11:32 AM, Rob Clark wrote: > Signed-off-by: Rob Clark > Reviewed-by: Eric Anholt > --- > tests/util/piglit-framework-gl/piglit_drm_dma_buf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[Piglit] [PATCH 1/2 v3] dmabuf: fix YUV tests for drivers other than intel

2016-09-10 Thread Rob Clark
Ok, so the basic problem with the YUV tests is that they currently completely ignore driver/hw pitch requirements, since the code that allocates the buffer doesn't know the pixel format, only the 'cpp'. The yuv test creates a small 4x4 yuv eglimage. If, say, the hardware requires the pitch to be

[Piglit] [PATCH 2/2] dmabuf: fix small typo in error message

2016-09-10 Thread Rob Clark
Signed-off-by: Rob Clark Reviewed-by: Eric Anholt --- tests/util/piglit-framework-gl/piglit_drm_dma_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/piglit-framework-gl/piglit_drm_dma_buf.c

[Piglit] [PATCH v2 1/2] shader_runner: add support for glDispatchComputeGroupSizeARB()

2016-09-10 Thread Samuel Pitoiset
This allows to dispatch compute shaders with a variable local size using the new "compute group size" command. Signed-off-by: Samuel Pitoiset --- tests/shaders/shader_runner.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/shaders/shader_runner.c

[Piglit] [PATCH v2 0/2] ARB_compute_variable_group_size

2016-09-10 Thread Samuel Pitoiset
v2: - add glDispatchComputeGroupSizeARB to shader_runner - update formatting spec quotations - add a new test which checks various local sizes From original cover-letter: Hi there, This patch adds some tests for ARB_compute_variable_group_size which is written against GL 4.3. All tests

[Piglit] [PATCH v2 2/2] add ARB_compute_variable_group_size tests

2016-09-10 Thread Samuel Pitoiset
v1: - update formatting spec quotations (Nicolai) - use shader_runner for the basic test (Ian) - add a new test which checks various local sizes (Nicolai) Signed-off-by: Samuel Pitoiset --- tests/all.py | 8 +

Re: [Piglit] [PATCH] cts_gl.py: only generate tests for GL45-CTS

2016-09-10 Thread Alejandro Piñeiro
On 10/09/16 15:39, Marek Olšák wrote: > On Sat, Sep 10, 2016 at 2:41 PM, Alejandro Piñeiro > wrote: >> On 09/09/16 15:10, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> Older versions don't work and there is no interest in fixing the official >> >>

Re: [Piglit] [PATCH] cts_gl.py: only generate tests for GL45-CTS

2016-09-10 Thread Alejandro Piñeiro
On 09/09/16 15:10, Marek Olšák wrote: > From: Marek Olšák > > Older versions don't work and there is no interest in fixing the official Could you elaborate that older versions doesn't work? We are right now focusing on gl44, and except some local patches that we needed to

Re: [Piglit] [PATCH] cl: Add a test for the predefined macros

2016-09-10 Thread Serge Martin
On Saturday 10 September 2016 11:46:32 Niels Ole Salscheider wrote: > Signed-off-by: Niels Ole Salscheider > --- > tests/cl/program/build/cl-defines.cl | 22 ++ > 1 file changed, 22 insertions(+) > create mode 100644

Re: [Piglit] [PATCH 0/15] Add support for shader_runner to run more than one test per process

2016-09-10 Thread Nicolai Hähnle
Thanks for doing that, the numbers are impressive. Two small comments on the C parts; it's been too long since I looked into the Python parts to be able to properly comment. Cheers, Nicolai On 09.09.2016 21:18, Dylan Baker wrote: This allows shader_runner to consume more than one test at a

Re: [Piglit] [PATCH 12/15] squash! shader_runner: add ability to run multiple tests per process

2016-09-10 Thread Nicolai Hähnle
On 09.09.2016 21:18, Dylan Baker wrote: Bug fixes from me for the above patch. I've split these out to make them easier to review. Before merging to master this will be squashed into the previous patch. Changes: - Fix the assertion of subuniform_locations - Add teardown function for UBOs

Re: [Piglit] [PATCH 6/15] shader_runner: propagate all errors to piglit_init

2016-09-10 Thread Nicolai Hähnle
On 09.09.2016 21:18, Dylan Baker wrote: From: Marek Olšák piglit_report_result prevents running multiple tests per process. --- tests/shaders/shader_runner.c | 231 +-- 1 file changed, 140 insertions(+), 91 deletions(-) diff --git

[Piglit] [PATCH] cl: Add a test for the predefined macros

2016-09-10 Thread Niels Ole Salscheider
Signed-off-by: Niels Ole Salscheider --- tests/cl/program/build/cl-defines.cl | 22 ++ 1 file changed, 22 insertions(+) create mode 100644 tests/cl/program/build/cl-defines.cl diff --git a/tests/cl/program/build/cl-defines.cl