Re: [Piglit] [PATCH 2/2] arb_post_depth_coverage: Make multisampling test more robust

[Cc'ing original test author/reviewer...] On Mon, May 22, 2017 at 2:55 PM, Lyude wrote: > The multisampling test we currently have is not very useful. If you > modify the vertex shader it uses that enables ARB_post_depth_coverage > such that the lines enabling said extension

Re: [Piglit] [PATCH 1/2] shaders: set missing blue color to glsl-const-builtin-distance.shader_test

Series is: Tested-by: Mark Janes Samuel Pitoiset writes: > Since b741bc770 ("parser_utils: do not overwrite value when no > digits are found "), the blue color has to be explicitly initialized > to zero. > > Cc: Mark Janes

[Piglit] [PATCH 1/2] shaders: set missing blue color to glsl-const-builtin-distance.shader_test

Since b741bc770 ("parser_utils: do not overwrite value when no digits are found "), the blue color has to be explicitly initialized to zero. Cc: Mark Janes Signed-off-by: Samuel Pitoiset ---

[Piglit] [PATCH 2/2] arb_gpu_shader_fp64: set missing 'w' component to glsl-uniform-initializer-4

Since b741bc770 ("parser_utils: do not overwrite value when no digits are found "), the 'w' component has to be explicitly initialized to zero. Cc: Mark Janes Signed-off-by: Samuel Pitoiset ---

[Piglit] [PATCH 0/2] Fix arb_post_depth_coverage piglit tests

Some fixes that had to be written since the original piglit test didn't execute on nouveau, and also didn't actually test if arb_post_depth_coverage actually worked. Lyude (2): arb_post_depth_coverage: Don't try sample rates we don't support arb_post_depth_coverage: Make multisampling test

[Piglit] [PATCH 2/2] arb_post_depth_coverage: Make multisampling test more robust

The multisampling test we currently have is not very useful. If you modify the vertex shader it uses that enables ARB_post_depth_coverage such that the lines enabling said extension are commented out, you will notice that the test still "passes" with flying colors. While this makes sure that

[Piglit] [PATCH 1/2] arb_post_depth_coverage: Don't try sample rates we don't support

Some intel hardware supports up to 16 samples, but nvidia only goes up to 8. So stop these tests from failing on nvidia hardware by only testing up to the max sample rate we can support. Signed-off-by: Lyude --- tests/spec/arb_post_depth_coverage/multisampling.c | 4 +++-

Re: [Piglit] [PATCH] drawoverhead: new microbenchmark

LGTM. Reviewed-by: Brian Paul On 04/30/2017 05:58 PM, Marek Olšák wrote: From: Marek Olšák Based on a benchmark from mesa/demos, but rewritten and extended. It's a benchmark expected to be run separately, not a piglit test. So why piglit? Because it's

Re: [Piglit] [PATCH] drawoverhead: new microbenchmark

On 05/15/2017 08:05 AM, Marek Olšák wrote: On Thu, May 11, 2017 at 9:49 PM, Eric Anholt wrote: Marek Olšák writes: From: Marek Olšák Based on a benchmark from mesa/demos, but rewritten and extended. It's a benchmark expected to be

Re: [Piglit] [PATCH] test/gleantest: fix missing --quick property from quick profile

On 19/05/17 03:21 PM, Timothy Arceri wrote: > --- > framework/test/gleantest.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/framework/test/gleantest.py b/framework/test/gleantest.py > index b2d56f3..0220c1a 100644 > --- a/framework/test/gleantest.py > +++