[Piglit] [PATCH] teximage-colors: accept -127 instead of -128 for exact snorm up/download

From: Roland Scheidegger -128 and -127 represent exactly the same value (-1.0) for snorm8 values, as do -32768/-32767 for snorm16. Therefore it seems quite reasonable that an implementation would return the other representation (in particular r600 will do this with a blit,

Re: [Piglit] [PATCH 0/1] Test for updating shared buffer

Fabian Bieler writes: > I think you'll have to call glFinish (or some fence functions) after > altering a buffer and before switching the context to ensure the changes > are visible in the new context. Thanks for digging up the relevant docs. I tried both Finish

Re: [Piglit] [PATCH 0/1] Test for updating shared buffer

On 2018-01-07 03:37, David McFarland wrote: > This test is based on the glx shader sharing test. It currently fails for me > on > radeonsi. The idea is: > > - create context A+B > - make A current > - create buffer > - set buffer content to red > - bind buffer as uniform > - draw quad

Re: [Piglit] [PATCH 17/18] !UPSTREAM util-gl: Probe with GS / TRAFO_FDBK

Please disregard this patch. On 2018-01-07 23:14, Fabian Bieler wrote: > WIP > > not faster -> drop it > --- > tests/util/piglit-util-gl.c | 180 > > 1 file changed, 180 insertions(+) > > diff --git a/tests/util/piglit-util-gl.c

Re: [Piglit] [PATCH 16/18] !UPSTREAM gles2: Add test fbo-draw-sample

Please disregard this patch. On 2018-01-07 23:14, Fabian Bieler wrote: > Alternate drawing solid colors to an fbo and sampling from it to the > framebuffer. > > Some Tiled renderers reorder draw calls so to to minimize tile switching. > > TODO > --- > tests/all.py |

[Piglit] [PATCH 02/18] util-gl: Add piglit_probe_rect_two_rgb.

Read color data from the given rectangle and compare its RGB value to the given two expected values. Print a log message if the color value deviates from both expected values. Return true if the color values match, false otherwise. This is useful to compare two renders drawn on top of each other

[Piglit] [PATCH 14/18] gles3: Test transform-feedback to uniform-buffer-object

Some tiling renderers reorder draw-calls for performance reasons. This could interfere with the integrity of resources written to by draws calls and read from by subsequent draw calls. This test uses a buffer object, written by transform feedback and read as a uniform buffer object. With

[Piglit] [PATCH 03/18] ignore-adjacent-veritces: Use util function to probe framebuffer.

Use newly created piglit_probe_rect_two_rgb instead of test-local framebuffer probing code. --- .../execution/ignore-adjacent-vertices.c | 37 +++--- 1 file changed, 4 insertions(+), 33 deletions(-) diff --git

[Piglit] [PATCH 05/18] util-gl: Silence some lint warnings.

clang-tidy complained about a potential memory leak, a type mismatch in a malloc call and a potential null-pointer deref. All three issues were false positives but I got tired of ignoring them. --- tests/util/piglit-util-gl.c | 25 + 1 file changed, 13 insertions(+), 12

[Piglit] [PATCH 08/18] util-gl: Consolidate printing of bad probed pixels.

Use common code for printing unexpeced results for float and ubyte color probes. --- tests/util/piglit-util-gl.c | 167 ++-- 1 file changed, 85 insertions(+), 82 deletions(-) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c index

[Piglit] [PATCH 09/18] util-gl: Add pixel comparison functions.

Add two static functions to compare n-component float or ubyte color values. This is code easily shared between multiple probing functions. Note: piglit_probe_rect_halves_equal_rgba was moved down to the other probing functions in order to use one of the new functions without a forward

[Piglit] [PATCH 06/18] util-gl: Make piglit_compare_images_color respect x and y arguments.

piglit_compare_images_color used to ignore it's x and y arguments. This commit fixes that and fixes piglit_probe_image_color which used to pass garbage values into piglit_compare_images_color. The header comment of piglit_probe_image_color is also updated. --- tests/util/piglit-util-gl.c | 13

[Piglit] [PATCH 10/18] util-gl: Remove tolerance from integer pixel probes.

The present tests using these functions use the default piglit_tolerance of 0.01 which is as good as no tolerance for integer values. --- tests/util/piglit-util-gl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c

[Piglit] [PATCH 01/18] util/gl: Print numeric value of unrecognized enums.

Use a static cyclic buffer of 4096 bytes. This should give returned strings a long enough lifetime. --- tests/util/piglit-util-gl-enum-gen.c.mako | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/tests/util/piglit-util-gl-enum-gen.c.mako

[Piglit] [PATCH 18/18] framework: Handle crashing subtest.

Piglit silently ignored crashes in subtests. It's impossible to know what subtest crashed. Theoretically it might even be possible that a test crashes after the last call to piglit_report_subtest_result and thus no subtest crashed. Though the odds of that happening are probably pretty long. If a

[Piglit] [PATCH 11/18] Add test for all user defined clip planes

Previously the only fixed function user defined clip plane test used only one clip plane and no coordinate transformation. This new test uses all clip planes and a non-identity coordinate transformation matrix. The test works as follows: Arrange all clip planes perpendicular to the x-y-plane

[Piglit] [PATCH 12/18] gl 1.0: Stress test GL_LINE_LOOP.

Draw circles with long line loops and check the result. In particular, check that the last line segment is drawn and that no additional segments in between arbitrary vertices are drawn. --- tests/all.py| 1 + tests/spec/gl-1.0/CMakeLists.gl.txt | 1 +

[Piglit] [PATCH 04/18] triangle-rasterization: Use util function to probe framebuffer.

Use newly created piglit_probe_rect_two_rgb instead of test-local framebuffer probing code. --- tests/general/triangle-rasterization.cpp | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/tests/general/triangle-rasterization.cpp

[Piglit] [PATCH 07/18] util-gl: Remove piglit prefix from static functions.

--- tests/util/piglit-util-gl.c | 55 +++-- 1 file changed, 28 insertions(+), 27 deletions(-) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c index 8b9b093b3..347036948 100644 --- a/tests/util/piglit-util-gl.c +++

[Piglit] [PATCH 13/18] arb_draw_indirect/draw-arrays-prim-restart: Ignore primitive restart.

glspec45 says since version 20141030 primitive restart only affects glDrawElements* calls. This is supposed to be a retroactive change. Previously, this test expected glDrawArraysIndirect to respect primitive restart. This commit modifies the test to expect glDrawArraysIndirect to ignore it,

[Piglit] [PATCH 17/18] !UPSTREAM util-gl: Probe with GS / TRAFO_FDBK

WIP not faster -> drop it --- tests/util/piglit-util-gl.c | 180 1 file changed, 180 insertions(+) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c index e9c20385e..39125e3a4 100644 --- a/tests/util/piglit-util-gl.c +++

[Piglit] [PATCH 15/18] arb_texture_barrier add test texture-halves-ping-pong-operation-chain

From the GL_ARB_texture_barrier spec: "Specifically, the values of rendered fragments are undefined if any shader stage fetches texels and the same texels are written via fragment shader outputs, even if the reads and writes are not in the same Draw call, unless any of the following

[Piglit] [PATCH 16/18] !UPSTREAM gles2: Add test fbo-draw-sample

Alternate drawing solid colors to an fbo and sampling from it to the framebuffer. Some Tiled renderers reorder draw calls so to to minimize tile switching. TODO --- tests/all.py | 1 + tests/spec/gles-2.0/CMakeLists.gles2.txt | 1 +

[Piglit] [Bug 99293] piglit test for render reordering

https://bugs.freedesktop.org/show_bug.cgi?id=99293 --- Comment #2 from Rob Clark --- hmm, I meant to write some test but never got around to it. I was in particular thinking of something really simple that toggled between two fbo's rendering to current fbo and sampling

[Piglit] [PATCH] ssbo/execution: test std140/430 struct deref

This catches Mesa bug 104492 on radeonsi. The existing std140/430 tests don't assign whole struct variables, only individual struct members, which does not trigger the bug. --- Timothy Arceri recommended that I turn my stand-alone test case for this bug into a piglit test case, which is a great