Re: [Piglit] [PATCH] arb_program_interface_query: corrected AoA's index variable expectation

actually want to fix this properly then we could do it by > making a NIR linker for GLSL. > > [1] https://bugs.freedesktop.org/show_bug.cgi?id=92822 OK. Thanks for the thorough explanation! I'll drop this patch. > > On 9/2/19 3:59 am, Andres Gomez wrote: > > Naming

Re: [Piglit] [PATCH] glsl-1.10: test for crash in loop analysis

This is: Reviewed-by: Andres Gomez On Tue, 2019-03-19 at 14:29 +1100, Timothy Arceri wrote: > This test for a crash in Mesa seen in an Assasins Creed Odyssey shader. > --- > ...riable-iteration-limit-unroll4.shader_test | 88 +++ > 1 file changed, 88 insertions(

Re: [Piglit] [PATCH 04/10] arb_enhanced_layouts: add aliasing tests with mixed type widths

On Wed, 2019-03-20 at 20:56 +1100, Timothy Arceri wrote: > > On 20/3/19 7:58 pm, Juan A. Suarez Romero wrote: > > For the 4 first patches in the series: > > > > Reviewed-by: Juan A. Suarez > > > > > > On Fri, 2019-02-01 at 19:55 +0200, Andres

Re: [Piglit] [PATCH 2/2] arb_program_interface_query: correct rendez-vous by name matching

On Tue, 2019-03-19 at 16:14 +0200, Andres Gomez wrote: > On Sat, 2019-02-16 at 10:22 +1100, Timothy Arceri wrote: > > It would be great if you could run this test on the Nvidia binary blob > > to confirm the results. If everything works as expected the series is: > > The p

Re: [Piglit] [PATCH 2/2] arb_program_interface_query: correct rendez-vous by name matching

, I'll understand I can land this series with your Rb. > Reviewed-by: Timothy Arceri > > Thanks for fixing all this! > > On 9/2/19 3:57 am, Andres Gomez wrote: > > Previuosly, this was overlooked asuming that, since they were SSOs, no > > inner interface matching

Re: [Piglit] [PATCH] editorconfig: Add max_line_length property

On Fri, 2019-02-22 at 18:15 +, Eric Engestrom wrote: > > On February 22, 2019 2:51:28 PM UTC, Andres Gomez wrote: > > The property is supported by most of the editors, but not all: > > https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length

[Piglit] [PATCH] editorconfig: Add max_line_length property

The property is supported by most of the editors, but not all: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length Cc: Eric Engestrom Cc: Eric Anholt Signed-off-by: Andres Gomez --- .editorconfig | 4 1 file changed, 4 insertions(+) diff --git

[Piglit] [PATCH] arb_program_interface_query: corrected AoA's index variable expectation

separate active variable." Cc: Timothy Arceri Cc: Martin Peres Signed-off-by: Andres Gomez --- .../spec/arb_program_interface_query/getprogramresourceindex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/arb_program_interface_query/getprogra

[Piglit] [PATCH 2/2] arb_program_interface_query: correct rendez-vous by name matching

Arceri Cc: Tapani Pälli Cc: Ilia Mirkin Cc: Martin Peres Signed-off-by: Andres Gomez --- .../spec/arb_program_interface_query/common.h | 61 --- .../getprogramresourceiv.c| 8 +-- .../resource-query.c | 48 +++ 3 files c

[Piglit] [PATCH 1/2] arb_program_interface_query: correct tests table indentation

Cc: Timothy Arceri Cc: Martin Peres Signed-off-by: Andres Gomez --- tests/spec/arb_program_interface_query/resource-query.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/spec/arb_program_interface_query/resource-query.c b/tests/spec/arb_program_interface_query

[Piglit] [PATCH 0/2] arb_program_interface_query: series correcting existing tests

This addresses, basically, problems due to interface mismatching with separable program objects. Andres Gomez (2): arb_program_interface_query: correct tests table indentation arb_program_interface_query: correct rendez-vous by name matching .../spec/arb_program_interface_query/common.h

[Piglit] [PATCH] arb_separate_shader_objects: add rendez-vous-by mismatch tests

nputs on the interface will be undefined." Cc: Timothy Arceri Cc: Iago Toral Quiroga Cc: Samuel Iglesias Gonsálvez Cc: Tapani Pälli Cc: Ian Romanick Cc: Ilia Mirkin Signed-off-by: Andres Gomez --- .../CMakeLists.gl.txt | 2 + .../rendezvous_by_location

[Piglit] [PATCH v2 10/10] arb_enhanced_layouts: add xfb_offset overlap test

From the GL_ARB_enhanced_layouts spec: " No aliasing in output buffers is allowed: It is a compile-time or link-time error to specify variables with overlapping transform feedback offsets." v2: added forgotten check_link. Cc: Timothy Arceri Signed-off-by: An

Re: [Piglit] [PATCH 09/10] arb_enhanced_layouts: add another xfb_stride overflow test

On Sat, 2019-02-02 at 10:15 +1100, Timothy Arceri wrote: > On 2/2/19 4:55 am, Andres Gomez wrote: > > Additional check to address a bug in mesa in which a stride which > > is a divisor of the declared offset for an overflowing varying > > won't fail. > > > > From

[Piglit] [PATCH 10/10] arb_enhanced_layouts: add xfb_offset overlap test

From the GL_ARB_enhanced_layouts spec: " No aliasing in output buffers is allowed: It is a compile-time or link-time error to specify variables with overlapping transform feedback offsets." Cc: Timothy Arceri Signed-off-by: Andres Gomez --- .../xfb_offset/invalid-ov

[Piglit] [PATCH 09/10] arb_enhanced_layouts: add another xfb_stride overflow test

tated on declarations before or after the *xfb_stride*, or in different compilation units." Cc: Timothy Arceri Signed-off-by: Andres Gomez --- .../xfb_stride/variable-stride-overflow2.vert | 28 +++ 1 file changed, 28 insertions(+) create mode 100644

[Piglit] [PATCH 04/10] arb_enhanced_layouts: add aliasing tests with mixed type widths

etect that every path through the vertex shader executable accesses multiple inputs aliased to any single component." Cc: Timothy Arceri Cc: Iago Toral Quiroga Cc: Ilia Mirkin Signed-off-by: Andres Gomez --- .../type-mismatch-signed-double.vert | 59 +++ .../widt

[Piglit] [PATCH 07/10] arb_enhanced_layouts: add component aliasing tests

d qualification, and neither has a location qualifier, or – the two variables are declared with the same location and component layout qualifiers and match in type and qualification." Cc: Timothy Arceri Cc: Iago Toral Quiroga Cc: Ilia Mirkin Signed-

[Piglit] [PATCH 08/10] arb_separate_shader_objects: add unused location qualified input test

." Cc: Timothy Arceri Cc: Iago Toral Quiroga Cc: Samuel Iglesias Gonsálvez Cc: Tapani Pälli Cc: Ian Romanick Signed-off-by: Andres Gomez --- ...explicit-location-unused-input.shader_test | 38 +++ 1 file changed, 38 insertions(+) create mode 100644 tests/spec/arb_sep

[Piglit] [PATCH 06/10] arb_separate_shader_objects: add location overlapping tests

es are assigned to the same location." Cc: Timothy Arceri Cc: Iago Toral Quiroga Cc: Ilia Mirkin Signed-off-by: Andres Gomez --- ...uplicated-input-overlap-double.shader_test | 58 +++ ...ation-duplicated-input-overlap.shader_test | 55 ++ ...pli

[Piglit] [PATCH 02/10] arb_enhanced_layouts: GL_ARB_gpu_shader_fp64 requires GLSL 1.50

Cc: Timothy Arceri Signed-off-by: Andres Gomez --- .../compiler/component-layout/double-component-1.vert | 4 ++-- .../compiler/component-layout/double-component-3.vert | 4 ++-- .../compiler/component-layout/dvec2.vert | 4 ++-- .../compiler/component-layout/dvec3.vert

[Piglit] [PATCH 05/10] arb_enhanced_layouts: correct component usage with dvec{3, 4} tests

mponent 1 or 3 as the beginning of a double or dvec2." Cc: Timothy Arceri Cc: Kenneth Graunke Signed-off-by: Andres Gomez --- .../arb_enhanced_layouts/compiler/component-layout/dvec3.vert | 2 +- .../arb_enhanced_layouts/compiler/component-layout/dvec4.vert | 2 +- .../execution/compon

[Piglit] [PATCH 01/10] arb_enhanced_layouts: corrected multiple comments

Cc: Timothy Arceri Signed-off-by: Andres Gomez --- .../vs-gs-fs-double.shader_test | 16 +++ .../vs-tcs-tes-fs-double.shader_test | 42 +-- ...-fs-type-mismatch-double-float.shader_test | 4 +- ...-fs-type-mismatch-signed-float.shader_test | 4

[Piglit] [PATCH 00/10] arb_enhanced_layouts: additional tests

This series adds several arb_enhanced_layouts tests and some arb_separate_shader_objects more addressing problems found in mesa and not checked in piglit. They are mostly related to the use of the location, component, xfb_offset and xfb_stride layout qualifiers. Andres Gomez (10

Re: [Piglit] [PATCH] travis: reflect new best-practice travis-ci configuration

This is: Reviewed-by: Andres Gomez On Sun, 2018-12-02 at 11:28 -0500, Rhys Kidd wrote: > Travis-CI has or will shortly make in early December 2018 a number of > beneficial > changes to their Linux continuous integration testing infrastructure [0][1]. > An accompanying benefit of

[Piglit] [PATCH] tests: Added a new GTF-GLES test profile for the Khronos CTS runner

Cc: Mark Janes Cc: Dylan Baker Cc: Juan A. Suarez Romero Signed-off-by: Andres Gomez --- tests/gtf_gles.py | 82 +++ 1 file changed, 82 insertions(+) create mode 100644 tests/gtf_gles.py diff --git a/tests/gtf_gles.py b/tests/gtf_gles.py new file

Re: [Piglit] [PATCH 1/2] tox: Remove testing of end-of-life Python 3.3

On Sun, 2018-07-29 at 13:10 +0100, Daniel Stone wrote: > Hi, > > On Mon, 23 Jul 2018 at 18:20, Eric Engestrom wrote: > > On Friday, 2018-07-20 09:41:12 +0300, Andres Gomez wrote: > > > On Mon, 2018-06-11 at 12:15 +0100, Eric Engestrom wrote: > > > > On Mon

Re: [Piglit] [PATCH] travis: drop python 3.3

On Thu, 2018-07-19 at 22:16 -0400, Rhys Kidd wrote: > On Thu, 19 Jul 2018 at 18:59, Andres Gomez wrote: > > It's quite old and not even supported by wheel any more. > > > > Cc: Juan A. Suarez Romero > > Cc: Dylan Baker > > Signed-off-by: Andres Gomez > &

[Piglit] [PATCH] travis: drop python 3.3

It's quite old and not even supported by wheel any more. Cc: Juan A. Suarez Romero Cc: Dylan Baker Signed-off-by: Andres Gomez --- .travis.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index b4cbcca49..b6e8136e8 100644 --- a/.travis.yml +++ b/.travis.yml

[Piglit] [PATCH] framework: deepcopy TestProfile's filters when copying it

This avoids modifications in the original filters object. Detected through Travis CI. Fixed also a couple of typos. Fixes: 1f0f2ad25 ("framework: Add filters class") Cc: Dylan Baker Cc: Michel Dänzer Signed-off-by: Andres Gomez --- framework/profile.py

[Piglit] [PATCH] tox: remove pytest-warnings and set pytest-timeout to 1.2.1

pytest-warnings is not needed since it was integrated into pytest's core since 3.1 pytest-timeout >= 1.3.0 requires pytest >= 3.6.0 and we want to keep using 3.2.5 Cc: Juan A. Suarez Romero Cc: Dylan Baker Signed-off-by: Andres Gomez --- tox.ini | 3 +-- 1 file changed, 1 insertion

Re: [Piglit] [PATCH] unittests: mustpass is a text list

This is: Reviewed-by: Andres Gomez <ago...@igalia.com> On Thu, 2018-04-19 at 09:44 +0200, Juan A. Suarez Romero wrote: > Commit 7cf9e743a updated deqp mustpass lists to use text based mustpass. > > Hence unit tests should use text based mustpass too. > > Fixes: 7cf9e743

[Piglit] [PATCH] tests: Added a new NoContext test profile for the Khronos CTS runner

l.com> Cc: Juan A. Suarez Romero <jasua...@igalia.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/khr_noctx.py | 79 ++ 1 file changed, 79 insertions(+) create mode 100644 tests/khr_noctx.py diff --git a/tests/khr_noctx

[Piglit] [PATCH] tests: Added a new GLES test profile for the Khronos CTS runner

gt; Cc: Dylan Baker <dylanx.c.ba...@intel.com> Cc: Juan A. Suarez Romero <jasua...@igalia.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/khr_gles.py | 88 +++ 1 file changed, 88 insertions(+) create mode 100644 tests

Re: [Piglit] [PATCH v4] travis: add docker based cmake build job

ed job. > > Acked-by: Dylan Baker <dy...@pnwbakers.com> > > Quoting Andres Gomez (2018-01-31 13:11:52) > > Until now we were only running the python unit tests. > > > > It seems desirable to also check that the CMake based build compiles > > successfully.

Re: [Piglit] [PATCH v3] travis: add docker based cmake build job

On Mon, 2018-01-29 at 14:06 -0800, Eric Anholt wrote: > Andres Gomez <ago...@igalia.com> writes: > > > Until now we were only running the python unit tests. > > > > It seems desirable to also check that the CMake based build compiles > > succe

[Piglit] [PATCH v4] travis: add docker based cmake build job

<dy...@pnwbakers.com> Cc: Juan A. Suarez <jasua...@igalia.com> Signed-off-by: Andres Gomez <ago...@igalia.com> Reviewed-by: Juan A. Suarez <jasua...@igalia.com> --- .travis.yml | 47 -- docker/Rockerfile.piglit | 74 +

[Piglit] [PATCH v3] travis: add docker based cmake build job

v2, as suggested by Juan. Cc: Dylan Baker <dy...@pnwbakers.com> Cc: Juan A. Suarez <jasua...@igalia.com> Signed-off-by: Andres Gomez <ago...@igalia.com> Reviewed-by: Juan A. Suarez <jasua...@igalia.com> --- .travis.yml | 47 +

[Piglit] [PATCH] tests: update documentation to include GL46 in khr_gl.py

Cc: Kenneth Graunke <kenn...@whitecape.org> Cc: Dylan Baker <dy...@pnwbakers.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/khr_gl.py | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/khr_gl.py b/tests/khr_gl.py index 6a4e845c4

[Piglit] [PATCH v2] travis: add docker based cmake build job

the changes for extra details regarding these variables. v2: Removed other build possibilities other than just from inside Travis-CI, as suggested by Juan. Cc: Dylan Baker <dy...@pnwbakers.com> Cc: Juan A. Suarez <jasua...@igalia.com> Signed-off-by: Andres Gomez <ago...@igalia.com>

[Piglit] [PATCH] travis: add docker based cmake build job

the changes for extra details regarding these variables. Cc: Dylan Baker <dy...@pnwbakers.com> Cc: Juan A. Suarez Romero <jasua...@igalia.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- We choose to do this task using docker instead of directly in the Travis CI VM because of vario

Re: [Piglit] [PATCH] arb_internalformat_query2: correct tessellation typo

On Tue, 2017-12-19 at 08:52 +0100, Alejandro Piñeiro wrote: > Reviewed-by: Alejandro Piñeiro > > PS: in fact I have that fix as part of one of my patches, but I have > pending to answer one Ilia question (need some investigation). In any > case, I think that we can fix the

Re: [Piglit] [PATCH] arb_shader_image_load_store: correct tessellation typo

On Mon, 2017-12-18 at 09:47 -0800, Francisco Jerez wrote: > Andres Gomez <ago...@igalia.com> writes: > > > Cc: Francisco Jerez <curroje...@riseup.net> > > Signed-off-by: Andres Gomez <ago...@igalia.com> > > --- > > tests/spec/arb_shader_image

[Piglit] [PATCH] arb_internalformat_query2: correct tessellation typo

Cc: Alejandro Piñeiro <apinhe...@igalia.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/spec/arb_internalformat_query2/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/arb_internalformat_query2/common.c b/tests/spec/arb_internalf

[Piglit] [PATCH] arb_shader_image_load_store: correct tessellation typo

Cc: Francisco Jerez <curroje...@riseup.net> Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/spec/arb_shader_image_load_store/grid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/arb_shader_image_load_store/grid.c b/tests/spec/arb_shader_imag

[Piglit] [PATCH 3/3] travis: add generator unittests

Cc: Dylan Baker <dylanx.c.ba...@intel.com> Cc: Juan A. Suarez Romero <jasua...@igalia.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- .travis.yml | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.travis.yml b/.travis.yml index 1d6c954f5

[Piglit] [PATCH 2/3] unittests: update python generator

Cc: Dylan Baker <dylanx.c.ba...@intel.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- unittests/generators/test_generators.py | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/unittests/generators/test_generators.py b/unittests/generators/test_generat

[Piglit] [PATCH 1/3] unittests: correct tessellation typo

Cc: Dylan Baker <dylanx.c.ba...@intel.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- unittests/generators/test_glsl.py | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/unittests/generators/test_glsl.py b/unittests/generators/test_g

[Piglit] [PATCH 0/3] Enable generator unittests

This is a small series which correct some small mistakes, update the unit test for the generator and enables it in Travis CI. Andres Gomez (3): unittests: correct tessellation typo unittests: update python generator travis: add generator unittests .travis.yml

Re: [Piglit] [PATCH] tox: stick to pytest 3.2.5

This is: Reviewed-by: Andres Gomez <ago...@igalia.com> On Mon, 2017-12-18 at 13:45 +0100, Juan A. Suarez Romero wrote: > Newer pytest versions (>=3.3.) require new versions of PythonSix > (>=1.10.0). > > We want to keep the current PythonSix version required by piglit.

Re: [Piglit] [PATCH 2/2] tox: pytest requires python != 3.3

The message should state why we do this. The reason is that python3.3 is not supported any more by the installed 3.3.1 version of pytest, since we don't force a maximum version any more after 2b0a9cc7a. On Fri, 2017-12-15 at 11:57 +0100, Juan A. Suarez Romero wrote: > Let's remove python3.3

Re: [Piglit] [PATCH 1/2] tox: use six >= 1.10.0

On Fri, 2017-12-15 at 11:57 +0100, Juan A. Suarez Romero wrote: > --- > tox.ini | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tox.ini b/tox.ini > index c1b7a0104..2bd99f544 100644 > --- a/tox.ini > +++ b/tox.ini > @@ -27,7 +27,7 @@ deps = > pytest-warnings >

[Piglit] [PATCH] unittests: test WflInfo in its own module and correct depending ones

Fixes: edc41a1db ("framework: move WflInfo class into new wflinfo.py module") Cc: Brian Paul <bri...@vmware.com> Cc: Dylan Baker <dylanx.c.ba...@intel.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- unittests/framework/test/test_glsl_parser_test.py | 2

[Piglit] [PATCH] unittests: include new elapsed time from the console summary output

Fixes: e76ecd048 ("framework: also print elapsed time with piglit-summary.py") Cc: Brian Paul <bri...@vmware.com> Cc: Dylan Baker <dylanx.c.ba...@intel.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- unittests/framework/summary/test_console.py | 14 +

[Piglit] [PATCH 1/2] Revert "tests: Update integration for khronos CTS runner."

This reverts commit 1f93e29d853c0dc9ee1a22bb7e6366b6eb8d5ac7. This broke backwards compatibility with already released API-specific test sets. Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/cts_gl.py | 20 ++-- tests/cts_gl45.py | 2 +- 2 files chang

[Piglit] [PATCH 0/2] Rewind the changes to the Khronos GL CTS profiles

-specific release, as explained at: https://github.com/KhronosGroup/VK-GL-CTS/wiki/Contributing#branches Now, we revert the changes and provide 2 new profiles to use with the renamed tests. Andres Gomez (2): Revert "tests: Update integration for khronos CTS runner." tests: Added a cou

[Piglit] [PATCH] tests: Update integration for khronos CTS runner.

After: https://github.com/KhronosGroup/VK-GL-CTS/commit/af8c22a343ee2c230488f6de71b36dc3070b2024 OpenGL GL*-CTS case lists have been renamed to KHR-GL*. Signed-off-by: Andres Gomez <ago...@igalia.com> --- tests/cts_gl.py | 20 ++-- tests/cts_gl45.py | 2 +- 2 files c

Re: [Piglit] [PATCH] glsl-1.50: instance name is not used to match UBO/SSBOs shader interfaces

On Tue, 2017-03-28 at 08:57 +1100, Timothy Arceri wrote: ... > With the remaining tests reworded in a similar way this patch is: > > Acked-by: Timothy Arceri > Thanks a lot for checking this. I've reworded the comments and this patch has already landed. -- Br, Andres

Re: [Piglit] [PATCH 2/2] arb_shader_atomic_counters: check different binding points

On Tue, 2017-03-07 at 13:20 -0800, Francisco Jerez wrote: > Andres Gomez <ago...@igalia.com> writes: > > > This adds a test to check that a link error is expected when > > specifying different binding points among compilation units for atomic > > counters wit

[Piglit] [PATCH] glsl-1.50: instance name is not used to match UBO/SSBOs shader interfaces

xcept the block name is always used in place of the instance name (API accesses are to interfaces, not to shaders)." Signed-off-by: Andres Gomez <ago...@igalia.com> Cc: Timothy Arceri <tarc...@itsqueeze.com> --- ...age-blocks-align-qualifier-mis

[Piglit] [PATCH v2 0/2] check different binding points with UBOs, SSBOs and Opaque-Uniforms

tch series adds tests to check that a link error is expected when specifying different binding points for matching Uniform Blocks, Shader Storage Blocks or Opaque-Uniforms across multiple compilation units. Andres Gomez (2): arb_shading_language_420pack: check different binding points arb_shader_at

[Piglit] [PATCH 2/2] arb_shader_atomic_counters: check different binding points

must be equal for a uniform variable of the same name." v2: Added GL minimum version restriction. Signed-off-by: Andres Gomez <ago...@igalia.com> Cc: Francisco Jerez <curroje...@riseup.net> Cc: Ian Romanick <ian.d.roman...@intel.com> --- .../different-bindings-atom

[Piglit] [PATCH 1/2] arb_shading_language_420pack: check different binding points

ieve that it applies to it too. v2: - Added GL minimum version restrictions. - Corrected GLSL minimum version restrictions. - Corrected the outcome and documentation for the linking failures on UBOs and SSBOs. - Added tests for UBOs and SSBOs without instance names. Si

Re: [Piglit] [PATCH] gles-es-3.10: unsized-array-not-in-last-position

Reviewed-by: Andres Gomez <ago...@igalia.com> On Fri, 2017-02-10 at 14:15 +0100, Jose Maria Casanova Crespo wrote: > From GLSL ES 3.10 spec, section 4.1.9 "Arrays": > > "If an array is declared as the last member of a shader storage block > and the size

[Piglit] [PATCH 2/2] arb_shader_atomic_counters: check different binding points

must be equal for a uniform variable of the same name." Signed-off-by: Andres Gomez <ago...@igalia.com> Cc: Francisco Jerez <curroje...@riseup.net> Cc: Kenneth Graunke <kenn...@whitecape.org> --- .../different-bindings-atomic-counter.shader_test | 50 ++

[Piglit] [PATCH 0/2] check different binding points with UBOs, SSBOs and Opaque-Uniforms

of Opaque-Uniforms, a link error is expected. Andres Gomez (2): arb_shading_language_420pack: check different binding points arb_shader_atomic_counters: check different binding points .../different-bindings-atomic-counter.shader_test | 50 ++ .../linker/differen

[Piglit] [PATCH 1/2] arb_shading_language_420pack: check different binding points

shown in the examples below." Although this restriction is not included in the ARB_shading_language_420pack spec, it is reasonable to believe that it applies to it too. Signed-off-by: Andres Gomez <ago...@igalia.com> Cc: Matt Turner <matts...@gmail.com> Cc: Kenneth Graunke

Re: [Piglit] [PATCH] tests/quick.py: reduce the number of vs_in tests in quick.py

uld be a better idea, dunno. From my side, this is: Reviewed-by: Andres Gomez <ago...@igalia.com> > > Dylan > > Quoting Dylan Baker (2016-10-31 14:40:35) > > There are 18000 of these tests, quick.py has 53000 tests, which is 34% > > of the total tests. That's just too

Re: [Piglit] [PATCH] dir-locals.el: Adds whitespace support

eview. I hope the changelog is explanatory enough ☺ > > -ilia > > On Sat, Oct 22, 2016 at 5:19 PM, Andres Gomez <ago...@igalia.com> wrote: > > Provides support for highlighting incorrect indentation. > > > > v2: python-mode inherits from prog-mode >

[Piglit] [PATCH] dir-locals.el: Adds White Space support

effect. v2: python-mode inherits from prog-mode v3: Removed too long lines trail highlighting, as suggested by Ilia Mirkin. Signed-off-by: Andres Gomez <ago...@igalia.com> --- .dir-locals.el | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/.dir-local

Re: [Piglit] [PATCH] dir-locals.el: Adds whitespace support

If nobody says otherwise, I will land this by the beginning of next week. On Sun, 2016-10-23 at 00:19 +0300, Andres Gomez wrote: > Provides support for highlighting incorrect indentation. > > v2: python-mode inherits from prog-mode > v3: Removed too long lines trail highlighting,

[Piglit] [PATCH 5/9] arb_enhanced_layouts: More duplicated layout-qualifier-names tests

input/output layout declarations. Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- ...tion-identifiers-in-single-layout-mismatch.geom | 38 +++ ...le-invocation-identifiers-in-single-layout.geom | 38

[Piglit] [PATCH 4/9] arb_shading_language_420pack: More multiple layout qualifiers in a single declaration tests

If the same layout-qualifier-name occurs in multiple layout qualifiers for the same declaration, the last one overrides the former ones." V2: Removed link check, as suggested by Timothy. Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <a

[Piglit] [PATCH 7/9] arb_shading_language_420pack: Adds multiple layout qualifiers in a single output declaration tests

than one layout qualifier may appear in a single declaration." Signed-off-by: Andres Gomez <ago...@igalia.com> --- ...e-layout-qualifier-in-single-declaration-1.geom | 25 ++ ...e-layout-qualifier-in-single-declaration-2.geom | 25 ++ ...e-

[Piglit] [PATCH 6/9] arb_shading_language_420pack: Adds multiple layout qualifiers in a single input declaration tests

than one layout qualifier may appear in a single declaration." Signed-off-by: Andres Gomez <ago...@igalia.com> --- ...e-layout-qualifier-in-single-declaration-1.geom | 31 ++ ...e-layout-qualifier-in-single-declaration-2.geom | 31 ++ ...e-

[Piglit] [PATCH 9/9] arb_shading_language_420pack: Adds multiple layout qualifiers in a single buffer declaration tests

. From the ARB_shading_language_420pack spec: "More than one layout qualifier may appear in a single declaration." Signed-off-by: Andres Gomez <ago...@igalia.com> --- ...e-layout-qualifier-in-single-declaration-1.vert | 31 ++ ...e-layout-qualifier-in-single-de

[Piglit] [PATCH 8/9] arb_shading_language_420pack: Adds multiple layout qualifiers in a single uniform declaration tests

. From the ARB_shading_language_420pack spec: "More than one layout qualifier may appear in a single declaration." Signed-off-by: Andres Gomez <ago...@igalia.com> --- ...e-layout-qualifier-in-single-declaration-1.vert | 30 ++ ...e-layout-qualifier-in-single-de

[Piglit] [PATCH 1/9] glsl-1.50: Add GS output layout qualifier redeclaration test

t;timothy.arc...@collabora.com> Signed-off-by: Andres Gomez <ago...@igalia.com> --- ...declaration-per-program-max-verts-mismatch.geom | 22 +++ ...-one-out-declaration-per-program-max-verts.geom | 25 +- 2 files changed, 42 insertions(+), 5 deletions(-) cre

[Piglit] [PATCH v2 0/9] More duplicated layout-qualifier-names tests

instead of just 1.40. Old patches 5/7 and 7/7 have been removed, which was testing multiple layout-qualifiers in the same declaration with ARB_enhanced_layouts in addition to ARB_shading_language_420pack. Patches 6/9, 7/9, 8/9 and 9/9 have been added with extra tests. Andres Gomez (9

Re: [Piglit] [PATCH 5/7] arb_enhanced_layouts: Multiple layout qualifiers in a single declaration tests

On Mon, 2016-10-24 at 11:05 +1100, Timothy Arceri wrote: > On Sat, 2016-10-22 at 23:42 +0300, Andres Gomez wrote: > > We already had tests for a repeated layout-qualifier-name in a single > > layout-qualifier. Now, we also add similar tests to check across > > multi

Re: [Piglit] [PATCH 4/7] arb_shading_language_420pack: More multiple layout qualifiers in a single declaration tests

On Mon, 2016-10-24 at 11:44 +1100, Timothy Arceri wrote: > Reviewed-by: Timothy Arceri <timothy.arc...@collabora.com> > > On Sat, 2016-10-22 at 23:42 +0300, Andres Gomez wrote: [snip] > > diff --git a/tests/spec/arb_shading_language_420pack/compiler/layout- > > qua

Re: [Piglit] [PATCH 1/7] glsl-1.50: Add GS output layout qualifier redeclaration test

On Mon, 2016-10-24 at 11:15 +1100, Timothy Arceri wrote: > On Sat, 2016-10-22 at 23:42 +0300, Andres Gomez wrote: > > Section 4.3.8.2 (Output Layout Qualifiers) of the GLSL 1.50 spec > > says: > > > > "All geometry shader output layout declaratio

Re: [Piglit] [PATCH 0/7] More duplicated layout-qualifier-names tests

On Mon, 2016-10-24 at 11:58 +1100, Timothy Arceri wrote: > On Sat, 2016-10-22 at 23:42 +0300, Andres Gomez wrote: > > ARB_shading_language_420pack > > > You may be interested in finishing off this patch: > > https://patchwork.freedesktop.org/patch/71093/ > > I ne

[Piglit] [PATCH] dir-locals.el: Adds whitespace support

Provides support for highlighting incorrect indentation. v2: python-mode inherits from prog-mode v3: Removed too long lines trail highlighting, as suggested by Ilia Mirkin. Signed-off-by: Andres Gomez <ago...@igalia.com> --- .dir-locals.el | 17 + 1 file chang

[Piglit] [PATCH 0/7] More duplicated layout-qualifier-names tests

they can be dropped straight away if I didn't make a proper interpretation. Andres Gomez (7): glsl-1.50: Add GS output layout qualifier redeclaration test arb_tessellation_shader: Add tests for TCS output size redeclaration arb_enhanced_layouts: Add more xfb_stride redeclaration tests

[Piglit] [PATCH 1/7] glsl-1.50: Add GS output layout qualifier redeclaration test

Section 4.3.8.2 (Output Layout Qualifiers) of the GLSL 1.50 spec says: "All geometry shader output layout declarations in a program must declare the same layout and same value for max_vertices." Signed-off-by: Andres Gomez <ago...@igalia.com> --- ...ut-declaration-cons

[Piglit] [PATCH 2/7] arb_tessellation_shader: Add tests for TCS output size redeclaration

From the ARB_tessellation_shader spec: "All tessellation control shader layout declarations in a program must specify the same output patch vertex count." Signed-off-by: Andres Gomez <ago...@igalia.com> --- ...e-qualifier-declarations-vertices-mi

[Piglit] [PATCH 7/7] arb_enhanced_layouts: More multiple layout qualifiers in a single declaration tests

r may appear in a single declaration. Additionally, the same layout-qualifier-name can occur multiple times within a layout qualifier or across multiple layout qualifiers in the same declaration" Signed-off-by: Andres Gomez <ago...@igalia.com> --- ...identifiers-in-sing

[Piglit] [PATCH 6/7] arb_enhanced_layouts: More duplicated layout-qualifier-names tests

This is also true for overriding layout-qualifier-names, where one overrides the other (e.g., row_major vs. column_major); only the last occurrence has any effect." Signed-off-by: Andres Gomez <ago...@igalia.com> --- ...tion-identifiers-in-single-layout-mismatch.geom | 38 +

[Piglit] [PATCH 5/7] arb_enhanced_layouts: Multiple layout qualifiers in a single declaration tests

ation. Additionally, the same layout-qualifier-name can occur multiple times within a layout qualifier or across multiple layout qualifiers in the same declaration" Signed-off-by: Andres Gomez <ago...@igalia.com> --- ...-in-single-declaration-no-enhanced-l

[Piglit] [PATCH 3/7] arb_enhanced_layouts: Add more xfb_stride redeclaration tests

From the GL_ARB_enhanced_layouts spec: "While *xfb_stride* can be declared multiple times for the same buffer, it is a compile-time or link-time error to have different values specified for the stride for the same buffer." Signed-off-by: Andres Gomez <ago.

Re: [Piglit] [PATCH] dir-locals.el: whitespace support

If nobody says otherwise, I will land this by the beginning of next week. On Tue, 2016-08-02 at 19:53 +0300, Andres Gomez wrote: > Highlight bogus indentation and long lines. > > v2: python-mode inherits from prog-mode > > Signed-off-by: Andres Gomez <ago...@igalia.com> &g

Re: [Piglit] [PATCH 1/2] glslparsertest: Added some few more struct construction tests

On Tue, 2016-08-09 at 13:14 +1000, Timothy Arceri wrote: > On Fri, 2016-08-05 at 17:43 +0300, Andres Gomez wrote: > > This set focus on checking invalid structs construction. > > Specifically, > > adds a test to check that only implicit conversions are perform and &

Re: [Piglit] [PATCH 2/2] arb_shading_language_420pack: Added some few more struct initializing tests

On Tue, 2016-08-09 at 13:18 +1000, Timothy Arceri wrote: > On Fri, 2016-08-05 at 17:43 +0300, Andres Gomez wrote: > > This set focus on checking invalid structs > > initializations. Specifically, adds a test to check that only > > implicit > > conversions are per

[Piglit] [PATCH 2/2] arb_shading_language_420pack: Added some few more struct initializing tests

This set focus on checking invalid structs initializations. Specifically, adds a test to check that only implicit conversions are perform and vector conversions of the type vec3 to vec2 through dropping the z component are not allowed. --- ...e-initializer-struct-wrong-bool-type-struct.frag | 20

[Piglit] [PATCH 1/2] glslparsertest: Added some few more struct construction tests

This set focus on checking invalid structs construction. Specifically, adds a test to check that only implicit conversions are perform and vector conversions of the type vec3 to vec2 through dropping the z component are not allowed. --- tests/glslparsertest/glsl2/constructor-29.vert | 13

[Piglit] [PATCH 0/2] Added some few more struct construction tests

landed in mesa: https://lists.freedesktop.org/archives/mesa-dev/2016-July/124852.html Andres Gomez (2): glslparsertest: Added some few more struct construction tests arb_shading_language_420pack: Added some few more struct initializing tests tests/glslparsertest/glsl2/constructor-29.vert

[Piglit] [PATCH] dir-locals.el: whitespace support

Highlight bogus indentation and long lines. v2: python-mode inherits from prog-mode Signed-off-by: Andres Gomez <ago...@igalia.com> --- .dir-locals.el | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/.dir-locals.el b/.dir-locals.el index 3bdca17..5

Re: [Piglit] [PATCH] generators/gen_vs_in_fp64: Different VBO values per vertex

at 14:40 +0300, Andres Gomez wrote: > Before, in every drawing we were having the same VBO values per vertex > to be compared against the values in the uniforms. Now, we also have > different values per vertex so we can be sure that it is truly its own > data. > > Signed-off-by:

Re: [Piglit] [PATCH] arb_texture_barrier: count of elements need to be multiple of three

Makes sense. Reviewed-by: Andres Gomez <ago...@igalia.com> On Fri, 2016-07-08 at 21:15 +0200, Alejandro Piñeiro wrote: > glDrawRangeElements is used to draw triangles so the count of elements > needs to be a multiple of three, so we need to be careful when > dividing by the numbe

  1   2   >