[Piglit] [PATCH v2 2/2] generated_tests: Fix require_extensions for constant_array_size

The extension requires a GL_ prefix, which the template didn't have. v2: - Actually fix things Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- generated_tests/gen_constant_array_size_tests.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/generated

[Piglit] [PATCH v2 1/2] generated_tests: fix tessellation -> tesselation typo

This typo causes some tests to be skipped that shouldn't. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- generated_tests/modules/glsl.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/generated_tests/modules/glsl.py b/generated_tests/modules/g

[Piglit] [PATCH 1/2] generated_tests: fix tessellation -> tesselation typo

This typo causes some tests to be skipped that shouldn't. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- generated_tests/modules/glsl.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/generated_tests/modules/glsl.py b/generated_tests/modules/g

[Piglit] [PATCH 2/2] generated_tests: Fix require_extensions for constant_array_size

The extension requires a GL_ prefix, which the template didn't have. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> cc: Jason Ekstrand <ja...@jlekstrand.net> --- generated_tests/gen_constant_array_size_tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Piglit] [PATCH v2 2/2] framework/backends/json.py: preserve 'tests' order

Thanks for making those changes for me. I still have one tiny nit. Otherwise both patches are: Reviewed-by: Dylan Baker <dy...@pnwbakers.com> I think I've asked before, but do you have commit access, or would you like me to commit? If you need me to push for you I'll fix my nit before

Re: [Piglit] [PATCH 1/2] framework/results.py: Copy 'tests' internally to OrderedDict

Quoting Dylan Baker (2017-02-09 08:34:47) > First, thanks for doing this it's a nice improvement. > > I have a few comments below, and a few on the next patch as well. > > Quoting Tomi Sarvela (2017-02-09 03:07:04) > > To preserve the original test running order, use Ordered

Re: [Piglit] [PATCH 0/2] Preserve the testrun test order

One more minor thing I noticed, you probably should change the name of the author in git from "Fi Jenkins" to your actual name :) Dylan Quoting Tomi Sarvela (2017-02-09 03:07:03) > One test can mess with the state of the machine and cause > later tests to fail. Because of this, the testing order

Re: [Piglit] [PATCH 2/2] framework/backends/json.py: preserve 'tests' order

Quoting Tomi Sarvela (2017-02-09 03:07:05) > New helper function numericlistdir() arranges the os.listdir() > in numerical order and deduplicates the code: reading in is done > in two places, finalize and _resume. > > Use OrderedDict when reading data in. > --- > framework/backends/json.py | 42

Re: [Piglit] [PATCH 1/2] framework/results.py: Copy 'tests' internally to OrderedDict

First, thanks for doing this it's a nice improvement. I have a few comments below, and a few on the next patch as well. Quoting Tomi Sarvela (2017-02-09 03:07:04) > To preserve the original test running order, use OrderedDict > when copying 'tests' values over. > --- > framework/results.py | 16

[Piglit] [PATCH] CMake: install .comp files that are not generated

Currently if installing some compute shader test files for shader runner will not be installed (those that are not auto generated). Fortunately it's a rather short list (33 tests as counted by `find tests -name '*.comp' | wc -l`). This patch fixes them to be installed Signed-off-by: Dylan Baker

Re: [Piglit] [PATCH 1/2] framework: handle UnicodeDecodeError

Quoting Marek Olšák (2017-02-06 14:39:03) > On Mon, Feb 6, 2017 at 11:10 PM, Dylan Baker <dy...@pnwbakers.com> wrote: > > I'm curious when you're hitting this because while this works around the > > problem > > it's not really fixing it, and I'd really like to fix

Re: [Piglit] [PATCH 1/2] framework: handle UnicodeDecodeError

I'm curious when you're hitting this because while this works around the problem it's not really fixing it, and I'd really like to fix it correctly. In the meantime I'm okay with this change: Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting Marek Olšák (2017-02-05 11:28:41) > Fr

Re: [Piglit] [PATCH] framework/programs/run.py: Allow comments in test-list files.

Pushed :) Quoting Petri Latvala (2017-02-02 01:24:56) > On 02/01/2017 08:36 PM, Dylan Baker wrote: > > This look good, thanks for making the changes. Do you have push access or > > should > > I push this for you? > > > > Reviewed-by: Dylan Baker <dy...@pnwbake

Re: [Piglit] [PATCH 1/5] Rename gen_conversion_fp64 to gen_conversion

Quoting Nicolai Hähnle (2017-02-02 06:48:39) > On 01.02.2017 19:30, Dylan Baker wrote: > > Can you modify 'unittests/generators/test_generators.py' to know about the > > rename, and run the tests? 'pytest unittest/generators' or "tox -e > > 'py{27,35}-generators'"

Re: [Piglit] [PATCH] framework/programs/run.py: Allow comments in test-list files.

This look good, thanks for making the changes. Do you have push access or should I push this for you? Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting Petri Latvala (2017-02-01 02:57:45) > IGT testing in Intel's CI is using static lists of tests to > run. Commenti

Re: [Piglit] [PATCH 1/5] Rename gen_conversion_fp64 to gen_conversion

Can you modify 'unittests/generators/test_generators.py' to know about the rename, and run the tests? 'pytest unittest/generators' or "tox -e 'py{27,35}-generators'" will run the tests, depending on what you have installed. If that passes, for the series: Acked-by: Dylan

Re: [Piglit] [PATCH 0/5] Add int64 conversion tests

I haven't looked to closely yet, though I'm planning to do so today or tomorrow. I do have one question, does this change the names of the fp64 tests? That would be less than ideal for us because of our CI system. Dylan Quoting Nicolai Hähnle (2017-01-26 10:59:21) > Hi all, > > increase the

Re: [Piglit] [PATCH] framework/backends/json: always flush the metadata to the disk

Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting Martin Peres (2017-01-30 04:26:25) > This guarantees that whatever the state we are in, we can always > continue the piglit run. Do not use FileBackend.__fsync as it would > not do the fsync call in the non-sync mode. > &

Re: [Piglit] [Review Request (master branch)] framework/test/glsl_parser_test.py: fix python script to run glslparsertest on windows

sys is not imported in glsl_parser_test.py, you'll need to do that. Quoting Neha Bhende (2017-01-25 15:19:54) > glslparsertest was not running on windows because python script is looking for > glslparsertest. On windows, piglit creates glslparsertest.exe. With this fix, > all glslparsertest will

Re: [Piglit] [PATCH] resume: use the previously-set test-list when resuming

Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting Martin Peres (2017-01-11 07:45:48) > Previously, the test-list was not saved when running and resuming a run > would ignore the test-list and execute the entire test set. > > This patch tries to follow Dylan's proposal[

Re: [Piglit] [PATCH] deqp: Search stdout and stderr for X connection failure

err_msg = "FATAL ERROR: Failed to open display" > +if x_err_msg in self.result.err or x_err_msg in self.result.out: > +continue > +return > > raise TestRunError('Failed to connect to X server 5 t

Re: [Piglit] [PATCH v5 1/2] Add arb_transform_feedback_overflow_query tests.

No further objections from me on the series. If Ilia has no more objections, for the series: Reviewed-by: Dylan Baker <dy...@pnwbakers.com> signature.asc Description: signature ___ Piglit mailing list Piglit@lists.freedesktop.org

Re: [Piglit] [PATCH v3 2/2] arb_transform_feedback_overflow_query: add error tests.

Quoting Ilia Mirkin (2016-12-15 11:33:59) > On Thu, Dec 15, 2016 at 2:27 PM, Rafael Antognolli > <rafael.antogno...@intel.com> wrote: > > On Thu, Dec 15, 2016 at 10:58:10AM -0800, Dylan Baker wrote: > >> Quoting Rafael Antognolli (2016-12-13 14:51:14) > >> >

Re: [Piglit] [PATCH v3 2/2] arb_transform_feedback_overflow_query: add error tests.

Quoting Rafael Antognolli (2016-12-13 14:51:14) > Add tests to verify that GL_ERROR_VALUE is returned if an invalid > index is used to begin, end or get a current query. > > v2: > - Add test to all.py (Ilia Mirkin) > - Add check for ARB_transform_feedback_overflow_query extension > v3: >

Re: [Piglit] [PATCH v3 1/2] Add arb_transform_feedback_overflow_query tests.

Quoting Rafael Antognolli (2016-12-13 14:51:13) > Add tests that verify that the xfb overflow query correctly detects > overflow on streams 0 and 1. Also add tests that check its interaction > with glBeginConditionalRender, and with ARB_query_buffer_object. > > v2: > - add test to all.py

Re: [Piglit] [PATCH 09/10] Require python 2.7

This should not be necessary, the Python_ADITIONAL_VERSIONS like right above this sets the valid versions to 3.5, 3.4, 3.3, and 2.7 in that order. It should only fail if you have none of those versions installed. Dylan On Tue, Dec 6, 2016, at 11:03, Matt Arsenault wrote: > > > On Dec 5, 2016,

Re: [Piglit] [PATCH] Add test-list after resume test

Quoting Rami Ben Hassine (2016-11-18 04:53:41) > Hello all, > > Actually piglit don’t use the test-list option if we reboot (for x resons) > and want to resume a test , note that is not related to suspend test. This is not a good commit message. A commit message should explain the change, and

Re: [Piglit] [PATCH v4 16/27] framework: Pull {include, exclude}_filter out of Options

Quoting Alejandro Piñeiro (2016-11-16 00:17:55) > Hi Dylan, > > On 09/11/16 21:53, Dylan Baker wrote: > > Since these are also just special cases of filters for the standard > > TestProfile filtering mechanism, and they have a lot of unique classes. > > This is

Re: [Piglit] [PATCH v4 16/27] framework: Pull {include, exclude}_filter out of Options

Quoting Alejandro Piñeiro (2016-11-16 00:17:55) > Hi Dylan, > > On 09/11/16 21:53, Dylan Baker wrote: > > Since these are also just special cases of filters for the standard > > TestProfile filtering mechanism, and they have a lot of unique classes. > > This is

Re: [Piglit] [PATCH] framework/profile: don't deepcopy when copying profiles

Quoting Dylan Baker (2016-11-15 13:08:59) > This reduces memory consumption by a lot (about 60% on my system), which > fixes some tests that fail sporadically on low memory systems. > > cc: Mark Janes <mark.a.ja...@intel.com> > Signed-off-by: Dylan Baker <

[Piglit] [PATCH] framework/profile: don't deepcopy when copying profiles

This reduces memory consumption by a lot (about 60% on my system), which fixes some tests that fail sporadically on low memory systems. cc: Mark Janes <mark.a.ja...@intel.com> Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 7 +++ 1 file changed,

Re: [Piglit] [PATCH v2] framework: Add mustpass option for the Vulkan CTS test runner

Quoting Dylan Baker (2016-11-10 14:15:51) > > Actually, I've got some patches I'm working on that completely rework this > madness (which I forgot about working on other things) and what you have is > easier to work into my series than what I suggested, lol. > > Please jus

Re: [Piglit] [PATCH v2] framework: Add mustpass option for the Vulkan CTS test runner

Quoting Alejandro Piñeiro (2016-11-10 12:08:23) > On 10/11/16 19:05, Dylan Baker wrote: > > Quoting Alejandro Piñeiro (2016-11-10 07:01:03) > >> This option was added mostly to being able to run the mustpass > >> case list included on Vulkan CTS repository. As that fil

Re: [Piglit] [PATCH v2] framework: Add mustpass option for the Vulkan CTS test runner

Quoting Alejandro Piñeiro (2016-11-10 12:08:23) > On 10/11/16 19:05, Dylan Baker wrote: > > Quoting Alejandro Piñeiro (2016-11-10 07:01:03) > >> This option was added mostly to being able to run the mustpass > >> case list included on Vulkan CTS repository. As that fil

Re: [Piglit] [PATCH v2] framework: Add mustpass option for the Vulkan CTS test runner

Quoting Alejandro Piñeiro (2016-11-10 07:01:03) > This option was added mostly to being able to run the mustpass > case list included on Vulkan CTS repository. As that file is in > txt format, we assume that the case list will be in txt format. > > That is not the case for the other deqp-xxx

Re: [Piglit] [PATCH 1/2] framework: fix typos on deqp-vk entry

This patch is: Reviewed-by: Dylan Baker <dy...@pnwbakers.com> Quoting Alejandro Piñeiro (2016-11-10 05:41:31) > --- > > Those are really trivial, I put them on a different patch to make easier the > review. But I think that when pushing, it would be better to squash it wit

Re: [Piglit] [PATCH] tests/quick.py: reduce the number of vs_in tests in quick.py

Quoting Andres Gomez (2016-11-10 01:06:57) > On Wed, 2016-11-09 at 14:56 -0800, Dylan Baker wrote: > > Bump. > > > > Anyone interested in this? > > > > > > As commented, although this is not a definitive solution I suppose this > can help in the mea

Re: [Piglit] [PATCH] tests/quick.py: reduce the number of vs_in tests in quick.py

Bump. Anyone interested in this? Dylan Quoting Dylan Baker (2016-10-31 14:40:35) > There are 18000 of these tests, quick.py has 53000 tests, which is 34% > of the total tests. That's just too many for quick.py. > > This patch takes the somewhat naive approach of just filt

[Piglit] [PATCH v4 24/27] framework/profile: Move group_manager from TestProfile to TestDict

This move is going to allow us to supplement the TestDict with a different class that can be used instead that loads xml. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py| 104 ++ tests/all.py

[Piglit] [PATCH v4 21/27] framework/profile: Split try/except block

This will avoid catching AttributeErrors when importing, and only catch them if mod.profile doesn't exist. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/framework/profil

[Piglit] [PATCH v4 3/27] framework/profile: make run hooks public

These are used in a couple of places, and since they're meant to be changed by subclasses they need to be public. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 28 tests/igt.py | 3 ++- tests/xts.py | 8 -

[Piglit] [PATCH v4 26/27] framework/test/glsl_parser_test.py: split the parser out of the class

This pulls the code for parsing the test file out of GLSLParserTest and puts them in a new Parser class. This is going be useful later for allowing the parsing to be done during the compile stage, and not require searching the file system at runtime. Signed-off-by: Dylan Baker <dylanx.c

[Piglit] [PATCH v4 27/27] tests/all.py: Make add_fbo_depthstencil_tests take an adder

be initialized outside of a TestProfile instance. Which, coincidently is something that the series to serialize the TestDict does. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- tests/all.py | 95 + 1 file changed, 39 insertions(

[Piglit] [PATCH v4 25/27] framework/test/base: Remove timeout parameter

This doesn't work and never has, setting it would cause an exception, and I'm not exactly sure how to fix it. It's also unused, so we can bring it back later if we need it. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/test/base.py | 5 + 1 file changed, 1 ins

[Piglit] [PATCH v4 22/27] framework/profile: replace Testprofile.{dmesg, monitoring} with dict

This allows a significant amount of cleanup to happen. It allows removing attributes from the global OPTIONS, removing tests that no longer apply, and because of the split run method it allows more values to simply be passed. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- fra

[Piglit] [PATCH v4 8/27] framework/profile: add a copy method to profile

py profile in incompatible ways. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 16 +- framework/programs/print_commands.py | 2 +- unittests/framework/test_profile.py | 52 +- 3 files changed, 69 insertion

[Piglit] [PATCH v4 12/27] framework/programs/run: remove redundant list() around comprehension

This is a list comprehension, it already results in a list. There is no need to wrap it in the list() constructor call. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/programs/run.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/pr

[Piglit] [PATCH v4 9/27] tests: Copy profiles to allow them to be run in parallel

Some of these would be rather silly to run in parallel (xts and xts-render, for example), but this will help avoid copy and pasting things leading to the propagation of bad code. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- tests/cpu.py| 4 +++- tests/glslparser.

[Piglit] [PATCH v4 23/27] framework/profile: remove unused argument from TestProfile.group_manager

Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/profile.py b/framework/profile.py index 1bde8fb..7e09081 100644 --- a/framework/profile.py +++ b/framework/profile.py @@ -217,7

[Piglit] [PATCH v4 14/27] framework/programs/run: import framework.profile as profile

Since there isn't a conflict in the name anymore, this just makes the code cleaner and easier to read. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/programs/run.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/framework/programs/

[Piglit] [PATCH v4 7/27] framework/programs/run: Remove use of TestrunResult

-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/programs/run.py | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/framework/programs/run.py b/framework/programs/run.py index 880d748..b92de99 100644 --- a/framework/programs/run.py +++ b/fra

[Piglit] [PATCH v4 19/27] framework/profile: Update __all__

Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 2 ++ 1 file changed, 2 insertions(+), 0 deletions(-) diff --git a/framework/profile.py b/framework/profile.py index 9f72718..5f4657a 100644 --- a/framework/profile.py +++ b/framework/profile.py @@ -49,8

[Piglit] [PATCH v4 11/27] framework/profile: Don't merge profiles

-concurrent options tests will run in a sort of zipper pattern: , , , etc. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py| 98 -- framework/programs/run.py | 33 --- framework/summary/feat

[Piglit] [PATCH v4 20/27] framework/profile: Update docstrings

Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 101 1 file changed, 48 insertions(+), 53 deletions(-) diff --git a/framework/profile.py b/framework/profile.py index 5f4657a..042cf98 100644 --- a/framework/prof

[Piglit] [PATCH v4 10/27] framework/programs/run: Only allow --test-list if one profile

This limitation has basically always existed, but for the next patch to function this is a requirement. This limitation will be properly fixed in a follow up series (that was originally part of this series, but the size and scope of the series got too big so this was split.) Signed-off-by: Dylan

[Piglit] [PATCH v4 18/27] framework/profile: Don't alter the TestProfile before running

the memory usage, and reduces surprise. It would be nice if there wasn't a need to create a concrete test list, but there wouldn't be any way to get the number of tests otherwise. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py

[Piglit] [PATCH v4 4/27] framework/profile: Drop unneeded except

A try/finally works better here anyway. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/framework/profile.py b/framework/profile.py index 0d2e1cf..f63180a 100644 --- a/framework/prof

[Piglit] [PATCH v4 1/27] framework/result: TestrunResult.options should be a dict

This changes the default type from None to a dict, which is what it is when setup in framework/programs/run. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/results.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/results.py b/fra

[Piglit] [PATCH v4 16/27] framework: Pull {include, exclude}_filter out of Options

Since these are also just special cases of filters for the standard TestProfile filtering mechanism, and they have a lot of unique classes. This is just a waste, the same can be achieved with a much simpler class structure. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- fra

[Piglit] [PATCH v4 17/27] framework/profile: Factor out check_all closure

This does away with the check_all closure, by simplifying it down to an equivalent lambda expression. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/framework/profil

[Piglit] [PATCH v4 5/27] framework: Split the run method out of profile.

There are a couple of reasons for doing this. First, profile is a big complex mess that does entirely too much, and this helps with that. Second, there are bugs in the way two profiles run at the same time work, and this is going to fix that. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.

[Piglit] [PATCH v4 6/27] framework: remove concurrent from OPTIONS, pass directly to profile

This removes a value out of the global OPTIONS, which is nice. It's very trivial to pass this instead of putting it in options. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/options.py | 2 -- framework/profile.py | 8 +--- framework/programs/run.p

[Piglit] [PATCH v4 13/27] framework/profile: Drop TestProfile.filter_tests

This was just a thin wrapper around the already public TestProfile.filters list. It seems silly to have such a method when it does nothing but call self.filters.append. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 16 +++- tests/all.py

[Piglit] [PATCH v4 15/27] framework: Remove exclude_tests from options.OPTIONS

Rather than putting this in a global variable, just add a filter for this in the runner. Far simpler, and removes more globals. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/options.py| 1 - framework/profile.py| 1 - framework/pr

[Piglit] [PATCH v4 2/27] unittests: Add tests for the feature completeness summary

This adds a few simple tests for the feature completeness summary object. Nothing to strenuous but much better than nothing. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- unittests/framework/summary/test_feature.py | 116 +- 1 file changed, 116 insertions

[Piglit] [PATCH v4 0/27] Various cleanups for profiles

for monitoring errors in profile.run Dylan Baker (27): framework/result: TestrunResult.options should be a dict unittests: Add tests for the feature completeness summary framework/profile: make run hooks public framework/profile: Drop unneeded except framework: Split the run method out of profile

Re: [Piglit] [PATCH 2/2] generated_tests: new compiler tests for NV_image_formats

Quoting Dylan Baker (2016-11-09 12:08:34) > Quoting Lionel Landwerlin (2016-11-09 03:39:33) > > This tests that the compiler accepts the new layout formats introduced by > > NV_image_formats and also it's correct interaction with the > > EXT_texture_norm16 specification

Re: [Piglit] [PATCH 2/2] generated_tests: new compiler tests for NV_image_formats

n('declaration-disallow-16bit', """\ > +${header('fail', False)} > + > +layout(rg16i) readonly uniform highp i${image_type} img_rg16i; > +layout(r16i) readonly uniform highp i${image_type} img_r16i; > + > +layout(rg16ui) readonl

[Piglit] [PATCH] framework/test/shader_test: Fix MultiShaderRunner handling of directories

but still enforces a separation between GLES and GL shaders. cc: Marek Olšák <mar...@gmail.com> Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/test/shader_test.py | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/framework/test/shad

Re: [Piglit] Piglit is broken

Quoting Marek Olšák (2016-11-08 11:26:04) > Hi, > > Piglit has started failing at startup. Not sure why. I'm not able to > find a good commit. > > Command: > PIGLIT_NO_FAST_SKIP=1 \ > ./piglit run --process-isolation 0 -p gbm quick > > Traceback (most recent call last): > File "./piglit",

Re: [Piglit] [PATCH] shader_runner: Check sscanf return value.

Quoting Vinson Lee (2016-11-07 14:34:23) > On Mon, Nov 7, 2016 at 2:29 PM, Dylan Baker <dy...@pnwbakers.com> wrote: > > Quoting Vinson Lee (2016-11-07 14:03:41) > >> On Mon, Nov 7, 2016 at 10:03 AM, Dylan Baker <dy...@pnwbakers.com> wrote: > >> &g

Re: [Piglit] [PATCH] shader_runner: Check sscanf return value.

Quoting Vinson Lee (2016-11-07 14:03:41) > On Mon, Nov 7, 2016 at 10:03 AM, Dylan Baker <dy...@pnwbakers.com> wrote: > > Quoting Vinson Lee (2016-11-04 16:30:39) > >> Fix Coverity unchecked return value defect. > >> > >> CID: 1373655 > >&

Re: [Piglit] [PATCH] shader_runner: Check sscanf return value.

Quoting Vinson Lee (2016-11-04 16:30:39) > Fix Coverity unchecked return value defect. > > CID: 1373655 > Signed-off-by: Vinson Lee > --- > tests/shaders/shader_runner.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git

Re: [Piglit] [PATCH 2/2] framework: Provide more helpful error message when loading results fails

Quoting Brian Paul (2016-11-04 16:02:38) > On 11/04/2016 02:49 PM, Dylan Baker wrote: > > Quoting Brian Paul (2016-11-04 13:18:21) > >> On 11/04/2016 01:49 PM, Dylan Baker wrote: > > [snip] > >> > >> This works, but > >> 1. seems like a lot of

Re: [Piglit] [PATCH 2/2] framework: Provide more helpful error message when loading results fails

Quoting Brian Paul (2016-11-04 13:18:21) > On 11/04/2016 01:49 PM, Dylan Baker wrote: [snip] > > This works, but > 1. seems like a lot of duplicated code. > 2. How about a simpler error message like: "Unable to open '%s'" But that's not the problem. The f

[Piglit] [PATCH 2/2] framework: Provide more helpful error message when loading results fails

to load a result format piglit doesn't understand. With that in mind this patch catches that exception in every case and raises a PiglitFatalError, appending a message that this is probably a typo or that you've pointed at the wrong directory. cc: Brian Paul <bri...@vmware.com> Signed-off-by:

[Piglit] [PATCH 1/2] framework/backends: Make BackendError a PiglitInternalError

Just a bit of house keeping. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/backends/__init__.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/framework/backends/__init__.py b/framework/backends/__init__.py index 488ad55..ce9f1db

[Piglit] [PATCH] framework/backends/json: Handle updating results without pid field

If it's not present make it an empty list. cc: Brian Paul <bri...@vmware.com> Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/backends/json.py | 5 - unittests/framework/backends/test_json_update.py | 24 2 files

Re: [Piglit] [PATCH] tests/quick.py: reduce the number of vs_in tests in quick.py

Quoting Eric Anholt (2016-11-01 10:32:23) > Dylan Baker <dy...@pnwbakers.com> writes: > > > There are 18000 of these tests, quick.py has 53000 tests, which is 34% > > of the total tests. That's just too many for quick.py. > > > > This patch takes the somewhat

[Piglit] [PATCH 8/9] tests: Add support for deqp_gles* for process isolation

These profiles don't actually support running without process isolation, but with this patch the provide a nice message about why they don't when one selects it. The reason is that they actually run slower with process isolation than without. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.

[Piglit] [PATCH 3/9] framework: Add an initial implementaiton of a DEQPGroupTest

eqp suites to change their parent class. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/test/deqp.py| 238 +++ tests/cts_gl.py | 2 +- tests/cts_gles.py | 2 +- tests/deqp_egl.py

[Piglit] [PATCH 5/9] tests/deqp_vk: add support for running without process isolation

This hooks up the boilerplate in deqp_vk to run without process isolation. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- tests/deqp_vk.py | 36 +++- 1 file changed, 27 insertions(+), 9 deletions(-) diff --git a/tests/deqp_vk.py b/tests/deqp

[Piglit] [PATCH 7/9] tests/cts_gles: Add support for running without process isolation

Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- tests/cts_gles.py | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/tests/cts_gles.py b/tests/cts_gles.py index a6a7ec8..7c2dc21 100644 --- a/tests/cts_gles.py +++ b/tests/cts_gles.py @@

[Piglit] [PATCH 6/9] tests/cts_gl: Add support for running without process isolation

Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- tests/cts_gl.py | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/tests/cts_gl.py b/tests/cts_gl.py index 5b03e4a..b3c0782 100644 --- a/tests/cts_gl.py +++ b/tests/cts_gl.py @@ -1,

[Piglit] [PATCH 9/9] tests/deqp_egl: add support for running without process isolation.

I can't actually test this patch, the egl tests from deqp are broken and all of them fail, I'm going to take a guess that they are like the deqp_gles* tests and don't benefit from removing process isolation, but that's just a guess. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> ---

[Piglit] [PATCH 4/9] framework: Implement boilerplate for removing process isolation

This patches adds all of the boilerplate code that is required to get group-at-a-time working. It adds the command line option, and all of the switches to choose between creating a profile full of single tests, or tests that run group at a time. Signed-off-by: Dylan Baker <dylanx.c

[Piglit] [PATCH 1/9] framework/test/deqp: Fix pylint warnings.

Mostly this is adding docstrings. There is also a value that is flagged as an error, but isn't, it's a bug in pylint. And there is one TODO that has never been hit, so I don't think we really need it. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/test/deqp.p

[Piglit] [PATCH 2/9] unittests: mark deqp_egl integration test as xfail

The dEQP suite itself (not through piglit) is broken upstream. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- unittests/suites/test_integration.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/unittests/suites/test_integration.py b/unittests/

[Piglit] [PATCH 0/9] Add support to deqp based profiles to remove process isolation

layer. Dylan Baker (9): framework/test/deqp: Fix pylint warnings. unittests: mark deqp_egl integration test as xfail framework: Add an initial implementaiton of a DEQPGroupTest framework: Implement boilerplate for removing process isolation tests/deqp_vk: add support for running without

[Piglit] [PATCH] tests/quick.py: reduce the number of vs_in tests in quick.py

There are 18000 of these tests, quick.py has 53000 tests, which is 34% of the total tests. That's just too many for quick.py. This patch takes the somewhat naive approach of just filtering out 80% of those tests from quick.py, which reduces the total number of tests to 38000, which makes a pretty

[Piglit] [PATCH v3 16/28] framework/profile: Factor out check_all closure

This does away with the check_all closure, by simplifying it down to an equivalent lambda expression. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/framework/profil

[Piglit] [PATCH v3 22/28] framework/profile: remove unused argument from TestProfile.group_manager

Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/profile.py b/framework/profile.py index e0c1f72..8c1fc4a 100644 --- a/framework/profile.py +++ b/framework/profile.py @@ -219,7

[Piglit] [PATCH v3 28/28] tests/xts: Use a tmpdir for output

This removes the need to pass the results directory to each test instance, but still gives the guarantee that each instance will write it's results to a unique location, since that guarantee is made by python's tempfile.mkdtemp. cc: Eric Anholt <e...@anholt.net> Signed-off-by: Dylan

[Piglit] [PATCH v3 24/28] framework/test/base: Remove timeout parameter

This doesn't work and never has, setting it would cause an exception, and I'm not exactly sure how to fix it. It's also unused, so we can bring it back later if we need it. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/test/base.py | 5 + 1 file changed, 1 ins

[Piglit] [PATCH v3 26/28] tests/all.py: Make add_fbo_depthstencil_tests take an adder

Like all of the other helper functions, and will be required by later patches in this series. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- tests/all.py | 95 + 1 file changed, 39 insertions(+), 56 deletions(-) diff --git a

[Piglit] [PATCH v3 18/28] framework/profile: Update __all__

Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 2 ++ 1 file changed, 2 insertions(+), 0 deletions(-) diff --git a/framework/profile.py b/framework/profile.py index 288e598..bd18e5e 100644 --- a/framework/profile.py +++ b/framework/profile.py @@ -54,8

[Piglit] [PATCH v3 23/28] framework/profile: Move group_manager from TestProfile to TestDict

This move is going to allow us to supplement the TestDict with a different class that can be used instead that loads xml. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py| 104 ++ tests/all.py

[Piglit] [PATCH v3 20/28] framework/profile: Split try/except block

This will avoid catching AttributeErrors when importing, and only catch them if mod.profile doesn't exist. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/framework/profil

[Piglit] [PATCH v3 21/28] framework/profile: replace Testprofile.{dmesg, monitoring} with dict

This allows a significant amount of cleanup to happen. It allows removing attributes from the global OPTIONS, removing tests that no longer apply, and because of the split run method it allows more values to simply be passed. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- fra

[Piglit] [PATCH v3 17/28] framework/profile: Don't alter the TestProfile before running

the memory usage, and reduces surprise. It would be nice if there wasn't a need to create a concrete test list, but there wouldn't be any way to get the number of tests otherwise. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py

<    1   2   3   4   5   6   7   8   9   10   >