[Piglit] [PATCH v3 7/28] framework/profile: add a copy method to profile

2016-10-31 Thread Dylan Baker
py profile in incompatible ways. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 16 +- framework/programs/print_commands.py | 2 +- unittests/framework/test_profile.py | 52 +- 3 files changed, 69 insertion

[Piglit] [PATCH v3 6/28] framework/programs/run: Remove use of TestrunResult

2016-10-31 Thread Dylan Baker
-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/programs/run.py | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/framework/programs/run.py b/framework/programs/run.py index 741a492..bf0cebe 100644 --- a/framework/programs/run.py +++ b/fra

[Piglit] [PATCH v3 1/28] framework/profile: make run hooks public

2016-10-31 Thread Dylan Baker
These are used in a couple of places, and since they're meant to be changed by subclasses they need to be public. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 28 tests/igt.py | 3 ++- tests/xts.py | 8 -

[Piglit] [PATCH v3 8/28] tests: Copy profiles to allow them to be run in parallel

2016-10-31 Thread Dylan Baker
Some of these would be rather silly to run in parallel (xts and xts-render, for example), but this will help avoid copy and pasting things leading to the propagation of bad code. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- tests/cpu.py| 4 +++- tests/glslparser.

[Piglit] [PATCH v3 15/28] framework: Pull {include, exclude}_filter out of Options

2016-10-31 Thread Dylan Baker
Since these are also just special cases of filters for the standard TestProfile filtering mechanism, and they have a lot of unique classes. This is just a waste, the same can be achieved with a much simpler class structure. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- fra

[Piglit] [PATCH v3 13/28] framework/programs/run: import framework.profile as profile

2016-10-31 Thread Dylan Baker
Since there isn't a conflict in the name anymore, this just makes the code cleaner and easier to read. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/programs/run.py | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/fra

[Piglit] [PATCH v3 14/28] framework: Remove exclude_tests from options.OPTIONS

2016-10-31 Thread Dylan Baker
Rather than putting this in a global variable, just add a filter for this in the runner. Far simpler, and removes more globals. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/options.py| 1 - framework/profile.py| 1 - framework/pr

[Piglit] [PATCH v3 3/28] framework: Split the run method out of profile.

2016-10-31 Thread Dylan Baker
There are a couple of reasons for doing this. First, profile is a big complex mess that does entirely too much, and this helps with that. Second, there are bugs in the way two profiles run at the same time work, and this is going to fix that. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.

[Piglit] [PATCH v3 4/28] framework: remove concurrent from OPTIONS, pass directly to profile

2016-10-31 Thread Dylan Baker
This removes a value out of the global OPTIONS, which is nice. It's very trivial to pass this instead of putting it in options. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/options.py | 2 -- framework/profile.py | 2 +- framework/programs/run.p

[Piglit] [PATCH v3 2/28] framework/profile: Drop unneeded except

2016-10-31 Thread Dylan Baker
A try/finally works better here anyway. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/framework/profile.py b/framework/profile.py index 0d2e1cf..f63180a 100644 --- a/framework/prof

[Piglit] [PATCH v3 5/28] [RFC] framework: Use an enum for concurrency.

2016-10-31 Thread Dylan Baker
concurrency. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 17 +++-- framework/programs/run.py | 18 +- tox.ini | 1 + 3 files changed, 25 insertions(+), 11 deletions(-) diff --git a/framework/profil

[Piglit] [PATCH v3 10/28] framework/profile: Don't merge profiles

2016-10-31 Thread Dylan Baker
-concurrent options tests will run in a sort of zipper pattern: , , , etc. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py| 97 +++--- framework/programs/run.py | 33 ++ unittests/framework/test_profile.p

[Piglit] [PATCH v3 0/28] Various cleanups for profiles

2016-10-31 Thread Dylan Baker
) removes the need to pass the results directory to its tests. - Fix RegexFilter to work for both the include filter (-t) and the exclude filter (-x), it previously only worked for one or the other. Also add tests. Dylan Baker (28): framework/profile: make run hooks public

[Piglit] [PATCH v2 13/26] framework/programs/run: import framework.profile as profile

2016-10-27 Thread Dylan Baker
Since there isn't a conflict in the name anymore, this just makes the code cleaner and easier to read. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/programs/run.py | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/fra

[Piglit] [PATCH v2 25/26] framework/test/glsl_parser_test.py: split the parser out of the class

2016-10-27 Thread Dylan Baker
This pulls the code for parsing the test file out of GLSLParserTest and puts them in a new Parser class. This is going be useful later for allowing the parsing to be done during the compile stage, and not require searching the file system at runtime. Signed-off-by: Dylan Baker <dylanx.c

[Piglit] [PATCH v2 26/26] tests/all.py: Make add_fbo_depthstencil_tests take an adder

2016-10-27 Thread Dylan Baker
Like all of the other helper functions, and will be required by later patches in this series. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- tests/all.py | 95 + 1 file changed, 39 insertions(+), 56 deletions(-) diff --git a

[Piglit] [PATCH v2 22/26] framework/profile: remove unused argument from TestProfile.group_manager

2016-10-27 Thread Dylan Baker
Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/profile.py b/framework/profile.py index 74ca4ea..f0a728a 100644 --- a/framework/profile.py +++ b/framework/profile.py @@ -212,7

[Piglit] [PATCH v2 20/26] framework/profile: Split try/except block

2016-10-27 Thread Dylan Baker
This will avoid catching AttributeErrors when importing, and only catch them if mod.profile doesn't exist. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/framework/profil

[Piglit] [PATCH v2 17/26] framework/profile: Don't alter the TestProfile before running

2016-10-27 Thread Dylan Baker
the memory usage, and reduces surprise. It would be nice if there wasn't a need to create a concrete test list, but there wouldn't be any way to get the number of tests otherwise. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py

[Piglit] [PATCH v2 15/26] framework: Pull {include, exclude}_filter out of Options

2016-10-27 Thread Dylan Baker
Since these are also just special cases of filters for the standard TestProfile filtering mechanism, and they have a lot of unique classes. This is just a waste, the same can be achieved with a much simpler class structure. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- fra

[Piglit] [PATCH v2 4/26] framework: remove concurrent from OPTIONS, pass directly to profile

2016-10-27 Thread Dylan Baker
This removes a value out of the global OPTIONS, which is nice. It's very trivial to pass this instead of putting it in options. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/options.py | 2 -- framework/profile.py | 2 +- framework/programs/run.p

[Piglit] [PATCH v2 8/26] tests: Copy profiles to allow them to be run in parallel

2016-10-27 Thread Dylan Baker
Some of these would be rather silly to run in parallel (xts and xts-render, for example), but this will help avoid copy and pasting things leading to the propagation of bad code. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- tests/cpu.py| 4 +++- tests/glslparser.

[Piglit] [PATCH v2 9/26] framework/programs/run: Only allow --test-list if one profile

2016-10-27 Thread Dylan Baker
This limitation has basically always existed, but for the next patch to function this is a requirement. This limitation will be properly fixed later in this series. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/programs/run.py | 4 1 file changed, 4 insertions

[Piglit] [PATCH v2 18/26] framework/profile: Update __all__

2016-10-27 Thread Dylan Baker
Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 2 ++ 1 file changed, 2 insertions(+), 0 deletions(-) diff --git a/framework/profile.py b/framework/profile.py index 048fd64..d875f10 100644 --- a/framework/profile.py +++ b/framework/profile.py @@ -54,8

[Piglit] [PATCH v2 11/26] framework/programs/run: remove redundant list() around comprehension

2016-10-27 Thread Dylan Baker
This is a list comprehension, it already results in a list. There is no need to wrap it in the list() constructor call. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/programs/run.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/pr

[Piglit] [PATCH v2 16/26] framework/profile: Factor out check_all closure

2016-10-27 Thread Dylan Baker
This does away with the check_all closure, by simplifying it down to an equivalent lambda expression. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/framework/profil

[Piglit] [PATCH v2 7/26] framework/profile: add a copy method to profile

2016-10-27 Thread Dylan Baker
py profile in incompatible ways. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 16 +- framework/programs/print_commands.py | 2 +- unittests/framework/test_profile.py | 52 +- 3 files changed, 69 insertion

[Piglit] [PATCH v2 21/26] framework/profile: replace Testprofile.{dmesg, monitoring} with dict

2016-10-27 Thread Dylan Baker
This allows a significant amount of cleanup to happen. It allows removing attributes from the global OPTIONS, removing tests that no longer apply, and because of the split run method it allows more values to simply be passed. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- fra

[Piglit] [PATCH v2 14/26] framework: Remove exclude_tests from options.OPTIONS

2016-10-27 Thread Dylan Baker
Rather than putting this in a global variable, just add a filter for this in the runner. Far simpler, and removes more globals. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/options.py| 1 - framework/profile.py| 1 - framework/pr

[Piglit] [PATCH v2 6/26] framework/programs/run: Remove use of TestrunResult

2016-10-27 Thread Dylan Baker
-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/programs/run.py | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/framework/programs/run.py b/framework/programs/run.py index 741a492..bf0cebe 100644 --- a/framework/programs/run.py +++ b/fra

[Piglit] [PATCH v2 5/26] [RFC] framework: Use an enum for concurrency.

2016-10-27 Thread Dylan Baker
concurrency. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 17 +++-- framework/programs/run.py | 18 +- tox.ini | 1 + 3 files changed, 25 insertions(+), 11 deletions(-) diff --git a/framework/profil

[Piglit] [PATCH v2 0/26] Various cleanups for profiles

2016-10-27 Thread Dylan Baker
. It probably makes startup a little faster though I haven't benchmarked to know if it's significant. Dylan Baker (26): framework/profile: drop pre and post run hooks. framework/profile: Drop unneeded except framework: Split the run method out of profile. framework: remove concurrent

[Piglit] [PATCH v2 2/26] framework/profile: Drop unneeded except

2016-10-27 Thread Dylan Baker
A try/finally works better here anyway. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/framework/profile.py b/framework/profile.py index 1edab03..53a17b7 100644 --- a/framework/prof

[Piglit] [PATCH v2 12/26] framework/profile: Drop TestProfile.filter_tests

2016-10-27 Thread Dylan Baker
This was just a thin wrapper around the already public TestProfile.filters list. It seems silly to have such a method when it does nothing but call self.filters.append. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 16 +++- tests/all.py

[Piglit] [PATCH v2 10/26] framework/profile: Don't merge profiles

2016-10-27 Thread Dylan Baker
-concurrent options tests will run in a sort of zipper pattern: , , , etc. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py| 93 +++--- framework/programs/run.py | 33 ++- unittests/framework/test_profile.p

[Piglit] [PATCH v2 3/26] framework: Split the run method out of profile.

2016-10-27 Thread Dylan Baker
There are a couple of reasons for doing this. First, profile is a big complex mess that does entirely too much, and this helps with that. Second, there are bugs in the way two profiles run at the same time work, and this is going to fix that. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.

[Piglit] [PATCH v2 1/26] framework/profile: drop pre and post run hooks.

2016-10-27 Thread Dylan Baker
These were never used for anything, and are just taking up space. They also get in the way of changes that are coming later in this series. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 20 1 file changed, 0 insertions(+), 20 del

Re: [Piglit] [PATCH v2] framework/backends/json: support non-piglit junit files

2016-10-27 Thread Dylan Baker
> +result.command = out[0] > +result.out = '\n'.join(out[1:]) > +else: > +result.out = out_tag.text > > # Try to get the values in stderr for time and pid > for line in result.err.split('\n'): > --

Re: [Piglit] [PATCH] framework/backends/json: support non-piglit junit files

2016-10-26 Thread Dylan Baker
Quoting Mark Janes (2016-10-26 17:04:49) > Dylan Baker <dy...@pnwbakers.com> writes: > > > Quoting Mark Janes (2016-10-26 16:30:12) > >> The junit loader is unnecessarily strict with the input that it > >> accepts. It expects input generated by piglit, but c

Re: [Piglit] [PATCH] framework/backends/json: support non-piglit junit files

2016-10-26 Thread Dylan Baker
Quoting Mark Janes (2016-10-26 16:30:12) > The junit loader is unnecessarily strict with the input that it > accepts. It expects input generated by piglit, but can be made to > handle junit from other test suites like crucible. > --- > framework/backends/junit.py | 28

Re: [Piglit] [PATCH 0/3] Fix summary breakage

2016-10-25 Thread Dylan Baker
Adding Mark signature.asc Description: signature ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

[Piglit] [PATCH 2/3] framework: Properly load JSON into internal representation

2016-10-25 Thread Dylan Baker
Currently piglit doesn't consistently deserialize JSON into it's internal representation, leaving some bits as dictionaries or lists, which breaks the summary code in particular. This patch corrects that. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/programs/

[Piglit] [PATCH 0/3] Fix summary breakage

2016-10-25 Thread Dylan Baker
problems. Dylan Baker (3): piglit: Only catch parsed.func AttributeError framework: Properly load JSON into internal representation framework: fix loading JUnit results framework/backends/junit.py| 6 ++- framework/programs/run.py | 2 +- framework/results.py

[Piglit] [PATCH 3/3] framework: fix loading JUnit results

2016-10-25 Thread Dylan Baker
The JUnit loader was never updated to handle PID's as lists rather than a single int. This patch corrects that and allows JUnit results to be loaded again. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/backends/junit.py| 6 +- unittests/fra

[Piglit] [PATCH 1/3] piglit: Only catch parsed.func AttributeError

2016-10-25 Thread Dylan Baker
Fixes catching AttributeErrors it shouldn't. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- piglit | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/piglit b/piglit index 4ce6c41..6c1d30a 100755 --- a/piglit +++ b/piglit @@ -163,11 +163,11 @@ de

Re: [Piglit] [PATCH v3 3/3] framework/backends/json: Don't convert to TestrunResult while updating

2016-10-25 Thread Dylan Baker
Quoting Michel Dänzer (2016-10-24 23:10:04) > On 13/10/16 05:59 AM, Dylan Baker wrote: > > This changes the way updates are done in the backend, instead of > > converting to a TestrunResult immediately, all of the transformations > > are done to the JSON data in it's rawe

[Piglit] [PATCH 24/27] framework/profile: Move group_manager from TestProfile to TestDict

2016-10-24 Thread Dylan Baker
This move is going to allow us to supplement the TestDict with a different class that can be used instead that loads xml. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py| 104 ++ tests/all.py

[Piglit] [PATCH 15/27] framework: Remove exclude_tests from options.OPTIONS

2016-10-24 Thread Dylan Baker
Rather than putting this in a global variable, just add a filter for this in the runner. Far simpler, and removes more globals. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/options.py| 1 - framework/profile.py| 1 - framework/pr

[Piglit] [PATCH 27/27] tests/all.py: Make add_fbo_depthstencil_tests take an adder

2016-10-24 Thread Dylan Baker
Like all of the other helper functions, and will be required by later patches in this series. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- tests/all.py | 95 + 1 file changed, 39 insertions(+), 56 deletions(-) diff --git a

[Piglit] [PATCH 10/27] framework/programs/run: Only allow --test-list if one profile

2016-10-24 Thread Dylan Baker
This limitation has basically always existed, but for the next patch to function this is a requirement. This limitation will be properly fixed later in this series. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/programs/run.py | 4 1 file changed, 4 insertions

[Piglit] [PATCH 7/27] framework/programs/run: Remove use of TestrunResult

2016-10-24 Thread Dylan Baker
-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/programs/run.py | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/framework/programs/run.py b/framework/programs/run.py index 4c2227f..556878a 100644 --- a/framework/programs/run.py +++ b/fra

[Piglit] [PATCH 21/27] framework/profile: Split try/except block

2016-10-24 Thread Dylan Baker
This will avoid catching AttributeErrors when importing, and only catch them if mod.profile doesn't exist. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/framework/profil

[Piglit] [PATCH 17/27] framework/profile: Factor out check_all closure

2016-10-24 Thread Dylan Baker
This does away with the check_all closure, by simplifying it down to an equivalent lambda expression. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/framework/profil

[Piglit] [PATCH 12/27] framework/profiles/run: remove redundant list() around comprehension

2016-10-24 Thread Dylan Baker
This is a list comprehension, it already results in a list. There is no need to wrap it in the list() constructor call. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/programs/run.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/pr

[Piglit] [PATCH 25/27] framework/test/base: Remove timeout parameter

2016-10-24 Thread Dylan Baker
This doesn't work and never has, setting it would cause an exception, and I'm not exactly sure how to fix it. It's also unused, so we can bring it back later if we need it. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/test/base.py | 5 + 1 file changed, 1 ins

[Piglit] [PATCH 11/27] framework/profile: Don't merge profiles

2016-10-24 Thread Dylan Baker
-concurrent options tests will run in a sort of zipper pattern: , , , etc. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py| 93 +++--- framework/programs/run.py | 33 ++- unittests/framework/test_profile.p

[Piglit] [PATCH 23/27] framework/profile: remove unused argument from TestProfile.group_manager

2016-10-24 Thread Dylan Baker
Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/profile.py b/framework/profile.py index 653dcec..29f71c1 100644 --- a/framework/profile.py +++ b/framework/profile.py @@ -191,7

[Piglit] [PATCH 26/27] framework/test/glsl_parser_test.py: split the parser out of the class

2016-10-24 Thread Dylan Baker
This pulls the code for parsing the test file out of GLSLParserTest and puts them in a new Parser class. This is going be useful later for allowing the parsing to be done during the compile stage, and not require searching the file system at runtime. Signed-off-by: Dylan Baker <dylanx.c

[Piglit] [PATCH 14/27] framework/programs/run: import framework.profile as profile

2016-10-24 Thread Dylan Baker
Since there isn't a conflict in the name anymore, this just makes the code cleaner and easier to read. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/programs/run.py | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/fra

[Piglit] [PATCH 1/27] framework/profile: drop pre and post run hooks.

2016-10-24 Thread Dylan Baker
These were never used for anything, and are just taking up space. They also get in the way of changes that are coming later in this series. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 20 1 file changed, 0 insertions(+), 20 del

[Piglit] [PATCH 3/27] piglit: Only catch parsed.func AttributeError

2016-10-24 Thread Dylan Baker
Fixes catching AttributeErrors it shouldn't. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- piglit | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/piglit b/piglit index 4ce6c41..6c1d30a 100755 --- a/piglit +++ b/piglit @@ -163,11 +163,11 @@ de

[Piglit] [PATCH 9/27] tests: Copy profiles to allow them to be run in parallel

2016-10-24 Thread Dylan Baker
Some of these would be rather silly to run in parallel (xts and xts-render, for example), but this will help avoid copy and pasting things leading to the propagation of bad code. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- tests/cpu.py| 4 +++- tests/glslparser.

[Piglit] [PATCH 4/27] framework: Split the run method out of profile.

2016-10-24 Thread Dylan Baker
There are a couple of reasons for doing this. First, profile is a big complex mess that does entirely too much, and this helps with that. Second, there are bugs in the way two profiles run at the same time work, and this is going to fix that. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.

[Piglit] [PATCH 20/27] framework/profile: Update docstrings

2016-10-24 Thread Dylan Baker
Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 101 1 file changed, 48 insertions(+), 53 deletions(-) diff --git a/framework/profile.py b/framework/profile.py index c118a67..cf8b2dd 100644 --- a/framework/prof

[Piglit] [PATCH 5/27] framework: remove concurrent from OPTIONS, pass directly to profile

2016-10-24 Thread Dylan Baker
This removes a value out of the global OPTIONS, which is nice. It's very trivial to pass this instead of putting it in options. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/options.py | 2 -- framework/profile.py | 2 +- framework/programs/run.p

[Piglit] [PATCH 19/27] framework/profile: Update __all__

2016-10-24 Thread Dylan Baker
Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py | 2 ++ 1 file changed, 2 insertions(+), 0 deletions(-) diff --git a/framework/profile.py b/framework/profile.py index 837498e..c118a67 100644 --- a/framework/profile.py +++ b/framework/profile.py @@ -52,8

[Piglit] [PATCH 18/27] framework/profile: Don't alter the TestProfile before running

2016-10-24 Thread Dylan Baker
the memory usage, and reduces surprise. It would be nice if there wasn't a need to create a concrete test list, but there wouldn't be any way to get the number of tests otherwise. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py

[Piglit] [PATCH 8/27] framework/profile: add a copy method to profile

2016-10-24 Thread Dylan Baker
py profile in incompatible ways. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/profile.py| 16 +- unittests/framework/test_profile.py | 52 ++- 2 files changed, 68 insertions(+), 0 deletions(-) diff --git a/framew

[Piglit] [PATCH] shader_runner: Check return from program_must_be_in_use

2016-10-24 Thread Dylan Baker
Which was changed in b300e1f58 to return a status, instead of exiting on failure, but the calls to the function weren't updated to handle this change. This fixes the remaining uses of program_must_be_in_use not fixed by Brian's patch. cc: Brian Paul <bri...@vmware.com> Signed-off-by: Dylan

Re: [Piglit] [PATCH 1/2] framework: change 'regressions' to mean 'regressions in the last test run'

2016-10-24 Thread Dylan Baker
I agree with Ilia that making regressions and fixes non-symmetric is bad. So at the very least I'd want to see the same change to fixes. The regressions page was designed that someone could run piglit using "git rebase -x" and see what was regressing at each step along the way, and this change

Re: [Piglit] [PATCH] shader_runner: report PIGLIT_FAIL if linking unexpectedly fails

2016-10-19 Thread Dylan Baker
ists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/piglit Reviewed-by: Dylan Baker <dy...@pnwbakers.com> signature.asc Description: signature ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] shader_runner: report PIGLIT_FAIL if linking unexpectedly fails

2016-10-19 Thread Dylan Baker
Quoting Brian Paul (2016-10-18 17:18:36) > On 10/18/2016 05:43 PM, Dylan Baker wrote: > > Quoting Brian Paul (2016-10-18 16:28:53) > >> We were previously reporting 'pass' if linking failed. > >> --- > >> tests/shaders/shader_runner.c | 1 + > >>

Re: [Piglit] [PATCH] shader_runner: report PIGLIT_FAIL if linking unexpectedly fails

2016-10-18 Thread Dylan Baker
Quoting Brian Paul (2016-10-18 16:28:53) > We were previously reporting 'pass' if linking failed. > --- > tests/shaders/shader_runner.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c > index b0bde2c..94865b7 100644 > ---

Re: [Piglit] [PATCH] shader_runner: report PIGLIT_FAIL if linking unexpectedly fails

2016-10-18 Thread Dylan Baker
Quoting Brian Paul (2016-10-18 16:28:53) > We were previously reporting 'pass' if linking failed. > --- > tests/shaders/shader_runner.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c > index b0bde2c..94865b7 100644 > ---

Re: [Piglit] [PATCH] arb_compute_variable_group_size: Fix require section.

2016-10-17 Thread Dylan Baker
Quoting Matt Turner (2016-10-17 13:33:11) > On Mon, Oct 17, 2016 at 12:54 PM, Samuel Pitoiset > wrote: > > > > > > On 10/17/2016 09:45 PM, Samuel Pitoiset wrote: > >> > >> Thanks for fixing this. > >> > >> Reviewed-by: Samuel Pitoiset > > > >

Re: [Piglit] [PATCH] framework/programs/run.py: Allow comments in test-list files.

2016-10-17 Thread Dylan Baker
Quoting Petri Latvala (2016-10-17 02:52:36) > IGT testing in Intel's CI is using a static list of tests to > run. Commenting out tests and annotating them will help > human-readability. > > Signed-off-by: Petri Latvala > --- > > Possible duplicate, I didn't see this

Re: [Piglit] [PATCH] glean: Fix indentation.

2016-10-13 Thread Dylan Baker
andle(NULL), > NULL); > > -if (!hWindow) > -return; > + if (!hWindow) > + return; > > hDC = GetDC(hWindow); > > -- > 2.10.1 > > ___ > Piglit mailing

[Piglit] [PATCH v3 3/3] framework/backends/json: Don't convert to TestrunResult while updating

2016-10-12 Thread Dylan Baker
of issues were being covered by the TestrunResult.to_json() method filling it missing values. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/backends/json.py | 61 + framework/results.py | 19 +++-- uni

[Piglit] [PATCH v3 1/3] framework/backends/json: replace str() with six.text_type()

2016-10-12 Thread Dylan Baker
since str() is incorrect in python2.x. This also fixes an indentation error. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/backends/json.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/backends/json.py b/framework/backends/json.py

[Piglit] [PATCH v3 2/3] framework: Drop support for JSON formats < 7

2016-10-12 Thread Dylan Baker
some of the versions we support since it simplifies the code considerably. This also drops support for the older "main" file, and only supports results.json and results.json. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/backends/json.py

[Piglit] [PATCH v3 0/3] Decouple JSON loading and python classes

2016-10-12 Thread Dylan Baker
er and fix the .to_json and .from_dict methods of various classes to work correctly without the piglit_decoder. Dylan Baker (3): framework/backends/json: replace str() with six.text_type() framework: Drop support for JSON formats < 7 framework/backends/json: Don't convert to Testru

Re: [Piglit] [PATCH] Add profile cts_gl45

2016-10-12 Thread Dylan Baker
> On Tue, Sep 27, 2016 at 7:52 PM, Dylan Baker <dy...@pnwbakers.com> wrote: > > Quoting Marek Olšák (2016-09-27 09:48:53) > >> From: Marek Olšák <marek.ol...@amd.com> > >> > >> Older versions are broken at the moment and I don't find

[Piglit] [PATCH v2 2/3] framework: Drop support for JSON formats < 7

2016-10-11 Thread Dylan Baker
Most of these are pretty old at this point (over a year), and it seems unlikely anyone still has results in those formats. The biggest problem with them is that some of them (especially the early ones) are complex transformations with a lot of validation needed, and some of the middle ones rely on

[Piglit] [PATCH v2 0/3] Decouple JSON loading and python classes

2016-10-11 Thread Dylan Baker
. This is available at my github: https://github.com/dcbaker/piglit wip/detangle-json-load v2: - remove support for '' extension for the JSON backend along with support for "main" files. - Fix result version being set to 9 instead of 8 in tests. Dylan Baker (3): framework/bac

[Piglit] [PATCH 3/3] framework/backends/json: Don't convert to TestrunResult while updating

2016-10-10 Thread Dylan Baker
This changes the way updates are done in the backend, instead of converting to a TestrunResult immediately, all of the transformations are done to the JSON data in it's rawest form, ie, as dicts and lists, and then transform to a TestrunResult (and children) after that. This makes the loading

[Piglit] [PATCH 2/3] framework: Drop support for JSON formats < 7

2016-10-10 Thread Dylan Baker
Most of these are pretty old at this point (over a year), and it seems unlikely anyone still has results in those formats. The biggest problem with them is that some of them (especially the early ones) are complex transformations with a lot of validation needed, and some of the middle ones rely on

[Piglit] [PATCH 1/3] framework/backends/json: replace str() with six.text_type()

2016-10-10 Thread Dylan Baker
Since str() is incorrect in python2.x. This also fixes an indentation error. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/backends/json.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/backends/json.py b/framework/backends/json.py

[Piglit] [PATCH 0/3] Decouple JSON loading and python classes

2016-10-10 Thread Dylan Baker
. This is available at my github: https://github.com/dcbaker/piglit wip/detangle-json-load Dylan Baker (3): framework/backends/json: replace str() with six.text_type() framework: Drop support for JSON formats < 7 framework/backends/json: Don't convert to TestrunResult while updating framew

[Piglit] [ANNOUNCE] shader_runner without process-isolation had landed

2016-10-07 Thread Dylan Baker
I've tested thoroughly and everything seems to be working, with one very big caveat, piglit currently has no way to filter on subtests. I'm working on this and hopefully it will be solved soon. Dylan signature.asc Description: signature ___ Piglit

Re: [Piglit] [PATCH 2/2] arb_enhanced_layouts: add test for filling the gaps in a dvec3 array

2016-10-07 Thread Dylan Baker
Quoting Nicolai Hähnle (2016-10-07 12:56:55) > From: Nicolai Hähnle > > --- > .../component-layout/vs-fs-array-dvec3.shader_test | 69 > ++ > 1 file changed, 69 insertions(+) > create mode 100644 >

Re: [Piglit] [PATCH 1/2] arb_enhanced_layouts: add test for partially overlapping arrays

2016-10-07 Thread Dylan Baker
Quoting Nicolai Hähnle (2016-10-07 12:56:54) > From: Nicolai Hähnle > > --- > .../vs-fs-array-interleave-range.shader_test | 90 > ++ > 1 file changed, 90 insertions(+) > create mode 100644 >

Re: [Piglit] [PATCH] tests/igt: dmesg noise is a kernel failure

2016-10-06 Thread Dylan Baker
if self.result.dmesg > +self.result.result = 'fail' > + > > def list_tests(listname): > """Parse igt test list and return them as a list.""" > -- > 2.9.3 > >

Re: [Piglit] [PATCH v2 0/16] Add support for shader_runner to run more than one test per process

2016-10-05 Thread Dylan Baker
bump signature.asc Description: signature ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH] utils: Move DRM_FORMATS defines to piglit_drm_dma_buf.h.

2016-10-03 Thread Dylan Baker
FORMAT_R8 > +#define DRM_FORMAT_R8 fourcc_code('R', '8', ' ', ' ') > +#endif > + > +#ifndef DRM_FORMAT_RG88 > +#define DRM_FORMAT_RG88 fourcc_code('R', 'G', '8', '8') > +#endif > + > +#ifndef DRM_FORMAT_GR88 > +#define DRM_FORMAT_GR88 fourcc_code('G', 'R', '8', '8') >

[Piglit] [PATCH 3/3] framework: On exception set the result to exception.

2016-09-30 Thread Dylan Baker
--- framework/backends/junit.py | 2 ++ framework/test/base.py | 6 -- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/framework/backends/junit.py b/framework/backends/junit.py index 4c9b7af..0cb48fa 100644 --- a/framework/backends/junit.py +++

[Piglit] [PATCH 2/3] framework/test: catch Exception rather than a bare except

2016-09-30 Thread Dylan Baker
Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/test/base.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/framework/test/base.py b/framework/test/base.py index 63fcaf4..191ecbc 100644 --- a/framework/test/base.py +++ b/framework/test/base.py @@

[Piglit] [PATCH 0/3] Add a new status for framework exceptions

2016-09-30 Thread Dylan Baker
This little series adds a new status used exclusively for cases where there is a framework exception. This has thankfully become pretty rare, but it's still better to not conflated a test failure and a problem in the python layer. Dylan Baker (3): framework/status: Add a new exception

[Piglit] [PATCH 1/3] framework/status: Add a new exception for framework exceptions

2016-09-30 Thread Dylan Baker
This status is meant to be used only for exception in the python framework, so they don't mask actual test failures and because they are *always* problems that need to be solved quickly. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/status.py

[Piglit] [PATCH v2 14/16] framework: Add class for running multiple shader_tests in a single process

2016-09-30 Thread Dylan Baker
This adds a class based on the ReducedProcessMixin that allows the python layer to understand the output of shader_runner when it runs more than one test per process. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/test/shader_test.py

[Piglit] [PATCH v2 5/16] framework: Add a Mixin class for running multiple tests in a single process

2016-09-30 Thread Dylan Baker
a cherry-like resume feature that starts again after a test crashes, without rerunning the crashed test. Signed-off-by: Dylan Baker <dylanx.c.ba...@intel.com> --- framework/test/base.py| 147 ++- framework/test/deqp.py| 4 +- unittests/fra

<    1   2   3   4   5   6   7   8   9   10   >