Re: [Piglit] [PATCH 1/2] shader_runner: fix error checking on MapBuffer gles workaround

ferParameteri64v(target, GL_BUFFER_SIZE, (GLint64*) ); > - if (piglit_check_gl_error(GL_NO_ERROR)) > + if (!piglit_check_gl_error(GL_NO_ERROR)) This patch is: Reviewed-by: Eric Engestrom > piglit_report_result(PIGLIT_FAIL); > > return glMap

Re: [Piglit] [PATCH] editorconfig: Add max_line_length property

On Monday, 2019-02-25 18:45:01 +0200, Andres Gomez wrote: > On Fri, 2019-02-22 at 18:15 +0000, Eric Engestrom wrote: > > > > On February 22, 2019 2:51:28 PM UTC, Andres Gomez wrote: > > > The property is supported by most of the editors, but not all: > > >

Re: [Piglit] [PATCH piglit] egl: add test for EGL_MESA_query_driver

On Tuesday, 2019-01-22 15:29:44 +, Eric Engestrom wrote: > On Tuesday, 2019-01-22 13:43:07 +, Emil Velikov wrote: > > Hi Eric, > > > > Thanks for writing this up. > > > > On Tue, 22 Jan 2019 at 12:43, Eric Engestrom > > wrote: > > >

[Piglit] [PATCH piglit v2] egl: add test for EGL_MESA_query_driver

Cc: Veluri Mithun Cc: Emil Velikov Cc: Rob Clark Cc: Nicolai Hähnle Signed-off-by: Eric Engestrom --- The extension is currently in development in this MR: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/47 Veluri will send updated versions of this test if the spec changes

Re: [Piglit] [PATCH piglit] egl: add test for EGL_MESA_query_driver

On Tuesday, 2019-01-22 13:43:07 +, Emil Velikov wrote: > Hi Eric, > > Thanks for writing this up. > > On Tue, 22 Jan 2019 at 12:43, Eric Engestrom wrote: > > > > Cc: Veluri Mithun > > Cc: Emil Velikov > > Cc: Rob Clark > > Cc: Nico

Re: [Piglit] [PATCH] tests: only run rounding tests if FE_UPWARD is present

On Friday, 2018-11-30 18:31:16 +, Burton, Ross wrote: > On Fri, 30 Nov 2018 at 17:44, Eric Engestrom wrote: > > On Friday, 2018-11-30 16:33:23 +, Ross Burton wrote: > > > On ARM, musl does not define FE_* when the architecture does not have VFP > > >

Re: [Piglit] [PATCH] tests: only run rounding tests if FE_UPWARD is present

onding rounding direction. Reviewed-by: Eric Engestrom > --- > tests/general/roundmode-getintegerv.c | 12 > tests/general/roundmode-pixelstore.c | 12 > 2 files changed, 16 insertions(+), 8 deletions(-) > > diff --git a/tests/general/roundmode-getinteger

Re: [Piglit] [PATCH V2] arb_texture_view: fix security format warnings

takes a format string, we can just remove the snprintf() > and let it construct the label. > > Also as X is used once and doesn't make the code clearer, just inline it. > > Signed-off-by: Ross Burton Thanks :) Reviewed-by: Eric Engestrom > --- > tests/spec/arb_texture_view/renderi

[Piglit] [PATCH piglit 2/2] ext_image_dma_buf_import/unsupported_format has no reason to be intel-only

Signed-off-by: Eric Engestrom --- tests/opengl.py | 3 +-- .../ext_image_dma_buf_import/CMakeLists.gles1.txt | 2 +- ...ntel_unsupported_format.c => unsupported_format.c} | 11 +-- 3 files changed, 3 insertions(+), 13 deletions(-) rename te

[Piglit] [PATCH piglit 1/2] make sure 'unsupported format' test always uses an unsupported format

Instead of using the fact this one driver currently doesn't support this one format, let's just use a format that will never be supported by anyone. Signed-off-by: Eric Engestrom --- .../ext_image_dma_buf_import/intel_unsupported_format.c| 7 ++- 1 file changed, 6 insertions(+), 1

[Piglit] [PATCH piglit] fix macro redefinition with libdrm>=2.4.95

DRM_FORMAT_INVALID was meant to be an nonexistent format but ironically, the name does exist now, so let's just rename it to what it really means. Signed-off-by: Eric Engestrom --- tests/spec/ext_image_dma_buf_import/invalid_attributes.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [Piglit] [PATCH 3/3] arb_texture_view: fix security format warnings

takes a format string, we can just remove the snprintf() > and let it construct the label. > > Signed-off-by: Ross Burton This patch is: Reviewed-by: Eric Engestrom I'm not sure this macro has any reason to exist though, it's only used once, doesn't do any macro magic, uses each of its param

Re: [Piglit] [PATCH 2/3] tests: Use FE_UPWARD only if its defined in fenv.h

On Friday, 2018-11-30 10:45:05 +, Ross Burton wrote: > From: Khem Raj > > On ARM, musl does not define FE_* when arch does not have > VFP, (which is right interpretation), therefore check if > it is defined before using it. > > Fixes errors like: > >

Re: [Piglit] [PATCH v2] EGL_EXT_image_dma_buf_import: add AYUV format support

On Friday, 2018-11-09 17:27:15 +, Lionel Landwerlin wrote: > v2: Forgot to add the new test to opengl.py > Drop some code to deal with alpha channel > > Signed-off-by: Lionel Landwerlin > --- > tests/opengl.py | 2 ++ >

Re: [Piglit] [PATCH] egl_ext_device_drm: Fix format warning.

ions to open %s\n"); >~^ > > Fixes: 039bbe4a61d1 ("egl_ext_device_drm: don't fail the test if > open("/dev/dri/cardX") errors") > Signed-off-by: Vinson Lee Yeah saw that too, thanks for typing up the fix! Reviewed-by: Er

Re: [Piglit] [PATCH v2 2/7] egl-context-preemption: Add check for high priority contexts.

On Monday, 2018-10-29 10:16:30 -0700, Rafael Antognolli wrote: > Check if we can create high priority contexts, otherwise just fail the > test immediately. There's no reason to test for preemption if we can't > create high priority contexts. > > v2: Require configless context (Tapani) > --- >

Re: [Piglit] [PATCH v2] framework/wflinfo: use x11_egl for gles with mixed_glx_egl

On Friday, 2018-10-05 09:06:24 -0700, Dylan Baker wrote: > Because wflinfo returns GL legacy (non-profile) for gles on glx. > > v2: - If the platform is pure GLX then warn that things aren't going to > work. > --- > framework/wflinfo.py | 21 +++-- > 1 file changed, 19

[Piglit] [PATCH piglit] idTech: fix extensions string list

From: Eric Engestrom CID: 1439995 Fixes: f787ad0b60869f969f02d "Add tests for GL_EXTENSION_STRING vs. old idTech2 / idTech3 games" Cc: Ian Romanick Signed-off-by: Eric Engestrom --- tests/general/idtech-extension-strings.c | 2 +- 1 file changed, 1

Re: [Piglit] [PATCH] framework/wflinfo: use x11_egl for gles with mixed_glx_egl

On Thursday, 2018-10-04 11:28:22 -0700, Dylan Baker wrote: > Because wflinfo returns GL legacy (non-profile) for gles on glx. > --- > framework/wflinfo.py | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/framework/wflinfo.py b/framework/wflinfo.py > index

Re: [Piglit] [PATCH piglit] egl_khr_create_context: Proper invalid attributes for EGL 1.5

ern EGLDisplay egl_dpy; > > +extern EGLint egl_major; > > +extern EGLint egl_minor; > > extern EGLConfig cfg; > > extern EGLContext ctx; > > > > @@ -75,3 +77,9 @@ version_is_valid_for_context(int ctx_major, int major, > > int minor) > > } > &

[Piglit] [PATCH piglit] util: stop overallocating shader memory

Fixes: 606e40b2659ad7fc4ae8e "util: Add utilities to handle shader_test files" Cc: Alejandro Piñeiro Signed-off-by: Eric Engestrom --- tests/util/piglit-shader-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/piglit-shader-test.c b/tests/util/pig

[Piglit] [PATCH piglit] util: avoid leaking memory when caller doesn't ask for it

Signed-off-by: Eric Engestrom --- tests/util/piglit-shader-test.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/tests/util/piglit-shader-test.c b/tests/util/piglit-shader-test.c index 4802983e56d1037be079..f11ee8ab5383080ae090 100644 --- a/tests/util/piglit-shader

Re: [Piglit] [PATCH piglit 2/4] util: fix memory leak

On Wednesday, 2018-08-22 09:58:16 -0700, Caio Marcelo de Oliveira Filho wrote: > On Wed, Aug 22, 2018 at 12:38:40PM +0100, Eric Engestrom wrote: > > CovID: 1438469 (RESOURCE_LEAK) > > Fixes: 606e40b2659ad7fc4ae8e "util: Add utilities to handle shader_test > > file

[Piglit] [PATCH piglit 3/4] egl: fix uninitialised counter

CovID: 1438470 (UNINIT) Fixes: 6c08c9fab326a526b41e1 "egl: Add basic EGL_EXT_device_drm test" Signed-off-by: Eric Engestrom --- tests/egl/spec/egl_ext_device_drm/egl_ext_device_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/egl/spec/egl_ext_

[Piglit] [PATCH piglit 4/4] egl: fix uninitialised counter

CovID: 1438468 (UNINIT) Fixes: e49d4479d6cabce970bb9 egl: Add basic EGL_MESA_device_software test" Signed-off-by: Eric Engestrom --- .../spec/egl_mesa_device_software/egl_mesa_device_software.c| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/egl

[Piglit] [PATCH piglit 2/4] util: fix memory leak

CovID: 1438469 (RESOURCE_LEAK) Fixes: 606e40b2659ad7fc4ae8e "util: Add utilities to handle shader_test files" Signed-off-by: Eric Engestrom --- tests/util/piglit-shader-test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/util/piglit-shader-test.c b/tests/util/piglit-sha

[Piglit] [PATCH piglit 1/4] arb_gpu_shader5: fix memory leak

CovID: 1438471 (RESOURCE_LEAK) Fixes: 7ec9b1734b66ee41c2700 "arb_gpu_shader5: Add support for testing spirv with XFB streams" Signed-off-by: Eric Engestrom --- .../execution/xfb-streams-without-invocations.c | 4 +++- 1 file changed, 3 insert

[Piglit] [PATCH piglit] dispatch: add missing break

Cc: Emil Velikov Fixes: 7356bdd050b8475ed13c "dispatch: fallback to eglGetProcAddress for core functions" Signed-off-by: Eric Engestrom --- tests/util/piglit-dispatch-init.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/util/piglit-dispatch

Re: [Piglit] [PATCH 1/2] tox: Remove testing of end-of-life Python 3.3

On Friday, 2018-07-20 09:41:12 +0300, Andres Gomez wrote: > On Mon, 2018-06-11 at 12:15 +0100, Eric Engestrom wrote: > > On Monday, 2018-06-11 06:39:46 -0400, Rhys Kidd wrote: > > > On 11 June 2018 at 05:40, Eric Engestrom wrote: > > > > > > > On Saturda

Re: [Piglit] [PATCH 1/2] tox: Remove testing of end-of-life Python 3.3

On Monday, 2018-06-11 06:39:46 -0400, Rhys Kidd wrote: > On 11 June 2018 at 05:40, Eric Engestrom wrote: > > > On Saturday, 2018-06-09 15:45:36 -0400, Rhys Kidd wrote: > > > Python 3.3 reached end-of-life in September 2017 [0]. > > > > > > Continuous inte

Re: [Piglit] [PATCH 1/2] tox: Remove testing of end-of-life Python 3.3

; > Signed-off-by: Rhys Kidd I just set up the travis build for the github mirror of piglit [1] an hour ago, and noticed this issue. Reviewed-by: Eric Engestrom Have you also noticed the other issues [2] (asserts firing up)? Is there another canonical travis instance of piglit, and I should r

Re: [Piglit] [Mesa-dev] GitLab migration of Piglit

On Tuesday, 2018-06-05 17:52:17 +0100, Daniel Stone wrote: > Hi Eric, > > On 5 June 2018 at 17:49, Eric Engestrom wrote: > > On Tuesday, 2018-06-05 09:11:58 -0700, Jason Ekstrand wrote: > >> Given the discussion below, I think we'll make piglit a sub-project of > >

Re: [Piglit] GitLab migration of Piglit

On Tuesday, 2018-06-05 09:11:58 -0700, Jason Ekstrand wrote: > Given the discussion below, I think we'll make piglit a sub-project of > mesa. Those who need commit access to piglit but not mesa can be added > directly to the piglit project. > > Unless someone objects strongly, I'll plan to

Re: [Piglit] [PATCH 1/8] README: Fix spelling mistake

On Mon, Apr 04, 2016 at 11:16:54AM -0700, Dylan Baker wrote: > Do you have commit access or do you need someone to push these for you? > > For the series: > Reviewed-by: Dylan Baker Somehow I completely missed your reply, sorry about that. I don't have access, someone

[Piglit] [PATCH 5/8] piglit: Fix spelling mistakes

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- piglit | 2 +- piglit-resume.py | 2 +- piglit-run.py | 2 +- piglit-summary-html.py | 2 +- piglit-summary.py | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/piglit b/piglit

[Piglit] [PATCH 3/8] framework: Fix spelling mistakes

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- framework/backends/__init__.py | 4 ++-- framework/backends/abstract.py | 2 +- framework/backends/json.py | 12 ++-- framework/core.py | 2 +- framework/dmesg.py | 2 +- fra

[Piglit] [PATCH 8/8] unittests: Fix spelling mistakes

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- unittests/backends_tests.py| 2 +- unittests/base_tests.py| 10 +- unittests/core_tests.py| 2 +- unittests/dmesg_tests.py | 2 +- unittests/glsl_parser_test_tests.py

[Piglit] [PATCH 1/8] README: Fix spelling mistake

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README b/README index 535a26e..d738cb1 100644 --- a/README +++ b/README @@ -407,7 +407,7 @@ Every test is run as a separate process. This minimizes the

[Piglit] [PATCH 4/8] generated_tests: Fix spelling mistakes

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- generated_tests/gen_builtin_packing_tests.py | 2 +- generated_tests/gen_builtin_uniform_tests.py | 2 +- generated_tests/gen_builtin_uniform_tests_fp64.py | 2 +- generated_tests/random_ubo.py

[Piglit] [PATCH 6/8] templates: Fix spelling mistakes

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- templates/empty_status.mako | 2 +- templates/index.mako| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/empty_status.mako b/templates/empty_status.mako index 8ee6fba..353b089 100644 --- a/tem

[Piglit] [PATCH 2/8] completion/bash: Fix spelling mistakes

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- completions/bash/piglit | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/completions/bash/piglit b/completions/bash/piglit index 1227ab6..b6cfdd1 100644 --- a/completions/bash/piglit +++ b/completions/bash/