Re: [Piglit] [PATCH] arb_gl_spirv: simple test, use correct reference colors

2018-12-06 Thread Józef Kucia
.shader_test| 23 +-- > 1 file changed, 6 insertions(+), 17 deletions(-) Reviewed-by: Józef Kucia > > diff --git a/tests/spec/arb_gl_spirv/execution/vs-ps-simple.shader_test > b/tests/spec/arb_gl_spirv/execution/vs-ps-simple.shader_test > index 88e3854

Re: [Piglit] [PATCH crucible] Add a test for bug 108909

2018-12-04 Thread Józef Kucia
On Tue, Dec 4, 2018 at 3:46 PM Lionel Landwerlin wrote: > > Signed-off-by: Lionel Landwerlin > --- > Makefile.am| 1 + > src/tests/bug/108909.c | 106 + > 2 files changed, 107 insertions(+) > create mode 100644 src/tests/bug/108909.c > >

Re: [Piglit] [PATCH] arb_gl_spirv: add test for uniform blocks with the same structure

2018-11-26 Thread Józef Kucia
On Sat, Nov 24, 2018 at 9:17 AM apinheiro wrote: > Then do you think that your test is still needed? An alternative, as we > didn't add any compute shader using ubo/ssbo, would be rename and update > the description of your test (something like "compute shader using ubo"). No, my test shouldn't

Re: [Piglit] [PATCH] arb_gl_spirv: add test for uniform blocks with the same structure

2018-11-23 Thread Józef Kucia
On Thu, Nov 22, 2018 at 11:21 AM apinheiro wrote: > some weeks ago I sent a series with ubo/ssbo tests (still pending review) > > https://lists.freedesktop.org/archives/piglit/2018-September/025116.html > > All those has the name stripped. Could you try them and see if any of > them triggers the

[Piglit] [PATCH] arb_gl_spirv: add test for uniform blocks with the same structure

2018-11-21 Thread Józef Kucia
This test reproduces a bug in Nvidia drivers: error: binding mismatch between shaders for UBO (named __defaultname) error: struct type mismatch between shaders for uniform (named __defaultname) error: binding mismatch between shaders for UBO (named __defaultname) error: struct type mismatch

[Piglit] [PATCH] glsl-1.50: Add test for geometry shader with unused outputs

2018-09-19 Thread Józef Kucia
Reproduces a GPU hang on radeonsi. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107857 Signed-off-by: Józef Kucia --- .../geometry/gs-point-unused-outputs.shader_test | 40 ++ 1 file changed, 40 insertions(+) create mode 100644 tests/spec/glsl-1.50/execution

[Piglit] [PATCH] arb_viewport_array: add test for fractional viewport coordinates

2018-05-15 Thread Józef Kucia
@@ +/* + * Copyright (c) 2018 Józef Kucia <joseph.ku...@gmail.com> + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including wi

[Piglit] [Crucible] [PATCH 2/2] Add test for separate bind points

2017-09-20 Thread Józef Kucia
Currently fails with Anv. Passes with Nvidia. --- Makefile.am | 2 + src/tests/func/bind-points.c | 415 +++ 2 files changed, 417 insertions(+) create mode 100644 src/tests/func/bind-points.c diff --git a/Makefile.am b/Makefile.am index

[Piglit] [Crucible] [PATCH 1/2] func.compute.num-workgroups.basic: Properly begin recording commands

2017-09-20 Thread Józef Kucia
Fixes crash on Nvidia. --- src/tests/func/compute-num-workgroups.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/tests/func/compute-num-workgroups.c b/src/tests/func/compute-num-workgroups.c index 35cae17..1ad45fc 100644 --- a/src/tests/func/compute-num-workgroups.c +++

Re: [Piglit] [Crucible] [PATCH 2/2] qonos: Create empty layouts for graphics pipelines

2017-09-16 Thread Józef Kucia
On Sat, Sep 9, 2017 at 9:15 PM, Józef Kucia <joseph.ku...@gmail.com> wrote: > The layout must be a valid VkPipelineLayout handle. > --- > src/qonos/qonos_pipeline.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/qonos/qonos_pipeline.c b/src/qonos/qonos_pi

[Piglit] [Crucible] [PATCH 1/2] build: Do not overwrite user variables

2017-09-09 Thread Józef Kucia
Allows passing CPPFLAGS, CFLAGS and CXXFLAGS to configure. --- I am not sure if this is the best place to submit patches for Crucible. --- Makefile.am | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile.am b/Makefile.am index 656ee22..0478868 100644 ---

Re: [Piglit] [PATCH] glsl-1.50: add linker test for unused in out blocks

2017-07-14 Thread Józef Kucia
On Tue, May 30, 2017 at 4:23 PM, Józef Kucia <joseph.ku...@gmail.com> wrote: > This test exposes a Mesa GLSL linker bug. The test fails with the > following error message: > > error: Input block `blk' is not an output of the previous stage > > Section 4.3.4 (Inputs) of

Re: [Piglit] [PATCH v5] pbo: Change the value expected from GetPixelMap. This fixes tests/spec/gl-2.1/pbo on Windows Intel driver.

2017-06-21 Thread Józef Kucia
You should fix the commit message. The subject should be shorter. Additional comments can be put in a longer description after the short summary line. See, e.g. https://www.mesa3d.org/submittingpatches.html for guidelines. On Thu, Jun 8, 2017 at 5:32 PM, Sandra Koroniewska

Re: [Piglit] [PATCH v3] pbo: delete unmapping the GL_PIXEL_UNPACK_BUFFER before using it and correct the data expected form glGetMapusv This fixes tests/spec/gl-2.1/pbo on Windows Intel driver. Accord

2017-06-06 Thread Józef Kucia
On Thu, Jun 1, 2017 at 1:11 PM, sandra koroniewska wrote: > Hi, > this change fixes a real problem for me (a crash on an Intel driver). > I don't know if I understand this right, but for glPixelMap there is written > in a spec (core 2.1, page 117): "If a pixel unpack

Re: [Piglit] [PATCH] glsl-1.50: add linker test for unused in out blocks

2017-05-31 Thread Józef Kucia
On Wed, May 31, 2017 at 9:42 PM, Ian Romanick <i...@freedesktop.org> wrote: > On 05/30/2017 07:23 AM, Józef Kucia wrote: >> This test exposes a Mesa GLSL linker bug. The test fails with the > > Is there a bugzilla for this issue? Was this encountered in a app or ... ?

[Piglit] [PATCH] glsl-1.50: add linker test for unused in out blocks

2017-05-30 Thread Józef Kucia
This test exposes a Mesa GLSL linker bug. The test fails with the following error message: error: Input block `blk' is not an output of the previous stage Section 4.3.4 (Inputs) of the GLSL 1.50 spec says: "Only the input variables that are actually read need to be written by the

[Piglit] [PATCH] arb_texture_view: add simple test for rendering to R32UI texture view

2017-05-30 Thread Józef Kucia
/tests/spec/arb_texture_view/rendering-r32ui.c new file mode 100644 index 000..4a4037b --- /dev/null +++ b/tests/spec/arb_texture_view/rendering-r32ui.c @@ -0,0 +1,101 @@ +/* + * Copyright (c) 2017 Józef Kucia <joseph.ku...@gmail.com> + * + * Permission is hereby granted, free of charge,

Re: [Piglit] [PATCH v3] pbo: delete unmapping the GL_PIXEL_UNPACK_BUFFER before using it and correct the data expected form glGetMapusv This fixes tests/spec/gl-2.1/pbo on Windows Intel driver. Accord

2017-05-25 Thread Józef Kucia
Hi Sandra, On Thu, May 25, 2017 at 4:38 PM, sandra koroniewska wrote: > Hi Józef, > sorry for responding here, but I didn't manage to send the corrections in > response to your previous mail. Thanks for your answer. The fragment of your > previous mail is: > > When

Re: [Piglit] [PATCH] pbo: delete unmapping the GL_PIXEL_UNPACK_BUFFER before using it and correct the data expected form glGetMapusv

2017-05-15 Thread Józef Kucia
On Fri, May 5, 2017 at 1:45 PM, Sandra Koroniewska wrote: > This fixes tests/spec/gl-2.1/pbo on Windows Intel driver. According to OpenGL > 2.1 spec, page 38 "Unmapping a mapped buffer > object invalidates the pointers to its data store and sets the object’s >

[Piglit] [PATCH v2] glx: add test for drawing to GL_FRONT between glxMakeCurrent()

2017-04-27 Thread Józef Kucia
Based on the glx-fbo-binding test. v2: - do not declare "piglit_width" and "piglit_height" - use piglit_get_gl_enum_name() Signed-off-by: Józef Kucia <joseph.ku...@gmail.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99116 --- I do not have commit

[Piglit] [PATCH] glx: add test for drawing to GL_FRONT between glxMakeCurrent()

2017-04-27 Thread Józef Kucia
Based on the glx-fbo-binding test. Signed-off-by: Józef Kucia <joseph.ku...@gmail.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99116 --- tests/all.py| 1 + tests/glx/CMakeLists.gl.txt | 1 + tests/glx/glx-multi-context-front.c