Re: [Piglit] [PATCH 1/1] cl: Add input dependent test for global_offset

2017-04-22 Thread Jan Vesely
On Fri, 2017-04-14 at 11:10 -0400, Jan Vesely wrote: > Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> > --- > tests/cl/program/execute/global-offset.cl | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/tests/cl/program/execute/global-offset.

[Piglit] [PATCH 1/1] cl: Add array of structures to program-scope-arrays test

2017-04-14 Thread Jan Vesely
Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- tests/cl/program/execute/program-scope-arrays.cl | 60 1 file changed, 60 insertions(+) diff --git a/tests/cl/program/execute/program-scope-arrays.cl b/tests/cl/program/execute/program-scope-arrays.cl index a

[Piglit] [PATCH 1/1] cl: Add input dependent test for global_offset

2017-04-14 Thread Jan Vesely
Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- tests/cl/program/execute/global-offset.cl | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tests/cl/program/execute/global-offset.cl b/tests/cl/program/execute/global-offset.cl index c75f2b3..da78d2b 100644 --- a

Re: [Piglit] [PATCH 1/1] cl: Unmap mapped cl buffer in buffer-flags test

2017-04-05 Thread Jan Vesely
On Mon, 2017-03-27 at 17:28 -0700, Francisco Jerez wrote: > Jan Vesely <jan.ves...@rutgers.edu> writes: > > > On Thu, 2017-03-16 at 19:17 -0400, Jan Vesely wrote: > > > Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> > > > --- > > > tests/cl

Re: [Piglit] [PATCH 1/1] cl: Unmap mapped cl buffer in buffer-flags test

2017-03-27 Thread Jan Vesely
On Thu, 2017-03-16 at 19:17 -0400, Jan Vesely wrote: > Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> > --- > tests/cl/custom/buffer-flags.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/cl/custom/buffer-flags.c b/tests/cl/custom/buffer-flags.c

Re: [Piglit] [PATCH 1/1] cl: OCL1.1 allows pointers to NULL as valid kernel args

2017-03-27 Thread Jan Vesely
On Wed, 2017-02-22 at 11:27 -0500, Jan Vesely wrote: > Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> > --- > tests/cl/api/set-kernel-arg.c | 21 - > 1 file changed, 12 insertions(+), 9 deletions(-) > > diff --git a/tests/cl/api/set-kernel-arg.c b

[Piglit] [PATCH 1/1] cl: Unmap mapped cl buffer in buffer-flags test

2017-03-16 Thread Jan Vesely
Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- tests/cl/custom/buffer-flags.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/cl/custom/buffer-flags.c b/tests/cl/custom/buffer-flags.c index 115fb92..1429de0 100644 --- a/tests/cl/custom/buffer-flags.c +++ b/tests/cl/

Re: [Piglit] [PATCH 1/1] cl: OCL1.1 allows pointers to NULL as valid kernel args

2017-03-08 Thread Jan Vesely
On Mon, 2017-02-27 at 20:44 -0500, Jan Vesely wrote: > On Wed, 2017-02-22 at 11:27 -0500, Jan Vesely wrote: > > Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> > > --- > > tests/cl/api/set-kernel-arg.c | 21 - > > 1 file chang

Re: [Piglit] [PATCH 08/10] cl: Add tests for mul24 and mulhi 24 bit optimizations

2017-02-27 Thread Jan Vesely
resending trimmed to appease the ML On Mon, 2017-02-27 at 16:26 -0500, Jan Vesely wrote: > On Thu, 2017-02-02 at 01:16 -0800, Matt Arsenault wrote: > > > On Dec 8, 2016, at 16:21, Jan Vesely <jan.ves...@rutgers.edu> wrote: > > > > > > On Mon, 2016-12-

[Piglit] [PATCH 1/1] cl: OCL1.1 allows pointers to NULL as valid kernel args

2017-02-22 Thread Jan Vesely
Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- tests/cl/api/set-kernel-arg.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/tests/cl/api/set-kernel-arg.c b/tests/cl/api/set-kernel-arg.c index d306931..8679ccb 100644 --- a/tests/cl/api/set-

Re: [Piglit] [PATCH] cl: Add sign_extend_inreg test

2017-02-09 Thread Jan Vesely
long a6, > +long a7, > +long a8, > +long a9, > +long a10, > +long a11, >

Re: [Piglit] [PROBLEM]Piglit OpenCL tests under windows.

2017-02-09 Thread Jan Vesely
On Wed, 2017-02-08 at 12:03 +0100, abu dabi wrote: > Hello there > I have a major issue compiling CL tests under windows. > I have everything prepared as i supposed to but compilation fails due to an > error: > Missing libgen.h > Its weird because this header is a part of GCC compiler not VS 13

Re: [Piglit] [PATCH] cl: Add tests for stored fneg

2017-01-26 Thread Jan Vesely
On Thu, 2017-01-26 at 15:09 -0800, arse...@gmail.com wrote: > From: Matt Arsenault <arse...@gmail.com> > > Make sure fneg that can't be folded into a use operand is > executed correctly. > > v2: Merge with other test > v3: Remove other test thanks. Revie

Re: [Piglit] [PATCH] cl: Add tests for stored fneg

2017-01-26 Thread Jan Vesely
On Thu, 2017-01-26 at 15:11 -0800, Matt Arsenault wrote: > > On Jan 20, 2017, at 11:56, Jan Vesely <jan.ves...@rutgers.edu> wrote: > > nly one config section per test file. > > > > > + > > > +[test] > > > +name: fneg > > > +kernel_name

Re: [Piglit] [PATCH 2/2] cl: Add tests for fdiv with neg/abs inputs

2017-01-20 Thread Jan Vesely
On Mon, 2017-01-16 at 11:02 -0800, arse...@gmail.com wrote: > From: Matt Arsenault <arse...@gmail.com> Reviewed-by: Jan Vesely <jan.ves...@rutgers.edu> Jan > > --- > tests/cl/program/execute/fdiv-modifiers-f32.cl | 257 > tests/cl/program/ex

Re: [Piglit] [PATCH] cl: Add tests for stored fneg

2017-01-20 Thread Jan Vesely
On Fri, 2017-01-20 at 11:40 -0800, arse...@gmail.com wrote: > From: Matt Arsenault > > Make sure fneg that can't be folded into a use operand is > executed correctly. > > v2: Merge with other test > --- > .../cl/program/execute/scalar-arithmetic-double.cl | 34 >

Re: [Piglit] [PATCH] cl: Add basic remainder(float, float) builtin tests

2017-01-20 Thread Jan Vesely
On Tue, 2017-01-17 at 21:18 -0600, Aaron Watry wrote: > Tested with libclc on a Radeon HD 7850. > > Hex output values were generated via remainderf(float, float). > > No implications as to the quality of the inputs is intended. > > Signed-off-by: Aaron Watry <awa...@gmai

Re: [Piglit] [PATCH 1/2] cl: Add tests for stored fneg

2017-01-20 Thread Jan Vesely
On Mon, 2017-01-16 at 11:02 -0800, arse...@gmail.com wrote: > From: Matt Arsenault > > Make sure fneg that can't be folded into a use operand is > executed correctly. These should be part of scalar-arithmetic-{float,double} tests (feel free to create the latter). Jan > ---

Re: [Piglit] [PATCH 2/3] CL: Fix up erf tests

2017-01-20 Thread Jan Vesely
th.erf (1 and 2 respectively), but the numbers look OK now, and they weren't using it before. for patches 1 and 2 Reviewed-by: Jan Vesely <jan.ves...@rutgers.edu> > > Signed-off-by: Aaron Watry <awa...@gmail.com> > --- > generated_tests/gen_cl_math_builtins.py | 2 +- >

Re: [Piglit] [PATCH 3/3] CL: Add some basic expm1 tests

2017-01-20 Thread Jan Vesely
On Mon, 2017-01-16 at 20:03 -0600, Aaron Watry wrote: > These aren't too comprehensive, but there's some checks for reasonable > accuracy > when the input is near 0. > > Signed-off-by: Aaron Watry > --- > generated_tests/gen_cl_math_builtins.py | 12 +++- > 1 file

Re: [Piglit] [PATCH 1/5] cl/program-tester: Make sure that platform_ids is initialized

2016-12-23 Thread Jan Vesely
On Thu, 2016-12-22 at 22:10 -0600, Aaron Watry wrote: > Otherwise, if you have ICDs installed and none successfully dlopen, you > end up freeing uninitialized/invalid memory. > > Signed-off-by: Aaron Watry <awa...@gmail.com> LGTM. Reviewed-by: Jan Vesely <jan.ves

Re: [Piglit] [PATCH] cl: Add f32 immediate tests

2016-12-08 Thread Jan Vesely
On Thu, 2016-12-08 at 11:46 -0800, Matt Arsenault wrote: > > On Dec 6, 2016, at 15:30, Jan Vesely <jan.ves...@rutgers.edu> wrote: > > > > git complains about whitespace error here. > > Reviewed-by: Jan Vesely <jan.ves...@rutgers.edu > > <mailto:jan.ves

Re: [Piglit] [PATCH 07/10] cl: Add test for negative index + small offset for private

2016-12-08 Thread Jan Vesely
On Thu, 2016-12-08 at 11:47 -0800, Matt Arsenault wrote: > > On Dec 7, 2016, at 11:03, Jan Vesely <jan.ves...@rutgers.edu> wrote: > > > > On Tue, 2016-12-06 at 11:05 -0800, Matt Arsenault wrote: > > > > On Dec 6, 2016, at 11:04, Jan Vesely <jan.ves...@rutg

Re: [Piglit] [PATCH 07/10] cl: Add test for negative index + small offset for private

2016-12-07 Thread Jan Vesely
On Tue, 2016-12-06 at 11:05 -0800, Matt Arsenault wrote: > > On Dec 6, 2016, at 11:04, Jan Vesely <jan.ves...@rutgers.edu> wrote: > > > > On Tue, 2016-12-06 at 10:52 -0800, Matt Arsenault wrote: > > > > On Dec 5, 2016, at 12:42, Jan Vesely <jan.ves...@rutg

Re: [Piglit] [PATCH] cl: Add test for clz optimizations

2016-12-06 Thread Jan Vesely
On Tue, 2016-12-06 at 11:15 -0800, arse...@gmail.com wrote: > From: Matt Arsenault <arse...@gmail.com> > > v2: Rename test Reviewed-by: Jan Vesely <jan.ves...@rutgers.edu> and pushed (with slight rename followup) Jan > --- > tests/cl/program/execute

Re: [Piglit] [PATCH] cl: Add test for f64 inline immediates

2016-12-06 Thread Jan Vesely
On Tue, 2016-12-06 at 11:14 -0800, arse...@gmail.com wrote: > From: Matt Arsenault <arse...@gmail.com> > > v2: Require cl_khr_fp64 Reviewed-by: Jan Vesely <jan.ves...@rutgers.edu> and pushed. Jan > --- > .../execute/amdgcn-f64-inline-immediates.cl| 270 &

Re: [Piglit] [PATCH] cl: Add f32 immediate tests

2016-12-06 Thread Jan Vesely
int id = get_global_id(0); > +out[id] = in[id] + as_float((int)-16); > +} > + > +kernel void add_i32_64(global float* out, global float* in) > +{ > +int id = get_global_id(0); > +out[id] = in[id] + as_float((int)64); > +} > + >

Re: [Piglit] [PATCH 02/10] cl: Add sign_extend_inreg test

2016-12-06 Thread Jan Vesely
On Tue, 2016-12-06 at 13:33 -0800, Matt Arsenault wrote: > > On Dec 6, 2016, at 12:18, Jan Vesely <jan.ves...@rutgers.edu> wrote: > > > > On Tue, 2016-12-06 at 10:55 -0800, Matt Arsenault wrote: > > > > On Dec 5, 2016, at 13:20, Jan Vesely <jan.ves.

Re: [Piglit] [PATCH 02/10] cl: Add sign_extend_inreg test

2016-12-06 Thread Jan Vesely
On Tue, 2016-12-06 at 10:55 -0800, Matt Arsenault wrote: > > On Dec 5, 2016, at 13:20, Jan Vesely <jan.ves...@rutgers.edu> wrote: > > > > On Mon, 2016-12-05 at 09:48 -0800, arse...@gmail.com > > <mailto:arse...@gmail.com> wrote: > > > From: M

Re: [Piglit] [PATCH 03/10] cl: Add tests for different versions of fmin / fmax.

2016-12-06 Thread Jan Vesely
On Tue, 2016-12-06 at 11:12 -0800, Matt Arsenault wrote: > > On Dec 5, 2016, at 13:35, Jan Vesely <jan.ves...@rutgers.edu> wrote: > > > > On Mon, 2016-12-05 at 09:48 -0800, arse...@gmail.com > > <mailto:arse...@gmail.com> wrote: > >

Re: [Piglit] [PATCH 07/10] cl: Add test for negative index + small offset for private

2016-12-06 Thread Jan Vesely
On Tue, 2016-12-06 at 10:52 -0800, Matt Arsenault wrote: > > On Dec 5, 2016, at 12:42, Jan Vesely <jan.ves...@rutgers.edu> wrote: > > > > On Mon, 2016-12-05 at 09:48 -0800, arse...@gmail.com > > <mailto:arse...@gmail.com> wrote: > >

Re: [Piglit] [PATCH 03/10] cl: Add tests for different versions of fmin / fmax.

2016-12-05 Thread Jan Vesely
On Mon, 2016-12-05 at 09:48 -0800, arse...@gmail.com wrote: > From: Matt Arsenault > > These do not use the normal simple format because the number > of combinations that need to be tested is simply too large, > especially when tests for min3/max3 are added. > > The unordered

Re: [Piglit] [PATCH 01/10] cl: Add tests for 24-bit div / rem optimization

2016-12-05 Thread Jan Vesely
this patch (same values for uint test) for some time: Reviewed-by: Jan Vesely <jan.ves...@rutgers.edu> > > diff --git a/tests/cl/program/execute/scalar-arithmetic-int.cl > b/tests/cl/program/execute/scalar-arithmetic-int.cl > index 3263df5..df6054e 100644 > --- a/tests/cl/pro

Re: [Piglit] [PATCH 02/10] cl: Add sign_extend_inreg test

2016-12-05 Thread Jan Vesely
On Mon, 2016-12-05 at 09:48 -0800, arse...@gmail.com wrote: > From: Matt Arsenault > > --- > tests/cl/program/execute/sign_extend_inreg.cl | 387 > ++ > 1 file changed, 387 insertions(+) > create mode 100644

Re: [Piglit] [PATCH 07/10] cl: Add test for negative index + small offset for private

2016-12-05 Thread Jan Vesely
ead \ > + 0xcafe \ > + 0xabcd \ > + 0xababfeed \ > + 0xca00fe \ > + 0xb00feed \ > + 0xca00fe \ > + 0xfeedbeef \ > + 0xfe \ > + 0xbe00fe \ > + 0xabcdef \ > + 0xbeef \ > + 0xde > +#endif > + > +kernel void read_write_private_base_plus_offset(g

Re: [Piglit] [PATCH 05/10] cl: Add f32 immediate tests

2016-12-05 Thread Jan Vesely
On Mon, 2016-12-05 at 09:48 -0800, arse...@gmail.com wrote: > From: Matt Arsenault > > --- > tests/cl/program/execute/f32-inline-immediates.cl | 237 > ++ > 1 file changed, 237 insertions(+) > create mode 100644

Re: [Piglit] [PATCH 09/10] Require python 2.7

2016-12-05 Thread Jan Vesely
On Mon, 2016-12-05 at 09:48 -0800, arse...@gmail.com wrote: > From: Matt Arsenault > > Things seem to break with python3 can you be more specific? things have run OK for me with python3.5 for some time. Jan > --- > CMakeLists.txt | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Piglit] [PATCH 06/10] cl: Add test for clz

2016-12-05 Thread Jan Vesely
On Mon, 2016-12-05 at 09:48 -0800, arse...@gmail.com wrote: > From: Matt Arsenault > > --- > tests/cl/program/execute/clz.cl | 389 > > 1 file changed, 389 insertions(+) > create mode 100644 tests/cl/program/execute/clz.cl > > diff

Re: [Piglit] [PATCH 04/10] cl: Add test for f64 inline immediates

2016-12-05 Thread Jan Vesely
On Mon, 2016-12-05 at 09:48 -0800, arse...@gmail.com wrote: > From: Matt Arsenault > > --- > tests/cl/program/execute/f64-inline-immediates.cl | 269 > ++ > 1 file changed, 269 insertions(+) > create mode 100644

Re: [Piglit] [PATCH v2] cl: add clGetExtensionFunctionAddressForPlatform

2016-11-10 Thread Jan Vesely
rs ***/ > + > + /* clIcdGetPlatformIDsKHR should be present in most of OpenCL 1.2 libs > */ > + ptr = clGetExtensionFunctionAddressForPlatform(NULL, > + > "clIcdGetPlatformIDsKHR"); > + if (ptr) { &

Re: [Piglit] [PATCH] cl: add clGetExtensionFunctionAddressForPlatform

2016-11-06 Thread Jan Vesely
clIcdGetPlatformIDsKHR should be present in most of OpenCL 1.2 libs > */ > + ptr = clGetExtensionFunctionAddressForPlatform(NULL, > + > "clIcdGetPlatformIDsKHR"); > + if (ptr) { > + fprintf(stder

Re: [Piglit] [PATCH v6] cl: Add a test for the predefined macros

2016-10-19 Thread Jan Vesely
On Wed, 2016-10-19 at 11:01 +0200, Niels Ole Salscheider wrote: > On Monday, 17 October 2016, 10:20:32 CEST, Jan Vesely wrote: > > > > On Sat, 2016-10-15 at 14:43 +0200, Niels Ole Salscheider wrote: > > > > > > v6: Fix OpenCL C version test if test is compiled

Re: [Piglit] [PATCH v6] cl: Add a test for the predefined macros

2016-10-17 Thread Jan Vesely
> report PIGLIT_SKIP for the values of IMAGE_SUPPORT and ENDIAN_LITTLE > v3: Fix alignment and typos > v2: Check the values of the defines and add more checks > > Signed-off-by: Niels Ole Salscheider <niels_...@salscheider-online.de> > Reviewed-by: Jan Vesely <jan.v

Re: [Piglit] [PATCH v5] cl: Add a test for the predefined macros

2016-10-11 Thread Jan Vesely
LE > v3: Fix alignment and typos > v2: Check the values of the defines and add more checks > > Signed-off-by: Niels Ole Salscheider <niels_...@salscheider-online.de> > Reviewed-by: Jan Vesely <jan.ves...@rutgers.edu> > --- > tests/cl.py | 1 +

Re: [Piglit] [PATCH v4] cl: Add a test for the predefined macros

2016-10-08 Thread Jan Vesely
ined for OpenCL > 2.0 and later"); > + piglit_merge_result(, result_cl_version_defined[3]); > + piglit_report_subtest_result(result_cl_version[0], > + "CL_VERSION_1_0 must be 100 if defined"); > + piglit_merge_result(

Re: [Piglit] [PATCH] Fix use of uninitialized variable valgrind error

2016-08-24 Thread Jan Vesely
On Tue, 2016-08-23 at 21:37 -0700, arse...@gmail.com wrote: > From: Matt Arsenault <arse...@gmail.com> Reviewed-by: Jan Vesely <jan.ves...@rutgers.edu> although I would not expect random value to be a valid mem object. Jan > > --- >  tests/cl/api/set-kernel-arg.c | 2

Re: [Piglit] [PATCH] Use right comparison function for double

2016-08-24 Thread Jan Vesely
On Tue, 2016-08-23 at 21:33 -0700, arse...@gmail.com wrote: > From: Matt Arsenault <arse...@gmail.com> I guess more cases can be consolidated this way... Reviewed-by: Jan Vesely <jan.ves...@rutgers.edu> Jan > > --- >  tests/cl/program/program-tester.c | 12 ++---

Re: [Piglit] [PATCH 1/4] cl: Add float type vstore test

2016-08-17 Thread Jan Vesely
On Wed, 2016-08-17 at 19:40 +, Tom Stellard wrote: > On Sat, Jul 30, 2016 at 01:56:03PM -0400, Jan Vesely wrote: > > > > Passes on intel, clover(AMD Turks,Kaveri), beignet, CUDA > > > > Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> > > For

Re: [Piglit] [PATCH v2 1/2] cl: Add support for cl_half to program tester

2016-08-16 Thread Jan Vesely
On Sat, 2016-08-06 at 14:47 -0400, Jan Vesely wrote: > Use explicit conversion from regexp matched array values > > v2: distance between two half numbers is 8192 single float ulps > no need to place converted float in the middle of single > precision range > > Sign

[Piglit] [PATCH v2 1/2] cl: Add support for cl_half to program tester

2016-08-06 Thread Jan Vesely
Use explicit conversion from regexp matched array values v2: distance between two half numbers is 8192 single float ulps no need to place converted float in the middle of single precision range Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- tests/cl/program/program-tester.

[Piglit] [PATCH v2 5/4] cl: Add vstore test generator

2016-08-01 Thread Jan Vesely
The tests try to use target mem type aligned access. Generated tests pass (except vstore-half which skips) on intel(cpu), beignet, nvidia CUDA, clover(kaveri - with patches) v2: Move code to main function, update copyright Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- Th

[Piglit] [PATCH 5/4] cl: Add vstore test generator

2016-07-30 Thread Jan Vesely
The tests try to use target mem type aligned access. Generated tests pass (except vstore-half which skips) on intel(cpu), beignet, nvidia CUDA vstore-half passes on patched beignet Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- This patch replaces patches 1,3,4. sorry for the

[Piglit] [PATCH 1/4] cl: Add float type vstore test

2016-07-30 Thread Jan Vesely
Passes on intel, clover(AMD Turks,Kaveri), beignet, CUDA Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- tests/cl/program/execute/vstore-float.cl | 126 +++ 1 file changed, 126 insertions(+) create mode 100644 tests/cl/program/execute/vstore-float.cl

[Piglit] [PATCH 4/4] cl: Add vstore_half double test

2016-07-30 Thread Jan Vesely
Passed on intel(CPU), beignet, CUDA Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- tests/cl/program/execute/vstore_half-double.cl | 140 + 1 file changed, 140 insertions(+) create mode 100644 tests/cl/program/execute/vstore_half-double.cl diff --git a/te

[Piglit] [PATCH 3/4] cl: Add vstore_half float test

2016-07-30 Thread Jan Vesely
Passed on intel(CPU), clover(AMD Kaveri), beignet, CUDA Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- tests/cl/program/execute/vstore_half-float.cl | 137 ++ 1 file changed, 137 insertions(+) create mode 100644 tests/cl/program/execute/vstore_half-float.cl

[Piglit] [PATCH 2/4] cl: Add support for cl_half to program tester

2016-07-30 Thread Jan Vesely
Use explicit conversion from regexp matched array values Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- tests/cl/program/program-tester.c | 31 + tests/util/piglit-util-cl.c | 42 +++ tests/util/piglit-uti

[Piglit] [PATCH v2 2/2] cl: Add global atomic_xchg tests

2016-06-13 Thread Jan Vesely
Passes on CUDA, beignet, clover on kaveri, and intel CPU. v2: fix threads float test name Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- .../builtin/atomic/atomic_xchg-global-return.cl| 89 ++ .../execute/builtin/atomic/atomic_xchg-global.cl

[Piglit] [PATCH 1/2] cl: Add global atomic_cmpxchg tests

2016-06-13 Thread Jan Vesely
Passes on CUDA, beignet, clover on kaveri, and intel CPU. Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- .../builtin/atomic/atomic_cmpxchg-global-return.cl | 74 ++ .../builtin/atomic/atomic_cmpxchg-global.cl| 69 2 files change

[Piglit] [PATCH 2/2] cl: Add global atomic_xchg tests

2016-06-13 Thread Jan Vesely
Passes on CUDA, beignet, clover on kaveri, and intel CPU. Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- .../builtin/atomic/atomic_xchg-global-return.cl| 89 ++ .../execute/builtin/atomic/atomic_xchg-global.cl | 86 + 2 files change

[Piglit] [PATCH 1/1] cl: declare enum counts as extern

2016-05-25 Thread Jan Vesely
The correct symbols are in libpiglitutil_cl.so Reported-by: Jose Luis Cercós <jlcer...@gmail.com> Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- tests/util/piglit-util-cl-enum.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/util/piglit-util

Re: [Piglit] PIGLIT_CL_ENUM_NUM(cl_device_type, env->version) return zero

2016-05-25 Thread Jan Vesely
; git://anongit.freedesktop.org/git/piglit > > I did not check other expansions of PIGLIT_CL_ENUM_NUM. > > Any hint on what is going wrong will be welcomed. > > Thanks! > Pepe > ___ > Piglit mailing list > Piglit@lists.freedesktop

Re: [Piglit] [PATCH 2/2] cl: add global offset test

2016-05-15 Thread Jan Vesely
On Sun, 2016-05-15 at 17:39 -0400, Jan Vesely wrote: > Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> Forgot to add that this passes on Intel CPU, Beignet and CUDA CL. > --- >  tests/cl/program/execute/global-offset.cl | 85 > +++ >  1 file c

[Piglit] [PATCH 1/2] cl: add support for global offset

2016-05-15 Thread Jan Vesely
Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- tests/cl/api/create-program-with-binary.c| 2 +- tests/cl/custom/buffer-flags.c | 2 +- tests/cl/custom/flush-after-enqueue-kernel.c | 2 +- tests/cl/custom/r600-create-release-buffer-bug.

[Piglit] [PATCH 2/2] cl: add global offset test

2016-05-15 Thread Jan Vesely
Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- tests/cl/program/execute/global-offset.cl | 85 +++ 1 file changed, 85 insertions(+) create mode 100644 tests/cl/program/execute/global-offset.cl diff --git a/tests/cl/program/execute/global-offset.cl b/te

Re: [Piglit] [PATCH 2/2] cl: check for image support using util/ functions

2016-05-06 Thread Jan Vesely
= > - piglit_cl_get_device_info(device, > CL_DEVICE_IMAGE_SUPPORT); > - > - if (!*has_image) { > - fprintf(stdout, "No image support. Sampler arg won't > be tested\n"); > - free(has_image); > - return false; > - } > - > - f

Re: [Piglit] [PATCH v2] cl: Fix cl_khr_fp64 checks

2016-05-06 Thread Jan Vesely
On Fri, 2016-05-06 at 13:38 +0200, Serge Martin wrote: > On Thursday 28 April 2016 22:22:06 Jan Vesely wrote: > > > > v2: fix sizeof test > > > > Signed-off-by: Jan Vesely <jano.ves...@gmail.com> > > --- > >  tests/cl/program/build/scalar-data-typ

[Piglit] [PATCH 1/1] cl: skip get image info test if there's no image support

2016-05-02 Thread Jan Vesely
Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- tests/cl/api/get-image-info.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/tests/cl/api/get-image-info.c b/tests/cl/api/get-image-info.c index 2d653b1..a8b5bec 100644 --- a/tests/cl/a

[Piglit] [PATCH v2] cl: Fix cl_khr_fp64 checks

2016-04-28 Thread Jan Vesely
v2: fix sizeof test Signed-off-by: Jan Vesely <jano.ves...@gmail.com> --- tests/cl/program/build/scalar-data-types.cl | 5 +++-- tests/cl/program/execute/sizeof.cl | 4 +++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/cl/program/build/scalar-data-types

[Piglit] [PATCH] cl: Initialize result variable.

2016-04-28 Thread Jan Vesely
Fixes Unknown status "Unknown result" python exception. Signed-off-by: Jan Vesely <jano.ves...@gmail.com> --- tests/cl/api/set-kernel-arg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/cl/api/set-kernel-arg.c b/tests/cl/api/set-kernel-arg.c index

[Piglit] [PATCH] cl: Fix cl_khr_fp64 check

2016-04-28 Thread Jan Vesely
Signed-off-by: Jan Vesely <jano.ves...@gmail.com> --- tests/cl/program/build/scalar-data-types.cl | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/cl/program/build/scalar-data-types.cl b/tests/cl/program/build/scalar-data-types.cl index 00693f5..09fd15f

Re: [Piglit] [PATCH RESEND] cl: Fix image support when built on CL<1.2

2016-04-26 Thread Jan Vesely
On Sun, 2016-04-24 at 10:08 +0200, Serge Martin wrote: > On Monday 04 April 2016 08:55:48 Jan Vesely wrote: > > > > On Mon, 2016-03-28 at 21:17 -0400, Jan Vesely wrote: > > > > > > Provide our own image_desc structure since it's too tangled to > > >

Re: [Piglit] [PATCH 5/8] arb_shader_image_load_store: add additional coherency test

2016-04-16 Thread Jan Vesely
On Sat, 2016-04-16 at 10:19 -0500, Nicolai Hähnle wrote: > On 15.04.2016 17:12, Francisco Jerez wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > For a test doing almost the same thing but not relying on > > > > > > unspecified > > > > > > invocation ordering, see > > > > > >

Re: [Piglit] [PATCH RESEND] cl: Fix image support when built on CL<1.2

2016-04-04 Thread Jan Vesely
On Mon, 2016-03-28 at 21:17 -0400, Jan Vesely wrote: > Provide our own image_desc structure since it's too tangled to > remove. > Tests that require OCL 1.2 result in WARN: > Piglit was compiled with lower OpenCL version (1.1) than version_min: > 12. > OCL 1.1 image tests pas

Re: [Piglit] [PATCH 1/2] framework: fix unicode input for python 2.x

2016-03-29 Thread Jan Vesely
On Fri, 2016-03-25 at 14:28 -0700, Dylan Baker wrote: > In python 3.x input is unicode by default, but in python 2.x > everything > is a byte string by default, this includes input. Currently when > running > with python 3.x it's possible to use unicode for input, but python > 2.x > will choke

[Piglit] [PATCH RESEND] cl: Fix image support when built on CL<1.2

2016-03-28 Thread Jan Vesely
Provide our own image_desc structure since it's too tangled to remove. Tests that require OCL 1.2 result in WARN: Piglit was compiled with lower OpenCL version (1.1) than version_min: 12. OCL 1.1 image tests pass on Intel CPU OCL when compiled in 1.1 environment. Signed-off-by: Jan Vesely

[Piglit] [PATCH v2 1/1] cl: Split setKernelArg into subtests

2016-03-09 Thread Jan Vesely
v2: coalesce input checks into one subtest Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- tests/cl/api/set-kernel-arg.c | 55 --- 1 file changed, 31 insertions(+), 24 deletions(-) diff --git a/tests/cl/api/set-kernel-arg.c b/tests/cl/a

Re: [Piglit] [PATCH 1/1] cl: Split setKernelArg into subtests

2016-03-09 Thread Jan Vesely
On Sat, 2016-03-05 at 16:18 +0100, Serge Martin wrote: > On Monday 29 February 2016 10:45:47 Jan Vesely wrote: > > > > Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> > > --- > > applies on top of Serge's changes. > In get-mem-object-info.c we only make s

[Piglit] [PATCH 1/1] cl: Split setKernelArg into subtests

2016-02-29 Thread Jan Vesely
Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- applies on top of Serge's changes. Jan tests/cl/api/set-kernel-arg.c | 24 ++-- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/tests/cl/api/set-kernel-arg.c b/tests/cl/api/set-kernel-arg.c index 4

Re: [Piglit] [PATCH 2/2] cl: clSetKernelArg test more args kind

2016-02-28 Thread Jan Vesely
rgc, >   /* >    * CL_INVALID_ARG_INDEX if arg_index is not a valid argument > index. >    */ > - test(kernel, 4, sizeof(cl_float), _num, > + test(kernel, 11, sizeof(cl_float), _num, >    CL_INVALID_ARG_INDEX, , >    "Tr

Re: [Piglit] [PATCH 1/2] cl: clSetKernelArg check for image support

2016-02-28 Thread Jan Vesely
evice_id device) > +{ > + cl_bool *has_image = > + piglit_cl_get_device_info(device, > CL_DEVICE_IMAGE_SUPPORT); > + > + if (!*has_image) { > + fprintf(stdout, "No image support. Sampler arg won't > be tested\n"); It would be nicer to use subtests

Re: [Piglit] [PATCH 1/2] cl: Add suport for builtins with multiple outputs

2016-02-23 Thread Jan Vesely
ank you, Jan > > On Thu, Feb 18, 2016 at 2:25 PM, Jan Vesely <jan.ves...@rutgers.edu> > wrote: > > > Hi, > > > > > > I plan to push both patches by the end of the week unless anyone > > objects. still a RB would be nice if anyone can spare some time.

Re: [Piglit] [PATCH 1/2] cl: Add suport for builtins with multiple outputs

2016-02-18 Thread Jan Vesely
Hi, I plan to push both patches by the end of the week unless anyone objects. still a RB would be nice if anyone can spare some time. thank you, Jan On Fri, 2016-02-05 at 12:34 -0500, Jan Vesely wrote: > On Thu, 2016-02-04 at 22:15 -0600, Aaron Watry wrote: > > Type-o in the subjec

Re: [Piglit] [PATCH] cl/math: Add some basic ilogb builtin tests

2016-02-11 Thread Jan Vesely
On Wed, 2016-02-10 at 20:57 -0600, Aaron Watry wrote: > Note: Doesn't test 0 or NaN as those inputs support multiple possible > output values. I guess FP_ILOGB{0,NAN} are available only in CLC. Reviewed-by: Jan Vesely <jan.ves...@rutgers.edu> > > Signed-off-by: Aaron Watry

Re: [Piglit] [PATCH] cl: Add frexp generated tests

2016-02-05 Thread Jan Vesely
On Thu, 2016-02-04 at 22:00 -0600, Aaron Watry wrote: > Tested on MacOS Intel CPU CL and GeForce 9400M. > > Signed-off-by: Aaron Watry <awa...@gmail.com> Reviewed-by: Jan Vesely <jan.ves...@rutgers.edu> passes on AMD Turks and Kaveri with your libclc patch > --- >

Re: [Piglit] [PATCH 1/2] cl: Add suport for builtins with multiple outputs

2016-02-05 Thread Jan Vesely
On Thu, 2016-02-04 at 22:15 -0600, Aaron Watry wrote: > Type-o in the subject (Suport). > > On Wed, Feb 3, 2016 at 6:37 PM, Jan Vesely <jan.ves...@rutgers.edu> > wrote: > > > Reuses parts of Tom's fract test patch. > > There is no change in generated tests with

[Piglit] [PATCH 2/2] cl: Add generated tests for fract

2016-02-03 Thread Jan Vesely
From: Tom Stellard v2 (jan): Drop custom generator in favour of new multiple output mechanism Passes on Intel CPU OCL and nVidia Clover on Kaveri has issues (0x3e instead of 0x3f) --- generated_tests/gen_cl_math_builtins.py | 12

[Piglit] [PATCH 1/2] cl: Add suport for builtins with multiple outputs

2016-02-03 Thread Jan Vesely
Reuses parts of Tom's fract test patch. There is no change in generated tests with single output Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- generated_tests/genclbuiltins.py | 108 --- 1 file changed, 79 insertions(+), 29 deletions(-) diff

[Piglit] [PATCH 1/1] cl: Don't warn when using deprecated functions.

2016-01-15 Thread Jan Vesely
Deprecated features are required to be supported until they are removed. Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- tests/cl/api/get-image-info.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/tests/cl/api/get-image-info.c b/tests/cl/api/get

[Piglit] [PATCH RESEND 1/1] cl: Extend program scope arrays with more types

2016-01-15 Thread Jan Vesely
Signed-off-by: Jan Vesely <jan.ves...@rutgers.edu> --- This used to trigger failure when LLVM put different types in different .rodata sections. Now there are no .rodata sections for radeon, but I think we should still test it. Jan tests/cl/program/execute/program-scope-arrays.cl

Re: [Piglit] [PATCH] CL: Fix check of ULP when probing float/double results

2016-01-03 Thread Jan Vesely
  regards, Jan (*) even is a bit misnomer since all SP floats >= 2.24 are even, I assume it means that mantissa is even > > --Aaron > > On Sun, Jun 14, 2015 at 4:19 PM, Jan Vesely <jan.ves...@rutgers.edu> > wrote: > > > On Sat, 2015-06-13 at 21:22 -0500,

Re: [Piglit] [PATCH] generated_tests/builtin_function.py: fix running with python 3.x

2015-11-11 Thread Jan Vesely
On Wed, 2015-11-11 at 15:02 -0800, baker.dyla...@gmail.com wrote: > From: Dylan Baker <baker.dyla...@gmail.com> > > The current code works under python 2.7, but not python 3.x. This > patch > corrects that by making the code work for both. Fixes the build for me. Tested-by

Re: [Piglit] [PATCH] generated_tests/builtin_function.py: hide RuntimeWarnings

2015-11-10 Thread Jan Vesely
e 1284, in _make_vector_or_matrix_test_vectors with warnings.catch_warnings(RuntimeWarning): TypeError: __init__() takes 1 positional argument but 2 were given $ python3 --version Jan > ___ > Piglit mailing list > Piglit@lists.freedesktop.org > http://lists.freedesktop.org/mailman

Re: [Piglit] [PATCH v2] gles-3.0: NV_read_depth extension test

2015-10-14 Thread Jan Vesely
On Mon, 2015-10-12 at 15:42 +0300, Tapani Pälli wrote: > v2: review feedback from Iago Toral and Ian Romanick > > Signed-off-by: Tapani Pälli > --- > tests/all.py | 5 + > tests/spec/gles-3.0/CMakeLists.gles3.txt | 1 + >

Re: [Piglit] [PATCH] cl: Update integer/long limit tests to detect incorrect storage sizes

2015-10-03 Thread Jan Vesely
gt; v2: Remove char/short modifications. > Test *_MAX vectorization as well as _MIN for int/long > > CC: Jan Vesely <jan.ves...@rutgers.edu> > Reported-By: Moritz Pflanzer <moritz.pflanze...@imperial.ac.uk> > Signed-off-by: Aaron Watry <awa...@gmail.com> I'm still

Re: [Piglit] [PATCH 2/2] cl: add printf builtin

2015-10-03 Thread Jan Vesely
"%s\n", "test_printf"); > +} It'd be nice to have more than just build test for printf, but it can be added later. For both patches: Reviewed-by: Jan Vesely <jan.ves...@rutgers.edu> Jan -- Jan Vesely <jan.ves...@rutgers.edu> signature.asc Description: This is

Re: [Piglit] [PATCH 2/2] cl: Change data types of char/short buffers in integer limits tests

2015-09-25 Thread Jan Vesely
On Tue, 2015-09-22 at 09:11 -0500, Aaron Watry wrote: > On Tue, Sep 22, 2015 at 12:02 AM, Jan Vesely <jan.ves...@rutgers.edu> > wrote: > > > On Mon, 2015-09-21 at 23:07 -0500, Aaron Watry wrote: > > > On Thu, Sep 17, 2015 at 7:06 PM, Jan Vesely < > >

Re: [Piglit] [PATCH 2/2] cl: Change data types of char/short buffers in integer limits tests

2015-09-21 Thread Jan Vesely
On Mon, 2015-09-21 at 23:07 -0500, Aaron Watry wrote: > On Thu, Sep 17, 2015 at 7:06 PM, Jan Vesely <jan.ves...@rutgers.edu> > wrote: > > > On Thu, 2015-09-17 at 10:34 -0500, Aaron Watry wrote: > > > On Wed, Sep 16, 2015 at 7:33 PM, Jan Vesely < > >

Re: [Piglit] [PATCH] cl: add clEnqueueMigrateMemObjects

2015-09-20 Thread Jan Vesely
On Fri, 2015-09-18 at 13:32 +0200, Serge Martin wrote: > On Thursday 17 September 2015 19:30:41 Jan Vesely wrote: > > On Sat, 2015-09-12 at 14:53 +0200, Serge Martin wrote: > > > On Thursday 13 August 2015 23:14:23 Serge Martin wrote: > > > > > > > > &g

Re: [Piglit] [PATCH 2/2] cl: Change data types of char/short buffers in integer limits tests

2015-09-17 Thread Jan Vesely
On Thu, 2015-09-17 at 10:34 -0500, Aaron Watry wrote: > On Wed, Sep 16, 2015 at 7:33 PM, Jan Vesely <jan.ves...@rutgers.edu> > wrote: > > > On Wed, 2015-09-16 at 17:18 -0500, Aaron Watry wrote: > > > On Tue, Sep 15, 2015 at 9:42 AM, Jan Vesely < > >

Re: [Piglit] [PATCH 2/2] cl: Change data types of char/short buffers in integer limits tests

2015-09-16 Thread Jan Vesely
On Wed, 2015-09-16 at 17:18 -0500, Aaron Watry wrote: > On Tue, Sep 15, 2015 at 9:42 AM, Jan Vesely <jan.ves...@rutgers.edu> > wrote: > > > > > > > On Tue, Sep 15, 2015 at 7:28 AM, Jan Vesely <jan.ves...@rutgers.edu > > > > > wrote: > &

<    1   2   3   4   >