[Piglit] [PATCH] framework/test: allow to set extra args with PIGLIT_VKRUNNER_EXTRA_ARGS

vkrunner recently added a new option (--device-id=) for selecting the physical device. This is quite useful in a multi-GPU scenario. This allows to set some vkrunner options via vkrunner:extra_args in the configuration file or with PIGLIT_VKRUNNER_EXTRA_ARGS. Signed-off-by: Samuel Pitoiset

Re: [Piglit] [PATCH v3] arb_bindless_texture: add test where we pass a handle through a function

Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> Thanks Karol. On 04/25/2018 12:09 PM, Karol Herbst wrote: currently fails in mesa with: ir_dereference_variable @ 0x1446830 specifies undeclared variable `wrongHandle' @ 0xffd1b0 v2: add image test convert to compile

Re: [Piglit] [PATCH v2 5/5] arb_bindless_texture: add test for conversion of bound sampler or image to uvec2

Patches 1,2,3,5 are: Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> Sorry for the delay. On 04/12/2018 12:58 PM, Karol Herbst wrote: conversion of bounded sampler2D to uvec2 is legal with ARB_bindless_texture. Currently Mesa fails with an assert: ../src/compile

Re: [Piglit] [PATCH v2 4/5] arb_bindless_texture: add test where we pass a handle through a function

On 04/12/2018 12:58 PM, Karol Herbst wrote: currently fails in mesa with: ir_dereference_variable @ 0x1446830 specifies undeclared variable `wrongHandle' @ 0xffd1b0 v2: add image test convert to compiler test quote the spec Signed-off-by: Karol Herbst ---

Re: [Piglit] [PATCH 3/3] arb_bindless_texture: rename vertex uniform test and add vertex attrib test

Same comment as the previous one. Images need to be tested. On 04/08/2018 10:56 PM, Karol Herbst wrote: Signed-off-by: Karol Herbst --- .../sampler-vertex-attrib-input-output.shader_test | 41 ++ ...ampler-vertex-uniform-input-output.shader_test} | 0

Re: [Piglit] [PATCH 2/3] arb_bindless_texture: add some uvec2 arithmetic test

Can you please write a similar test with bindless images? We usually have both tests. Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 04/08/2018 10:56 PM, Karol Herbst wrote: Signed-off-by: Karol Herbst <kher...@redhat.com> --- .../basic-arithmetic-uvec2-texture2D

Re: [Piglit] [PATCH 1/3] shader_runner: add vertex attrib command for setting bindless texture handles

support(); + parse_uint64s(line, uint64s, 1, NULL); parse_uints() is enough because it's an index in the resident_handles array (where the max is 31). With that changed, patch is: Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> + glVert

Re: [Piglit] [PATCH] arb_bindless_texture: add test where we pass a handle through a function

Can you please reference the spec as much as possible? See other ARB_bindless_texture if you need an example. More comments below. On 04/10/2018 12:32 PM, Karol Herbst wrote: currently fails in mesa with: ir_dereference_variable @ 0x1446830 specifies undeclared variable `wrongHandle' @

Re: [Piglit] [PATCH] ARB_shader_atomic_counter_ops: fix glsl version

Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 11/01/2017 11:25 PM, Timothy Arceri wrote: --- tests/spec/arb_shader_atomic_counter_ops/compiler/functions.frag | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/arb_shader_atomic_counter_ops/co

Re: [Piglit] [PATCH] compute: add more tests for verifying inter-shader derived values

Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 10/23/2017 02:20 AM, Ilia Mirkin wrote: In this case, the derived values are used in a shader that doesn't contain the main function. Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu> --- .../execution/separate

Re: [Piglit] [PATCH] arb_compute_variable_group_size: ensure local size works with fixed

Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 10/23/2017 12:12 AM, Ilia Mirkin wrote: The new gl_LocalGroupSizeARB variable is meant to work with fixed sizes as well. Test it. Signed-off-by: Ilia Mirkin <imir...@alum.mit.edu> --- .../execution/fixed-local-size

Re: [Piglit] [PATCH] compute: add test variants for local_size decls in other shaders

Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 10/22/2017 11:58 PM, Ilia Mirkin wrote: Only one shader is required to have a local_size layout, and it's not required to be the one with the main function. Add tests which verify that these derived values are properly co

Re: [Piglit] [PATCH] draw-pixels: fix KHR_no_error logic

On 08/25/2017 06:08 AM, Timothy Arceri wrote: On 23/08/17 17:23, Samuel Pitoiset wrote: On 08/23/2017 06:11 AM, Timothy Arceri wrote: ---   This was my fault. The flaw was in my suggestion from the code   review. You probably need to use PIGLIT_HAS_ERRORS as well. I don't think so

Re: [Piglit] [PATCH] draw-pixels: fix KHR_no_error logic

On 08/23/2017 06:11 AM, Timothy Arceri wrote: --- This was my fault. The flaw was in my suggestion from the code review. You probably need to use PIGLIT_HAS_ERRORS as well. tests/general/draw-pixels.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [Piglit] [PATCH 50/50] general: add missing KHR_no_error status

On 08/22/2017 06:45 AM, Timothy Arceri wrote: On 11/08/17 01:22, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> ---   tests/general/draw-pixels.c   |  2 ++   tests/general/geterror-inside-begin.c |  2 ++   tests/general/geterror-invalid-enum.

Re: [Piglit] [PATCH 44/50] gl-2.0: set KHR_no_error status

On 08/22/2017 02:15 AM, Timothy Arceri wrote: On 11/08/17 01:22, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> ---   tests/spec/gl-2.0/api/active-sampler-conflict.c |  1 +   tests/spec/gl-2.0/api/clip-flag-behavior.c

Re: [Piglit] [PATCH 42/50] arb_texture_view: set KHR_no_error status

On 08/22/2017 02:06 AM, Timothy Arceri wrote: On 11/08/17 01:22, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> ---   tests/spec/arb_texture_view/clear-into-view-2d-array.c   |  1 +   tests/spec/arb_texture_view/clear-into-view-2d.c   

Re: [Piglit] [PATCH 33/50] arb_occlusion_query2: set KHR_no_error status

On 08/21/2017 09:38 AM, Timothy Arceri wrote: On 11/08/17 01:22, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_occlusion_query2/api.c| 34 +--- tests/spec/arb_occlusion_query2/render.c | 1

[Piglit] [PATCH] glsl-4.50: add test that makes sure extra semicolons are forbidden

Only allowed with GLSL 4.60. Cc: Ilia Mirkin <imir...@alum.mit.edu> Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- .../glsl-4.50/compiler/extra-semilons-at-global-scope.frag | 12 1 file changed, 12 insertions(+) create mode 100644 tests/spec/glsl-4

Re: [Piglit] [PATCH 2/2] glsl-4.60: add a test that allows extra semicolons at global scope

On 08/10/2017 07:04 PM, Ilia Mirkin wrote: And an identical test to make sure it's disallowed at earlier GLSL versions? I see no such test already. I can do that yeah. On Thu, Aug 10, 2017 at 12:44 PM, Samuel Pitoiset <samuel.pitoi...@gmail.com> wrote: Cc: Ian Romanick <ia

[Piglit] [PATCH 2/2] glsl-4.60: add a test that allows extra semicolons at global scope

Cc: Ian Romanick <ian.d.roman...@intel.com> Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- .../compiler/extra-semilons-at-global-scope.frag| 17 + 1 file changed, 17 insertions(+) create mode 100644 tests/spec/glsl-4.60/compiler/extra-semilo

[Piglit] [PATCH 47/50] gl-3.2: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/gl-3.2/adj-prims.c | 1 + tests/spec/gl-3.2/basevertex-vertexid.c | 1 + tests/spec/gl-3.2/clear-no-buffers.c | 1 + tests/spec/gl-3.2

[Piglit] [PATCH 48/50] gl-3.3: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/gl-3.3/minmax.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/gl-3.3/minmax.c b/tests/spec/gl-3.3/minmax.c index 964e49964..2eae411b5 100644 --- a/tests/spec/gl-3.3/minmax.c +++ b/tests/spec/gl-3.3/mi

[Piglit] [PATCH 43/50] arb_vertex_attrib_64bit: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- .../execution/check-explicit-location.c| 2 ++ .../execution/double_attribs.c | 22 +- .../execution/getactiveattrib.c| 1 + .../execution/max-vertex-at

[Piglit] [PATCH 50/50] general: add missing KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/general/draw-pixels.c | 2 ++ tests/general/geterror-inside-begin.c | 2 ++ tests/general/geterror-invalid-enum.c | 2 ++ tests/general/masked-clear.c | 1 + tests/general/roundmode-pixelstore.c

[Piglit] [PATCH 49/50] gl-4.5: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/gl-4.5/compare-framebuffer-parameter-with-get.c | 2 ++ tests/spec/gl-4.5/named-framebuffer-draw-buffers-errors.c | 2 ++ tests/spec/gl-4.5/named-framebuffer-read-buffer-errors.c | 2 ++ 3 files changed, 6 inse

[Piglit] [PATCH 46/50] gl-3.1: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/gl-3.1/default-vao.c | 1 + tests/spec/gl-3.1/draw-buffers-errors.c | 1 + tests/spec/gl-3.1/enable-vertex-array.c | 16 ++-- tests/spec/gl-3.1/genned-names.c | 1 + tests/spec/

[Piglit] [PATCH 38/50] arb_sync: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_sync/ClientWaitSync-errors.c | 1 + tests/spec/arb_sync/ClientWaitSync-timeout.c | 1 + tests/spec/arb_sync/DeleteSync.c | 9 ++--- tests/spec/arb_sync/FenceSync-errors.c | 1 + test

[Piglit] [PATCH 35/50] arb_provoking_vertex: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_provoking_vertex/provoking-vertex-control.c | 1 + tests/spec/arb_provoking_vertex/provoking-vertex-initial.c | 1 + tests/spec/arb_provoking_vertex/quads-follow-provoking-vertex.c | 1 + test

[Piglit] [PATCH 45/50] gl-3.0: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- .../gl-3.0/api/bindfragdata-invalid-parameters.c | 1 + tests/spec/gl-3.0/api/bindfragdata-link-error.c| 1 + .../gl-3.0/api/bindfragdata-nonexistent-variable.c | 1 + tests/spec/gl-3.0/api/clearbuffer-common.c

[Piglit] [PATCH 36/50] arb_shader_objects: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_shader_objects/bindattriblocation-scratch-name.c | 2 ++ tests/spec/arb_shader_objects/clear-with-deleted.c| 8 ++-- tests/spec/arb_shader_objects/delete-repeat.c

[Piglit] [PATCH 44/50] gl-2.0: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/gl-2.0/api/active-sampler-conflict.c | 1 + tests/spec/gl-2.0/api/clip-flag-behavior.c | 33 ++--- 2 files changed, 19 insertions(+), 15 deletions(-) diff --git a/tests/spec/gl-2.0/api/

[Piglit] [PATCH 33/50] arb_occlusion_query2: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_occlusion_query2/api.c| 34 +--- tests/spec/arb_occlusion_query2/render.c | 1 + 2 files changed, 24 insertions(+), 11 deletions(-) diff --git a/tests/spec/arb_occlusion_query2/ap

[Piglit] [PATCH 30/50] arb_framebuffer_no_attachments: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_framebuffer_no_attachments/atomic.c | 1 + tests/spec/arb_framebuffer_no_attachments/minmax.c | 1 + tests/spec/arb_framebuffer_no_attachments/params.c | 1 + test

[Piglit] [PATCH 28/50] arb_debug_output: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_debug_output/api_error.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/spec/arb_debug_output/api_error.c b/tests/spec/arb_debug_output/api_error.c index 596092f45..43294fbfb 100644 --- a/test

[Piglit] [PATCH 42/50] arb_texture_view: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_texture_view/clear-into-view-2d-array.c | 1 + tests/spec/arb_texture_view/clear-into-view-2d.c | 1 + tests/spec/arb_texture_view/clear-into-view-layered.c| 1 + tests/spec/arb_textur

[Piglit] [PATCH 39/50] arb_texture_cube_map_array: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_texture_cube_map_array/cubemap-lod.c | 1 + tests/spec/arb_texture_cube_map_array/cubemap.c | 1 + tests/spec/arb_texture_cube_map_array/fbo-cubemap-array.c | 1 + test

[Piglit] [PATCH 41/50] arb_texture_storage_multisample: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_texture_storage_multisample/tex-param.c | 2 ++ tests/spec/arb_texture_storage_multisample/tex-storage.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tests/spec/arb_texture_storage_multisample/tex-para

[Piglit] [PATCH 40/50] arb_texture_rectangle: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_texture_rectangle/texrect-simple.c | 1 + tests/spec/arb_texture_rectangle/texture-base-level-error.c | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/spec/arb_texture_rectangle/texrect-simpl

[Piglit] [PATCH 29/50] arb_explicit_uniform_location: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_explicit_uniform_location/array-elements.c| 1 + tests/spec/arb_explicit_uniform_location/inactive-uniform.c | 1 + tests/spec/arb_explicit_uniform_location/loc-boundaries.c| 1 + test

[Piglit] [PATCH 34/50] arb_occlusion_query: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- .../spec/arb_occlusion_query/gen_delete_while_active.c | 18 +++--- tests/spec/arb_occlusion_query/occlusion_query.c | 1 + .../spec/arb_occlusion_query/occlusion_query_conform.

[Piglit] [PATCH 37/50] arb_shading_language_420pack: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- .../arb_shading_language_420pack/execution/active-sampler-conflict.c| 2 ++ tests/spec/arb_shading_language_420pack/execution/binding-layout.c | 1 + .../arb_shading_language_420pack/execution/multiple-layout-qualifiers

[Piglit] [PATCH 26/50] arb_texture_stencil8: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_texture_stencil8/draw.c| 1 + tests/spec/arb_texture_stencil8/fbo-stencil8.c| 1 + tests/spec/arb_texture_stencil8/getteximage.c | 1 + tests/spec/arb_texture_stencil8/stencil-texture.

[Piglit] [PATCH 31/50] arb_gpu_shader_fp64: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_gpu_shader_fp64/double_in_bool_uniform.c | 1 + .../arb_gpu_shader_fp64/execution/double-gettransformfeedbackvarying.c | 1 + tests/spec/arb_gpu_shader_fp64/execution/fs-getunifo

[Piglit] [PATCH 23/50] arb_get_program_binary: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_get_program_binary/api-errors.c | 1 + tests/spec/arb_get_program_binary/overrun.c | 1 + tests/spec/arb_get_program_binary/retrievable_hint.c | 1 + 3 files changed, 3 insertions(+) diff --git a

[Piglit] [PATCH 22/50] arb_program_interface_query: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- .../spec/arb_program_interface_query/compare-with-shader-subroutine.c | 1 + tests/spec/arb_program_interface_query/getprograminterfaceiv.c| 1 + tests/spec/arb_program_interface_query/getprogramresourceindex.c

[Piglit] [PATCH 24/50] khr_debug: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/khr_debug/debug-object-label.c | 1 + tests/spec/khr_debug/debug-push-pop-group.c | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/spec/khr_debug/debug-object-label.c b/tests/spec/khr_debug/debug-

[Piglit] [PATCH 32/50] arb_internalformat_query2: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_internalformat_query2/api-errors.c | 1 + tests/spec/arb_internalformat_query2/color-encoding.c | 1 + tests/spec/arb_internalformat_query2/filter.c

[Piglit] [PATCH 20/50] arb_clear_buffer_object: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_clear_buffer_object/formats.c | 1 + tests/spec/arb_clear_buffer_object/invalid-internal-format.c | 1 + tests/spec/arb_clear_buffer_object/invalid-size.c| 1 + test

[Piglit] [PATCH 12/50] ext_texture_array: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/ext_texture_array/errors.c | 1 + tests/spec/ext_texture_array/gen-mipmap.c | 1 + tests/spec/ext_texture_array/maxlayers.c | 1 + 3 files changed, 3 insertions(+) diff --git a/tests/spec/ext_texture_array/error

[Piglit] [PATCH 16/50] arb_transform_feedback3: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_transform_feedback3/begin_end.c | 1 + .../arb_transform_feedback3/bind_buffer_invalid_index.c | 1 + .../draw_using_invalid_stream_index.c| 1 + .../arb_transform_fee

[Piglit] [PATCH 18/50] arb_tessellation_shader: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_tessellation_shader/get-tcs-params.c | 1 + tests/spec/arb_tessellation_shader/get-tes-params.c | 1 + tests/spec/arb_tessellation_shader/invalid-get-program-params.c | 1 + test

[Piglit] [PATCH 27/50] arb_clear_texture: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_clear_texture/3d.c | 2 ++ tests/spec/arb_clear_texture/base-formats.c| 2 ++ tests/spec/arb_clear_texture/clear-max-level.c | 1 + tests/spec/arb_clear_texture/cube.c| 1 + test

[Piglit] [PATCH 15/50] arb_transform_feedback_overflow_query: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_transform_feedback_overflow_query/basic.c | 1 + tests/spec/arb_transform_feedback_overflow_query/errors.c | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/spec/arb_transform_feedback_overflow_query/b

[Piglit] [PATCH 25/50] nv_conditional_render: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/nv_conditional_render/begin-while-active.c | 1 + tests/spec/nv_conditional_render/begin-zero.c | 1 + tests/spec/nv_conditional_render/bitmap.c | 1 + tests/spec/nv_conditional_render/blitframebu

[Piglit] [PATCH 21/50] arb_timer_query: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_timer_query/timestamp-get.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/arb_timer_query/timestamp-get.c b/tests/spec/arb_timer_query/timestamp-get.c index 9ff6ee7c3..39676c692 100644 --- a/test

[Piglit] [PATCH 11/50] ext_packet_float: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/ext_packed_float/getteximage-invalid-format-for-packed-type.c | 1 + tests/spec/ext_packed_float/pack.c | 1 + 2 files changed, 2 insertions(+) diff --git a/test

[Piglit] [PATCH 19/50] arb_texture_buffer_range: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_texture_buffer_range/dlist.c| 1 + tests/spec/arb_texture_buffer_range/errors.c | 1 + tests/spec/arb_texture_buffer_range/ranges-2.c | 1 + tests/spec/arb_texture_buffer_range/ranges.c | 1 + 4 files chan

[Piglit] [PATCH 17/50] arb_texture_storage: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_texture_storage/attach-before-storage.c | 1 + tests/spec/arb_texture_storage/texture-storage.c | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/spec/arb_texture_storage/attach-before-storage.c b

[Piglit] [PATCH 05/50] arb_multisample: fix KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_multisample/beginend.c | 2 ++ tests/spec/arb_multisample/pushpop.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/tests/spec/arb_multisample/beginend.c b/tests/spec/arb_multisample/beginend.c index 5d2

[Piglit] [PATCH 14/50] arb_vertex_array_bgra: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_vertex_array_bgra/api-errors.c | 1 + tests/spec/arb_vertex_array_bgra/get.c| 1 + 2 files changed, 2 insertions(+) diff --git a/tests/spec/arb_vertex_array_bgra/api-errors.c b/tests/spec/arb_vertex_arra

[Piglit] [PATCH 01/50] arb_draw_elements_base_vertex: fix KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_draw_elements_base_vertex/dlist.c | 1 + tests/spec/arb_draw_elements_base_vertex/multidrawelements.c | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/spec/arb_draw_elements_base_vertex/dlis

[Piglit] [PATCH 02/50] arb_draw_instanced: fix KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_draw_instanced/execution/dlist.c | 1 + tests/spec/arb_draw_instanced/execution/negative-arrays-first-negative.c | 1 + tests/spec/arb_draw_instanced/execution/negative-elements-

[Piglit] [PATCH 04/50] arb_map_buffer_range: fix KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_map_buffer_range/map_buffer_range_error_check.c | 2 ++ tests/spec/arb_map_buffer_range/map_buffer_range_test.c| 2 ++ 2 files changed, 4 insertions(+) diff --git a/tests/spec/arb_map_buffer

[Piglit] [PATCH 08/50] ext_texture_swizzle: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/ext_texture_swizzle/api.c | 12 +++- .../ext_texture_swizzle/depth_texture_mode_and_swizzle.c | 1 + tests/spec/ext_texture_swizzle/swizzle.c | 1 + 3 files c

[Piglit] [PATCH 07/50] arb_transform_feedback2: set KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_transform_feedback2/api-queries.c | 1 + .../spec/arb_transform_feedback2/cannot-bind-when-active.c | 13 + .../arb_transform_feedback2/change-objects-while-paused.c | 1 + test

[Piglit] [PATCH 03/50] arb_instanced_arrays: fix KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_instanced_arrays/vertex-attrib-divisor-index-error.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/arb_instanced_arrays/vertex-attrib-divisor-index-error.c b/tests/spec/arb_instanced_arrays/

[Piglit] [PATCH 06/50] arb_robustness: fix KHR_no_error status

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_robustness/client-mem-bounds.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/arb_robustness/client-mem-bounds.c b/tests/spec/arb_robustness/client-mem-bounds.c index cbc0923e7..b67907cd7

Re: [Piglit] [PATCH] arb_direct_state_access: adapt to spec fixes in OpenGL 4.6

Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 08/09/2017 09:27 AM, Iago Toral Quiroga wrote: TextureStorage* functions should produce INVALID_OPERATION instead of INVALID_ENUM when the target is not valid. --- tests/spec/arb_direct_state_access/getcompressedtextureimage

Re: [Piglit] [PATCHi V2] ext_memory_object: add some basic api error checks

Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 08/06/2017 06:48 AM, Timothy Arceri wrote: This only tests for errors when is 0, but its a start. v2: - make use of piglit_check_gl_error() - shorten spec quote Cc: Samuel Pitoiset <samuel.pitoi...@gmail.com> ---

Re: [Piglit] [PATCH 2/2] ext_memory_object: add some basic api error checks

On 08/04/2017 03:43 AM, Timothy Arceri wrote: This only tests for errors when is 0, but its a start. --- tests/all.py | 6 + tests/spec/CMakeLists.txt | 1 + tests/spec/ext_memory_object/CMakeLists.gl.txt | 14 ++

Re: [Piglit] [PATCH 2/2] ext_memory_object: add some basic api error checks

1/2 got lost? On 08/04/2017 03:43 AM, Timothy Arceri wrote: This only tests for errors when is 0, but its a start. --- tests/all.py | 6 + tests/spec/CMakeLists.txt | 1 + tests/spec/ext_memory_object/CMakeLists.gl.txt | 14 ++

[Piglit] [PATCH] arb_bindless_texture: add a test which sets mixed texture units/handles

This test currently fails to return the correct 64-bit handle value with Mesa. This is because it ends up by performing the slower convert-and-copy process instead of just memcpy'ing the value. Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_bindless_t

Re: [Piglit] [PATCH 1/8] ext_framebuffer_multisample: set KHR_no_error status

Thanks! For the series: Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 07/06/2017 05:53 AM, Timothy Arceri wrote: --- .../spec/ext_framebuffer_multisample/alpha-blending-after-rendering.c | 1 + .../ext_framebuffer_multisample/alpha-to-coverage-dual-src-blend.cp

Re: [Piglit] [PATCH] arb_texture_buffer_object: set KHR_no_error support

Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 07/06/2017 06:41 AM, Timothy Arceri wrote: Here we also move some of the config setup to the top of the file as this is the layout of piglit tests everywhere else in piglit. --- tests/spec/arb_texture_buffer_object/buffersto

Re: [Piglit] [PATCH 01/10] arb_shader_atomic_counters: fix KHR_no_error support for buffer binding test

For the series: Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 07/05/2017 07:23 AM, Timothy Arceri wrote: --- tests/spec/arb_shader_atomic_counters/buffer-binding.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/test

Re: [Piglit] [PATCH] bugs: set KHR_no_error support for remaining bugs tests

Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 06/29/2017 07:39 AM, Timothy Arceri wrote: --- tests/bugs/crash-cubemap-order.c| 1 + tests/bugs/crash-texparameter-before-teximage.c | 1 + tests/bugs/drawbuffer-modes.c | 1 + test

Re: [Piglit] [PATCH] gl-1.0: set KHR_no_error support for remaining gl-1.0 tests

Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 06/29/2017 08:07 AM, Timothy Arceri wrote: --- tests/spec/gl-1.0/blend.c | 1 + tests/spec/gl-1.0/dlist-bitmap.c| 1 + tests/spec/gl-1.0/dlist-shademodel.c

Re: [Piglit] [PATCH] ARB_blend_func_extended: set KHR_no_error status

Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 06/29/2017 08:24 AM, Timothy Arceri wrote: --- .../api/bindfragdataindexed-invalid-parameters.c | 1 + tests/spec/arb_blend_func_extended/api/blend-api.c| 1 + tests/spec/arb_blend_func_extended/api/builtins.c

[Piglit] [PATCH] ext_packed_depth_stencil: set KHR_no_error compatibility

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/ext_packed_depth_stencil/depth-stencil-texture.c | 1 + tests/spec/ext_packed_depth_stencil/errors.c| 8 ++-- tests/spec/ext_packed_depth_stencil/getteximage.c | 1 + test

Re: [Piglit] [PATCH] fbo: set KHR_no_error compatibility for remaining fbo tests

On 06/27/2017 02:19 AM, Timothy Arceri wrote: On 26/06/17 19:04, Samuel Pitoiset wrote: Looks like you forgot to update fbo-storage-formats.c. It's updated. Did you mean something else? I meant, there is a GL_INVALID_ENUM which is not handled correctly, no? With that fixed, patch

Re: [Piglit] [PATCH] fbo: set KHR_no_error compatibility for remaining fbo tests

Looks like you forgot to update fbo-storage-formats.c. With that fixed, patch is: Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> Thanks! On 06/26/2017 08:00 AM, Timothy Arceri wrote: --- tests/fbo/fbo-1d.c | 1 + tests/fbo/fb

[Piglit] [PATCH 2/3] amd_vertex_shader_viewport_index: set KHR_no_error compatibility

--- tests/spec/amd_vertex_shader_viewport_index/render.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/amd_vertex_shader_viewport_index/render.c b/tests/spec/amd_vertex_shader_viewport_index/render.c index a5c59c96b..a08cbe931 100644 ---

[Piglit] [PATCH 1/3] arb_clip_control: set KHR_no_error compatibility

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- .../clip-control-depth-precision.c | 1 + tests/spec/arb_clip_control/clip-control.c | 24 -- tests/spec/arb_clip_control/viewport.c | 1 + 3 files changed, 15 inse

Re: [Piglit] [PATCH] Revert "arb_get_texture_sub_image-errors: Fix expected error values"

Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 06/22/2017 05:50 PM, Juan A. Suarez Romero wrote: In commit aec149c we test that glGetTextureSubImage() and glGetCompressedTextureSubImage() returns INVALID_VALUE when the texture is not the name of an existing texture

[Piglit] [PATCH] arb_bindless_texture: set KHR_no_error compatibility

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/spec/arb_bindless_texture/border-color.c | 7 +++ tests/spec/arb_bindless_texture/conversions.c| 1 + tests/spec/arb_bindless_texture/errors.c | 1 + tests/spec/arb_bindless_texture/handles.c

Re: [Piglit] [PATCH] arb_bindless_texture: add new compiler tests for struct with image arrays

ping? On 05/25/2017 08:02 PM, Samuel Pitoiset wrote: Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- .../nested-struct-arrays-mismatch-format.frag | 27 .../nested-struct-with-arrays-no-qualifiers.frag | 29 ++ .../images/

Re: [Piglit] [PATCH 4/4] TexSubImage1D tests: set KHR_no_error status

Thanks for this patchset Tim. Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 06/05/2017 02:19 AM, Timothy Arceri wrote: --- tests/fbo/fbo-generatemipmap-1d.c | 1 + tests/spec/arb_texture_view/lifetime_format.c | 1 + tests/spec/arb_textur

Re: [Piglit] [PATCH 3/4] texturing/tex3d-maxsize: set KHR_no_error status

UAL_DOUBLE; +config.khr_no_error_support = PIGLIT_NO_ERRORS There is a missing ; here. Fixed locally. Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> PIGLIT_GL_TEST_CONFIG_END static GLint MaxSize; /** * Compute size (in megabytes) of a texture of the

Re: [Piglit] [PATCH 2/4] gl-3.2/layered-rendering: set KHR_no_error status

Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 06/05/2017 02:19 AM, Timothy Arceri wrote: --- tests/spec/gl-3.2/layered-rendering/blit.c | 1 + tests/spec/gl-3.2/layered-rendering/clear-color-all-types.c| 1 + .../layered-rendering/clear

Re: [Piglit] [PATCH 1/4] ARB_invalidate_subdata: set KHR_no_error status

Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 06/05/2017 02:19 AM, Timothy Arceri wrote: --- tests/spec/arb_invalidate_subdata/buffer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/spec/arb_invalidate_subdata/buffer.c b/tests/spec/arb_invalidate_subdata/bu

[Piglit] [PATCH] arb_bindless_texture: add new compiler tests for struct with image arrays

Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- .../nested-struct-arrays-mismatch-format.frag | 27 .../nested-struct-with-arrays-no-qualifiers.frag | 29 ++ .../images/struct-with-arrays-mismatch-format.fra

Re: [Piglit] [PATCH 7/7] arb_shader_storage_buffer_object: set KHR_no_error compatibility

Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 05/18/2017 04:00 AM, Timothy Arceri wrote: --- .../array-ssbo-binding.c | 1 + .../deletebuffers.c| 1 + .../getintegeri_v.c

Re: [Piglit] [PATCH 6/7] arb_shader_atomic_counters: set KHR_no_error compatibility

Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 05/18/2017 04:00 AM, Timothy Arceri wrote: --- .../arb_shader_atomic_counters/active-counters.c | 29 +- .../arb_shader_atomic_counters/array-indexing.c| 1 + .../arb_shader_atomic_counters/

[Piglit] [PATCH 1/2] shaders: set missing blue color to glsl-const-builtin-distance.shader_test

Since b741bc770 ("parser_utils: do not overwrite value when no digits are found "), the blue color has to be explicitly initialized to zero. Cc: Mark Janes <mark.a.ja...@intel.com> Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/shad

[Piglit] [PATCH 2/2] arb_gpu_shader_fp64: set missing 'w' component to glsl-uniform-initializer-4

Since b741bc770 ("parser_utils: do not overwrite value when no digits are found "), the 'w' component has to be explicitly initialized to zero. Cc: Mark Janes <mark.a.ja...@intel.com> Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- .../execution/glsl

Re: [Piglit] [PATCH 5/7] arb_indirect_parameters: set KHR_no_error compatibility

Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 05/18/2017 04:00 AM, Timothy Arceri wrote: --- tests/spec/arb_indirect_parameters/tf-count-arrays.c | 1 + tests/spec/arb_indirect_parameters/tf-count-elements.c | 1 + 2 files changed, 2 insertions(+) diff --git a/test

Re: [Piglit] [PATCH 3/7] arb_uniform_buffer_object: set KHR_no_error compatibility

As discussed offline, I missed the HAS_ERRORS bits. On 05/19/2017 11:18 AM, Samuel Pitoiset wrote: Few comments below, you missed all negative-* tests. With those fixed, patch is: Reviewed-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> On 05/18/2017 04:00 AM, Timothy Arceri

[Piglit] [PATCH] parser_utils: do not overwrite value when no digits are found

ture bound at 0". Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- tests/shaders/parser_utils.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/tests/shaders/parser_utils.c b/tests/shaders/parser_utils.c index 3b1400c47..

[Piglit] [PATCH 3/4] arb_bindless_texture: add new explicit-image-binding.shader_test

Similar to explicit-sampler-binding.shader_test but that one exercices the explicit binding layout qualifier with bound/bindless images. Signed-off-by: Samuel Pitoiset <samuel.pitoi...@gmail.com> --- .../images/explicit-image-binding.shader_test | 58 ++ 1 file c

  1   2   >