[Piglit] [PATCH] arb_tessellation_shader: fix broken compat gl_ClipVertex test

2019-08-01 Thread Timothy Arceri
The expected projection wasn't being applied. --- .../tes-clip-vertex-different-from-position.shader_test | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/spec/arb_tessellation_shader/execution/compatibility/tes-clip-vertex-different-from-position.shader_test

[Piglit] [PATCH] arb_get_program_binary: test restore of SSO program

2019-07-10 Thread Timothy Arceri
gram.c @@ -0,0 +1,94 @@ +/* + * Copyright (c) 2019 Timothy Arceri + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * t

Re: [Piglit] [PATCH] s3tc-errors: Fix GCC unused-function warning.

2019-05-06 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 7/5/19 3:02 am, Vinson Lee wrote: s3tc-errors.c:155:1: warning: ‘check_gl_error2_’ defined but not used [-Wunused-function] check_gl_error2_(GLenum err1, GLenum err2, int line) ^~~~ Fixes: Fixes: d433792407e7 ("s3tc-errors: port to g

[Piglit] [PATCH] glx: make sure contexts are destroyed before we exit the test

2019-04-12 Thread Timothy Arceri
Without this the last two contexts that are created will not have been destroyed when exiting the test. This creates a race condition in Mesa between any threads that might be using glsl_types and the atexit() callback that destroys these types. --- tests/glx/glx-multithread-shader-compile.c | 1

Re: [Piglit] [PATCH] arb_program_interface_query: corrected AoA's index variable expectation

2019-03-21 Thread Timothy Arceri
On 22/3/19 1:48 am, Andres Gomez wrote: On Sat, 2019-02-16 at 10:05 +1100, Timothy Arceri wrote: NAK. The problem is this will end up making the test fail on the Nvidia blob. Technically neither is incorrect, but the test does show Mesa's failure to detect the unused element. Again

[Piglit] [PATCH] glsl-1.10: test unreachable code in a loop is not accessed

2019-03-20 Thread Timothy Arceri
--- .../vs-loop-with-dead-code-unroll.shader_test | 43 +++ 1 file changed, 43 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/vs-loop-with-dead-code-unroll.shader_test diff --git a/tests/spec/glsl-1.10/execution/vs-loop-with-dead-code-unroll.shader_test

Re: [Piglit] [PATCH 01/10] arb_enhanced_layouts: corrected multiple comments

2019-03-20 Thread Timothy Arceri
On 2/2/19 4:55 am, Andres Gomez wrote: Cc: Timothy Arceri Signed-off-by: Andres Gomez --- .../vs-gs-fs-double.shader_test | 16 +++ .../vs-tcs-tes-fs-double.shader_test | 42 +-- ...-fs-type-mismatch-double-float.shader_test | 4 +- ...-fs

Re: [Piglit] [PATCH 02/10] arb_enhanced_layouts: GL_ARB_gpu_shader_fp64 requires GLSL 1.50

2019-03-20 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 2/2/19 4:55 am, Andres Gomez wrote: Cc: Timothy Arceri Signed-off-by: Andres Gomez --- .../compiler/component-layout/double-component-1.vert | 4 ++-- .../compiler/component-layout/double-component-3.vert | 4 ++-- .../compiler/component-layout

Re: [Piglit] [PATCH 03/10] arb_enhanced_layouts: correct interpolation qualifiers

2019-03-20 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 2/2/19 4:55 am, Andres Gomez wrote: Corrected several component aliasing tests which shouldn't be failing or were failing due to a different reason than the tested one: interpolation qualifiers mismatch. From Section 4.4.1 (Input Layout Qualifiers) of the GLSL

Re: [Piglit] [PATCH 04/10] arb_enhanced_layouts: add aliasing tests with mixed type widths

2019-03-20 Thread Timothy Arceri
onent." Cc: Timothy Arceri Cc: Iago Toral Quiroga Cc: Ilia Mirkin Signed-off-by: Andres Gomez --- .../type-mismatch-signed-double.vert | 59 +++ .../width-mismatch-float-double.vert | 59 +++ ...s-width-mismatch-double-float.shader_

[Piglit] [PATCH] glsl-1.10: test for crash in loop analysis

2019-03-18 Thread Timothy Arceri
This test for a crash in Mesa seen in an Assasins Creed Odyssey shader. --- ...riable-iteration-limit-unroll4.shader_test | 88 +++ 1 file changed, 88 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/vs-loop-variable-iteration-limit-unroll4.shader_test diff --git

[Piglit] [PATCH] glsl-1.10: test unrolling another loop with variable iteration limits

2019-02-25 Thread Timothy Arceri
This tests unrolling of a loop with a single exit point but where the exact trip count is unknown, only the max iteration count is known. Here we make sure that the and condition won't be simplified into a min() by another opt pass. --- ...riable-iteration-limit-unroll3.shader_test | 75

Re: [Piglit] [PATCH 0/3] arb_enhanced_layouts: minor clean-up and one bugfix

2019-02-20 Thread Timothy Arceri
series: Reviewed-by: Timothy Arceri Thanks! On 21/2/19 3:06 am, Alejandro Piñeiro wrote: We found this issues while working with ARB_gl_spirv, but all those are independent of it, so we are sending independently. Alejandro Piñeiro (2): arb_enhanced_layouts: don't call glLinkProgram twice

Re: [Piglit] [PATCH] arb_separate_shader_objects: add rendez-vous-by mismatch tests

2019-02-15 Thread Timothy Arceri
Thanks! Reviewed-by: Timothy Arceri ___ Piglit mailing list Piglit@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/piglit

Re: [Piglit] [PATCH 2/2] arb_program_interface_query: correct rendez-vous by name matching

2019-02-15 Thread Timothy Arceri
It would be great if you could run this test on the Nvidia binary blob to confirm the results. If everything works as expected the series is: Reviewed-by: Timothy Arceri Thanks for fixing all this! On 9/2/19 3:57 am, Andres Gomez wrote: Previuosly, this was overlooked asuming that, since

Re: [Piglit] [PATCH] arb_program_interface_query: corrected AoA's index variable expectation

2019-02-15 Thread Timothy Arceri
ormed by concatenating the name of the array, the "[" character, an integer identifying the element number, and the "]" character. These enumeration rules are applied recursively, treating each enumerated array element as a separate active variable.

Re: [Piglit] [PATCH v2 10/10] arb_enhanced_layouts: add xfb_offset overlap test

2019-02-06 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 7/2/19 2:52 am, Andres Gomez wrote: From the GL_ARB_enhanced_layouts spec: " No aliasing in output buffers is allowed: It is a compile-time or link-time error to specify variables with overlapping transform feedback offsets." v2: added

Re: [Piglit] [PATCH 09/10] arb_enhanced_layouts: add another xfb_stride overflow test

2019-02-02 Thread Timothy Arceri
On 3/2/19 7:30 am, Andres Gomez wrote: On Sat, 2019-02-02 at 10:15 +1100, Timothy Arceri wrote: On 2/2/19 4:55 am, Andres Gomez wrote: Additional check to address a bug in mesa in which a stride which is a divisor of the declared offset for an overflowing varying won't fail. From

Re: [Piglit] [PATCH 05/10] arb_enhanced_layouts: correct component usage with dvec{3, 4} tests

2019-02-01 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 2/2/19 4:55 am, Andres Gomez wrote: There was a pre-existing test using "component = 0" with dvec3 which was not failing as it should. This was because the other tests checking for the usage of the component keyword with dvec3 and dvec4 were f

Re: [Piglit] [PATCH 06/10] arb_separate_shader_objects: add location overlapping tests

2019-02-01 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 2/2/19 4:55 am, Andres Gomez wrote: New tests for location overlap with scalars, doubles and for duplicated inputs which match the same output variable in the previous stage. From the ARB_separate_shader_objects spec v.25: " * An output var

Re: [Piglit] [PATCH 08/10] arb_separate_shader_objects: add unused location qualified input test

2019-02-01 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 2/2/19 4:55 am, Andres Gomez wrote: New tests to check that an unused input varying, which would be matched based on its explicit location, won't cause a link failure if there is no matching output variable. From the ARB_separate_shader_objects spec v.25

[Piglit] [PATCH] arb_gpu_shader5: add more variants of the struct interpolateAt tests

2019-01-21 Thread Timothy Arceri
--- ...ateAtCentroid-array-of-structs.shader_test | 63 +++ ...-interpolateAtCentroid-struct2.shader_test | 59 + 2 files changed, 122 insertions(+) create mode 100644

Re: [Piglit] [PATCH] Test that ES frag shader with invariant outputs compiles

2019-01-09 Thread Timothy Arceri
On 10/1/19 4:35 am, Danylo Piliaiev wrote: In all GLSL ES versions output variables in fragment shader are allowed to be invariant. From Section 4.6.1 ("The Invariant Qualifier") GLSL ES 1.00 spec: "Only the following variables may be declared as invariant: ... - Built-in special

[Piglit] [PATCH 1/2] glsl-1.10: test unrolling loops with variable iteration limits

2018-12-06 Thread Timothy Arceri
This tests unrolling of some loops with a single exit point but where the exact trip count is unknown, only the max iteration count is known. --- ...ariable-iteration-limit-unroll.shader_test | 62 ...riable-iteration-limit-unroll2.shader_test | 73 +++ 2 files

[Piglit] [PATCH 2/2] glsl-1.10: test unrolling of loop where max iteration count guessed

2018-12-06 Thread Timothy Arceri
This tests unrolling of a loop with a single exit point where the exact trip count is unknown, but the max iteration count can be guessed using the size of an array indexed via the induction variable. --- .../vs-loop-array-index-unroll.shader_test| 58 +++ 1 file changed, 58

Re: [Piglit] [PATCH] glsl-1.10: add tests for an array index on a swizzled vec lvalue

2018-10-07 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 6/10/18 10:58 am, Ilia Mirkin wrote: Current mesa fails both of these (in different ways!). Inspired by WebGL conformance test conformance2/glsl3/vector-dynamic-indexing-swizzled-lvalue.html Signed-off-by: Ilia Mirkin --- .../swizzled-writemask-indexing

Re: [Piglit] [PATCH piglit] idTech: fix extensions string list

2018-10-07 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 8/10/18 3:26 am, Eric Engestrom wrote: From: Eric Engestrom CID: 1439995 Fixes: f787ad0b60869f969f02d "Add tests for GL_EXTENSION_STRING vs. old idTech2 / idTech3 games" Cc: Ian Romanick Signed-off-by: Eric Engestrom -

Re: [Piglit] [PATCH 12/17] arb_gl_spirv: add ubo array test with different array_stride

2018-09-20 Thread Timothy Arceri
On 16/9/18 2:22 am, Alejandro Piñeiro wrote: For more info, see the long explanation at the commit "arb_gl_spirv: add ubo matrix test with different matrix_stride" --- .../array-different-array-stride-ubo.shader_test | 147 + 1 file changed, 147 insertions(+) create

Re: [Piglit] [PATCH v2] glsl-1.10: add a 'initialization-incompatible-type-propagation' test

2018-09-19 Thread Timothy Arceri
error message it did result in a crash in case of second test. v2: Splitted the test in several ones (Timothy Arceri) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107547 Signed-off-by: Danylo Piliaiev --- ...ation-incompatible-type-propagation-1.frag | 17 +++ ...ation

Re: [Piglit] [PATCH] glsl-1.10: add a 'initialization-incompatible-type-propagation' test

2018-09-17 Thread Timothy Arceri
On 17/9/18 7:56 pm, Danylo Piliaiev wrote: On 9/17/18 12:28 PM, Timothy Arceri wrote: On 16/8/18 12:23 am, Danylo Piliaiev wrote: This tests the case when initialising with incompatible type changed a type of the variable being initialized. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi

Re: [Piglit] [PATCH] glsl-1.10: add a 'initialization-incompatible-type-propagation' test

2018-09-17 Thread Timothy Arceri
On 16/8/18 12:23 am, Danylo Piliaiev wrote: This tests the case when initialising with incompatible type changed a type of the variable being initialized. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107547 Signed-off-by: Danylo Piliaiev --- I'm not sure if it's a proper way to test

Re: [Piglit] [PATCH 2/4] glsl-1.20/fs-deref-literal-array-of-structs-with-multiple-members-large-array: Fix it

2018-09-14 Thread Timothy Arceri
Whoops I probably did something silly like forgot to commit the rest of the changes to that test. Reviewed-by: Timothy Arceri On 14/9/18 4:10 am, Nicolai Hähnle wrote: From: Nicolai Hähnle Hard to believe that this was never noticed... --- ...f-structs-with-multiple-members-large

Re: [Piglit] [PATCH 1/4] fbo-drawbuffers-maxtargets: fix a warning

2018-09-14 Thread Timothy Arceri
(fs_source) + 5); + fs_count_source = malloc(strlen(fs_source) + 10); max_targets is clamped to 16 so it's not really needed is it? I guess it won't hurt though. Acked-by: Timothy Arceri sprintf(fs_count_source, fs_source, count); fs = piglit_compile_shader_text

Re: [Piglit] [PATCH] glsl-1.10: Put an if-statement in a macro in the false path of an ifdef

2018-08-31 Thread Timothy Arceri
Thanks! I believe I have a fix I'm just running it in CI to confirm it doesn't cause any other issues. Reviewed-by: Timothy Arceri On 01/09/18 03:49, Ian Romanick wrote: From: Ian Romanick Signed-off-by: Ian Romanick Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107772 Cc

Re: [Piglit] [PATCH] glsl-1.30: add linker test for inter stage in/out vars usage

2018-08-29 Thread Timothy Arceri
On 28/08/18 17:19, Vadim Shovkoplias wrote: Hi Timothy, Thanks for the review! Can you please push this patch ? Pushed. Thanks for the patch. вт, 28 авг. 2018 г. в 3:45, Timothy Arceri <mailto:tarc...@itsqueeze.com>>: Reviewed-by: Timothy Arceri mailto:tarc...@itsq

[Piglit] [PATCH] glsl-1.10: add some preprocessor stringification tests

2018-08-28 Thread Timothy Arceri
From Section 3.3. (Preprocessor) of the GLSL 4.60 spec: "The following operators are also available: defined ## ... Any directive not listed above will cause a compile-time error." --- .../stringification-in-unreachable-branch.frag | 12

Re: [Piglit] [PATCH] glsl-1.30: add linker test for inter stage in/out vars usage

2018-08-27 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 27/08/18 22:19, Vadym Shovkoplias wrote: This test exposes a Mesa GLSL linker bug. The test fails with the following error message: error: fragment shader input `foo' has no matching output in the previous stage Bugzilla: https

Re: [Piglit] [PATCH] arb_program_interface_query: fix array of arrays case

2018-08-21 Thread Timothy Arceri
On 21/08/18 21:38, asimiklit.w...@gmail.com wrote: From: Andrii Simiklit According to spec: "For an active variable declared as an array of an aggregate data type (structures or arrays), a separate entry will be generated for each active array element, unless noted immediately

Re: [Piglit] [PATCH 31/35] arb_gpu_shader5: Add support for testing spirv with XFB streams

2018-08-20 Thread Timothy Arceri
On 18/08/18 19:30, Alejandro Piñeiro wrote: On 18/08/18 06:36, Timothy Arceri wrote: On 18/08/18 14:32, Timothy Arceri wrote: Won't this cause shader runner to needlessly parse the .shader_test file? True, good point. In any case, as the test lacks a [test] section, full shader.py runs would

Re: [Piglit] [PATCH 31/35] arb_gpu_shader5: Add support for testing spirv with XFB streams

2018-08-17 Thread Timothy Arceri
On 18/08/18 14:32, Timothy Arceri wrote: Won't this cause shader runner to needlessly parse the .shader_test file? The file extension is also confusing. Maybe we should name these type of files .shader_source or something similar rather than .shader_test ??? On 09/08/18 21:36, Alejandro

Re: [Piglit] [PATCH 31/35] arb_gpu_shader5: Add support for testing spirv with XFB streams

2018-08-17 Thread Timothy Arceri
Won't this cause shader runner to needlessly parse the .shader_test file? On 09/08/18 21:36, Alejandro Piñeiro wrote: From: Neil Roberts v2: use shader_test file with the spirv assembly, instead of include two SPIRV binaries (Alejandro Piñeiro) Signed-off-by: Neil Roberts

Re: [Piglit] [PATCH] shaders: add a glslparsertest for bug 98699

2018-08-12 Thread Timothy Arceri
/glsl-1.10/compiler/post-increment-in-array-size.shader_test Yes I agree with Dylan on all points. With the move/rename this is: Reviewed-by: Timothy Arceri Or whatever you think is better (I'm just reading the bug and trying to come up with something). Otherwise this test looks good, so with

Re: [Piglit] [PATCH] arb_gpu_shader_fp64: Test the sign() function with abs() and negation of its argument

2018-06-29 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 27/06/18 17:28, Ian Romanick wrote: From: Ian Romanick The saturate version hits an assertion failure in the Mesa i965 driver: src/intel/compiler/brw_fs.cpp:2377: bool fs_visitor::opt_algebraic(): Assertion `!"unimplemented: saturate mixed types&quo

[Piglit] [PATCH] arb_vertex_attrib_64bit: test display list interaction

2018-06-27 Thread Timothy Arceri
--- tests/opengl.py | 1 + .../execution/CMakeLists.gl.txt | 1 + .../execution/double_attribs_dlist.c | 297 ++ 3 files changed, 299 insertions(+) create mode 100644

[Piglit] [PATCH v3] arb_compute_shader: test dispatch functions with display lists

2018-06-27 Thread Timothy Arceri
); + +enum piglit_result +cs_ids_confirm_initial_atomic_counters(); + +enum piglit_result +cs_ids_confirm_size(); + #endif diff --git a/tests/spec/arb_compute_shader/dlist.c b/tests/spec/arb_compute_shader/dlist.c new file mode 100644 index 0..fe2262a3d --- /dev/null +++ b/te

Re: [Piglit] [PATCH v2] glsl-1.10: test bug with lessThan() when the input expression has mixed sizes

2018-06-27 Thread Timothy Arceri
On 28/06/18 08:58, Ian Romanick wrote: On 06/27/2018 03:44 PM, Timothy Arceri wrote: On 28/06/18 08:28, Timothy Arceri wrote: On 27/06/18 21:58, Tapani Pälli wrote: On 06/27/2018 02:43 PM, Timothy Arceri wrote: ---   V2: Fix some spelling typos and the commit description   ...on-vec4

Re: [Piglit] [PATCH v2] glsl-1.10: test bug with lessThan() when the input expression has mixed sizes

2018-06-27 Thread Timothy Arceri
On 28/06/18 08:28, Timothy Arceri wrote: On 27/06/18 21:58, Tapani Pälli wrote: On 06/27/2018 02:43 PM, Timothy Arceri wrote: ---   V2: Fix some spelling typos and the commit description   ...on-vec4-mixed-arithmetic-input.shader_test | 37 +++   1 file changed, 37

Re: [Piglit] [PATCH v2] glsl-1.10: test bug with lessThan() when the input expression has mixed sizes

2018-06-27 Thread Timothy Arceri
On 27/06/18 21:58, Tapani Pälli wrote: On 06/27/2018 02:43 PM, Timothy Arceri wrote: ---   V2: Fix some spelling typos and the commit description   ...on-vec4-mixed-arithmetic-input.shader_test | 37 +++   1 file changed, 37 insertions(+)   create mode 100644 tests/spec/glsl

[Piglit] [PATCH v2] glsl-1.10: test bug with lessThan() when the input expression has mixed sizes

2018-06-27 Thread Timothy Arceri
--- V2: Fix some spelling typos and the commit description ...on-vec4-mixed-arithmetic-input.shader_test | 37 +++ 1 file changed, 37 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/comparision-vec4-mixed-arithmetic-input.shader_test diff --git

[Piglit] [PATCH] glsl-1.10: test bug with lessThan() with input expression has mixed sizes

2018-06-27 Thread Timothy Arceri
--- ...on-vec4-mixed-arithmetic-input.shader_test | 37 +++ 1 file changed, 37 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/comparision-vec4-mixed-arithmetic-input.shader_test diff --git

Re: [Piglit] [PATCH] tests/opengl.py: add couple missing arb_get_program_binary tests

2018-06-27 Thread Timothy Arceri
Thanks! Reviewed-by: Timothy Arceri On 27/06/18 16:49, Tapani Pälli wrote: Signed-off-by: Tapani Pälli --- tests/opengl.py | 4 1 file changed, 4 insertions(+) diff --git a/tests/opengl.py b/tests/opengl.py index 2592fa404..cafda2576 100644 --- a/tests/opengl.py +++ b/tests

Re: [Piglit] [PATCH] Add a test for instanced GS inputs.

2018-06-26 Thread Timothy Arceri
On 22/06/18 18:36, andrii.simiklit wrote: Hello, It would be great If somebody could take a look this test) This test against following bug: https://bugs.freedesktop.org/show_bug.cgi?id=96354 I've clean up the description, removed some trailing spaces and pushed this test. Thanks!

Re: [Piglit] [PATCH v2] arb_compute_shader: test dispatch functions with display lists

2018-06-26 Thread Timothy Arceri
I'm going to hold this one back for the moment. I've filled a spec bug and I'm hoping the indirect call will just be made to generate an error inside display lists. On 27/06/18 11:30, Marek Olšák wrote: Acked-by: Marek Olšák Marek On Sun, Jun 24, 2018 at 9:40 PM, Timothy Arceri wrote

Re: [Piglit] [PATCH] glsl-1.10: Test the sign() function with abs() and negation of its argument

2018-06-26 Thread Timothy Arceri
On 27/06/18 11:24, Ian Romanick wrote: On 06/26/2018 05:15 PM, Timothy Arceri wrote: On 27/06/18 07:44, Ian Romanick wrote: From: Ian Romanick The fsign(-abs(x)) tests tickle a bug in the Mesa i965 driver that was found by inspection. Signed-off-by: Ian Romanick ---   .../execution/fs

Re: [Piglit] [PATCH] glsl-1.10: Test the sign() function with abs() and negation of its argument

2018-06-26 Thread Timothy Arceri
On 27/06/18 07:44, Ian Romanick wrote: From: Ian Romanick The fsign(-abs(x)) tests tickle a bug in the Mesa i965 driver that was found by inspection. Signed-off-by: Ian Romanick --- .../execution/fs-sign-neg-abs.shader_test | 28

[Piglit] [PATCH v2] ARB_vertex_attrib_64bit: add doubles support to attributes test

2018-06-25 Thread Timothy Arceri
--- V2: Add missing opengl.py entry. tests/general/attribs.c | 68 +++-- tests/opengl.py | 3 +- 2 files changed, 67 insertions(+), 4 deletions(-) diff --git a/tests/general/attribs.c b/tests/general/attribs.c index 05a0d4a1e..bf627dece 100644 ---

[Piglit] [PATCH] ARB_vertex_attrib_64bit: add doubles support to attributes test

2018-06-25 Thread Timothy Arceri
--- tests/general/attribs.c | 68 +++-- 1 file changed, 65 insertions(+), 3 deletions(-) diff --git a/tests/general/attribs.c b/tests/general/attribs.c index 05a0d4a1e..bf627dece 100644 --- a/tests/general/attribs.c +++ b/tests/general/attribs.c @@ -53,6 +53,7

[Piglit] [PATCH v2] arb_compute_shader: test dispatch functions with display lists

2018-06-24 Thread Timothy Arceri
t_result +cs_ids_confirm_initial_atomic_counters(); + +enum piglit_result +cs_ids_confirm_size(); + #endif diff --git a/tests/spec/arb_compute_shader/dlist.c b/tests/spec/arb_compute_shader/dlist.c new file mode 100644 index 0..0cbdea743 --- /dev/null +++ b/tests/spec/arb_compute_shader/dl

[Piglit] [PATCH] general: better test display lists in attribute test

2018-06-23 Thread Timothy Arceri
We weren't really testing that the displays list worked since the calls could have just been executed immediately. --- tests/general/attribs.c | 12 1 file changed, 12 insertions(+) diff --git a/tests/general/attribs.c b/tests/general/attribs.c index 05a0d4a1e..ddb0b060a 100644 ---

[Piglit] [PATCH] arb_draw_indirect: test when 0 bound to DRAW_INDIRECT_BUFFER in compat

2018-06-23 Thread Timothy Arceri
From the ARB_draw_indirect spec: "Initially zero is bound to DRAW_INDIRECT_BUFFER. In the compatibility profile, this indicates that DrawArraysIndirect and DrawElementsIndirect are to source their arguments directly from the pointer passed as their parameters." ---

[Piglit] [PATCH] compatibility: test vertex color clamping in geom and tess shaders

2018-06-22 Thread Timothy Arceri
--- .../tes-clamp-vertex-color.shader_test| 76 +++ .../gs-clamp-vertex-color.shader_test | 47 2 files changed, 123 insertions(+) create mode 100644 tests/spec/arb_tessellation_shader/execution/compatibility/tes-clamp-vertex-color.shader_test

[Piglit] [PATCH] arb_compute_shader: test dispatch functions with display lists

2018-06-21 Thread Timothy Arceri
ze(uint32_t x, uint32_t y, uint32_t z); enum piglit_result cs_ids_run_test(); +void +cs_ids_run_test_without_check(); + +void +cs_ids_setup_atomics_for_test(); + +enum piglit_result +cs_ids_confirm_initial_atomic_counters(); + +enum piglit_result +cs_ids_confirm_size(); + #endif diff --git a/tests/sp

Re: [Piglit] [PATCH] arb_tessellation_shader: test GL_PATCHES with immediate mode

2018-06-20 Thread Timothy Arceri
On 21/06/18 14:05, Marek Olšák wrote: On Mon, Jun 18, 2018 at 12:50 AM, Timothy Arceri wrote: --- tests/opengl.py | 1 + .../arb_tessellation_shader/CMakeLists.gl.txt | 1 + .../immediate-mode-draw-patches.c | 111 ++ 3 files

[Piglit] [PATCH] arb_viewport_array: test display list support

2018-06-20 Thread Timothy Arceri
0..35f78ec0f --- /dev/null +++ b/tests/spec/arb_viewport_array/dlist.c @@ -0,0 +1,355 @@ +/* + * Copyright © 2018 Timothy Arceri + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), +

[Piglit] [PATCH] arb_shader_subroutine: add simple display list test

2018-06-19 Thread Timothy Arceri
--- .../simple-subroutine-dlist.shader_test | 92 +++ 1 file changed, 92 insertions(+) create mode 100644 tests/spec/arb_shader_subroutine/execution/simple-subroutine-dlist.shader_test diff --git

[Piglit] [PATCH] arb_gpu_shader_fp64: test display list support

2018-06-19 Thread Timothy Arceri
--- tests/opengl.py | 1 + .../arb_gpu_shader_fp64/CMakeLists.gl.txt | 1 + .../arb_gpu_shader_fp64/dlist-fp64-uniforms.c | 406 ++ 3 files changed, 408 insertions(+) create mode 100644 tests/spec/arb_gpu_shader_fp64/dlist-fp64-uniforms.c

Re: [Piglit] [PATCH] ARB_get_program_binary: Test that XFB varying info works on program reload

2018-06-18 Thread Timothy Arceri
GL_SEPARATE_ATTRIBS)) + piglit_report_result(PIGLIT_FAIL); + + if (!get_programiv(prog, GL_TRANSFORM_FEEDBACK_VARYINGS, + ARRAY_SIZE(varyings) - 1)) + piglit_report_result(PIGLIT_FAIL); It would be nice to actually compare the st

[Piglit] [PATCH] arb_tessellation_shader: test GL_PATCHES with immediate mode

2018-06-17 Thread Timothy Arceri
Timothy Arceri + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merg

[Piglit] [PATCH 1/2] glsl-1.50: test gs interaction with fixed function fragment shader

2018-06-17 Thread Timothy Arceri
--- .../compatibility/gs-ff-frag.shader_test | 42 ++ .../compatibility/vs-gs-ff-frag.shader_test | 43 +++ 2 files changed, 85 insertions(+) create mode 100644 tests/spec/glsl-1.50/execution/compatibility/gs-ff-frag.shader_test create mode 100644

[Piglit] [PATCH 2/2] arb_tessellation_shader: test tes interaction with fixed function fragment shader

2018-06-17 Thread Timothy Arceri
--- .../compatibility/tcs-tes-ff-frag.shader_test | 63 +++ 1 file changed, 63 insertions(+) create mode 100644 tests/spec/arb_tessellation_shader/execution/compatibility/tcs-tes-ff-frag.shader_test diff --git

Re: [Piglit] [PATCH 9/9] ARB_get_program_binary: Test that restoring active program takes effect

2018-06-17 Thread Timothy Arceri
Looks like you forgot to add these to tests/opengl.py ? On 09/06/18 15:48, Jordan Justen wrote: Signed-off-by: Jordan Justen Cc: Timothy Arceri --- .../arb_get_program_binary/CMakeLists.gl.txt | 2 + .../restore-implicit-use-program.c| 145 ++ 2 files

Re: [Piglit] [PATCH] glsl-4.60: backdate semicolon test to run from glsl 1.10

2018-06-13 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 14/06/18 10:24, Dave Airlie wrote: From: Dave Airlie Since this was a bug fix and real world apps have the old behaviour --- .../glsl-4.60/compiler/extra-semilons-at-global-scope.frag | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

Re: [Piglit] [PATCH 1/9] shader_runner: Support testing GL_NUM_PROGRAM_BINARY_FORMATS

2018-06-10 Thread Timothy Arceri
On 10/06/18 16:06, Jordan Justen wrote: On 2018-06-09 21:56:33, Timothy Arceri wrote: Small nit with patch 2. Patch 8 seems obsolete with patch 6 I'm a missing something? They are close. Patch 6 tests that the uniform is reset by examining the result of drawing. Patch 8 tests by reading

Re: [Piglit] [PATCH 1/9] shader_runner: Support testing GL_NUM_PROGRAM_BINARY_FORMATS

2018-06-09 Thread Timothy Arceri
Small nit with patch 2. Patch 8 seems obsolete with patch 6 I'm a missing something? Otherwise, this series looks great thanks for working on it :) Reviewed-by: Timothy Arceri On 09/06/18 15:47, Jordan Justen wrote: Signed-off-by: Jordan Justen --- tests/shaders/shader_runner.c | 16

Re: [Piglit] [PATCH 8/9] ARB_get_program_binary: Test that uniforms are reset on program reload (API)

2018-06-09 Thread Timothy Arceri
Isn't this exactly the same test as patch 6? On 09/06/18 15:48, Jordan Justen wrote: Signed-off-by: Jordan Justen --- .../arb_get_program_binary/CMakeLists.gl.txt | 1 + .../arb_get_program_binary/reset-uniform.c| 121 ++ 2 files changed, 122 insertions(+) create

Re: [Piglit] [PATCH 2/9] shader_runner: Add -get-program-binary parameter

2018-06-09 Thread Timothy Arceri
On 09/06/18 15:48, Jordan Justen wrote: This parameter will test ARB_get_program_binary and OES_get_program_binary with any shader runner test. If -get-program-binary, then shader_runner will check to see if the extension is supported, and if 1 or more binary formats are supported. If the

Re: [Piglit] [PATCH] general/draw: Test that checks propper render order in mixed draw setups.

2018-06-05 Thread Timothy Arceri
nit: Normally we try to put piglit_init() at the bottom so we can get right into the interesting things first. Otherwise this is: Acked-by: Timothy Arceri Thanks for writing a piglit test to cover this! + + +enum piglit_result +piglit_display(void) +{ + const GLfloat Vertices

[Piglit] [PATCH] glsl-1.10: test loop unrolling when induction variable is inside if branch

2018-06-03 Thread Timothy Arceri
--- ...induction-variable-inside-if-branch.shader_test | 61 ++ 1 file changed, 61 insertions(+) create mode 100644 tests/spec/glsl-1.10/execution/vs-loop-simple-unroll-induction-variable-inside-if-branch.shader_test diff --git

Re: [Piglit] [PATCH] vertex-program-two-side: Fix GCC format-security warnings.

2018-05-31 Thread Timothy Arceri
Thanks. Are these warning not enabled by default? Reviewed-by: Timothy Arceri On 01/06/18 07:46, Vinson Lee wrote: vertex-program-two-side.c: In function ‘piglit_display’: vertex-program-two-side.c:370:3: warning: format not a string literal and no format arguments [-Wformat-security

Re: [Piglit] [PATCH] gl-3.2-compat: Fix GCC format-security warnings.

2018-05-31 Thread Timothy Arceri
Reviewed-by: Timothy Arceri On 01/06/18 07:31, Vinson Lee wrote: glsl-fs-fogscale.c: In function ‘piglit_display’: glsl-fs-fogscale.c:140:3: warning: format not a string literal and no format arguments [-Wformat-security] piglit_report_subtest_result(PIGLIT_SKIP, tests[1

Re: [Piglit] [PATCH] gl-3.0: Remove unused variable.

2018-05-29 Thread Timothy Arceri
Thanks! Reviewed-by: Timothy Arceri On 30/05/18 10:10, Vinson Lee wrote: Fix build warning. dlist-uint-uniforms.c: In function ‘piglit_init’: dlist-uint-uniforms.c:48:11: warning: unused variable ‘glsl_version’ [-Wunused-variable] unsigned glsl_version; ^~~~ Fixes

Re: [Piglit] [PATCH 3/3] glsl-1.50: test compat built in constants

2018-05-28 Thread Timothy Arceri
I forgot to add this to OpenGL.py but I've fixed it locally. On 29/05/18 10:52, Timothy Arceri wrote: --- tests/spec/glsl-1.50/minimum-maximums-compat.txt | 4 1 file changed, 4 insertions(+) create mode 100644 tests/spec/glsl-1.50/minimum-maximums-compat.txt diff --git a/tests/spec

[Piglit] [PATCH 1/3] built-in-constants: add support for testing compatibility profile built ins

2018-05-28 Thread Timothy Arceri
--- tests/shaders/built-in-constants.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/tests/shaders/built-in-constants.c b/tests/shaders/built-in-constants.c index 32cd2638f..e1512a04c 100644 --- a/tests/shaders/built-in-constants.c +++

[Piglit] [PATCH 2/3] built-in-constants: fix desktop GL version check for geometry shaders

2018-05-28 Thread Timothy Arceri
The check is meant to compare GLSL version which for OpenGL 3.2 is 1.50. --- tests/shaders/built-in-constants.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/shaders/built-in-constants.c b/tests/shaders/built-in-constants.c index e1512a04c..df5fa2a84 100644 ---

[Piglit] [PATCH 3/3] glsl-1.50: test compat built in constants

2018-05-28 Thread Timothy Arceri
--- tests/spec/glsl-1.50/minimum-maximums-compat.txt | 4 1 file changed, 4 insertions(+) create mode 100644 tests/spec/glsl-1.50/minimum-maximums-compat.txt diff --git a/tests/spec/glsl-1.50/minimum-maximums-compat.txt b/tests/spec/glsl-1.50/minimum-maximums-compat.txt new file mode

Re: [Piglit] [PATCH 2/3] arb_tessellation_shader: add basic display list test for glPatchParameteri()

2018-05-28 Thread Timothy Arceri
This and the following patch should have: GL COMPAT >= 3.2 I've fixed this locally. On 28/05/18 20:36, Timothy Arceri wrote: --- .../tcs-tes-vertex-dlist.shader_test | 89 +++ 1 file changed, 89 insertions(+) create mode 100644 tests/spec/arb_tessellation_sha

[Piglit] [PATCH 1/3] shader_runner: add basic display list support

2018-05-28 Thread Timothy Arceri
--- tests/shaders/shader_runner.c | 16 1 file changed, 16 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index c2b27ad20..794524e8f 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c @@ -2952,6 +2952,7 @@

[Piglit] [PATCH 3/3] arb_tessellation_shader: test display list support for glPatchParameterfv()

2018-05-28 Thread Timothy Arceri
--- ...r-tessouter-inputs-quads-dlist.shader_test | 83 +++ 1 file changed, 83 insertions(+) create mode 100644 tests/spec/arb_tessellation_shader/execution/vs-tes-tessinner-tessouter-inputs-quads-dlist.shader_test diff --git

[Piglit] [PATCH 2/3] arb_tessellation_shader: add basic display list test for glPatchParameteri()

2018-05-28 Thread Timothy Arceri
--- .../tcs-tes-vertex-dlist.shader_test | 89 +++ 1 file changed, 89 insertions(+) create mode 100644 tests/spec/arb_tessellation_shader/execution/tcs-tes-vertex-dlist.shader_test diff --git

[Piglit] [PATCH 1/2] piglit-util-gl: add support for using patches with fixed function attributes

2018-05-27 Thread Timothy Arceri
--- tests/util/piglit-util-gl.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/tests/util/piglit-util-gl.c b/tests/util/piglit-util-gl.c index 2443be03e..ebd57d77b 100644 --- a/tests/util/piglit-util-gl.c +++ b/tests/util/piglit-util-gl.c @@ -684,10

[Piglit] [PATCH 2/2] ARB_tessellation_shader: test gl_*Color built-ins with tessellation shaders

2018-05-27 Thread Timothy Arceri
--- tests/spec/gl-2.0/vertex-program-two-side.c | 157 ++-- 1 file changed, 147 insertions(+), 10 deletions(-) diff --git a/tests/spec/gl-2.0/vertex-program-two-side.c b/tests/spec/gl-2.0/vertex-program-two-side.c index c53668124..a659e521b 100644 ---

[Piglit] [PATCH] gl-3.2-compat: test gl_FogFragCoord built-in with geometry shaders

2018-05-25 Thread Timothy Arceri
This extends the fogscale test to test a gl_FogFragCoord value passed via a geometry shader. --- tests/shaders/glsl-fs-fogscale.c | 100 +-- 1 file changed, 82 insertions(+), 18 deletions(-) diff --git a/tests/shaders/glsl-fs-fogscale.c

Re: [Piglit] [PATCH 1/2] glslparsertest: support compatibility profile tests

2018-05-24 Thread Timothy Arceri
Reviewed-by: Timothy Arceri <tarc...@itsqueeze.com> On 23/05/18 11:29, Marek Olšák wrote: From: Marek Olšák <marek.ol...@amd.com> --- framework/test/glsl_parser_test.py| 5 + tests/glslparsertest/glslparsertest.c | 18 +- 2 files changed, 18 inse

[Piglit] [PATCH] gl-3.2-compat: test gl_ClipVertex built-in with geometry shaders

2018-05-21 Thread Timothy Arceri
These tests have been adapted from the glsl-1.20 clipping tests. This tests both setting gl_ClipVertex in the geometry shader and using the gs to passthrough the gl_ClipVertex value from the vertex shader. I tested these on NVIDIA 384.111 binary driver but some of these get a cryptic error

[Piglit] [PATCH v2] gl-3.2-compat: test gl_TexCoord[] built-in with geometry shaders

2018-05-21 Thread Timothy Arceri
This tests both setting gl_TexCoord[] in the geometry shader and using the gs to passthrough the gl_TexCoord[] values from the vertex shader. --- .../gs-texcoord-array-2.shader_test | 57 .../gs-texcoord-array.shader_test | 51 ++

[Piglit] [PATCH] gl-3.2-compat: test gl_TexCoord[] built-in with geometry shaders

2018-05-21 Thread Timothy Arceri
--- .../texcoord-array-2.shader_test | 65 ++ .../compatibility/texcoord-array.shader_test | 66 +++ 2 files changed, 131 insertions(+) create mode 100644 tests/spec/glsl-1.50/execution/compatibility/texcoord-array-2.shader_test create mode 100644

[Piglit] [PATCH] gl-3.2-compat: test gl_*Color built-ins with geometry shaders

2018-05-21 Thread Timothy Arceri
This updates the existing vertex shader test and makes it more flexable. --- tests/spec/gl-2.0/vertex-program-two-side.c | 195 +++- 1 file changed, 145 insertions(+), 50 deletions(-) diff --git a/tests/spec/gl-2.0/vertex-program-two-side.c

[Piglit] [PATCH] gl-3.0: test glUniform*ui{v} functions are compiled into display lists

2018-05-09 Thread Timothy Arceri
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78097 --- tests/opengl.py | 2 + tests/spec/gl-3.0/CMakeLists.gl.txt | 1 + tests/spec/gl-3.0/dlist-uint-uniforms.c | 305 3 files changed, 308 insertions(+) create mode 100644

[Piglit] [PATCH v2] ext_packed_float: Add a test that queries GL_RGBA_SIGNED_COMPONENTS_EXT

2018-05-09 Thread Timothy Arceri
From: Bruce Merry <bme...@gmail.com> V2 (Timothy Arceri): - use piglit_get_gl_enum_name() - use ARRAY_SIZE() - set config.khr_no_error_support Cc: Brian Paul <bri...@vmware.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73096 --- tes

Re: [Piglit] [PATCH] ext_packed_float: Add a test that queries GL_RGBA_SIGNED_COMPONENTS_EXT

2018-05-09 Thread Timothy Arceri
the line :) Thanks for writing test and reporting the bug. Tim Bruce On 9 May 2018 at 18:44, Brian Paul <bri...@vmware.com> wrote: Minor things below. -Brian On 05/09/2018 12:13 AM, Timothy Arceri wrote: From: Bruce Merry <bme...@gmail.com> Cc: Brian Paul <bri...@vmware.com&g

  1   2   3   4   5   6   7   >