Re: [Piglit] [PATCH 4/5] all.py: fix misnamed tests

2015-07-13 Thread Timothy Arceri
This patch is: Reviewed-by: Timothy Arceri t_arceri at yahoo.com.au On Tue, 2015-02-03 at 12:09 -0800, Dylan Baker wrote: At some point OpenGL 3.2 was shortened to OpenGL, which is clearly wrong Signed-off-by: Dylan Baker dylanx.c.ba...@intel.com --- tests/all.py | 4 ++-- 1 file

Re: [Piglit] [PATCH v2] cl: add clLinkProgram test

2015-07-13 Thread Timothy Arceri
On Tue, 2015-01-06 at 21:20 +0100, EdB wrote: I don't have commit acces. Can someone push it? I think you need to update tests/cl.py before this can be pushed. Le 2014-12-19 20:41, Tom Stellard a écrit : On Fri, Dec 19, 2014 at 02:39:06PM +0100, EdB wrote: v2: Use

Re: [Piglit] [PATCH] glsl 1.10: Fix broken ternary void test

2015-07-10 Thread Timothy Arceri
On Fri, 2015-07-10 at 16:52 +0200, Renaud Gaubert wrote: Now that this bug is fixed in the following commit sent to mesa-dev: glsl: avoid compiler's segfault when processing operators with void arguments This test proved to be broken: It did not set gl_Position It did not compare the right

Re: [Piglit] [PATCH 4/5] core_tests.py: use PiglitConfig instead of SafeConfigParser

2015-07-07 Thread Timothy Arceri
Feel free to push the change when you make it. I'm happy to take a look at a v2 if you wan't someone to double check before you push, up to you :) On Mon, 2015-07-06 at 16:26 -0700, Dylan Baker wrote: On Tue, Jul 07, 2015 at 08:10:49AM +1000, Timothy Arceri wrote: I'd probably merge the config

Re: [Piglit] [PATCH] Move crash cubemap test from bugs/ to spec/

2015-07-07 Thread Timothy Arceri
If you change the filename and test name to cubemap-unusual-order I'll commit this for you. On Thu, 2015-04-02 at 20:41 +0100, Guy-Daniel Tiku wrote: --- tests/bugs/CMakeLists.gl.txt | 1 - tests/bugs/crash-cubemap-order.c | 51 ---

Re: [Piglit] [PATCH] arb_gpu_shader5: add textureSize sampler indexing tests

2015-07-07 Thread Timothy Arceri
commited and was going to reply at the time. Anyway to bump it I just thought I'd add that I like the fractions how they are as it makes them less abstract. And have another reviewed-by for waiting. Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au Reviewed-by: Ilia Mirkin imir...@alum.mit.edu

Re: [Piglit] [PATCH 2/5] framework/status.py: Add a __hash__ method to Status class

2015-07-06 Thread Timothy Arceri
Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au On Thu, 2015-07-02 at 16:46 -0700, Dylan Baker wrote: This is necessary in Python 3 to put a Status in a dictionary or set, but is optional in python 2. It doesn't do any harm implementing it now, and will easy the python 3 transition Signed

Re: [Piglit] [PATCH 3/5] framwork/summary: use mako's render_unicode method instead of render

2015-07-06 Thread Timothy Arceri
Looks reasonable, I'm not 100% sure on the formating of python code in piglit but I'm sure you know what your doing with the whitespace changes. Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au On Thu, 2015-07-02 at 16:46 -0700, Dylan Baker wrote: Because python 3 uses unicode by default

[Piglit] [PATCH V3 1/6] arb_arrays_of_arrays: test linking of interface fields

2015-07-05 Thread Timothy Arceri
Test results: AMD Radeon HD 6670 - Catalyst 14.501.1003 OpenGL 4.4 vs-to-fs-interface-field-mismatch.shader_test - fail vs-to-fs-interface-field-mismatch2.shader_test - fail vs-to-fs-interface-field-unsized-mismatch.shader_test - crash vs-to-fs-interface-field-unsized-mismatch2.shader_test -

[Piglit] [PATCH V3 2/6] arb_arrays_of_arrays: add some sampler indexing execution tests

2015-07-05 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47 fs-const-index-three-dimensions.shader_test - pass fs-const-index.shader_test - pass fs-initializer-const-index.shader_test - fail fs-initializer-non-const-index.shader_test - fail fs-mixed-const-and-non-const-index.shader_test - pass

[Piglit] [PATCH V3 6/6] arb_arrays_of_arrays: basic image store execution tests

2015-07-05 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47 basic-imageStore-const-uniform-index.shader_test - pass basic-imageStore-non-const-uniform-index.shader_test - pass --- ...asic-imageStore-const-uniform-index.shader_test | 58 ...-imageStore-non-const-uniform-index.shader_test |

[Piglit] [PATCH V3 3/6] arb_arrays_of_arrays: test binding limits for uniforms

2015-07-05 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47: fail V2: use GL_MAX_COMBINED_TEXTURE_IMAGE_UNITS for sampler test --- tests/all.py | 6 + tests/spec/CMakeLists.txt | 1 + tests/spec/arb_arrays_of_arrays/CMakeLists.gl.txt | 15

[Piglit] [PATCH V3 5/6] arb_arrays_of_arrays: add basic linking tests for atomic counters

2015-07-05 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47 vs-to-fs-atomic-counter-mismatch.shader_test - fail vs-to-fs-atomic-counter.shader_test - pass --- .../vs-to-fs-atomic-counter-mismatch.shader_test | 38 ++ .../linker/vs-to-fs-atomic-counter.shader_test | 38

[Piglit] [PATCH V2] arb_separate_shader_objects: extend active sampler conflict to test arrays

2015-07-05 Thread Timothy Arceri
V2: dont try to work around mesa limitations by initialising uniforms that might be optimised out --- .../active-sampler-conflict.c | 167 +++-- 1 file changed, 123 insertions(+), 44 deletions(-) diff --git

Re: [Piglit] [PATCH 1/5] framework/backends/abstract.py: use next() instead of generator.next()

2015-07-03 Thread Timothy Arceri
For this patch Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au I'm no python wizard so I don't have much to say about the other patches just yet. On Thu, 2015-07-02 at 16:46 -0700, Dylan Baker wrote: Python2.7 supports both the legacy next method, and the future looking next() function

[Piglit] [PATCH 2/2] arb_arrays_of_arrays: test precision qualifier with samplers

2015-07-03 Thread Timothy Arceri
V2: Add ifdef to test cube map array samplers Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass --- .../compiler/precision-qualifier-sampler.frag | 74 + .../compiler/precision-qualifier-sampler.vert | 75 ++ 2 files changed, 149

[Piglit] [PATCH V2 1/2] glsl-1.30: test precision qualifier with sampler array

2015-07-03 Thread Timothy Arceri
V2: Add ifdef to test cube map array samplers Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass --- .../precision-sampler-array.frag | 72 + .../precision-sampler-array.vert | 73 ++ 2 files changed, 145

[Piglit] [PATCH 1/2] glsl-1.30: test precision qualifier with sampler array

2015-07-03 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass --- .../precision-sampler-array.frag | 66 + .../precision-sampler-array.vert | 67 ++ 2 files changed, 133 insertions(+) create mode 100644

[Piglit] [PATCH 2/2] arb_arrays_of_arrays: test precision qualifier with samplers

2015-07-03 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass --- .../compiler/precision-qualifier-sampler.frag | 67 + .../compiler/precision-qualifier-sampler.vert | 68 ++ 2 files changed, 135 insertions(+) create mode 100644

[Piglit] [PATCH 1/2] arb_program_interface_query: add more arrays of arrays tests

2015-07-03 Thread Timothy Arceri
From the ARB_program_interface_query spec (issue 8): We only accept entries of the form a[2][1][0] or a[2][1], which is consistent with the existing rules that only allow applications to omit the last index of a bottom-level array that has been rolled up. Test results: Nvidia GeForce

[Piglit] [PATCH 2/2] arb_program_interface_query: add missing space to error message

2015-07-03 Thread Timothy Arceri
Cc: Tapani Pälli tapani.pa...@intel.com --- tests/spec/arb_program_interface_query/getprogramresourceindex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/arb_program_interface_query/getprogramresourceindex.c

Re: [Piglit] [PATCH] arb_program_interface_query: update and fix arrays of arrays tests

2015-06-30 Thread Timothy Arceri
On Mon, 2015-06-29 at 13:49 +0300, Tapani Pälli wrote: On 06/27/2015 02:14 AM, Timothy Arceri wrote: Add a 3D array test and fix the expected result for an array without a subscript attached to the name. The arb_program_interface_query spec says: If name exactly matches the name

Re: [Piglit] [PATCH] arb_program_interface_query: update and fix arrays of arrays tests

2015-06-30 Thread Timothy Arceri
On Tue, 2015-06-30 at 13:24 +0300, Tapani Pälli wrote: On 06/30/2015 12:48 PM, Timothy Arceri wrote: On Mon, 2015-06-29 at 13:49 +0300, Tapani Pälli wrote: On 06/27/2015 02:14 AM, Timothy Arceri wrote: Add a 3D array test and fix the expected result for an array without

[Piglit] [PATCH] arb_program_interface_query: update and fix arrays of arrays tests

2015-06-26 Thread Timothy Arceri
Add a 3D array test and fix the expected result for an array without a subscript attached to the name. The arb_program_interface_query spec says: If name exactly matches the name string of one of the active resources for programInterface, the index of the matched resource is returned.

[Piglit] [PATCH V2 5/8] arb_arrays_of_arrays: test binding limits for uniforms

2015-06-23 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47: atmoic counters - pass samplers - fail interface blocks - fail The Nvidia driver fails because is doesn't support interfce block AoA and because it doesn't seem to think the sampler AoA goes over the limit if I change the sampler to a 4 element

[Piglit] Re-run filtered tests results

2015-06-22 Thread Timothy Arceri
On 11/06/15 10:04, Emil Velikov wrote: On 10 June 2015 at 23:56, Rob Clark robdcl...@gmail.com wrote: On Wed, Jun 10, 2015 at 7:28 PM, Emil Velikov emil.l.veli...@gmail.com wrote: On 5 June 2015 at 22:08, Rob Clark robdcl...@gmail.com wrote: so, maybe a bit off topic (and maybe doesn't really

[Piglit] [PATCH 6/8] arb_arrays_of_arrays: add simple atomic counters execution test

2015-06-20 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass --- .../vs-simple-inc-dec-read.shader_test | 119 + 1 file changed, 119 insertions(+) create mode 100644 tests/spec/arb_arrays_of_arrays/execution/atomic_counters/vs-simple-inc-dec-read.shader_test diff

[Piglit] [PATCH 5/8] arb_arrays_of_arrays: test binding limits for uniforms

2015-06-20 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47: fail --- tests/all.py | 6 + tests/spec/CMakeLists.txt | 1 + tests/spec/arb_arrays_of_arrays/CMakeLists.gl.txt | 15 ++ tests/spec/arb_arrays_of_arrays/CMakeLists.txt| 1 +

[Piglit] [PATCH 4/8] arb_arrays_of_arrays: add some sampler indexing execution tests

2015-06-20 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47 sampler-precision-qualifier.frag - pass fs-const-index-three-dimensions.shader_test - pass fs-const-index.shader_test - pass fs-initializer-const-index.shader_test - fail fs-initializer-non-const-index.shader_test - fail

[Piglit] [PATCH 1/8] varying-packing: add arrays of arrays support

2015-06-20 Thread Timothy Arceri
V3: rebase and test double types V2: renamed variables from 'inner' that should have been 'outer' --- To see some shaders generated by these changes see here: http://lists.freedesktop.org/archives/piglit/2015-May/015955.html tests/all.py | 4 +-

[Piglit] [PATCH 8/8] arb_arrays_of_arrays: basic image store execution tests

2015-06-20 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47 basic-imageStore-const-uniform-index.shader_test - pass basic-imageStore-non-const-uniform-index.shader_test - pass --- ...asic-imageStore-const-uniform-index.shader_test | 58 ...-imageStore-non-const-uniform-index.shader_test |

Re: [Piglit] Weekly 10 Picks from Patchwork for review and friendly reminder to clean out your old patches

2015-06-19 Thread Timothy Arceri
On Fri, 2015-06-19 at 16:18 -0400, Ilia Mirkin wrote: On Fri, Jun 19, 2015 at 4:12 PM, Jose Fonseca jfons...@vmware.com wrote: On 19/06/15 20:45, Ilia Mirkin wrote: On Fri, Jun 19, 2015 at 3:39 PM, Jose Fonseca jfons...@vmware.com wrote: On 19/06/15 13:32, Timothy Arceri wrote: Hi

Re: [Piglit] Weekly 10 Picks from Patchwork for review and friendly reminder to clean out your old patches

2015-06-19 Thread Timothy Arceri
On Fri, 2015-06-19 at 21:12 +0100, Jose Fonseca wrote: On 19/06/15 20:45, Ilia Mirkin wrote: On Fri, Jun 19, 2015 at 3:39 PM, Jose Fonseca jfons...@vmware.com wrote: On 19/06/15 13:32, Timothy Arceri wrote: Hi all, Unfortunately since its introduction patchwork hasn't seen a lot

[Piglit] Weekly 10 Picks from Patchwork for review and friendly reminder to clean out your old patches

2015-06-19 Thread Timothy Arceri
Hi all, Unfortunately since its introduction patchwork hasn't seen a lot of love in the Piglit and Mesa projects so I thought I'd try something out to bring it out of the shadows and into the limelight. The idea is simple we have many useful but long forgotten patches sitting on the mailing list

[Piglit] [PATCH] arb_gpu_shader5: test indexing of samplers inside structs

2015-06-18 Thread Timothy Arceri
fragment shader tests already exist, this adds vertex and geometry tests for completeness. Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass Cc: Ilia Mirkin imir...@alum.mit.edu --- .../gs-struct-nonconst-sampler-const.shader_test | 91

[Piglit] [PATCH] sampler_array_indexing: also check that texture coordinates work

2015-06-18 Thread Timothy Arceri
Previously the shaders were using a checkerboard texture with identical colours for each part of the grid. That meant that it didn't actually matter what texture coordinates were used to sample. This patch changes it so that they all have a dark red colour for one of the colours and then it

Re: [Piglit] [1/2] sample-mask-execution: fix misleading description

2015-06-18 Thread Timothy Arceri
Was just looking at patchwork seems this is the oldest unreviewed patch in there. If you also fix line 37 then to * - render a green thing Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au ___ Piglit mailing list Piglit@lists.freedesktop.org http

[Piglit] [PATCH] khr-debug: fix broken label test

2015-06-18 Thread Timothy Arceri
--- tests/spec/khr_debug/debug-object-label.c | 36 --- 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/tests/spec/khr_debug/debug-object-label.c b/tests/spec/khr_debug/debug-object-label.c index 151e684..ad4c9fc 100644 ---

[Piglit] [PATCH] glsl-es-3.10: dont run gles tests where restrictions apply

2015-06-17 Thread Timothy Arceri
In GLES vertex shader outputs cant be arrays of structs or structs that contain arrays or structs. The GLSL ES 3.0 spec says: Vertex output variables output per-vertex data and are declared using the out storage qualifier or the centroid out storage qualifier. They can only be float,

[Piglit] [PATCH] arb_separate_shader_objects: extend active sampler conflict to test arrays

2015-06-17 Thread Timothy Arceri
--- .../active-sampler-conflict.c | 187 - 1 file changed, 143 insertions(+), 44 deletions(-) diff --git a/tests/spec/arb_separate_shader_objects/active-sampler-conflict.c b/tests/spec/arb_separate_shader_objects/active-sampler-conflict.c index

Re: [Piglit] [PATCH] arb_gpu_shader5: test indexing of samplers inside structs

2015-06-16 Thread Timothy Arceri
in gallium either... maybe having a failing piglit on i965 will cause the intel folk to figure out how to properly fix it... and I can copy again ;) ] On Tue, Jun 16, 2015 at 6:50 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: Hi Neil, No problem. I'll update the tests give them a run

Re: [Piglit] [PATCH] arb_gpu_shader5: test indexing of samplers inside structs

2015-06-16 Thread Timothy Arceri
as well so that they match? I didn't want to do this myself because the new tests seem to be failing with Mesa i965 and I don't have a suitable NVIDIA card handy to test it with. Regards, - Neil Timothy Arceri t_arc...@yahoo.com.au writes: Test results: Nvidia GeForce 840M

Re: [Piglit] [PATCH] ext_transform_feedback: dont run gles tests where restrictions apply

2015-06-12 Thread Timothy Arceri
I'm not longer as confident about this as old GL specs are just as vague but the restriction isn't enforced there, for more information please see: https://bugs.freedesktop.org/show_bug.cgi?id=90961 On Sat, 13 Jun 2015 11:30:49 +1000 Timothy Arceri t_arc...@yahoo.com.au wrote: In GLES vertex

[Piglit] [PATCH] ext_transform_feedback: dont run gles tests where restrictions apply

2015-06-12 Thread Timothy Arceri
In GLES vertex shader outputs cant be arrays of structs or structs that contain arrays or structs. The GLSL ES 3.0 spec says: Vertex output variables output per-vertex data and are declared using the out storage qualifier or the centroid out storage qualifier. They can only be float,

[Piglit] [PATCH 2/4] arb_arrays_of_arrays: add simple atomic counters execution test

2015-06-07 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass --- .../vs-simple-inc-dec-read.shader_test | 119 + 1 file changed, 119 insertions(+) create mode 100644 tests/spec/arb_arrays_of_arrays/execution/atomic_counters/vs-simple-inc-dec-read.shader_test diff

[Piglit] [PATCH 4/4] arb_arrays_of_arrays: basic image store execution tests

2015-06-07 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47 basic-imageStore-const-uniform-index.shader_test - pass basic-imageStore-non-const-uniform-index.shader_test - pass --- ...asic-imageStore-const-uniform-index.shader_test | 58 ...-imageStore-non-const-uniform-index.shader_test |

[Piglit] [PATCH 1/4] arb_arrays_of_arrays: test binding limits for uniforms

2015-06-07 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47: fail --- tests/all.py | 6 + tests/spec/CMakeLists.txt | 1 + tests/spec/arb_arrays_of_arrays/CMakeLists.gl.txt | 15 ++ tests/spec/arb_arrays_of_arrays/CMakeLists.txt| 1 +

[Piglit] [PATCH 3/4] arb_arrays_of_arrays: add basic linking tests for atomic counters

2015-06-07 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47 vs-to-fs-atomic-counter-mismatch.shader_test - fail vs-to-fs-atomic-counter.shader_test - pass --- .../vs-to-fs-atomic-counter-mismatch.shader_test | 38 ++ .../linker/vs-to-fs-atomic-counter.shader_test | 38

[Piglit] [PATCH] arb_arrays_of_arrays: add some sampler tests

2015-06-06 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47 sampler-precision-qualifier.frag - pass fs-const-index-three-dimensions.shader_test - pass fs-const-index.shader_test - pass fs-initializer-const-index.shader_test - fail fs-initializer-non-const-index.shader_test - fail

[Piglit] [PATCH] arb_gpu_shader5: test indexing of samplers inside structs

2015-06-03 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass --- .../fs-struct-nonconst-sampler-const.shader_test | 72 ...fs-struct-nonconst-sampler-nonconst.shader_test | 77 ++ .../fs-struct-nonconst-sampler.shader_test | 72

Re: [Piglit] [PATCH] varying-packing: add arrays of arrays support

2015-05-12 Thread Timothy Arceri
Anyone brave enough to to give this a quick review? It's been on the list since mid last year I'd really like to push it so I can move on :) Thanks, Tim On Sun, 2015-04-26 at 16:13 +1000, Timothy Arceri wrote: V3: rebase and test double types V2: renamed variables from 'inner' that should

[Piglit] [PATCH] varying-packing: add arrays of arrays support

2015-04-26 Thread Timothy Arceri
V3: rebase and test double types V2: renamed variables from 'inner' that should have been 'outer' --- tests/all.py | 4 +- .../glsl-1.10/execution/varying-packing/simple.c | 137 +++-- 2 files changed, 100 insertions(+), 41 deletions(-)

Re: [Piglit] [PATCH 14/14] khr_debug/debug-push-pop-group: fix test

2015-04-25 Thread Timothy Arceri
, it reuses the one from PushDebugGroup(). On Sat, Apr 25, 2015 at 6:59 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: On Mon, 2015-04-13 at 20:28 +0200, Marek Olšák wrote: From: Daniel Kurtz djku...@chromium.org AFAICT from [0], only PopDebugGroup() adds a message to the log

Re: [Piglit] [PATCH V3 2/2] arb_arrays_of_arrays: compile test all basic types

2015-04-24 Thread Timothy Arceri
There seems to be no other feedback on this. Do you guys mind if I push this now? On Wed, 2015-04-01 at 16:44 +1100, Timothy Arceri wrote: V3: Tell piglit that GL_ARB_arrays_of_arrays is required V2: fix glsl-1.20-basic-types.vert previously it contained the glsl-4.20-basic-types.frag test

Re: [Piglit] [PATCH 14/14] khr_debug/debug-push-pop-group: fix test

2015-04-24 Thread Timothy Arceri
On Mon, 2015-04-13 at 20:28 +0200, Marek Olšák wrote: From: Daniel Kurtz djku...@chromium.org AFAICT from [0], only PopDebugGroup() adds a message to the log, not PushDebugGroup(). [0] https://www.opengl.org/registry/specs/KHR/debug.txt Thus, there should only be three messages in

[Piglit] [PATCH 2/2] arb_arrays_of_arrays: compile test all basic types

2015-03-31 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass --- .../compiler/glsl-1.20-basic-types.vert| 46 ++ .../compiler/glsl-1.30-basic-types.vert| 31 +++ .../compiler/glsl-1.40-basic-types.vert| 19 +

[Piglit] [PATCH 1/2] arb_arrays_of_arrays: change input compile tests to fragment shaders

2015-03-31 Thread Timothy Arceri
Although the existing tests are valid until link time, it doesn't make much sense to test this way. --- .../compiler/input-array-array-var.frag | 15 +++ .../compiler/input-array-array-var.vert | 15 ---

[Piglit] [PATCH V3 2/2] arb_arrays_of_arrays: compile test all basic types

2015-03-31 Thread Timothy Arceri
V3: Tell piglit that GL_ARB_arrays_of_arrays is required V2: fix glsl-1.20-basic-types.vert previously it contained the glsl-4.20-basic-types.frag test Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass --- .../compiler/glsl-1.20-basic-types.vert| 45 +

Re: [Piglit] [PATCH 2/2] arb_arrays_of_arrays: compile test all basic types

2015-03-31 Thread Timothy Arceri
On Wed, 2015-04-01 at 01:29 -0400, Ilia Mirkin wrote: On Wed, Apr 1, 2015 at 1:01 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass --- .../compiler/glsl-1.20-basic-types.vert| 46

Re: [Piglit] [PATCH] arb_arrays_of_arrays: compile test basic types

2015-03-31 Thread Timothy Arceri
On Tue, 2015-03-31 at 12:02 +0300, Martin Peres wrote: On 30/03/15 10:29, Timothy Arceri wrote: Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass --- This is just /tests/spec/glsl-1.20/compiler/structure-and-array-operations/array-of-any-type.vert with an extra dimension

[Piglit] [PATCH] arb_arrays_of_arrays: compile test basic types

2015-03-30 Thread Timothy Arceri
Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass --- This is just /tests/spec/glsl-1.20/compiler/structure-and-array-operations/array-of-any-type.vert with an extra dimension added. .../compiler/arrays-of-any-type.vert | 44 ++ 1 file changed, 44

Re: [Piglit] [PATCH] arb_arrays_of_arrays: compile test basic types

2015-03-30 Thread Timothy Arceri
On Mon, 2015-03-30 at 10:51 +0300, Martin Peres wrote: On 30/03/15 10:29, Timothy Arceri wrote: Test results: Nvidia GeForce 840M - NVIDIA 346.47: pass --- This is just /tests/spec/glsl-1.20/compiler/structure-and-array-operations/array-of-any-type.vert with an extra dimension

[Piglit] [PATCH 2/2] arb_arrays_of_arrays: fix output size

2015-03-29 Thread Timothy Arceri
Fix array sizes so that the arrays are not larger than the minimum implementation requirement of GL_MAX_VERTEX_ATTRIBS. Also assign something to the output so that its marked as used. The minumum for GL_MAX_VERTEX_ATTRIBS is 64. ---

[Piglit] [PATCH 1/2] arb_arrays_of_arrays: test linking of interface fields

2015-03-29 Thread Timothy Arceri
Test results: AMD Radeon HD 6670 - Catalyst 14.501.1003 OpenGL 4.4 vs-to-fs-interface-field-mismatch.shader_test - fail vs-to-fs-interface-field-mismatch2.shader_test - fail vs-to-fs-interface-field-unsized-mismatch.shader_test - crash vs-to-fs-interface-field-unsized-mismatch2.shader_test -

[Piglit] [PATCH] glsl-1.50: check read only interfaces are read only

2015-03-27 Thread Timothy Arceri
Test results: AMD Radeon HD 6670 - Catalyst 14.501.1003 OpenGL 4.4 interface-block-instance-name-input-read-only.frag - pass interface-block-input-read-only.frag - pass interface-block-instance-name-uniform-read-only.frag - fail interface-block-uniform-read-only.frag - fail ---

[Piglit] [PATCH 2/2] arb_arrays_of_arrays: fix output size

2015-03-13 Thread Timothy Arceri
Fix array sizes so that the arrays are not larger than the minimum implementation requirement of GL_MAX_VERTEX_ATTRIBS. Also assign something to the output so that its marked as used. The minumum for GL_MAX_VERTEX_ATTRIBS is 64. ---

[Piglit] [PATCH 1/2] arb_arrays_of_arrays: test linking of interface fields

2015-03-13 Thread Timothy Arceri
Test results: AMD Radeon HD 6670 - Catalyst 14.501.1003 OpenGL 4.4 vs-to-fs-interface-field-mismatch.shader_test - fail vs-to-fs-interface-field-mismatch2.shader_test - fail vs-to-fs-interface-field-unsized-mismatch.shader_test - crash vs-to-fs-interface-field-unsized-mismatch2.shader_test -

[Piglit] [PATCH] glsl-1.50: fix some linker tests

2014-12-23 Thread Timothy Arceri
From: Timothy Arceri t.arc...@bom.gov.au dont assign values to shader inputs --- I didn't realise my mistake as Mesa currently allows inputs to change. I'm working on some Mesa fixes for this. .../intrastage-unsized-interface-array-mismatch.shader_test | 12 +--- ...intrastage

[Piglit] [PATCH] glsl-1.50: check shader input is read only

2014-12-23 Thread Timothy Arceri
--- tests/spec/glsl-1.50/compiler/input-read-only.frag | 17 + 1 file changed, 17 insertions(+) create mode 100644 tests/spec/glsl-1.50/compiler/input-read-only.frag diff --git a/tests/spec/glsl-1.50/compiler/input-read-only.frag

[Piglit] [PATCH] glsl-1.50: test implicitly sized arrays match explicitly sized arrays across the same stage

2014-12-22 Thread Timothy Arceri
--- ...ge-unsized-interface-array-mismatch.shader_test | 55 + ...e-unsized-interface-array-mismatch2.shader_test | 56 ++ .../intrastage-unsized-interface-array.shader_test | 55 + ...intrastage-unsized-interface-array2.shader_test | 56

[Piglit] [PATCH V2] glsl-1.20: test implicitly sized arrays match explicitly sized arrays across the same stage

2014-12-04 Thread Timothy Arceri
AMD: pass Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- .../intrastage-unsized-array-mismatch.shader_test | 33 ++ .../intrastage-unsized-array-mismatch2.shader_test | 33 ++ .../linker/intrastage-unsized-array.shader_test| 33

[Piglit] [PATCH 2/2] arb_arrays_of_arrays: linker intrastage tests

2014-12-04 Thread Timothy Arceri
: pass intrastage-unsized-mismatch.shader_test AMD: pass intrastage-unsized-mismatch2.shader_test AMD: pass intrastage-unsized.shader_test AMD: pass intrastage.shader_test AMD: pass Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- These tests lead me to finding a bug with single

[Piglit] [PATCH 1/2 V2] arb_arrays_of_arrays: linker tests

2014-12-04 Thread Timothy Arceri
: crash vs-to-fs-unsized.shader_test AMD: pass vs-to-fs.shader_test AMD: pass vs-to-gs-invalid-dimensions.shader_test AMD: crash vs-to-gs.shader_test AMD: crash Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- I could do more negitive tests but it feels like this is really just

[Piglit] [PATCH] glsl-1.20: test implicitly sized arrays match explicitly sized arrays across the same stage

2014-11-25 Thread Timothy Arceri
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- .../intrastage-unsized-array-mismatch.shader_test | 33 ++ .../intrastage-unsized-array-mismatch2.shader_test | 33 ++ .../linker/intrastage-unsized-array.shader_test| 33

[Piglit] [PATCH] arb_arrays_of_arrays: linker tests

2014-11-22 Thread Timothy Arceri
: crash Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- I could do more negitive tests but it feels like this is really just testing the compile stage rather than linking. tests/all.py | 3 ++ .../vs-to-fs-dimension-size-mismatch.shader_test | 31

[Piglit] [PATCH V2 1/2] glsl-1.10: extend to test arrays of arrays

2014-11-18 Thread Timothy Arceri
Extends the varying packing tests to support testing arrays of arrays V2: renamed variables from 'inner' that should have been 'outer' Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- tests/all.py | 2 +- .../glsl-1.10/execution/varying-packing

[Piglit] [PATCH V2 2/2] arb_arrays_of_arrays: geometry shader tests

2014-11-18 Thread Timothy Arceri
* gs-redeclares-pervertex-in-as-array-of-arrays2.geom AMD: fail Nvidia: pass* Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- This is a resend of a patch from July Can be tested on mesa using this branch: https://github.com/tarceri/Mesa_arrays_of_arrays/tree/linking3 These geom shader

[Piglit] [PATCH V3] gl-4.4: Test GL_MAX_VERTEX_ATTRIB_STRIDE

2014-08-15 Thread Timothy Arceri
V3: add positive version of each test V2: changed to - too Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- tests/all.py| 1 + tests/spec/CMakeLists.txt | 1 + tests/spec/gl-4.4/CMakeLists.gl.txt | 14 +++ tests

[Piglit] [PATCH] gl-4.4: Test GL_MAX_VERTEX_ATTRIB_STRIDE

2014-08-14 Thread Timothy Arceri
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- tests/all.py| 1 + tests/spec/CMakeLists.txt | 1 + tests/spec/gl-4.4/CMakeLists.gl.txt | 14 +++ tests/spec/gl-4.4/CMakeLists.txt| 1 + tests/spec

[Piglit] [PATCH V2] gl-4.4: Test GL_MAX_VERTEX_ATTRIB_STRIDE

2014-08-14 Thread Timothy Arceri
V2: changed to - too Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- tests/all.py| 1 + tests/spec/CMakeLists.txt | 1 + tests/spec/gl-4.4/CMakeLists.gl.txt | 14 +++ tests/spec/gl-4.4/CMakeLists.txt

Re: [Piglit] Help with finishing ARB_arrays_of_arrays

2014-08-07 Thread Timothy Arceri
On Wed, 2014-08-06 at 15:46 -0700, Matt Turner wrote: On Thu, Jul 31, 2014 at 5:04 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: Hi guys. Is anyone interested in helping me finish of the arrays of arrays extension by taking on a mentor type role for reviewing my piglit tests? I'm just

Re: [Piglit] [patch v3 13/15] arb_arrays_of_arrays/compiler/subroutine.vert: make parse correctly

2014-07-31 Thread Timothy Arceri
On Mon, 2014-07-28 at 17:34 -0700, Dylan Baker wrote: This currently uses 3 require extensions lines, this doesn't actually work and never has, but with patches earlier in this series this stops parsing since the parser raises an error. Reviewed-by: Timothy Arceri t_arc...@yahoo.com.au

[Piglit] Help with finishing ARB_arrays_of_arrays

2014-07-31 Thread Timothy Arceri
Hi guys. Is anyone interested in helping me finish of the arrays of arrays extension by taking on a mentor type role for reviewing my piglit tests? I'm just looking for someone I can cc in on the tests that will get around to reviewing them at some point in time (no rush). It just seems

[Piglit] [PATCH] arb_arrays_of_arrays: fix required extensions

2014-06-24 Thread Timothy Arceri
Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- tests/spec/arb_arrays_of_arrays/compiler/initialization-invalid2.vert | 3 +-- tests/spec/arb_arrays_of_arrays/compiler/initialization-invalid3.vert | 3 +-- tests/spec/arb_arrays_of_arrays/compiler/initialization-invalid4.vert | 3

[Piglit] [PATCH V4 07/11] arb_arrays_of_arrays: length and bounds tests

2014-06-14 Thread Timothy Arceri
-array.vert AMD: pass Nvida: fail (Nvidia only warns for outofbounds) Intel: pass Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- .../compiler/length-array-array-var.vert | 13 + .../compiler/length-array-var-array.vert | 13

[Piglit] [PATCH V4 06/11] arb_arrays_of_arrays: interface and struct tests

2014-06-14 Thread Timothy Arceri
: pass Nvida: pass Intel: pass structure-field-var-array-array.frag AMD: pass Nvida: pass Intel: pass Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- .../arrays-of-struct-with-field-arrays.vert| 29 ++ .../compiler/interface-field-array-array-var.vert | 18

[Piglit] [PATCH V4 02/11] arb_arrays_of_arrays: add more initializer tests

2014-06-14 Thread Timothy Arceri
-by: Timothy Arceri t_arc...@yahoo.com.au --- ...alizer-dec-list-type-array-array-var1-var2.vert | 43 +++ ...-dec-list-type-array-var1-array-var2-array.vert | 47 + ...ist-type-var1-array-array-var2-array-array.vert | 43 +++ .../initializer-struct

[Piglit] [0/11 V4] ARB_arrays_of_arrays compile tests

2014-06-14 Thread Timothy Arceri
Hi all, I've been carrying around these tests for 6 months and would really like to push them if there are no objections. I've started work on some execution tests and my current mesa branch for arrays of arrays now passes all these tests so it would be good if I could just push these now and

[Piglit] [PATCH V4 05/11] arb_arrays_of_arrays: input and output tests

2014-06-14 Thread Timothy Arceri
Intel: pass output-array-var-array.vert AMD: pass Nvida: pass Intel: pass output-var-array-array.frag AMD: pass Nvida: pass Intel: pass output-var-array-array.vert AMD: pass Nvida: pass Intel: pass Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- .../compiler/input-array-array-var.vert

[Piglit] [PATCH V4 03/11] arb_arrays_of_arrays: add more constructor tests

2014-06-14 Thread Timothy Arceri
: pass constructor-three-dimensions.vert AMD: pass Nvida: pass Intel: pass constructor-unsized.vert AMD: pass Nvida: pass Intel: pass Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- .../compiler/constructor-invalid-assignment.vert | 17 + .../constructor-invalid

[Piglit] [PATCH V4 04/11] arb_arrays_of_arrays: function parameter and comparision tests

2014-06-14 Thread Timothy Arceri
-parameter-definition-var-array-array.vert AMD: pass Nvida: pass Intel: pass function-parameter-unsized.vert AMD: pass Nvida: pass Intel: pass Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- .../compiler/equal-implicit-size.vert | 33 ++ .../compiler/equal

[Piglit] [PATCH V4 01/11] arb_arrays_of_arrays: initializer and constructor tests

2014-06-14 Thread Timothy Arceri
: pass Nvida: pass Intel: pass Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- tests/all.py | 7 +++ .../compiler/constructor-array-array-var.vert | 17 + .../compiler/constructor-array-var-array.vert | 17

[Piglit] [PATCH V4 08/11] arb_arrays_of_arrays: redeclaration and subroutine tests

2014-06-14 Thread Timothy Arceri
Intel: pass subroutine.vert AMD: pass Nvida: skip Intel: skip Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- .../compiler/redeclaration-initializer.vert| 31 ++ .../compiler/redeclaration-too-small.vert | 29 + .../compiler/redeclaration

[Piglit] [PATCH V4 09/11] arb_arrays_of_arrays: uniform tests

2014-06-14 Thread Timothy Arceri
Intel: pass uniform-unsized-invalid-var-array-array2.vert AMD: pass Nvida: fail Intel: pass uniform-unsized-var-array-array.vert AMD: pass Nvida: pass Intel: crash uniform-var-array-array.vert AMD: pass Nvida: pass Intel: crash Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au

[Piglit] [PATCH V4 11/11] arb_arrays_of_arrays: builtin test

2014-06-14 Thread Timothy Arceri
: pass Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- .../compiler/gl_TexCoord-invalid-multidim.vert | 17 + 1 file changed, 17 insertions(+) create mode 100644 tests/spec/arb_arrays_of_arrays/compiler/gl_TexCoord-invalid-multidim.vert diff --git a/tests/spec

[Piglit] [PATCH V4 10/11] arb_arrays_of_arrays: assignment tests

2014-06-14 Thread Timothy Arceri
-to-3d.vert AMD: pass Intel: pass Signed-off-by: Timothy Arceri t_arc...@yahoo.com.au --- .../compiler/assignment-1d-to-3d.vert | 18 ++ .../compiler/assignment-2d-to-3d-from-3d.vert | 18 ++ .../compiler/assignment-2d-to-3d.vert | 18

Re: [Piglit] [PATCH] khr_debug: add basic tests for glDebugMessageControl

2014-05-22 Thread Timothy Arceri
I've skimmed over this and it looks ok. Haven't had time to review fully but I have tested on Mesa and Catalyst so: Tested-by: Timothy Arceri t_arc...@yahoo.com.au On Fri, 2014-04-25 at 18:36 +0800, Chia-I Wu wrote: Signed-off-by: Chia-I Wu o...@lunarg.com Cc: Timothy Arceri t_arc

Re: [Piglit] [PATCH] glsl-1.10: extend to test arrays of arrays

2014-05-22 Thread Timothy Arceri
Bump. Anyone able to take a look over this? I understand that arrays of arrays is not really a glsl-1.10 test by this test also contains tests for 1.20 and 1.30 so I figured I'd add arrays of arrays too rather than duplicating the code elsewhere. On Tue, 2014-05-06 at 11:10 +1000, Timothy Arceri

[Piglit] Suggestions for creating statistical information from piglit results

2014-05-14 Thread Timothy Arceri
After Valve's Rich Geldreich blasting of OpenGL drivers and reading this post [2] which trys to compare the driver quality of different drivers using the g-truc samples [3] I'm now interested in creating a similar graph and html page with a breakdown of pass/fail into gl version categories similar

Re: [Piglit] Suggestions for creating statistical information from piglit results

2014-05-14 Thread Timothy Arceri
On Wed, 2014-05-14 at 10:23 -0400, Ilia Mirkin wrote: On Wed, May 14, 2014 at 3:11 AM, Timothy Arceri t_arc...@yahoo.com.au wrote: After Valve's Rich Geldreich blasting of OpenGL drivers and reading this post [2] which trys to compare the driver quality of different drivers using the g-truc

<    1   2   3   4   5   6   7   >