Re: [Piglit] [PATCH 3/5] framwork/summary: use mako's render_unicode method instead of render

2015-07-06 Thread Dylan Baker
On Mon, Jul 06, 2015 at 04:30:19PM -0700, Liam Middlebrook wrote: > No problem. > > Happy Python 3! > > Reviewed-by: Liam Middlebrook Thanks! signature.asc Description: Digital signature ___ Piglit mailing list Piglit@lists.freedesktop.org http://li

Re: [Piglit] [PATCH 3/5] framwork/summary: use mako's render_unicode method instead of render

2015-07-06 Thread Liam Middlebrook
No problem. Happy Python 3! Reviewed-by: Liam Middlebrook On 07/06/2015 04:25 PM, Dylan Baker wrote: * PGP Signed by an unknown key On Mon, Jul 06, 2015 at 04:18:48PM -0700, Liam Middlebrook wrote: I find it's generally a good idea to follow the PEP8 standard for Python formatting. https://

Re: [Piglit] [PATCH 3/5] framwork/summary: use mako's render_unicode method instead of render

2015-07-06 Thread Dylan Baker
On Mon, Jul 06, 2015 at 04:18:48PM -0700, Liam Middlebrook wrote: > I find it's generally a good idea to follow the PEP8 standard for Python > formatting. > https://www.python.org/dev/peps/pep-0008/ Absolutely, and except when following PEP8 would produce odd results we do follow PEP8, and both f

Re: [Piglit] [PATCH 3/5] framwork/summary: use mako's render_unicode method instead of render

2015-07-06 Thread Liam Middlebrook
I find it's generally a good idea to follow the PEP8 standard for Python formatting. https://www.python.org/dev/peps/pep-0008/ Also this change lgtm. On 07/02/2015 04:46 PM, Dylan Baker wrote: Because python 3 uses unicode by default, this is required to get python 3 to work; for python 2 thi

Re: [Piglit] [PATCH 3/5] framwork/summary: use mako's render_unicode method instead of render

2015-07-06 Thread Dylan Baker
On Tue, Jul 07, 2015 at 08:00:10AM +1000, Timothy Arceri wrote: > Looks reasonable, I'm not 100% sure on the formating of python code in piglit > but I'm sure you know what your doing with the whitespace changes. We do a bit of both. Mainly we try to be < 80 characters wide, so whichever is easier

Re: [Piglit] [PATCH 3/5] framwork/summary: use mako's render_unicode method instead of render

2015-07-06 Thread Timothy Arceri
Looks reasonable, I'm not 100% sure on the formating of python code in piglit but I'm sure you know what your doing with the whitespace changes. Reviewed-by: Timothy Arceri On Thu, 2015-07-02 at 16:46 -0700, Dylan Baker wrote: > Because python 3 uses unicode by default, this is required to get p

[Piglit] [PATCH 3/5] framwork/summary: use mako's render_unicode method instead of render

2015-07-02 Thread Dylan Baker
Because python 3 uses unicode by default, this is required to get python 3 to work; for python 2 this has no effect on the generated values. Signed-off-by: Dylan Baker --- framework/summary.py | 43 +++ 1 file changed, 23 insertions(+), 20 deletions(-) di