Re: [Piglit] [PATCH 2/7] gl-4.4: set KHR_no_error compatibility

On 05/18/2017 04:00 AM, Timothy Arceri wrote: --- tests/spec/gl-4.4/gl_max_vertex_attrib_stride.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/tests/spec/gl-4.4/gl_max_vertex_attrib_stride.c b/tests/spec/gl-4.4/gl_max_vertex_attrib_stride.c index

Re: [Piglit] [PATCH 1/7] arb_base_instance: set KHR_no_error compatibility

Reviewed-by: Samuel Pitoiset On 05/18/2017 04:00 AM, Timothy Arceri wrote: --- tests/spec/arb_base_instance/baseinstance-doesnt-affect-gl-instance-id.c | 1 + tests/spec/arb_base_instance/drawarrays.c| 1 + 2 files changed, 2

Re: [Piglit] [PATCH 3/7] arb_uniform_buffer_object: set KHR_no_error compatibility

Few comments below, you missed all negative-* tests. With those fixed, patch is: Reviewed-by: Samuel Pitoiset On 05/18/2017 04:00 AM, Timothy Arceri wrote: --- .../bindbuffer-general-point.c | 1 +

Re: [Piglit] [PATCH] glean: remove test_uniform_multiple_samplers()

On 05/19/2017 02:41 AM, Timothy Arceri wrote: There are enought shader_runner and likely CTS tests to make this redundant. Typo: enough Reviewed-by: Samuel Pitoiset --- tests/glean/tshaderapi.cpp | 18 -- 1 file changed, 18 deletions(-) diff

Re: [Piglit] [PATCH 4/7] arb_draw_indirect: set KHR_no_error compatibility

Reviewed-by: Samuel Pitoiset On 05/18/2017 04:00 AM, Timothy Arceri wrote: --- tests/spec/arb_draw_indirect/api-errors.c | 1 + tests/spec/arb_draw_indirect/draw-arrays-base-instance.c | 1 +

Re: [Piglit] [PATCH 3/4] arb_bindless_texture: add new explicit-image-binding.shader_test

On 19/05/17 22:52, Samuel Pitoiset wrote: Similar to explicit-sampler-binding.shader_test but that one but that one -> but this one ? exercices the explicit binding layout qualifier with bound/bindless images. Signed-off-by: Samuel Pitoiset ---

Re: [Piglit] [PATCH] parser_utils: do not overwrite value when no digits are found

Reviewed-by: Timothy Arceri On 19/05/17 22:52, Samuel Pitoiset wrote: "If there were no digits at all, strtol() stores the original value of nptr in *endptr (and returns 0)." If the parsing helper functions are used inside a loop like the "fb tex 2d x" command, the

[Piglit] [PATCH 1/4] shader_runner: clear resident handles before texture bindings

At this point, the resident handles are already removed and glMake{Texture,Image}HandleNonResidentARB() reported INVALID_OPERATION errors because handles weren't resident. Signed-off-by: Samuel Pitoiset --- tests/shaders/shader_runner.c | 6 +++--- 1 file changed, 3

[Piglit] [PATCH 4/4] arb_bindless_texture: fix setting bound/bindless uniforms

The initial arb_bindless_texture-uniform wasn't totally correct after getting a confirmation from Jeff Bolz (NVIDIA). The spec allows setting a bindless sampler uniform with either glUniformi1*() or glUniformHandle*(), while a bound sampler uniform can only be set using glUniform1*().

[Piglit] [PATCH 2/4] shader_runner: only clear handles that are resident

To avoid potential INVALID_OPERATION errors reported by glMake{Texture,Image}HandleNonResidentARB(). Signed-off-by: Samuel Pitoiset --- tests/shaders/shader_runner.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git

[Piglit] [PATCH] parser_utils: do not overwrite value when no digits are found

"If there were no digits at all, strtol() stores the original value of nptr in *endptr (and returns 0)." If the parsing helper functions are used inside a loop like the "fb tex 2d x" command, the parsed value is overwritten with zero and this ends up by reporting "No texture bound at 0".

[Piglit] [PATCH 3/4] arb_bindless_texture: add new explicit-image-binding.shader_test

Similar to explicit-sampler-binding.shader_test but that one exercices the explicit binding layout qualifier with bound/bindless images. Signed-off-by: Samuel Pitoiset --- .../images/explicit-image-binding.shader_test | 58 ++ 1 file changed,

[Piglit] [PATCH] test/gleantest: fix missing --quick property from quick profile

--- framework/test/gleantest.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/test/gleantest.py b/framework/test/gleantest.py index b2d56f3..0220c1a 100644 --- a/framework/test/gleantest.py +++ b/framework/test/gleantest.py @@ -49,21 +49,21 @@ class

Re: [Piglit] [PATCH 4/5] framework: Add command.setter method to Test

On 19/05/17 16:12, Timothy Arceri wrote: On 18/05/17 19:17, Michel Dänzer wrote: On 12/05/17 01:47 PM, Timothy Arceri wrote: From: Dylan Baker This allows the command to be overwritten or modified after instantiation, which is useful for adding additional arguments

[Piglit] [PATCH] test_gleantest: make sure --quick is returned when set in GLOBAL_PARAMS

--- unittests/framework/test/test_gleantest.py | 1 + 1 file changed, 1 insertion(+) diff --git a/unittests/framework/test/test_gleantest.py b/unittests/framework/test/test_gleantest.py index b9122d2..3ff2b8c 100644 --- a/unittests/framework/test/test_gleantest.py +++

Re: [Piglit] [PATCH 4/5] framework: Add command.setter method to Test

On 18/05/17 19:17, Michel Dänzer wrote: On 12/05/17 01:47 PM, Timothy Arceri wrote: From: Dylan Baker This allows the command to be overwritten or modified after instantiation, which is useful for adding additional arguments in a profile. Signed-off-by: Dylan Baker