Re: [Piglit] [PATCH] drawpix-z: test glDrawPixels(GL_DEPTH_COMPONENT)

2012-06-12 Thread Eric Anholt
On Mon, 11 Jun 2012 14:07:37 -0600, Brian Paul bri...@vmware.com wrote: v2: simplify the Z coord code: use [0,1] range for Z for all drawing. --- tests/all.tests |1 + tests/general/CMakeLists.gl.txt |1 + tests/general/drawpix-z.c | 136

[Piglit] [PATCH 1/2] Add test to verify the functionality of glBitmap() with multisample FBO

2012-06-12 Thread Anuj Phogat
glBitmap() is expected to work exactly the same way on multisample FBO as it works on single sample FBO. Test assumes that MSAA accuracy test already passes. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/all.tests|6 +

[Piglit] [PATCH 2/2] Add test to verify the functionality of polygon stipple with multisample FBO

2012-06-12 Thread Anuj Phogat
Test assumes that MSAA accuracy test already passes. Signed-off-by: Anuj Phogat anuj.pho...@gmail.com --- tests/all.tests|6 + .../ext_framebuffer_multisample/CMakeLists.gl.txt |1 + .../polygon-stipple.cpp| 271

[Piglit] [PATCH 0/5] Initial GLX_ARB_create_context_profile and GLX_EXT_create_context_es2_profile tests

2012-06-12 Thread Ian Romanick
(Apologies to people on CC who received this twice. I mistyped the address for the piglit list the first time.) This is an initial set of tests for GLX_ARB_create_context_profile and GLX_EXT_create_context_es2_profile. These tests just verify that the GLX API generates the correct errors and

[Piglit] [PATCH 1/5] glx_arb_create_context_profile: Verify that invalid profiles are rejected

2012-06-12 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com NVIDIA's closed-source driver passes this test. AMD's closed-source driver has not been tested. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- tests/all.tests|4 +

[Piglit] [PATCH 2/5] glx_arb_create_context_profile: Verify that the core profile is supported for OpenGL 3.2

2012-06-12 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com NVIDIA's closed-source driver passes this test. AMD's closed-source driver has not been tested. NVIDIA's closed-source driver supports both core and compatibility profiles. Signed-off-by: Ian Romanick ian.d.roman...@intel.com --- tests/all.tests

[Piglit] [PATCH 4/5] glx_ext_create_context_es2_profile: Verify that indirect-rendering is impossible

2012-06-12 Thread Ian Romanick
From: Ian Romanick ian.d.roman...@intel.com The spec doesn't forbid indirect rendering with OpenGL ES 2.0. There's no protocol defined, so it seems impossible that this could ever work. NVIDIA's closed-source driver fails this test. An indirect-rendering ES2 context is created. I have not

Re: [Piglit] [PATCH 1/6] glsl-1.20 / glsl-1.30: Add tests for uniforms with initializers

2012-06-12 Thread Paul Berry
On 21 May 2012 14:10, Ian Romanick i...@freedesktop.org wrote: On 05/21/2012 10:34 AM, Paul Berry wrote: On 16 May 2012 14:23, Ian Romanick i...@freedesktop.org mailto:i...@freedesktop.org wrote: From: Ian Romanick ian.d.roman...@intel.com mailto:ian.d.romanick@intel.**com

Re: [Piglit] [PATCH 4/5] glx_ext_create_context_es2_profile: Verify that indirect-rendering is impossible

2012-06-12 Thread Ian Romanick
On 06/12/2012 02:56 PM, James Jones wrote: On 6/12/12 2:47 PM, Ian Romanick wrote: On 06/12/2012 02:35 PM, James Jones wrote: On 6/12/12 2:25 PM, Ian Romanick wrote: From: Ian Romanickian.d.roman...@intel.com The spec doesn't forbid indirect rendering with OpenGL ES 2.0. There's no protocol

[Piglit] [PATCH 1/2] msaa: Refactor all.tests so that sample counts to test are specified once.

2012-06-12 Thread Paul Berry
--- tests/all.tests | 21 - 1 files changed, 12 insertions(+), 9 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index a004323..6d9e0ce 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -64,6 +64,9 @@ try: except SystemExit: pass +# List of all of

[Piglit] [PATCH 2/2] msaa: Test that msaa blits are clipped and scissored correctly.

2012-06-12 Thread Paul Berry
There are three reasons why the set of rectangles passed to glBlitFramebuffer() might need to be clipped before performing the blit: 1. If the destination rectangle falls (partly or completely) outside the bounds of the draw framebuffer. 2. If the destination rectangle falls (partly or

Re: [Piglit] [PATCH 5/5] glx_ext_create_context_es2_profile: Verify that the invalid ES versions are rejected

2012-06-12 Thread Ian Romanick
On 06/12/2012 02:40 PM, James Jones wrote: On 6/12/12 2:25 PM, Ian Romanick wrote: From: Ian Romanickian.d.roman...@intel.com NVIDIA's closed-source driver fails this test. GLXBadProfileARB is generated instead of BadMatch. The specification isn't specific about what error should be

Re: [Piglit] [PATCH 4/5] glx_ext_create_context_es2_profile: Verify that indirect-rendering is impossible

2012-06-12 Thread James Jones
On 6/12/12 3:12 PM, Ian Romanick wrote: On 06/12/2012 02:56 PM, James Jones wrote: On 6/12/12 2:47 PM, Ian Romanick wrote: On 06/12/2012 02:35 PM, James Jones wrote: On 6/12/12 2:25 PM, Ian Romanick wrote: From: Ian Romanickian.d.roman...@intel.com The spec doesn't forbid indirect rendering

[Piglit] [PATCH 00/14] Move main() from libpiglitutil into each test

2012-06-12 Thread Chad Versace
The goal that this series achieves is to replace the main() function in piglit-framework.c with a new function, piglit_gl_test_run(), that takes as its input a data structure describing the test initialization info. This goal is a stepping stone towards a larger set of goals discussed earlier

[Piglit] [PATCH 02/14] cmake: For MSVC, add include/msvc/c99 to include path

2012-06-12 Thread Chad Versace
Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- CMakeLists.txt |2 ++ 1 file changed, 2 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 7202417..0dbb14f 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -138,6 +138,8 @@ if (MINGW) endif () if (WIN32) +

[Piglit] [PATCH 03/14] util: Remove custom defs of C99 types for MSVC

2012-06-12 Thread Chad Versace
piglit-util.h contained an #ifdef that defined C99 types for MSVC. Remove that #ifdef block and let MSVC simply include the C99 headers located at $PIGLIT_TOP/include/msvc/c99. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-util.h | 22 ++ 1

[Piglit] [PATCH 04/14] util: Add missing #include

2012-06-12 Thread Chad Versace
piglit-framework-fbo.h used bool, but did not include stdbool.h. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-fbo.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/util/piglit-framework-fbo.h

[Piglit] [PATCH 05/14] util: Move piglit_use_fbo to piglit-framework.*

2012-06-12 Thread Chad Versace
piglit_use_fbo was declared and defined in piglit-framework-fbo.{h,c}. The next commit adds module piglit-framework-glut, which implements functionality orthogonal to piglit-framework-fbo, and hence shouldn't rely on its header. That's why piglit_use_fbo should be moved to the neutral parent

[Piglit] [PATCH 06/14] util: Remove unused piglit_present_results()

2012-06-12 Thread Chad Versace
This was declared in piglit-framework.h, but never defined. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework.h |1 - 1 file changed, 1 deletion(-) diff --git a/tests/util/piglit-framework.h b/tests/util/piglit-framework.h index a01b050..fcf38cf 100644

[Piglit] [PATCH 07/14] util: Move glut code from piglit-framework.* to piglit-framework-glut.*

2012-06-12 Thread Chad Versace
The fbo code has already been moved into piglit-framework-fbo.*. For symmetry and clarity, the glut code should exist in its own module too. As a bonus, this refactor gives piglit-framework.c a well-defined purpose: to parse argv and then dispatch the testrun to either piglit-framework-fbo or

[Piglit] [PATCH 08/14] util: Refactor argv processing out of main()

2012-06-12 Thread Chad Versace
Move argument processing out of main() into a separate function. By simplifying main(), we simplify the transition of main() from libpiglitutil to test executable. Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework.c | 26 +++--- 1

[Piglit] [PATCH 09/14] util: Move more GLUT initializtion code into piglit-framework-glut.c

2012-06-12 Thread Chad Versace
Why move initialize GLUT in two different places? This patch moves the GLUT initiliazation code located in piglit-util.c into piglit_framework_glut_init(). Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-glut.c | 14 +-

Re: [Piglit] [PATCH 03/14] util: Remove custom defs of C99 types for MSVC

2012-06-12 Thread Kenneth Graunke
On 06/12/2012 04:02 PM, Chad Versace wrote: piglit-util.h contained an #ifdef that defined C99 types for MSVC. Remove that #ifdef block and let MSVC simply include the C99 headers located at $PIGLIT_TOP/include/msvc/c99. Signed-off-by: Chad Versace chad.vers...@linux.intel.com ---

Re: [Piglit] [PATCH 1/6] glsl-1.20 / glsl-1.30: Add tests for uniforms with initializers

2012-06-12 Thread Ian Romanick
On 06/12/2012 03:02 PM, Paul Berry wrote: On 21 May 2012 14:10, Ian Romanick i...@freedesktop.org mailto:i...@freedesktop.org wrote: On 05/21/2012 10:34 AM, Paul Berry wrote: On 16 May 2012 14:23, Ian Romanick i...@freedesktop.org mailto:i...@freedesktop.org

Re: [Piglit] [PATCH 03/14] util: Remove custom defs of C99 types for MSVC

2012-06-12 Thread Chad Versace
On 06/12/2012 05:21 PM, Kenneth Graunke wrote: On 06/12/2012 04:02 PM, Chad Versace wrote: piglit-util.h contained an #ifdef that defined C99 types for MSVC. Remove that #ifdef block and let MSVC simply include the C99 headers located at $PIGLIT_TOP/include/msvc/c99. Signed-off-by: Chad

[Piglit] [PATCH] util: Remove unused piglit_set_default_fbo() [v2]

2012-06-12 Thread Chad Versace
This was declared in piglit-framework.h, but never defined. CC: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework.h |1 - 1 file changed, 1 deletion(-) diff --git a/tests/util/piglit-framework.h