Re: [Piglit] [PATCH 2/2] glsl-max-varyings: Add a variant that also tests MAX_VARYING_COMPONENTS.

2012-11-14 Thread Brian Paul
On 11/13/2012 04:21 PM, Eric Anholt wrote: Given that piglit hasn't been testing this, I don't want to modify the existing glsl-max-varyings which has been very useful. I don't want a non-rendering test, though, because gl 2.0 allows an implementation to allow shaders

Re: [Piglit] [PATCH 3/5] GL_ARB_texture_buffer_object/formats: Add real support for testing GL core.

2012-11-14 Thread Eric Anholt
Chad Versace chad.vers...@linux.intel.com writes: Reviewed-by: Chad Versace chad.vers...@linux.intel.com I have a few open-ended comments on the approach you used here. One of the original goals of switching Piglit to Waffle and adding a config block to the top of each test was to allow

Re: [Piglit] [PATCH] Add test glsl-uniform-out-of-bounds-2.c

2012-11-14 Thread Ian Romanick
On 11/05/2012 11:39 AM, Frank Henigman wrote: This test shows the problem fixed by my add bounds checking for uniform array access patch, sent to mesa-dev on Nov. 2. Check behavior of glGetUniformLocation, glGetUniform and glUniform(Matrix) when attempting to access non-existent array elements.

[Piglit] GLES

2012-11-14 Thread Tom Gall
Hi All, I've an interest in using piglit for GLES testing on ARM for both linux and android. I've noticed that things are a bit light in the GLES test department. It seems like perhaps some selective porting of parts of Glean but written for GLES might be the wise thing to do however I'm new

Re: [Piglit] GLES

2012-11-14 Thread Ian Romanick
On 11/14/2012 12:11 PM, Tom Gall wrote: Hi All, I've an interest in using piglit for GLES testing on ARM for both linux and android. I've noticed that things are a bit light in the GLES test department. That is something of an understatement. :) Which version of GLES do you want to test?

Re: [Piglit] GLES

2012-11-14 Thread Tom Gall
On Wed, Nov 14, 2012 at 2:20 PM, Ian Romanick i...@freedesktop.org wrote: On 11/14/2012 12:11 PM, Tom Gall wrote: Hi All, I've an interest in using piglit for GLES testing on ARM for both linux and android. I've noticed that things are a bit light in the GLES test department. That is

Re: [Piglit] [PATCH] Fix discovery of OpenCL framework on MacOS.

2012-11-14 Thread tom
On 2012-11-14 02:41, Aaron Watry wrote: Tested on Mac OS 10.7 --- Reviewed-by: Tom Stellard thomas.stell...@amd.com cmake/Modules/FindOpenCL.cmake |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/cmake/Modules/FindOpenCL.cmake

Re: [Piglit] [PATCH 2/5] shader_runner: Use integers for GL and GLSL versions

2012-11-14 Thread Ian Romanick
On 11/14/2012 01:18 PM, Eric Anholt wrote: Ian Romanick i...@freedesktop.org writes: From: Ian Romanick ian.d.roman...@intel.com In floating point, 3.1 is actually 3.09, and that's just awsome for comparing GL versions. + sscanf(line, %u.%u, major, minor); + + /* This

Re: [Piglit] [PATCH 2/2] egl: Add test egl-create-context-verify-gl-flavor (v2)

2012-11-14 Thread Ian Romanick
On 11/14/2012 08:29 AM, Chad Versace wrote: On 11/13/2012 04:36 PM, Ian Romanick wrote: On 11/09/2012 11:45 AM, Chad Versace wrote: This test requests various flavors (that is, api and version and profile) of contexts and verifies that the context's actual flavor is compatible with the

[Piglit] [PATCH] Fix MacOS build for OpenCL tests

2012-11-14 Thread Aaron Watry
1) Fix creation of libpiglitutil_cl.dylib 2) Fix includes of OpenCL.h to finish fixing MacOS build Previous error message when linking dylib was: Linking C shared library ../../../../lib/libpiglitutil_cl.dylib Undefined symbols for architecture x86_64: _piglit_cl_get_test_config, referenced

Re: [Piglit] [PATCH] Fix discovery of OpenCL framework on MacOS.

2012-11-14 Thread Aaron Watry
Would someone mind pushing this for me (as well as [1] from Nov 1)? I've just applied for a fd.o account and piglit commit access, but until this (hopefully) gets approved I'll need a little help. [1] - http://lists.freedesktop.org/archives/piglit/2012-November/003641.html --Aaron Watry On Wed,

[Piglit] [PATCH] all.tests: Remove glean/rgbTriStrip.

2012-11-14 Thread Kenneth Graunke
It doesn't actually test anything, and thus can never fail. --- tests/all.tests | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/all.tests b/tests/all.tests index 70dca35..b1002d4 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -112,7 +112,6 @@ glean['pointSprite'] =