are not written into the tests
dictionary.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
the value of CMakeCache.txt:WAFFLE_VERSION in any text
editor.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
CMakeLists.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 7418ac3..d9bd28e 100644
--- a/CMakeLists.txt
+++ b
Let make_context_current_singlepass() directly call
waffle_config_choose(). Add helper function make_config_attrib_list()
that makes the attribute list passed to waffle_config_choose(). This
refactor will make possible better error messages.
Signed-off-by: Chad Versace chad.vers
When waffle_config_choose() or waffle_context_create() fails, print
Waffle's error message to stderr. Several people (Carl, Ian, Timothy
Arceri) have requested this.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/piglit-framework-gl/piglit_wfl_framework.c | 7 ---
1
on my branch:
git://people.freedesktop.org/~chadversary/piglit
branch=fwd-compat-and-debug-contexts
I found no regressions when running against mesa-10.0 on GLX with Ivybridge.
v3: Add patch 1, which works around a deficiency in CMake's dependency
validation.
Chad Versace (9):
cmake: Fix
Unify the 3 occurences of message Failed to create ... context, and
move the message closer to the failure.
Print a more helpful message when special_case_gl_31() fails.
Add helper function make_context_description(), used in the newer better
error messages.
Signed-off-by: Chad Versace
the version instead with
if(WAFFLE_VERSION VERSION_LESS 1.2.2)
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
CMakeLists.txt | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/CMakeLists.txt b/CMakeLists.txt
index e952e24..7418ac3 100644
forward-compatible contexts,
because, according to thw EGL_KHR_create_context spec, requesting
a forward-compatible context for OpenGL versions less than
3.0 will generate an error.
Remove the hack. Pass the requested context version to Waffle.
Signed-off-by: Chad Versace chad.vers
Add a new boolean flag to the PIGLIT_GL_TEST_CONFIG block,
`config.require_forward_compatible_context`. If the test is unable to
create a foward-compatible context, then the test skips.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/piglit-framework-gl.h
Create a context with or without the forward-compatible bit, according to
a command line flag. Then verify that GL_CONTEXT_FLAGS does or does not
contain GL_CONTEXT_FLAG_FORWARD_COMPATIBLE_BIT.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/all.tests
On Mon, Dec 30, 2013 at 07:42:27PM +1100, Timothy Arceri wrote:
Here is some feedback from my testing with AMD Catalyst drivers. As
previously discussed they seem to be missing GLX_ARB_create_context
extension is from server glx extensions
With V1 on Catalyst I got:
piglit: info: Failed
On Mon, Jan 06, 2014 at 11:41:26AM -0800, Ian Romanick wrote:
On 12/30/2013 04:08 PM, Chad Versace wrote:
Subsequent patches will enable creation of forward-compatible and debug
contexts, which arrived in waffle-1.3.
After this patch, you may need to remove CMakeCache.txt and rerun CMake
On Tue, Jan 07, 2014 at 12:02:37AM +0800, Daniel Kurtz wrote:
When using the PIGLIT_GL_TEST_CONFIG_* macros to create a test, a
piglit_gl_framework, 'gl_fw' is used to store gl framework state,
including core and extension gl dispatch handlers.
Just before running the actual test code,
]);
^
Signed-off-by: Daniel Kurtz djku...@chromium.org
---
tests/spec/gles-3.0/texture-immutable-levels.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
___
Piglit mailing list
Piglit
+ ' -auto -fbo')
+gles30['texture-immutable-levels'] =
concurrent_test('texture-immutable-levels_gles3')
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo
/GLSL_ES_Specification_3.00.4.pdf
Signed-off-by: Daniel Kurtz djku...@chromium.org
---
tests/spec/ext_texture_array/compressed.c | 1 +
1 file changed, 1 insertion(+)
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
___
Piglit mailing list
Piglit
(const struct
piglit_gl_test_config *test_config)
fail:
destroy(gl_fw);
return NULL;
+#endif /* PIGLIT_USE_OPENGL_ES1 */
}
This makes sense to me.
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
___
Piglit mailing list
Piglit
/glCopyTexImage2D.xml
[3] http://www.khronos.org/opengles/sdk/docs/man3/xhtml/glCopyTexImage2D.xml
Signed-off-by: Daniel Kurtz djku...@chromium.org
---
.../oes_compressed_etc1_rgb8_texture-basic.c | 4
1 file changed, 4 insertions(+)
Looks good to me.
Reviewed-by: Chad
On Fri, Jan 10, 2014 at 10:50:50AM -0800, Matt Turner wrote:
On Fri, Jan 10, 2014 at 10:30 AM, Chad Versace
chad.vers...@linux.intel.com wrote:
On Tue, Jan 07, 2014 at 12:02:43AM +0800, Daniel Kurtz wrote:
Add these gles specific tests to CMakelists so they will be built when
targeting
(If you don't use Piglit's Waffle backend, then you can safely ignore
this announcement).
(If commit dca9752 from 2014-01-10 didn't break your build, then you too
can safely this announcement).
A recent commit, dca9752, bumped Piglit's Waffle requirement from 1.2 to
1.3. This was required to add
files changed, 5 insertions(+), 3 deletions(-)
Thanks, committed to master.
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On Mon, Jan 13, 2014 at 08:30:16PM +0800, Daniel Kurtz wrote:
Hi Chad,
With this patch applied, we don't even get as far as glGetIntegerv(),
since we can't even resolve glGetString to deduce the GL_VERSION in
piglit_dispatch_default_init()-piglit_dispatch_init()-piglit_get_gl_version().
#
On Tue, Jan 14, 2014 at 09:47:45PM +0800, Daniel Kurtz wrote:
On Tue, Jan 14, 2014 at 9:38 AM, Chad Versace
chad.vers...@linux.intel.com wrote:
On Mon, Jan 13, 2014 at 08:30:16PM +0800, Daniel Kurtz wrote:
Hi Chad,
With this patch applied, we don't even get as far as glGetIntegerv
}.format(self.__test_filepath))
return
@property
--
1.8.5.2
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On Wed, Jan 15, 2014 at 04:20:46PM -0800, Eric Anholt wrote:
Chad Versace chad.vers...@linux.intel.com writes:
On Tue, Jan 14, 2014 at 09:47:45PM +0800, Daniel Kurtz wrote:
Likewise, yesterday as I began to go deeper into solving the EGL
dispatch problem, and discovered a chain
On Wed, Jan 15, 2014 at 07:09:55PM +0800, Daniel Kurtz wrote:
With the following patches I am able to build and run piglit tests on a system
with no OpenGL and no GLX (ie, no glproto, no libGL.so and no
/usr/include/GL).
The X11, GBM and wayland patches are really 'bug reports', it seems
On Wed, Jan 22, 2014 at 11:08:17AM -0800, Dylan Baker wrote:
On Monday, January 20, 2014 10:04:06 AM Daniel Kurtz wrote:
This block was accidentally left in place when patch [0] was applied.
[0] fc007bc7c6729c2d4ad61fe8360c43c973404ce5
cmake: indent spaces - tabs
Signed-off-by:
in attribs,
these changes make sure that we gracefully detault to desktop GL if ES
not chosen by user.
tests/egl/egl-util.c | 40 ++--
1 file changed, 34 insertions(+), 6 deletions(-)
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
And committed
If found, add PIGLIT_HAS_UDEV to CFLAGS and set the cmake variable of
the same name.
Future tests for EGL_MESA_platform_gbm will use udev.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
CMakeLists.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/CMakeLists.txt b
Add tests for Linux platform extensions layered atop
EGL_EXT_platform_base:
EGL_EXT_platform_x11
EGL_EXT_platform_wayland
EGL_MESA_platform_gbm
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/all.py | 9 +
tests/egl/spec
Weston open and a kernel with render nodes.
Chad Versace (5):
cmake: Search for udev.pc on Linux
util/egl: Add EGLDisplay parameter to piglit_require_egl_extension()
egl: Use piglit_require_egl_extension() when appropriate
util/egl: Support querying client extensions
EGL_EXT_platform_base
This patch replaces all occurences of
if (!piglit_is_egl_extension_supported(...)) {
piglit_report_result(PIGLIT_SKIP);
}
with piglit_require_egl_extension().
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/egl/spec/egl-1.4/egl-terminate-then-unbind-context.c
This patch fixes piglit_is_egl_extension_supported() to correctly handle
client extensions.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/piglit-util-egl.c | 8
1 file changed, 8 insertions(+)
diff --git a/tests/util/piglit-util-egl.c b/tests/util/piglit-util
EGL_NO_DISPLAY.
This is useful for EGL tests that need to create a display for
a specific platform.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/piglit-util-egl.c | 55
tests/util/piglit-util-egl.h | 14 +++
2 files changed, 69
Add new header piglit-log.h which exposes the following functions:
piglit_log_get_opt()
piglit_log_set_opt()
piglit_loge()
piglit_logi()
This new module should help to reduce redundant logging boilerplate
found in many Piglit files.
Signed-off-by: Chad Versace chad.vers
Set PIGLIT_HAS_PTHREADS as a CMake variable and cpp feature macro if
CMake succeeds in compiling a small test file that uses pthread_self(),
Future EGL_KHR_fence_sync tests will be multi-threaded.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
CMakeLists.txt | 18
of piglit_require_egl_extension()
match that of piglit_is_egl_extension_supported().
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/spec/ext_image_dma_buf_import/intel_external_sampler_only.c| 5 +++--
.../ext_image_dma_buf_import/intel_external_sampler_with_dma_only.c | 5 +++--
tests/spec
lives in GL-dependent file
piglit-framework-gl.c, and must be moved to the API-independent file
piglit-util.c so that non-GL tests can use it.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/piglit-framework-gl.c | 104 ++-
1 file changed
This prepares for using Piglit's subtest magic for non-GL tests.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/piglit-framework-gl.c | 6 +++---
tests/util/piglit-framework-gl.h | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/util/piglit
This prepares for using Piglit's subtest magic in non-GL tests.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/spec/arb_compute_shader/api_errors.c | 2 +-
tests/util/piglit-framework-gl.c | 10 +-
tests/util/piglit-framework-gl.h | 12
, add the tests.
I verified this series does not regression Piglit master 4de1a79 on Ivybridge
with PIGLIT_PLATFORM=x11_egl.
Chad Versace (13):
util: Add func streq()
util: Refactor parsing subtest args
util/gl: Reject unrecongized subtest names
util/gl: Rename struct piglit_gl_subtest
some latent bugs in the tests.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/all.py |4 +
tests/egl/spec/CMakeLists.txt |1 +
.../spec/egl_khr_fence_sync/CMakeLists.gles2.txt |9 +
tests/egl/spec
not fail until
it attempted to execute the invalid subtest. Post-patch, the test fails
during arg parsing.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/piglit-framework-gl.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/tests/util/piglit-framework-gl.c b/tests/util
Please. Let's stop writing `!strcmp(...)` and `strcmp(...) == 0`. This
patch defines a little function streq() that reads much more nicely than
idioms using strcmp.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/piglit-util.c | 6 ++
tests/util/piglit-util.h | 6
I forgot to say... this series lives on a personal branch:
git://people.freedesktop.org/~chadversary/piglit EGL_KHR_fence_sync
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On Wed, Mar 26, 2014 at 11:06:01AM -0700, Matt Turner wrote:
It's a one line wrapper -- just define it in the header and let
inlining do its thing.
Makes sense. I'll make the change before comitting.
___
Piglit mailing list
On Thu, Mar 27, 2014 at 08:08:50AM -0700, Jose Fonseca wrote:
I think it would be more portable to use FindThreads module that comes with
cmake. e.g.:
find_package (Threads)
target_link_libraries (my_program
${CMAKE_THREAD_LIBS_INIT}
)
if (CMAKE_USE_PTHREADS_INIT)
On Fri, Apr 18, 2014 at 11:13:28AM -0400, Ilia Mirkin wrote:
Hi Chad,
I've recently started getting build errors on piglit...
I think it's a little annoying to force people to build against the
very latest EGL headers, but I guess it's not the worst thing in the
world either.
Any ideas?
XOpenDisplay, eglInitialize, etc.) However, the tests pass in their
current state, so there's no reason they shouldn't be merged.
Thanks a bunch to Chad Versace and Rob Bradford, who helped me debug
this code!
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Cc: Chad Versace chad.vers
On Tue, Apr 22, 2014 at 06:29:46PM -0700, Sarah Sharp wrote:
On Sat, Apr 19, 2014 at 12:20:26PM -0700, Chad Versace wrote:
On Fri, Apr 18, 2014 at 03:37:38PM -0700, Sarah Sharp wrote:
fail:
if (state.egl_dpy) {
eglMakeCurrent(state.egl_dpy, EGL_NO_SURFACE, EGL_NO_SURFACE
On Tue, Apr 22, 2014 at 12:22:12PM -0700, Sarah Sharp wrote:
On Fri, Apr 18, 2014 at 06:21:31PM -0700, Jamey Sharp wrote:
I'm no expert on OML_sync_control, but in a funny coincidence I've
been reading that spec and Xorg's DRI2 implementation of it pretty
carefully recently. (I blame
On Thu, Apr 24, 2014 at 09:17:50AM -0700, Jamey Sharp wrote:
On Apr 23, 2014 1:36 PM, Chad Versace chad.vers...@linux.intel.com wrote:
On Tue, Apr 22, 2014 at 12:22:12PM -0700, Sarah Sharp wrote:
On Fri, Apr 18, 2014 at 06:21:31PM -0700, Jamey Sharp wrote:
- I don't see that MSC has
Eric said:
But then there's the broken configure caching that makes it so you have
to git clean regularly, and the broken library directory handling. I
mean, look at the workarounds in chad's [Piglit] [ANNOUNCE] waffle =
1.3 required, you may need to rerun CMake. This build system is
-dependent, so it may behave differently on Windows, Linux,
and Apple. The test just makes sure it increments monotonically.
The test uses Chad's new subtest infrastructure and the EGL convenience
functions from egl-util.c.
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
Cc: Chad
Patches 1-6 are
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
-off-by: Dylan Baker baker.dyla...@gmail.com
---
generated_tests/gen_texture_lod_tests.py | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
Patch 7 is
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
___
Piglit mailing
Waffle's website and source has moved from Freedesktop to Github. The
mailing list will remain at Freedesktop.
These are the new urls:
source: git://github.com/waffle-gl/waffle
gitweb: https://github.com/waffle-gl/waffle
issue-tracker: https://github.com/waffle-gl/waffle/issues
= ['profile']
import itertools
import os
-import os.path as path
import platform
import subprocess
import sys
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org
I'm working to clean up Piglit's crazy build system, which builds each
target multiple times, once for each supported API.
You can track my progress here:
git://people.freedesktop.org/~chadversary/piglit refs/heads/unify-build
The directory is no longer used because Piglit now generates
piglit-dispatch from the Khronos XML.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
Full patch redacted due to size.
CMakeLists.txt | 1 -
cmake/piglit_glapi.cmake |45 -
glapi/.gitignore
Rename
generated_dispatch.[ch] - piglit-dispatch-gen.[ch]
to match the filename convention followed by all other files in
tests/util.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
cmake/piglit_dispatch.cmake | 4 ++--
tests/util/.gitignore| 4 ++--
tests/util
Import revision 26792 on 2014-05-22 from
(https://cvs.khronos.org/svn/repos/ogl/trunk/doc/registry/public/api/gl.xml).
I'm importing the Khronox XML because I want to generate piglit-dispatch
code from it rather than scraping GL headers and unmaintained *.spec
files.
Signed-off-by: Chad Versace
This patch removes the files piglit-util-gl*-enum.c and instead replaces
them with a single piglit-util-gl-enum-gen.c generated from the Khronos
XML.
The two functions now generated are:
piglit_get_gl_enum_name(GLenum param)
piglit_get_prim_name(GLenum prim)
Signed-off-by: Chad Versace
piglit-dispatch*.c to libpiglitutil_gles1 in the CMake.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
src/piglit/gl_wrap.h | 68 +-
.../depth-stencil-texture.c| 9 ---
tests/util/CMakeLists.gl.txt
piglit-dispatch*.c to libpiglitutil_gles1 in the CMake.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
src/piglit/gl_wrap.h | 68 +-
.../depth-stencil-texture.c| 9 ---
tests/util/CMakeLists.gl.txt
refs/tags/unify-build-2014-06-16
You can follow work in progress on the branch:
git://people.freedesktop.org/~chadversary/piglit refs/heads/unify-build
v2:
- Fix typo: s/Khronox/Khronos/
- Truncate patch 2 so that mailmain accepts it.
Chad Versace (6):
registry: Import gl.xml from
The directory is no longer used because Piglit now generates
piglit-dispatch from the Khronos XML.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
Patch truncated due to size.
CMakeLists.txt | 1 -
cmake/piglit_glapi.cmake |45 -
glapi/.gitignore | 1
This patch removes the files piglit-util-gl*-enum.c and instead replaces
them with a single piglit-util-gl-enum-gen.c generated from the Khronos
XML.
The two functions now generated are:
piglit_get_gl_enum_name(GLenum param)
piglit_get_prim_name(GLenum prim)
Signed-off-by: Chad Versace
On Fri, Jun 13, 2014 at 12:35:07PM -0700, Matt Turner wrote:
On Fri, Jun 13, 2014 at 8:27 AM, Dylan Baker baker.dyla...@gmail.com wrote:
Is there an obvious way for us to tell when our version of gl.xml has
drifted
out of date with the upstream khronos version?
Download a new one and
On Mon, Jun 23, 2014 at 05:36:13PM -0700, Dylan Baker wrote:
Chad, you mentioned you had comments on this patch?
Right, I commented on the Bugzilla ticket.
https://bugs.freedesktop.org/show_bug.cgi?id=80261
___
Piglit mailing list
on failure:
Hint: Try installing Mako with `pip install --user --upgrade Mako`
Reported-by: Tom Stellard thomas.stell...@amd.com
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
CMakeLists.txt | 13 ++
cmake/Modules/PiglitFindMako.cmake | 93
for this to cmake.
Patch sent:
From: Chad Versace chad.vers...@linux.intel.com
Date: Wed, 25 Jun 2014 20:38:25 -0700
Subject: [PATCH] cmake: Require Mako = 0.7
If no one objects, I will commit it Thursday evening.
___
Piglit mailing list
Piglit
...@alum.mit.edu
---
tests/util/piglit-framework-gl/piglit_wfl_framework.c | 4
1 file changed, 4 insertions(+)
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org
The function logs a debug message if environment variable
PIGLIT_DEBUG is 1 or true.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/piglit-log.c | 37 +
tests/util/piglit-log.h | 6 ++
2 files changed, 43 insertions(+)
diff --git
Commit 1fdb953 removed some noisy debug messages with preprocessor
guards. This patch re-enables them, but only if the environment variable
PIGLIT_DEBUG is 1 or true.
Fixes some unused variable warnings.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/piglit-framework-gl
On Mon, Jun 30, 2014 at 08:14:16PM -0400, Ilia Mirkin wrote:
On Mon, Jun 30, 2014 at 8:11 PM, Chad Versace
chad.vers...@linux.intel.com wrote:
The function logs a debug message if environment variable
PIGLIT_DEBUG is 1 or true.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
...@freedesktop.org
---
tests/egl/egl-create-surface.c | 6 --
1 file changed, 6 deletions(-)
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
and committed.
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org
of XDG_CONFIG_HOME should respect the environment variable,
if set. Like this:
xdg_config_dir = os.environ.get('XDG_CONFIG_HOME',
os.path.expanduser('~/.config'))
Respect the XDG_CONFIG_HOME env var, and this patches is
Reviewed-by: Chad Versace chad.vers
On Mon, Jun 30, 2014 at 04:53:21PM -0700, Dylan Baker wrote:
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
piglit.conf.example | 4
tests/igt.py| 11 ---
2 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/piglit.conf.example b/piglit.conf.example
On Thu, Jul 03, 2014 at 12:37:57PM -0700, Josh Triplett wrote:
This patch series unifies both the GL and GLES utility functions into a single
set of functions in piglit-util-gl-common.c, in preparation for unifying the
libraries themselves.
I've confirmed (on an IVB test system) that this
On Fri, Jul 04, 2014 at 08:43:29AM -0700, Tom Stellard wrote:
On Wed, Jun 25, 2014 at 08:47:24PM -0700, Chad Versace wrote:
Piglit began requiring Mako 0.7 as of commit ac1f382 dispatch:
Generate piglit-dispatch from Khronos XML.
Piglit has required Mako for a long time, and CMake did
This series eliminates all compiler warnigns when building with clang.
Chad Versace (4):
util: Fix a -Wtautological-compare warning
util: Fix an -Wabsolute-value warning
util: Fix an -Wabsolute-value warning
util/fbo: Fix -Wunused-function warnings
tests/util/piglit-framework-gl
tests/util/piglit-log.c: warning: comparison of unsigned enum \
expression 0 is always false [-Wtautological-compare]
return opt 0 || opt PIGLIT_LOG_OPT_MAX;
~~~ ^ ~
Fix the warning by removing the dead comparison.
Signed-off-by: Chad Versace chad.vers
To fix the warning below, cast uint to int.
tests/util/piglit-util-gl-common.c:1273:9: warning: taking the absolute value \
of unsigned type 'unsigned int' has no effect [-Wabsolute-value]
if (fabs(probe[p] - expected[p]) = piglit_tolerance[p]) {
Signed-off-by: Chad Versace chad.vers
]) {
^
tests/util/piglit-util-gl-common.c:1240:9: note: use function 'abs' instead
if (fabs(probe[p] - expected[p]) = piglit_tolerance[p]) {
^~~~
abs
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/piglit-util-gl-common.c | 2 +-
1 file changed, 1 insertion
guards.
This patch shouldn't change any runtime behavior.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/piglit-framework-gl/piglit_fbo_framework.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/tests/util/piglit-framework-gl
piglit_wfl_framework already initializes piglit-dispatch. Don't do it
again.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/piglit-framework-gl/piglit_fbo_framework.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/util/piglit-framework-gl
.
This patch brings us one step closer to unifying Piglit's CMake files.
piglit_require_GLSL
piglit_require_vertex_shader
piglit_require_fragment_shader
piglit_program_pipeline_check_status
piglit_program_pipeline_check_status_quiet
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
The entire file piglit-shader-gl.c was protected by #ifdef
PIGLIT_USE_OPENGL. This patch removes the #ifdef. Now that
piglit-dispatch supports every OpenGL API, there is no longer a need for
it.
This patch brings us one step closer to unifying Piglit's CMake files.
Signed-off-by: Chad Versace
CMake never knew about this file, and now it never will.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/piglit-shader-gles1.c | 65
1 file changed, 65 deletions(-)
delete mode 100644 tests/util/piglit-shader-gles1.c
diff --git
These files are no longer used after moving all their functions to
piglit-shader.c.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/CMakeLists.gl.txt | 3 ---
tests/util/CMakeLists.gles2.txt | 2 --
tests/util/CMakeLists.gles3.txt | 2 --
tests/util
Now that piglit-dispatch supports every OpenGL API, there is no
longer a need to provide separate implementations for GL and GLES.
This patch brings us one step closer to unifying Piglit's CMake files.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/minmax-test.c | 8
Now that piglit-dispatch supports every OpenGL API, there is no
longer a need to provide separate implementations for GL and GLES.
Piglit can make API-based decisions at runtime rather than buildtime.
This patch brings us one step closer to unifying Piglit's CMake files.
Signed-off-by: Chad
Now that piglit-dispatch supports every OpenGL API, there is no
longer a need to provide separate implementations for GL and GLES.
Piglit can make API-based decisions at runtime rather than buildtime.
This patch brings us one step closer to unifying Piglit's CMake files.
Signed-off-by: Chad
of libpiglitutil_{gl,gles1,gles2,gles3} contain
the same set of source files.
This patch brings us one step closer to unifying Piglit's CMake files.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/CMakeLists.gl.txt| 10 --
tests/util/CMakeLists.gles2.txt | 8
Now that piglit-dispatch supports every OpenGL API, there is no
longer a need to provide separate implementations for GL and GLES.
This patch brings us one step closer to unifying Piglit's CMake files.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/piglit-util-gl
Now that piglit-dispatch supports every OpenGL API, there is no
longer a need to provide separate implementations for GL and GLES.
Piglit can make API-based decisions at runtime rather than buildtime.
This patch brings us one step closer to unifying Piglit's CMake files.
Signed-off-by: Chad
-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/piglit-shader.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/util/piglit-shader.c b/tests/util/piglit-shader.c
index 38e5182..1f20a8e 100644
--- a/tests/util/piglit-shader.c
+++ b/tests/util/piglit-shader.c
@@ -101,14 +101,12
Now that piglit-dispatch supports every OpenGL API, there is no
longer a need to provide separate implementations for GL and GLES.
This patch brings us one step closer to unifying Piglit's CMake files.
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
tests/util/piglit-util-gl
',
+ os.path.expandvars('$HOME/.config')),
+ os.path.join(os.path.dirname(__file__), '..', '..')]:
The code searches in the correct order, but the comment describes a
different order. Fix the comment and
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
401 - 500 of 566 matches
Mail list logo
