On 07/07/2014 04:20 PM, Dylan Baker wrote:
v2: - replace config name bindir with path (chadv)
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
piglit.conf.example | 3 +++
tests/xts.py| 5 +++--
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/piglit.conf.example
Patches 1-15 are
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
I don't know Piglit's Python well enough to judge patches 16-18.
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
crashes.
Signed-off-by: Daniel Kurtz djku...@chromium.org
---
I do not have commit access, so can someone please submit this for me if it
looks good?
Thanks
-djk
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
And I committed to master
On 08/07/2014 04:09 AM, Daniel Kurtz wrote:
These tests all require EGL_KHR_reusable_sync.
No they don't, at least according to the spec. Have you found a buggy driver?
Or... maybe I wrote the test totally wrong... I hope not.
EGL_KHR_resuable_sync defines the sync type EGL_SYNC_REUSABLE_KHR,
it was just Xlib deprecation warnings, and they're
there without your patch. Sorry for the false alarm.
Reviewed-by: Kristian Høgsberg k...@bitplanet.net
Looks good to me too.
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
___
Piglit mailing
On 08/13/2014 07:13 PM, Daniel Kurtz wrote:
On Thu, Aug 14, 2014 at 6:41 AM, Chad Versace chad.vers...@linux.intel.com
mailto:chad.vers...@linux.intel.com wrote:
On 08/07/2014 04:09 AM, Daniel Kurtz wrote:
These tests all require EGL_KHR_reusable_sync.
No they don't
On 08/18/2014 07:46 PM, Daniel Kurtz wrote:
On Tue, Aug 19, 2014 at 7:05 AM, Chad Versace
chad.vers...@linux.intel.com wrote:
On 08/13/2014 07:13 PM, Daniel Kurtz wrote:
I think the original reason why I wrote this patch was to address
build breakage due to the incomplete dispatch (using
Laura, I tested your updated branch 'master-xml' and commited it to
master. Thanks.
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
On Thu 13 Nov 2014, Tom Gall wrote:
Within Linaro we've recently picked up piglit and added into our
buckets of automated tests, running on Android.
We'd sure like to see piglit advance for GLES testing so there seems
like a lot of room for collaboration. More than willing to give it a
go.
On
= 2.0**(-14) * (1.0 / 2.0**10)
-subnormal_max = 2.0**(-14) * (1023.0 / 2.0**10)
Weird, yeah. Seems unused. Chad?
Yes, unused. Maybe I used it in an uncommitted version of the patch, but
it's unused now.
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
On 12/01/2014 09:41 AM, Chad Versace wrote:
On 11/26/2014 01:11 AM, Emil Velikov wrote:
Things are not as black and white as you might think. Most of piglit
uses what I call target-less rules, which means that when one does
add_definitions ( -DPIGLIT_USE_GLX )
or
link_libraries
Janes mark.a.ja...@intel.com
Signed-off-by: Emil Velikov emil.l.veli...@gmail.com
---
tests/util/CMakeLists.txt | 5 +
1 file changed, 5 insertions(+)
Strangely, I can't reproduce the linking error on Fedora 20.
Anyway, this patch looks good to me.
Reviewed-by: Chad Versace chad.vers
On 12/03/2014 05:16 AM, Emil Velikov wrote:
On 01/12/14 18:17, Chad Versace wrote:
On 12/01/2014 09:41 AM, Chad Versace wrote:
On 11/26/2014 01:11 AM, Emil Velikov wrote:
Things are not as black and white as you might think. Most of piglit
uses what I call target-less rules, which means
On 12/08/2014 03:45 AM, Dylan Baker wrote:
Hi Chad,
I have a few comments below for you, mostly relating to the use of the
global keyword.
I admit that I had trouble with the global variables in this patch.
Python wasn't behaving like C, and that confused me.
diff --git
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
v2:
- Fix DEQPTest.interpret_result to correctly parse test output. (mwmason)
- Remove unused imports (dcbaker)
- Remove extra newlines (dcbaker)
- Don't use 'global' keyword (dcbaker)
- Use global constant
On 12/10/2014 09:03 AM, Mike Mason wrote:
Hi Chad,
See comments below...
Mike, I sent v2 before I saw your reply. I'll respin a v3 shortly that takes
your comments into account.
+def iter_deqp_test_cases():
+Iterate over original dEQP GLES3 testcase names.
+caselist_path =
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
v2:
- Remove unused imports (dcbaker)
- Remove extra newlines (dcbaker)
- Don't use 'global' keyword (dcbaker)
- Use global constant for DEQP_GLES3_EXE (dcbaker)
- Fix DEQPTest.interpret_result to correctly parse test
for PIGLIT_DEQP_GLES_EXTRA_ARGS and
piglit.conf:deqp-gles.extra_args.
Cc: Dylan Baker dylanx.c.ba...@intel.com
Cc: Michael W Mason michael.w.ma...@intel.com
Signed-off-by: Chad Versace chad.vers...@linux.intel.com
---
v2:
- Remove unused imports (dcbaker)
- Remove extra newlines (dcbaker)
- Don't use 'global
On 12/16/2014 02:10 PM, Dylan Baker wrote:
On Tuesday, December 16, 2014 01:49:20 PM Chad Versace wrote:
+try:
+opt = framework.core.PIGLIT_CONFIG.get(config_option[0],
+ config_option[1])
+except ConfigParser.NoSectionError
On 12/28/2014 10:21 PM, Tapani Pälli wrote:
On 12/23/2014 12:35 AM, Ian Romanick wrote:
How do I make a piglit test that calls an unsupported function? I want
to verify that calling a function not supported by the context either
crashes or generates GL_INVALID_OPERATION. All of the
On 10/15/2014 04:36 AM, Tapani Pälli wrote:
Reviewed-by: Chad Versace chad.vers...@intel.com
Signed-off-by: Tapani Pälli tapani.pa...@intel.com
---
...fs-texture-uniforms-share-same-unit.shader_test | 24
++
1 file changed, 24 insertions(+)
create mode 100644
tests
(0) pass;
glGetProgramiv(prog, GL_PROGRAM_BINARY_RETRIEVABLE_HINT, value);
- got_error = piglit_check_gl_error(0);
+ pass = piglit_check_gl_error(0) pass;
if (value != GL_TRUE) {
fprintf(stderr,
Reviewed-by: Chad Versace chad.vers...@intel.com
On Mon 13 Apr 2015, Marek Olšák wrote:
Hi everyone,
These are mostly fixes that I took from Daniel Kurtz's github
repository because I think they are good and he said he had no time to
upstream them. I've been working on the fence extensions for
Mesa/egl_dri2, so I've tested them all.
All
, then we
can easily fix it by changing it to use get_ext_proc_address() instead of
dlsym().
Reviewed-by: Chad Versace chad.vers...@intel.com
Thanks for upstreaming all of Daniel's fixes.
___
Piglit mailing list
Piglit@lists.freedesktop.org
http
The following commit regressed lookup of some new OpenGL symbols:
commit cb334db3f2bb7ddf9b2f43641f898896f99c69b1
Author: Daniel Kurtz djku...@chromium.org
Date: Thu Oct 16 21:36:01 2014 +0800
Subject: dispatch: Use dlsym to lookup core symbols for EGL (v2)
It regressed these
On Wed, Apr 29, 2015 at 8:56 AM, Marek Olšák mar...@gmail.com wrote:
Correction: Only 2 pipeline statistics tests were broken, so all seems
to be good (except those 2 tests).
Marek
On Tue, Apr 28, 2015 at 3:18 PM, Marek Olšák mar...@gmail.com wrote:
Hi Chad,
The patch breaks
On Tue 12 May 2015, Ilia Mirkin wrote:
ping? should be pretty innocuous (i'd think!)
It looks innocuous to me.
Reviewed-by: Chad Versace chad.vers...@intel.com
___
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman
On Tue 12 May 2015, Emil Velikov wrote:
On 9 May 2015 at 08:08, Ilia Mirkin imir...@alum.mit.edu wrote:
GBM presumably defaults to RGB565 otherwise. Not all of these are
required, as some would still work with less precision, but this makes
the tests consistent. At least fp-formats and
On Tue 12 May 2015, Ilia Mirkin wrote:
On Tue, May 12, 2015 at 1:13 PM, Emil Velikov emil.l.veli...@gmail.com
wrote:
On 9 May 2015 at 08:08, Ilia Mirkin imir...@alum.mit.edu wrote:
GBM presumably defaults to RGB565 otherwise. Not all of these are
required, as some would still work with
Emil discovered that my implementation in Mesa was bogus. This test
exposes the error.
Cc: Emil Velikov emil.l.veli...@gmail.com
---
tests/all.py | 6 +
tests/egl/spec/CMakeLists.txt | 1 +
.../CMakeLists.no_api.txt
On Fri 02 Oct 2015, Nanley Chery wrote:
> From: Nanley Chery
>
> These tests check that 2D texture arrays work for the 5x5 and
> 12x12 block sizes.
>
> v2. add to all.py (Ilia).
> create test for gles2.
> v3. upgrade required GLES version to 3.1 (for 2d array
ssed and decompressed
> texture was generated with a reference codec.
>
> v2. numerous changes (Chad).
> v3. upgrade required GLES version to 2.
>
> Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com>
Patch 3/5 is
Revi
/CMakeLists.gl.txt | 1 +
> .../CMakeLists.gles2.txt | 1 +
> .../khr_compressed_astc-basic.c| 385
> +
> 4 files changed, 389 insertions(+)
> create mode 100644
> tests/spec/khr_texture_compression_astc/khr_compressed_astc-
> Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com>
> ---
> tests/all.py | 5 +++
> .../spec/arb_texture_compression/invalid-formats.c | 51
> +-
> 2 files changed, 55 insertions(+), 1 deletion
Add test that transcodes NV12 to RGBA8 by importing the Y plane
as DRM_FORMAT_R8 and importing the UV plane as DRM_FORMAT_GR88.
v2: Delete commented-out code.
CC: Peter Frühberger peter.fruehber...@gmail.com
Cc: Rainer Hochecker rainer.hochec...@onlinehome.de
---
This test requires a patch
Add test that transcodes NV12 to RGBA8 by importing the Y plane
as DRM_FORMAT_R8 and importing the UV plans as DRM_FORMAT_GR88.
CC: Peter Frühberger peter.fruehber...@gmail.com
Cc: Rainer Hochecker rainer.hochec...@onlinehome.de
---
This patch lives on my branch:
> Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com>
> ---
> tests/util/piglit-util-gl.c | 81
> +
> tests/util/piglit-util-gl.h | 31 +
> 2 files changed, 112 insertions(+)
There's a small typo below.
On Fri 28 Aug 2015, Nanley Chery wrote:
> From: Nanley Chery
>
> These tests check that the GL error returned by valid and invalid API calls
> are as defined by the spec.
>
> Signed-off-by: Nanley Chery
> ---
>
.@intel.com>
> ---
> .../spec/arb_texture_compression/invalid-formats.c | 51
> +-
> 1 file changed, 50 insertions(+), 1 deletion(-)
Patch 1 is
Reviewed-by: Chad Versace <chad.vers...@intel.com>
___
Pi
On Tue 08 Sep 2015, Chad Versace wrote:
> On Fri 28 Aug 2015, Nanley Chery wrote:
> > From: Nanley Chery <nanley.g.ch...@intel.com>
> >
> > ASTC formats are added to the list of formats that should not be returned
> > by the
> > COMPRESSED_TEXTURE_FORMAT
do they
still get run during a full Piglit run?
> On Sep 8, 2015 09:50, "Chad Versace" <chad.vers...@intel.com> wrote:
>
> > On Tue 08 Sep 2015, Chad Versace wrote:
> > > On Fri 28 Aug 2015, Nanley Chery wrote:
> > > > From: Nanley Chery <nanley.g.
On Fri 28 Aug 2015, Nanley Chery wrote:
> From: Nanley Chery
>
> These tests run through every ASTC configuration, comparing the
> render of a compressed texture against a render of the decompressed
> version of that compressed texture. The compressed and decompressed
>
On Mon 14 Sep 2015, Nanley Chery wrote:
> On Tue, Sep 8, 2015 at 11:45 AM, Chad Versace <chad.vers...@intel.com>
> wrote:
>
> > On Fri 28 Aug 2015, Nanley Chery wrote:
> > > From: Nanley Chery <nanley.g.ch...@intel.com>
> > >
> > > These tests
This is the obvious thing to do. This eliminates the need to explicitly
link to libGL in every other CMakeLists.gl.txt.
Tested-by: Nanley Chery
---
tests/util/CMakeLists.gl.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/util/CMakeLists.gl.txt
On Wed 16 Sep 2015, Nanley Chery wrote:
> From: Nanley Chery
>
> These tests run through every ASTC configuration, comparing the
> render of a compressed texture against a render of the decompressed
> version of that compressed texture. The compressed and decompressed
>
S version to 3.1 (for 2d array support).
> v4. Move CONFIG block to the top of the file (Chad).
>
> Signed-off-by: Nanley Chery <nanley.g.ch...@intel.com>
Acked-by: Chad Versace <chad.vers...@intel.com>
___
Piglit mailing list
Piglit
The function always returned texture name 0. Fix to to return the
actual texture name.
Found by GCC warning:
tests/util/piglit-util-gl.c:2623:1: warning: control reaches end of
non-void function [-Wreturn-type]
---
tests/util/piglit-util-gl.c | 2 ++
1 file changed, 2 insertions(+)
On Tue 26 Apr 2016, Chad Versace wrote:
> On Mon 18 Apr 2016, Eric Anholt wrote:
> > Fixes test result in non-auto-fbo mode on Intel, where you end up
> > without an alpha channel if you forget to ask for one.
> > ---
> > tests/spec/ext_image_dma_buf_import/sample_rgb.
This fixes `bin/ext_image_dma_buf_import-sample_rgb -fmt=XR24 -alpha-one
-auto` for me.
Reviewed-by: Chad Versace <chad.vers...@intel.com>
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
On Mon 25 Apr 2016, Nicolai Hähnle wrote:
> Hi Chad,
>
> I saw Matt's email and went ahead and just did this before seeing your
> email. Sorry about that!
No problem. All that matters is that the bugs get fixed!
___
Piglit mailing list
The GL_OES_EGL_image_external tests only passed if they succeeded
to DRI2-authenticate with the X server, because piglit_drm_dma_buf.c
used /dev/dri/card0 as the DRM device. This patch teaches that file to
first try /dev/dri/renderD128, then fallback to /dev/dri/card0.
Despite the simple goal of
Return early if xcb_get_setup() returns NULL. Don't use the NULL.
---
tests/util/piglit-framework-gl/piglit_drm_dma_buf.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/tests/util/piglit-framework-gl/piglit_drm_dma_buf.c
Stop calling eglGetProcAddress. Let piglit-dispatch do it.
---
.../intel_external_sampler_only.c | 26 +++---
1 file changed, 3 insertions(+), 23 deletions(-)
diff --git a/tests/spec/ext_image_dma_buf_import/intel_external_sampler_only.c
free(ref_rgba_image);
> return PIGLIT_FAIL;
> }
>
> + free(ref_rgba_image);
> return PIGLIT_PASS;
Reviewed-by: Chad Versace <chad.vers...@intel.com>
And pushed.
There are two calls to piglit_report_result() that also trigger the
leak. Those should be fixe
el Skylake:
spec.ext_framebuffer_object.getteximage-formats init-by-clear-and-render
spec.ext_framebuffer_object.getteximage-formats init-by-render
Regressed by Mesa:
commit c4b87f129eb036c9615df3adcc1cebd9df10fc84
Author: Chad Versace <chadvers...@chromium.org>
Subject: meta: Disable
Pushed.
___
Piglit mailing list
Piglit@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/piglit
On Tue 25 Oct 2016, Rob Clark wrote:
> On Tue, Oct 25, 2016 at 5:19 PM, Rafael Antognolli
> wrote:
> > Hi,
> >
> > I finally got to work on these piglit tests (took longer than I
> > expected). But here is an initial version, and I would like to know if
> > I'm going
On Wed 19 Oct 2016, Ilia Mirkin wrote:
> It builds. I wonder if this should go into piglit-util-egl.h instead.
> Your call. Either way,
>
> Tested-by: Ilia Mirkin
I'll put it in piglit-util-egl.h. That's a good idea.
___
Piglit
Adds 4 subtests:
- initialize_display
- create_window
- create_pixmap
- create_pbuffer
---
tests/egl/spec/CMakeLists.txt | 4 +-
.../CMakeLists.no_api.txt | 7 +
.../egl_mesa_platform_surfaceless/CMakeLists.txt | 1 +
Tests for my EGL_MESA_platform_surfaceless v2 series on mesa-dev.
Branches:
- mesa:
http://git.kiwitree.net/cgit/~chadv/mesa/log/?h=review/EGL_MESA_platform_surfaceless-v02
- piglit:
http://git.kiwitree.net/cgit/~chadv/piglit/log/?h=review/EGL_MESA_platform_surfaceless-v01
Chad Versace
If the args contain -h or --help, then print some help and exit.
The help test describes how to list and run subtests.
---
tests/util/piglit-util.c | 20 +++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/tests/util/piglit-util.c b/tests/util/piglit-util.c
index
piglit_parse_subtest_args() now knows how to parse -h and --help, and
then print a help message.
---
.../spec/egl_khr_fence_sync/egl_khr_fence_sync.c | 76 --
1 file changed, 12 insertions(+), 64 deletions(-)
diff --git
If PIGLIT_HAS_GBM, then add GBM_LDFLAGS to the linker flags. Fixes
undefined symbol errors at link time for me, using Arch Linux.
---
tests/util/CMakeLists.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/util/CMakeLists.txt b/tests/util/CMakeLists.txt
index 3d5bef5..277386e
Add test 'egl_khr_gl_renderbuffer_image-clear-shared-image'. It creates
two renderbuffers which share storage through an EGLImage; clears
a renderbuffer; then checks that the other renderbuffer pixels have the
clear value.
On Mesa master@c4b87f12 with Intel Broadwell,
testing GL_RGBA fails and
On Tue 03 Jan 2017, Ben Widawsky wrote:
> On 17-01-03 13:07:54, Chad Versace wrote:
> > Add test 'egl_khr_gl_renderbuffer_image-clear-shared-image'. It creates
> > two renderbuffers which share storage through an EGLImage; clears
> > a renderbuffer; then checks that the othe
On Wed 12 Apr 2017, Eric Anholt wrote:
> For a solution to the startup time, I wish we would just build our whole
> test list using filesystem walks or whatever at piglit build time,
> instead of executing python to build the test list per piglit run.
A nice benefit of building the test list
501 - 566 of 566 matches
Mail list logo