On 08/18/2014 11:15 AM, Kristian Høgsberg wrote:
> On Sun, Aug 17, 2014 at 5:32 PM, Daniel Kurtz <[email protected]> wrote:
>>
>> On Aug 18, 2014 3:49 AM, "Kristian Høgsberg" <[email protected]> wrote:

>>> It certainly shouldn't be in the header, but egl-util.c needs it and
>>> breaks if you remove it.
>>
>> egl-util.c builds fine for GLES without <GL/gl.h> (and breaks with it).  Why
>> is it needed for GL?  What am I missing?

I think this file used to require <GL/gl.h> before the EGL tests began using 
piglit-dispatch.
> 
> I got compile errors that looked like a missing Xlib.h include, not
> gl.h.  Trying again it was just Xlib deprecation warnings, and they're
> there without your patch.  Sorry for the false alarm.
> 
> Reviewed-by: Kristian Høgsberg <[email protected]>

Looks good to me too.
Reviewed-by: Chad Versace <[email protected]>
_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to