This program does not support resume, but has some code copied from
piglit-run.py for resuming interupted runs, so drop it.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-print-commands.py | 9 -
1 file changed, 9 deletions(-)
diff --git a/piglit-print-commands.py b
available
in python 2.7+ and 3.2+. However, since python 2.7 was released in
July 2010, that doesn't seem unreasonable.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
README | 2 +-
piglit-print-commands.py | 80 +++--
piglit-run.py| 184
Move the re.compile into the core.Enivironment constructor, which
reduces code duplication. It also allows us to pass environment data on
initilization of the object, rather that having edit it's attributes
individually.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/core.py
Excluding tests already uses a similar syntax (--exclude-tests), so this
is more consistent.
V2: - Leaves --tests option, but marks it as deprecated
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-print-commands.py | 12 ++--
piglit-run.py| 12 ++--
2
-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-run.py | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/piglit-run.py b/piglit-run.py
index 9d319eb..28d1a2b 100755
--- a/piglit-run.py
+++ b/piglit-run.py
@@ -52,8 +52,11 @@ Options:
-x regexp, --exclude
This option was implemented, however, it was not added to the help menu,
meaning that a user needed to know that it existed before they could
even attempt to use it.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-run.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/piglit
with python 2.7.1
- 2.7.3 is available for windows
V2: - Splits this change from the next patch (Replaces getopt with
argparse)
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
README | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/README b/README
index 68108c9..69f9e9b
as deprecated
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-print-commands.py | 98 +++
piglit-run.py| 249 +++
2 files changed, 159 insertions(+), 188 deletions(-)
diff --git a/piglit-print-commands.py b/piglit-print
-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/core.py| 26 +++--
piglit-print-commands.py | 29 +++
piglit-run.py| 60
3 files changed, 58 insertions(+), 57 deletions(-)
diff --git
Excluding tests already uses a similar syntax (--exclude-tests), so this
is more consistent.
V2: - Leaves --tests option, but marks it as deprecated
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-print-commands.py | 12 ++--
piglit-run.py| 12 ++--
2
-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-run.py | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/piglit-run.py b/piglit-run.py
index 9d319eb..28d1a2b 100755
--- a/piglit-run.py
+++ b/piglit-run.py
@@ -52,8 +52,11 @@ Options:
-x regexp, --exclude
This option was implemented, however, it was not added to the help menu,
meaning that a user needed to know that it existed before they could
even attempt to use it.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-run.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/piglit
with python 2.7.1
- 2.7.3 is available for windows
V2: - Splits this change from the next patch (Replaces getopt with
argparse)
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
README | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/README b/README
index 68108c9..69f9e9b
as deprecated
V3: - Fixes deprecated warning for tests from V2 always being triggered
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-print-commands.py | 98 +++
piglit-run.py| 249 +++
2 files changed, 159 insertions
Creates a smaller, simpler file that should be easier to maintain going
forward.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-merge-results.py | 39 +--
1 file changed, 9 insertions(+), 30 deletions(-)
diff --git a/piglit-merge-results.py b
Optparse has been deprecated in favor of argparse upstream (PEP 389
http://www.python.org/dev/peps/pep-0389/), and since we are using
argparse already in the other modules, it makes sense to replace
optparse and use only one parsing method in all piglit.
Signed-off-by: Dylan Baker baker.dyla
,
and simplifies the tables.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
Reviewed-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-summary-html.py | 10 --
templates/index.css| 11 +++
templates/index.html | 17 +++--
templates/index_group.html | 3
on
some CSS fragments, this was the intent all along, but didn't work.
This also changes the striping slightly: it now stripes purely based on
whether the row is even/odd, rather than striping on a per-group basis.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
Reviewed-by: Dylan Baker
From: Kenneth Graunke kenn...@whitecape.org
It was entirely empty.
Reviewed-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-summary-html.py | 5 +
templates/index_groupgroup.html | 1 -
2 files changed, 1 insertion(+), 5 deletions(-)
delete mode 100644 templates
in the python code.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
Reviewed-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-summary-html.py | 3 +--
templates/index.css | 4
templates/index_testrun.html | 1 -
3 files changed, 5 insertions(+), 3 deletions(-)
delete mode 100644
the first
row. This works out just fine.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
Reviewed-by: Dylan Baker baker.dyla...@gmail.com
---
templates/index.css | 1 +
1 file changed, 1 insertion(+)
diff --git a/templates/index.css b/templates/index.css
index 27128e4..d066a04 100644
From: Kenneth Graunke kenn...@whitecape.org
Characters like and are need to be escaped in proper HTML/XML.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
Reviewed-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-summary-html.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion
From: Kenneth Graunke kenn...@whitecape.org
We weren't specifying a DTD, which made validator.w3.org angry. There's
no reason not to be strict or use SGML-based HTML, so go with XHTML.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
Reviewed-by: Dylan Baker baker.dyla...@gmail.com
.
There is an updated version on my github.
On Mon, Apr 29, 2013 at 12:38 AM, Kenneth Graunke kenn...@whitecape.orgwrote:
On 04/25/2013 05:02 PM, Dylan Baker wrote:
From: Kenneth Graunke kenn...@whitecape.org
The usual auto table layout algorithm makes the browser look at the
contents of each row
on
some CSS fragments, this was the intent all along, but didn't work.
This also changes the striping slightly: it now stripes purely based on
whether the row is even/odd, rather than striping on a per-group basis.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
Reviewed-by: Dylan Baker
From: Kenneth Graunke kenn...@whitecape.org
It was entirely empty.
Reviewed-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-summary-html.py | 5 +
templates/index_groupgroup.html | 1 -
2 files changed, 1 insertion(+), 5 deletions(-)
delete mode 100644 templates
From: Kenneth Graunke kenn...@whitecape.org
Characters like and are need to be escaped in proper HTML/XML.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
Reviewed-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-summary-html.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion
From: Kenneth Graunke kenn...@whitecape.org
We weren't specifying a DTD, which made validator.w3.org angry. There's
no reason not to be strict or use SGML-based HTML, so go with XHTML.
Signed-off-by: Kenneth Graunke kenn...@whitecape.org
Reviewed-by: Dylan Baker baker.dyla...@gmail.com
While I'm not against renaming all.tests;
We already have include/exclude switches in piglit, what about loading the
include/exclude switches with blacklists, like with a --profile switch or
something similar?
Also python standard very strongly suggests not using `'from module import
*'
On
Have you tested this? When I try to run with just -o (nothing added after)
it attempts to scoop up the next positional argument as the argument for
-o, and fails.
Also, instead of using \ escapes, line up the quotation marks on the left
and python will magically concatenate the strings.
Have you
Oops. My bad, ignore that last email. I understand now.
-Dylan
On Wed, May 8, 2013 at 4:52 PM, Dylan Baker baker.dyla...@gmail.com wrote:
Have you tested this? When I try to run with just -o (nothing added after)
it attempts to scoop up the next positional argument as the argument for
-o
The sections headings are not really that useful, but they might as well
be kept as class level docstrings instead of being thrown away.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py | 28 +++-
1 file changed, 15 insertions(+), 13 deletions
The new summary code (in the next patch) is space indented, and rather
than having a file with mixed tabs and spaces just have one.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py | 366 +--
1 file changed, 183
Adds the actual templates used to by the new mako based summary code.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
templates/index.mako | 79 ++
templates/test_index.mako | 49
templates/test_result.mako
updates the .gitignore file to ignore some generated content
created by this class.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
.gitignore | 2 +
framework/summary.py | 585 +++
2 files changed, 587 insertions(+)
diff --git
Drops almost all of the code used in this file, all of that
functionality is now handled in the summary class. Instead, the majority
of this file is just the argparse instance, and a few short lines
calling the new summary class.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
piglit
These template files are no longer used, and so they should be removed
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
templates/index.html | 33 -
templates/index_group.html | 5 -
templates/index_group_testrun.html | 1
). This is a tidy little speedup.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py | 76 --
templates/test_result.mako | 6 ++--
2 files changed, 30 insertions(+), 52 deletions(-)
diff --git a/framework/summary.py b/framework
In the old summary code one was set equal to the other, and then
written. In order to produce the same output they were both brought over
to the mako code. But they're rather silly and worthless and only one
should be kept.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
templates
-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py | 92 ++--
templates/index.mako | 4 +--
2 files changed, 63 insertions(+), 33 deletions(-)
diff --git a/framework/summary.py b/framework/summary.py
index 5288543..ecaa804 100644
or because it didn't exist yet.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/framework/summary.py b/framework/summary.py
index ecaa804..2d8cc42 100644
--- a/framework/summary.py
+++ b/framework/summary.py
The sections headings are not really that useful, but they might as well
be kept as class level docstrings instead of being thrown away.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py | 29 -
1 file changed, 16 insertions(+), 13 deletions
updates the .gitignore file to ignore some generated content
created by this class.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
.gitignore | 2 +
framework/summary.py | 585 +++
2 files changed, 587 insertions(+)
diff --git
Adds the actual templates used to by the new mako based summary code.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
templates/index.mako | 79 ++
templates/test_index.mako | 49
templates/test_result.mako
These template files are no longer used, and so they should be removed
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
templates/index.html | 33 -
templates/index_group.html | 5 -
templates/index_group_testrun.html | 1
). This is a tidy little speedup.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py | 76 --
templates/test_result.mako | 6 ++--
2 files changed, 30 insertions(+), 52 deletions(-)
diff --git a/framework/summary.py b/framework
In the old summary code one was set equal to the other, and then
written. In order to produce the same output they were both brought over
to the mako code. But they're rather silly and worthless and only one
should be kept.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
templates
or because it didn't exist yet.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/framework/summary.py b/framework/summary.py
index 6780458..0702319 100644
--- a/framework/summary.py
+++ b/framework/summary.py
/library/argparse.html#epilog
ArgumentParser formatter_class information:
http://docs.python.org/dev/library/argparse.html#formatter-class
On Fri, May 17, 2013 at 11:31 AM, Dylan Baker baker.dyla...@gmail.com
wrote:
Drops almost all of the code used in this file, all of that
functionality is now
, 2013 at 3:27 PM, Dylan Baker baker.dyla...@gmail.com
wrote:
You're probably right. I'll make that change too.
Though I am wondering if it's even worth having the list syntax, it's
been
broken for over two months and no one has complained or even noticed it
until now. If it's still
expand *anything* implicitly, and I have not used os.path.expandvars() or
os.path.expanduser()
Otherwise I'll make the changes.
On Sat, May 25, 2013 at 3:00 AM, Kenneth Graunke kenn...@whitecape.orgwrote:
On 05/17/2013 09:31 AM, Dylan Baker wrote:
With 10,000+ tests all living in the same
Adds the actual templates used to by the new mako based summary code.
V3: Replace tabs with spaces like python code
Rename test_index.mako to testrun_info.mako
Refactor testrun_info.mako links bar generation
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py
to match the newline seperated format
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py | 7 +-
piglit-summary-html.py | 261 -
2 files changed, 21 insertions(+), 247 deletions(-)
diff --git a/framework/summary.py b
Change the div:nth-child for operating on everything except head to only
working on group. This is lays groundwork for some other changes.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
templates/index.css | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/templates
). This is a tidy little speedup.
V3: Correct some spelling errors/remove excess comments
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py | 32 ++--
templates/test_result.mako | 6 +++---
2 files changed, 21 insertions(+), 17 deletions
In the old summary code one was set equal to the other, and then
written. In order to produce the same output they were both brought over
to the mako code. But they're rather silly and worthless and only one
should be kept.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
templates
seconds, with just pass and skip disabled it only
takes ~2.5 seconds. This only becomes more significant as more testsruns
are added the HTML page.
V3: Remove some bad comments
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py | 45
or because it didn't exist yet.
V3: Change N/A to Not Run
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/framework/summary.py b/framework/summary.py
index fc08d2b..3fc03e7 100644
--- a/framework
NAK this. I just noticed the problem still exists with this patch
On Fri, May 31, 2013 at 4:51 PM, Dylan Baker baker.dyla...@gmail.comwrote:
The checking in TestrunResult to determine if a file was proper json or
not is very fragile: it assumes that the last line of the file
file.tell() so
that file.seek would fail in self.__repairFile()
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/core.py | 46 ++
1 file changed, 26 insertions(+), 20 deletions(-)
diff --git a/framework/core.py b/framework/core.py
file.tell() so
that file.seek would fail in self.__repairFile()
V3: - refactor duplicated code
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/core.py | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/framework/core.py b/framework/core.py
time to load the current index; further, the all page is so
long that it's often not even useful.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py | 50 +---
templates/index.css | 79
Replaces self.alltests, self.changes, self.problems, self.regressions,
self.fixes, and self.skipped with self.test, a dictionary containing all
of the same information. This cleans the namespace for the NewSummary
object, as well as allowing for some other code simplification
Signed-off-by: Dylan
There were whitespace errors as a result of the recent tabs to spaces
conversion. This patch corrects those
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-summary-junit.py | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/piglit-summary-junit.py b
This new page is able to convey the same information, but takes less
time to generate
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py| 21 -
templates/empty_status.mako | 27 +++
2 files changed, 43 insertions(+), 5
-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py | 125 ---
1 file changed, 69 insertions(+), 56 deletions(-)
diff --git a/framework/summary.py b/framework/summary.py
index 5d4fe57..40f5ec0 100644
--- a/framework/summary.py
+++ b
Using mako as an alternative to the junit.py file has a couple of
advantages: First there is a lot less code involved, mako just does most
of the work for us. Second, it works in almost the same way as the HTML
generation.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
templates
This method is about 50% faster than the existing implementation which
uses junit.py.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py | 55
1 file changed, 55 insertions(+)
diff --git a/framework/summary.py b
Stop using the old JUnit generation code, and start using the new code.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-summary-junit.py | 84 +++--
1 file changed, 4 insertions(+), 80 deletions(-)
diff --git a/piglit-summary-junit.py b
-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py | 3 ++-
templates/junit.mako | 2 +-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/framework/summary.py b/framework/summary.py
index 9ceb3ba..4adb568 100644
--- a/framework/summary.py
+++ b/framework/summary.py
@@ -861,5
Argparse requires less code, and is much easier to read and maintain.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
piglit-summary.py | 94 +--
1 file changed, 29 insertions(+), 65 deletions(-)
diff --git a/piglit-summary.py b/piglit
Since -s/--summary will always override -d/--diff don't allow them to be
called together. While this may seem a little confusing, the idea of
asking for --diffs and then not getting them is a bug in the original
implementation.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
piglit
Since nothing now depends on the old summary backend, delete it. This
first eliminates dead code, but also ensures that no new functionality
becomes dependent on this code.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py | 232
The old name existed simply as a holdover until the Summary name could
be cleared up. Since it is now available, use the Summary name.
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
framework/summary.py| 4 ++--
piglit-summary-html.py | 2 +-
piglit-summary-junit.py | 2 +-
piglit
I'm bumping this series hoping to get some review, since I feel it's too
big to 'just push'
Brian and Jose, I'd specifically appreciate if you would look at the later
set of patches, since they change/replace code that you originally wrote.
Thanks.
On Thu, Jun 13, 2013 at 8:36 AM, Dylan Baker
.
On Thu, Jun 13, 2013 at 8:36 AM, Dylan Baker baker.dyla...@gmail.com
wrote:
Replaces self.alltests, self.changes, self.problems, self.regressions,
self.fixes, and self.skipped with self.test, a dictionary containing
all
of the same information. This cleans the namespace for the NewSummary
more
tests
here.
Jose
Thanks.
On Thu, Jun 13, 2013 at 8:36 AM, Dylan Baker
baker.dyla...@gmail.com
wrote:
Replaces self.alltests, self.changes, self.problems,
self.regressions,
self.fixes, and self.skipped with self.test, a dictionary
containing
---
generated_tests/generate-cl-int-builtins.py | 690 ++--
1 file changed, 351 insertions(+), 339 deletions(-)
diff --git a/generated_tests/generate-cl-int-builtins.py
b/generated_tests/generate-cl-int-builtins.py
index ae60ad2..3734031 100755
---
I think you're right. But all I've changed here is the indenting not the
content, and I don't think it really belongs in this patchset.
If I make another patch with that change can I put your reviewed-by on it?
On Wed, Jul 10, 2013 at 5:33 PM, Chris Forbes chr...@ijw.co.nz wrote:
+NOTE:
not
be changes.
I decided that the latter case outweighed the former. Obviously if I erred
in that decision I can make changes.
On Fri, Jul 12, 2013 at 1:17 PM, Paul Berry stereotype...@gmail.com wrote:
On 28 June 2013 06:49, Dylan Baker baker.dyla...@gmail.com wrote:
Splits the code that finds
I'm pretty sure this breaks Debian based systems were python == python2
On Fri, Jul 12, 2013 at 2:10 PM, Chad Versace
chad.vers...@linux.intel.comwrote:
Fix the shebang (#!) line in all toplevel python scripts with
s/python/python2
Fixes Piglit on systems where Python3 is the default.
yes, sorry i wasn't clear.
On Fri, Jul 12, 2013 at 2:50 PM, Chad Versace
chad.vers...@linux.intel.comwrote:
On 07/12/2013 02:15 PM, Dylan Baker wrote:
I'm pretty sure this breaks Debian based systems were python == python2
I assume you mean where /usr/bin/python2 doesn't exist
Allright, I'm going to push this upstream, but I'm trying to work on
something better.
On Tue, Jul 16, 2013 at 4:39 PM, Chris Forbes chr...@ijw.co.nz wrote:
After reading the rest of the summary code,
Reviewed-by: Chris Forbes chr...@ijw.co.nz
___
...@linux.intel.comwrote:
On 07/10/2013 03:19 PM, Dylan Baker wrote:
There are a 3 lines that are just over the recommended 79 character
limit, however, breaking them made them harder to read so they were
left.
---
glapi/parse_glspec.py | 76 --**
-
1 file
Okay
On Mon, Jul 22, 2013 at 2:45 PM, Chad Versace
chad.vers...@linux.intel.comwrote:
On 07/10/2013 03:19 PM, Dylan Baker wrote:
---
generated_tests/gen_**interpolation_tests.py | 500
++---
1 file changed, 250 insertions(+), 250 deletions(-)
Did this patch
Currently this file uses a mixture of tabs and white spaces. The tabs
are assumed to be 8 spaces. PEP8 is very clear to *never* use mixed
spaces and tabs, which this file currently does, it is also very clear
that 4 spaces, not 8 should be the standard indent for python files.
---
v2: - Add noncompliant formatting back to tables. This increases
readability, even if it's not PEP8 compliant per Chad
Reviewed-by: Aaron Watry awa...@gmail.com
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
generated_tests
take a look for changes like this and
revert them.
On Tue, Jul 23, 2013 at 11:38 AM, Chad Versace chad.vers...@linux.intel.com
wrote:
On 07/23/2013 07:46 AM, Dylan Baker wrote:
I'll look through for the parens, It might be in a seperate patch, but I
think it deserves to be here, since PEP8
Currently this file uses a mixture of tabs and white spaces. The tabs
are assumed to be 8 spaces. PEP8 is very clear to *never* use mixed
spaces and tabs, which this file currently does, it is also very clear
that 4 spaces, not 8 should be the standard indent for python files.
---
v3: - Revert some changes made as a result of false positives from the
pep8 tool
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
Reviewed-by: Chad Versace chad.vers...@linux.intel.com
---
generated_tests/gen_builtin_uniform_tests.py | 636 +--
1 file changed, 314
...@linux.intel.com
Signed-off-by: Dylan Baker baker.dyla...@gmail.com
---
generated_tests/generate-cl-int-builtins.py | 659 +++-
1 file changed, 343 insertions(+), 316 deletions(-)
diff --git a/generated_tests/generate-cl-int-builtins.py
b/generated_tests/generate-cl-int
Yes. I'll make that change.
On Tue, Jul 30, 2013 at 11:42 AM, Tom Stellard t...@stellard.net wrote:
Hi,
I recall this being discussed on the list a few weeks ago, but I can't
find the email now. There was a recent change to piglit which caused
tests that were 'Not Run' to be excluded from
On Wed, Jul 31, 2013 at 11:37 PM, Dylan Baker baker.dyla...@gmail.comwrote:
I have some python comments for you, they're mainly style type comments,
but some of them should help your code readability a lot.
On Wed, Jul 31, 2013 at 7:16 PM, Tom Stellard t...@stellard.net wrote:
From: Tom
This change has already landed
On Thu, Aug 1, 2013 at 10:27 AM, Chad Versace
chad.vers...@linux.intel.comwrote:
Would it be possible to restore the old piglit behavior or at least come
up with another solution?
I second this change. I need to see skipped tests.
Ah, that makes sense.
I have no further complaints and I'm not sure what the most approriate tag
is, since I'm not a CL expert. I'm guessing acked-by, but feel free to use
something else if it's more appropriate.
Acked-by: Dylan Baker baker.dyla...@gmail.com
On Thu, Aug 1, 2013 at 7:34 PM, Tom
If it's not pressing this is about two tasks out on my list of things to do
for Intel, since we want this feature. If you can wait a little while for
it I will have patches for this in the next month or two.
On Fri, Aug 2, 2013 at 5:57 AM, Jose Fonseca jfons...@vmware.com wrote:
- Original
Looks good.
Reviewed-by: Dylan Baker baker.dyla...@gmail.com
On Mon, Aug 12, 2013 at 2:54 PM, Kenneth Graunke kenn...@whitecape.orgwrote:
If the Python framework fails to run a program for some reason, it'll
record a 'fail' status. It also records a 'traceback' key in the
dictionary
Actually, this patch breaks a bunch of stuff. I'll rework this and send it
out later. The rest of the patches are fine.
On Fri, Aug 16, 2013 at 9:09 AM, Dylan Baker baker.dyla...@gmail.comwrote:
This patch removes the Result class from Summary, and the
loadTestResults function from core
First, this is not a CL specific problem. This is part of the core piglit
framework. Please only use CL: in the header if fixing a CL test or CL
specific framework
On Fri, Aug 16, 2013 at 6:38 AM, Tom Stellard t...@stellard.net wrote:
On Fri, Aug 16, 2013 at 11:28:23AM +0800, Homer Hsing wrote:
I have two concerns, first, it you've used tabs and space mixed. Please do not
use tabs, please only use spaces for the python portions of piglit. There is a
wonderful pep8 tool available from the python 'pip' tool, or from most linux
distros package managers, that can be very helpful in
1 - 100 of 3305 matches
Mail list logo
