[Piglit] [PATCH] framework: use os.path instead of manual path management

2013-10-31 Thread Dylan Baker
Working with paths is hard, and we don't always do it right. Instead of trying to be perfect, just use python's os.path module to do all of the hard work for us Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/core.py | 9 + framework/exectest.py | 2 +- framework

Re: [Piglit] [PATCH 13/13] cmake: use PythonInterp package and update version.

2013-10-31 Thread Dylan Baker
On Thursday, October 31, 2013 09:48:09 AM Kenney Phillis wrote: The find_package(PythonInterp) for cmake version 2.8.6 and newer is capable of properly handling multiple versions of python. This is extremely useful on mixed systems where a person may have Python2 and Python3 installed side by

Re: [Piglit] [PATCH 11/13] framework/summary.py: add crashed page.

2013-10-31 Thread Dylan Baker
the same name. ie, With those nits addressed this patch is: reviewed-by Dylan Baker baker.dyla...@gmail.com signature.asc Description: This is a digitally signed message part. ___ Piglit mailing list Piglit@lists.freedesktop.org http

Re: [Piglit] [PATCH 1/2 v2] genclbuiltins.py: Add two new function types.

2013-10-31 Thread Dylan Baker
On Friday, November 01, 2013 12:20:46 AM Yi Sun wrote: Sometimes we should handle scalar/vector types separately. For example some builtin functions only support scalar type input, and some relational builtin functions get different results between scalar and vector type though with the same

Re: [Piglit] [PATCH] update the HACKING file's Coding style section

2013-11-02 Thread Dylan Baker
Could you add a note about python code? Just something like: All python code should conform to python's PEP8 standard, using only spaces and no tabs would be great. On Fri, Nov 1, 2013 at 1:50 PM, Paul Berry stereotype...@gmail.com wrote: On 1 November 2013 08:14, Brian Paul bri...@vmware.com

[Piglit] [PATCH 5/6] summary.py: Simplify the way HTMLIndex works

2013-11-04 Thread Dylan Baker
This patch replaces home-rolled code with built-in python functions, this results in cleaner, simpler, and faster code. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/summary.py | 124 +++ 1 file changed, 36 insertions(+), 88

[Piglit] [PATCH 3/6] Summary.py: Move code out of HTMLIndex into a mako template

2013-11-04 Thread Dylan Baker
Moving the column headers out of the HTMLIndex class simplifies the class, since the code that existed for handling this was special case. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/summary.py | 17 + templates/index_columns.mako | 7 +++ 2

[Piglit] [PATCH] tests/igt.tests: PEP8 compliance

2013-11-04 Thread Dylan Baker
formatting changes. - replace tabs with 8 spaces - fix long lines - remove trailing semicolons - fix hanging indent problems - add two spaces before and after top level classes and functions - use os.path.join instead of concat Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- tests

[Piglit] [PATCH 6/6] Summary.py: Convert HTMLIndex class into a generator

2013-11-04 Thread Dylan Baker
This change does a couple of really nice things for us, first it cuts down on the memory consumption by using a generator (which is lazy). Further, as a part of the Summary.generate_html() method it doesn't need to have the summary instance passed to it, reducing complexity. Signed-off-by: Dylan

[Piglit] [PATCH 2/6] index.mako: Split index.mako into three files

2013-11-04 Thread Dylan Baker
This is groundwork for simplifying the generation of the HTML pages. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/summary.py | 25 -- templates/index.mako | 81 -- templates/index_body.mako | 41

[Piglit] [PATCH 1/6] Summary.py: use mako's TemplateLookup class

2013-11-04 Thread Dylan Baker
This change reduces code duplication by setting arguments to the templates to be set once, rather than once per template. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/summary.py | 56 ++-- 1 file changed, 24 insertions(+), 32

[Piglit] [PATCH 4/6] templates/index_body.mako: remove unused subtestResult

2013-11-04 Thread Dylan Baker
This code was left over from an early iteration of the code, and isn't used. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- templates/index_body.mako | 4 1 file changed, 4 deletions(-) diff --git a/templates/index_body.mako b/templates/index_body.mako index 0056912..9e67311 100644

Re: [Piglit] [PATCH 0/7] Reducing ortho use in shader_runner

2013-11-05 Thread Dylan Baker
On Tuesday, November 05, 2013 09:38:16 AM Ian Romanick wrote: On 11/04/2013 10:18 PM, Matt Turner wrote: We'd like to shrink the window sizes of shader runner when running in simulation, and ortho tests make it difficult to reason about reducing the window size. The following patches

Re: [Piglit] [PATCH 0/7] Reducing ortho use in shader_runner

2013-11-05 Thread Dylan Baker
failing. As a tip, Just run the glean tests on windows and then try to make a html output for it... It'll fail every time due to invalid characters... I have tested this on Windows 7 and it should also apply to any version of windows. On Tue, Nov 5, 2013 at 12:09 PM, Dylan Baker baker.dyla

[Piglit] [PATCH 2/2] core.py: don't write subtests as full entries

2013-11-05 Thread Dylan Baker
This stops subtests from being written as full entries in the json. Instead, in the summary code the test with subtests is treated as a group, and the subtests as real tests. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/core.py | 7 +-- 1 file changed, 1 insertion(+), 6

[Piglit] [PATCH 1/2] summary.py: Treat subtests as groups

2013-11-05 Thread Dylan Baker
This patch causes tests with subtests to be treated as a group, rather than as a test. This means that the status the test itself stores will be overwritten by those in the subtest. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/summary.py | 33

[Piglit] Fix subtests

2013-11-05 Thread Dylan Baker
This series attempts to fix the way piglit handles subtests. In particular there are two problems with subtests: 1. A subtest failure does not cause the test it is a part of to be a failure 2. Each subtest writes an additional copy of itself in the json Patch 1 attempts to correct point 1

Re: [Piglit] [PATCH 0/7] Reducing ortho use in shader_runner

2013-11-05 Thread Dylan Baker
On Tuesday, November 05, 2013 10:23:53 AM Matt Turner wrote: On Tue, Nov 5, 2013 at 10:09 AM, Dylan Baker baker.dyla...@gmail.com wrote: I'm kicking for something brainless to do, are these generators laying around somewhere? I'll have a look at how hard it would be to convert them

Re: [Piglit] Fix subtests

2013-11-11 Thread Dylan Baker
forgot to mention this is available from my github: https://github.com/crymson/piglit.git simplify_subtests On Tuesday, November 05, 2013 10:34:49 AM Dylan Baker wrote: This series attempts to fix the way piglit handles subtests. In particular there are two problems with subtests: 1

Re: [Piglit] [PATCH 1/3] igt: retab

2013-11-12 Thread Dylan Baker
('igt', test, subtest)] = \ IGTTest(test, ['--run-subtest', subtest]) multiTests = listTests(list-multi-tests) I must have written this patch myself about a dozen times, no idea why I never sent it. Anyway this patch is: reviewed-by: Dylan Baker baker.dyla...@gmail.com

Re: [Piglit] [PATCH 2/3] framework: Add support for a test timeout

2013-11-12 Thread Dylan Baker
On Tuesday, November 12, 2013 11:36:32 AM Daniel Vetter wrote: i-g-t tests can take a long time, and for a bunch of reasons (bad tuning on disparate set of platforms, stuck in the kernel which often can be recovered by interrupting with a signal, ...) that sometimes extends to a good

[Piglit] RFC enhance dmesg handling in piglit

2013-11-12 Thread Dylan Baker
This series cleans up the dmesg handlingin piglit by implementing a module with two classes, one for reading dmesg, and the other that acts as a dummy class on non-posix systems, this allows dmesg to just always be turned on all the time. Secondly this new dmesg class has the ability to filter

[Piglit] [PATCH 2/6] dmesg: Use the dmesg class instead of the dmesg functions

2013-11-12 Thread Dylan Baker
class for non-posix systems. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/core.py | 3 +-- framework/exectest.py | 38 -- framework/gleantest.py | 4 ++-- piglit-run.py | 7 +-- tests/es3conform.tests | 4 ++-- tests

[Piglit] [PATCH 6/6] igt.tests: make use of dmesg

2013-11-12 Thread Dylan Baker
This patch allows the igt integrated tests to use the new dmesg implementation. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- tests/igt.tests | 72 +++-- 1 file changed, 39 insertions(+), 33 deletions(-) diff --git a/tests/igt.tests b

[Piglit] [PATCH 5/6] es3conform.tests: Check dmesg

2013-11-12 Thread Dylan Baker
This allows es3conform to use the dmesg class. NOTE: can someone confirm that this works? --- tests/es3conform.tests | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tests/es3conform.tests b/tests/es3conform.tests index 65e48af..42a6017 100644 ---

Re: [Piglit] RFC enhance dmesg handling in piglit

2013-11-12 Thread Dylan Baker
On Tuesday, November 12, 2013 07:21:50 PM Daniel Vetter wrote: On Tue, Nov 12, 2013 at 07:53:58AM -0800, Dylan Baker wrote: This series cleans up the dmesg handlingin piglit by implementing a module with two classes, one for reading dmesg, and the other that acts as a dummy class on non

[Piglit] [PATCH v2 2/2] core.py: don't write subtests as full entries

2013-11-13 Thread Dylan Baker
This stops subtests from being written as full entries in the json. Instead, in the summary code the test with subtests is treated as a group, and the subtests as real tests. This has the added benefit of reducing the size of the json by 80%. Signed-off-by: Dylan Baker baker.dyla...@gmail.com

[Piglit] [PATCH v2 1/2] summary.py: Treat subtests as groups

2013-11-13 Thread Dylan Baker
color of Not Run tests correctly in HTML - Apply subtest fractions down the stack Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/summary.py | 73 ++-- 1 file changed, 59 insertions(+), 14 deletions(-) diff --git a/framework

[Piglit] [PATCH 2/2] CMakeLists.txt: install templates directory

2013-11-13 Thread Dylan Baker
Without this piglit-summary-html will not work when piglit is installed. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- CMakeLists.txt | 5 + 1 file changed, 5 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 3cfd76d..9bbffe9 100644 --- a/CMakeLists.txt +++ b

[Piglit] [PATCH 1/2] framework/summary.py: Set constants for directories

2013-11-13 Thread Dylan Baker
This uses python's tempfile module to get a platform dependent place to put temporary files, which should allow html summary to work even when installed somewhere read-only. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/summary.py | 25 +++-- 1 file changed

Re: [Piglit] [PATCH 1/2] framework/summary.py: Set constants for directories

2013-11-13 Thread Dylan Baker
On Wednesday, November 13, 2013 07:46:31 PM Damien Lespiau wrote: On Wed, Nov 13, 2013 at 11:12:24AM -0800, Dylan Baker wrote: This uses python's tempfile module to get a platform dependent place to put temporary files, which should allow html summary to work even when installed somewhere

Re: [Piglit] Integrating external test suites with piglit

2013-11-13 Thread Dylan Baker
On Wednesday, November 13, 2013 01:00:39 PM Tom Stellard wrote: Hi, I've been doing a lot of testing lately with the OpenCV library (http://opencv.org). It has its own gtest based regression test suite, and so far I've been trying to port some of these tests over to piglit. Unfortunately,

Re: [Piglit] [PATCH] framework: Add support for a test timeout

2013-11-13 Thread Dylan Baker
of of a reference pointing at the original object. So assinging anything to them won't have any effect outside of the lambda. Hence we need to jump through hoops and pass an array around. Nicer fix would be to create a class or something, but that seems like overkill. Cc: Dylan Baker baker.dyla

Re: [Piglit] [PATCH 1/2] framework/summary.py: Set constants for directories

2013-11-13 Thread Dylan Baker
On Wednesday, November 13, 2013 12:51:27 PM Dylan Baker wrote: On Wednesday, November 13, 2013 07:46:31 PM Damien Lespiau wrote: On Wed, Nov 13, 2013 at 11:12:24AM -0800, Dylan Baker wrote: This uses python's tempfile module to get a platform dependent place to put temporary files, which

Re: [Piglit] [PATCH 1/2] framework/summary.py: Set constants for directories

2013-11-14 Thread Dylan Baker
On Wednesday, November 13, 2013 09:58:32 PM Damien Lespiau wrote: On Wed, Nov 13, 2013 at 12:51:27PM -0800, Dylan Baker wrote: PIGLIT_SOURCE_DIR is always set in core.py in an way nearly identical to the way you're looking for piglitDir, which we import, so I don't think this should

Re: [Piglit] [PATCH 3/6] dmesg: setup dmesg to be able to mark a test warn or fail

2013-11-14 Thread Dylan Baker
On Thursday, November 14, 2013 02:52:41 PM Daniel Vetter wrote: On Tue, Nov 12, 2013 at 07:54:01AM -0800, Dylan Baker wrote: This gives the dmesg class lists of statuses that will make a test a warn or a fail, it includes a few basic checks, namely i915 errors and that tests have

[Piglit] [PATCH v3 2/2] core.py: don't write subtests as full entries

2013-11-14 Thread Dylan Baker
-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/core.py | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/framework/core.py b/framework/core.py index 2d5d0dc..e7767c2 100644 --- a/framework/core.py +++ b/framework/core.py @@ -483,12 +483,7 @@ class Test

[Piglit] [PATCH v3 1/2] summary.py: Treat subtests as groups

2013-11-14 Thread Dylan Baker
color of Not Run tests correctly in HTML - Apply subtest fractions down the stack v3: - Don't generate a link for Not Run tests in html page Tested-by: Tom Stellard thomas.stell...@amd.com Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/summary.py | 77

Re: [Piglit] [PATCH 3/6] dmesg: setup dmesg to be able to mark a test warn or fail

2013-11-14 Thread Dylan Baker
On Thursday, November 14, 2013 05:34:38 PM Daniel Vetter wrote: On Thu, Nov 14, 2013 at 08:04:20AM -0800, Dylan Baker wrote: On Thursday, November 14, 2013 02:52:41 PM Daniel Vetter wrote: On Tue, Nov 12, 2013 at 07:54:01AM -0800, Dylan Baker wrote: This gives the dmesg class lists

[Piglit] [PATCH] piglit-run.py: record whether the test run was concurrent

2013-11-14 Thread Dylan Baker
cc: b...@bwidawsk.net Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- piglit-run.py | 1 + 1 file changed, 1 insertion(+) diff --git a/piglit-run.py b/piglit-run.py index 1d63cd4..4aa5929 100755 --- a/piglit-run.py +++ b/piglit-run.py @@ -142,6 +142,7 @@ def main

Re: [Piglit] [PATCH] piglit-run.py: record whether the test run was concurrent

2013-11-14 Thread Dylan Baker
On Thursday, November 14, 2013 09:47:57 PM Damien Lespiau wrote: On Thu, Nov 14, 2013 at 01:16:02PM -0800, Ben Widawsky wrote: On Thu, Nov 14, 2013 at 08:52:19PM +, Damien Lespiau wrote: On Thu, Nov 14, 2013 at 10:44:37AM -0800, Dylan Baker wrote: cc: b...@bwidawsk.net Signed-off

Re: [Piglit] [PATCH 3/6] dmesg: setup dmesg to be able to mark a test warn or fail

2013-11-15 Thread Dylan Baker
On Friday, November 15, 2013 10:42:11 AM Daniel Vetter wrote: On Thu, Nov 14, 2013 at 10:35:03AM -0800, Dylan Baker wrote: On Thursday, November 14, 2013 05:34:38 PM Daniel Vetter wrote: On Thu, Nov 14, 2013 at 08:04:20AM -0800, Dylan Baker wrote: On Thursday, November 14, 2013 02:52:41

Re: [Piglit] [PATCH] framework: Dump the result of 'uname -a' in the report

2013-11-15 Thread Dylan Baker
+/td + /tr + tr tdlspci/td td pre${lspci}/pre This looks fine. Reviewed-by: Dylan Baker baker.dyla...@gmail.com signature.asc Description: This is a digitally signed message part. ___ Piglit mailing list Piglit

Re: [Piglit] [PATCH] framework: Humanize time values in the HTML report

2013-11-15 Thread Dylan Baker
On Friday, November 15, 2013 04:26:07 PM Damien Lespiau wrote: On Fri, Nov 15, 2013 at 08:11:07AM -0800, Dylan Baker wrote: +if amount == 'None': +return 'None' the python idiom is 'if not amount: return None' These are strings, not the built-in. Doh, that's what I get

Re: [Piglit] [PATCH] framework: Fix resuming of previous runs

2013-11-15 Thread Dylan Baker
implemented this when I did the status work, but then didn't think I needed it. Resume is not a commonly used feature obviously. Reviewed-by: Dylan Baker baker.dyla...@gmail.com signature.asc Description: This is a digitally signed message part. ___ Piglit

Re: [Piglit] [PATCH] framework: Fix resuming of previous runs

2013-11-15 Thread Dylan Baker
On Friday, November 15, 2013 08:37:27 AM Dylan Baker wrote: On Thursday, November 14, 2013 06:03:54 PM Damien Lespiau wrote: When resuming and loading the partial JSON file from disk, the 'status' property is replaced by status.Status objects. When serializing back those objects

[Piglit] [PATCH v2 1/2] piglit-run.py: record whether the test run was concurrent

2013-11-15 Thread Dylan Baker
cc: b...@bwidawsk.net Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- piglit-run.py | 1 + 1 file changed, 1 insertion(+) diff --git a/piglit-run.py b/piglit-run.py index 1d63cd4..4aa5929 100755 --- a/piglit-run.py +++ b/piglit-run.py @@ -142,6 +142,7 @@ def main

[Piglit] [PATCH v2 2/2] piglit-run.py: resume honors saved concurrency flag

2013-11-15 Thread Dylan Baker
This breaks incomplete runs started before applying the previous patch in this series, since there will be no key for concurrency v2: - Add this patch (Damien Lespiau) Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- piglit-run.py | 1 + 1 file changed, 1 insertion(+) diff --git a/piglit

[Piglit] [PATCH 1/3] piglit-run.py: Cleanups

2013-11-15 Thread Dylan Baker
This patch tidies up a few things, and lays groundwork for later patches in this series. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- piglit-run.py | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/piglit-run.py b/piglit-run.py index

[Piglit] [PATCH 2/3] piglit-run.py: Record all attributes of Environment and restore them

2013-11-15 Thread Dylan Baker
This causes all attributes in the Environment instance env to be dumped into the json and reloaded on a resume. It adds an __iter__ magic method to core.Environment to allow this. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/core.py | 5 + piglit-run.py | 4 ++-- 2

[Piglit] [PATCH 3/3] Split resume functionality out of piglit-run.py

2013-11-15 Thread Dylan Baker
it out into it's own file. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- CMakeLists.txt | 1 + piglit-resume.py | 84 piglit-run.py| 40 +++ 3 files changed, 89 insertions(+), 36 deletions(-) create

Re: [Piglit] [PATCH v3 1/2] summary.py: Treat subtests as groups

2013-11-15 Thread Dylan Baker
On Friday, November 15, 2013 06:25:48 PM Damien Lespiau wrote: On Thu, Nov 14, 2013 at 10:26:08AM -0800, Dylan Baker wrote: This patch causes tests with subtests to be treated as a group, rather than as a test. This means that the status the test itself stores will be overwritten by those

Re: [Piglit] [PATCH 3/6] dmesg: setup dmesg to be able to mark a test warn or fail

2013-11-15 Thread Dylan Baker
), and it can do a couple of other things. Marek On Fri, Nov 15, 2013 at 5:26 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Friday, November 15, 2013 10:42:11 AM Daniel Vetter wrote: On Thu, Nov 14, 2013 at 10:35:03AM -0800, Dylan Baker wrote: On Thursday, November 14, 2013 05:34:38 PM

Re: [Piglit] [PATCH v3 1/2] summary.py: Treat subtests as groups

2013-11-15 Thread Dylan Baker
On Friday, November 15, 2013 10:58:15 AM Kenneth Graunke wrote: On 11/14/2013 10:26 AM, Dylan Baker wrote: This patch causes tests with subtests to be treated as a group, rather than as a test. This means that the status the test itself stores will be overwritten by those in the subtest

Re: [Piglit] [PATCH v3 1/2] summary.py: Treat subtests as groups

2013-11-15 Thread Dylan Baker
On Friday, November 15, 2013 06:25:48 PM Damien Lespiau wrote: On Thu, Nov 14, 2013 at 10:26:08AM -0800, Dylan Baker wrote: This patch causes tests with subtests to be treated as a group, rather than as a test. This means that the status the test itself stores will be overwritten by those

Re: [Piglit] [PATCH v3 1/2] summary.py: Treat subtests as groups

2013-11-15 Thread Dylan Baker
On Friday, November 15, 2013 11:09:30 PM Damien Lespiau wrote: On Fri, Nov 15, 2013 at 11:05:49AM -0800, Dylan Baker wrote: @#$ -e option. I never should have written it, all I do is break it. sigh. :( Looks like a test suite for the test runner would be a brilliant idea

Re: [Piglit] [PATCH 3/6] dmesg: setup dmesg to be able to mark a test warn or fail

2013-11-15 Thread Dylan Baker
. This only has to deal with the effects of synchronization. On Fri, Nov 15, 2013 at 12:42 PM, Marek Olšák mar...@gmail.com wrote: Why not to have both? Marek On Fri, Nov 15, 2013 at 7:33 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Friday, November 15, 2013 06:28:41 PM Marek

Re: [Piglit] [PATCH 3/6] dmesg: setup dmesg to be able to mark a test warn or fail

2013-11-15 Thread Dylan Baker
On Friday, November 15, 2013 06:04:28 PM Ken Phillis Jr wrote: On Fri, Nov 15, 2013 at 5:49 PM, Marek Olšák mar...@gmail.com wrote: I decided to leave this decision to the user. Of course you should expect false negative results with concurrency, but that's acceptable for people who want

Re: [Piglit] [PATCH 2/2] core: don't report warn if stderr is not empty

2013-11-18 Thread Dylan Baker
On Monday, November 18, 2013 03:33:34 PM Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com The usefulness of this is questionable to say the least. --- framework/core.py | 72 --- framework/exectest.py | 2 -- 2 files changed, 74

Re: [Piglit] [PATCH 2/2] core: don't report warn if stderr is not empty

2013-11-19 Thread Dylan Baker
On Tuesday, November 19, 2013 10:52:38 AM Eric Anholt wrote: Marek Olšák mar...@gmail.com writes: From: Marek Olšák marek.ol...@amd.com The usefulness of this is questionable to say the least. My initial reaction was to be against this one, but I think I'm OK with it, actually. While

Re: [Piglit] [PATCH 1/2] summary: fix regression and fixes summaries

2013-11-20 Thread Dylan Baker
On Monday, November 18, 2013 03:33:33 PM Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Somebody broke this. --- framework/status.py| 48 + framework/summary.py | 6 ++--- framework/tests/summary.py | 66

Re: [Piglit] piglit-run.py regression

2013-11-20 Thread Dylan Baker
-packages/simplejson/encoder.py, line 213, in default raise TypeError(repr(o) + is not JSON serializable) TypeError: _sre.SRE_Pattern object at 0x7fdb9aab36c0 is not JSON serializable Bisection says it's caused by: commit 0618aa38d4a8a7c82994fb28a41576da9a2cc414 Author: Dylan Baker

[Piglit] [PATCH] bugzilla 71822: Fix regression introduced to piglit-run.py

2013-11-20 Thread Dylan Baker
. This will cause the json encoder to choke. This patch corrects the __iter__ method in core.Environment to yield regex items as regex.pattern, and attribute storing the original string used to create the pattern. cc: bri...@vmware.com cc: v...@freedesktop.org Signed-off-by: Dylan Baker baker.dyla

Re: [Piglit] [PATCH 1/2] summary: fix regression and fixes summaries

2013-11-20 Thread Dylan Baker
On Thursday, November 21, 2013 12:30:53 AM Marek Olšák wrote: On Thu, Nov 21, 2013 at 12:04 AM, Dylan Baker baker.dyla...@gmail.com wrote: On Monday, November 18, 2013 03:33:33 PM Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Somebody broke this. --- framework

Re: [Piglit] [00/16] Enable concurrency for a lot of tests

2013-11-27 Thread Dylan Baker
Is this on a public branch somewhere? I'd like to test this so we can land it. On Monday, November 25, 2013 12:52:19 AM Marek Olšák wrote: This series enables concurrency for about one half of non-concurrent tests. The time it takes to run all of quick.tests improved from 14.5 minutes to 11.7

[Piglit] [PATCH 2/4] piglit-resume.py: pep8 fixes

2013-12-12 Thread Dylan Baker
This fixes pep8 whitespace errors Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- piglit-resume.py | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/piglit-resume.py b/piglit-resume.py index ae5de9b..9e14b16 100755 --- a/piglit-resume.py +++ b

[Piglit] [PATCH 4/6] environment.py: replace loops in constructor with comprehensions

2013-12-18 Thread Dylan Baker
The list comprehensions are easier to read. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/environment.py | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/framework/environment.py b/framework/environment.py index 50cbd43..c5693cc 100644 --- a/framework

[Piglit] Refactor environment out of core.py

2013-12-18 Thread Dylan Baker
This patch series creates a new module called environment to hold information about the piglit run environment, including the testBinDir constant and the Environment class. Once these are pulled out into a seperate module the series goes on to clean up the environment module, adding docstrings,

[Piglit] [PATCH 5/6] environment.py: replace docstring with block comment

2013-12-18 Thread Dylan Baker
This was incorrectly formatted and should have been using block comments from the begining. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/environment.py | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/framework/environment.py b/framework

[Piglit] [PATCH 6/6] environment.py: Add docstrings

2013-12-18 Thread Dylan Baker
This patch adds docstrings to the remaining places that are needed. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/environment.py | 15 +++ 1 file changed, 15 insertions(+) diff --git a/framework/environment.py b/framework/environment.py index ad7b861..48a2a71

[Piglit] [PATCH] Save and restore platform for piglit

2013-12-19 Thread Dylan Baker
This patch adds support in piglit-run to save the -p platform information if it was provided, and adds support in piglit-resume to restore this information if it is stored. CC: kenn...@whitecape.org Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- piglit-resume.py | 7 +-- piglit

[Piglit] [PATCH 06/12] tests: trest the tests folder as part of the python package

2013-12-23 Thread Dylan Baker
By adding __init__.py to tests folder python can search that folder for modules to import. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- tests/__init__.py | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 tests/__init__.py diff --git a/tests/__init__.py b/tests

[Piglit] [PATCH 02/12] Add support to load multiple test profiles

2013-12-23 Thread Dylan Baker
-by: Dylan Baker baker.dyla...@gmail.com --- framework/core.py | 32 piglit-resume.py | 4 ++-- piglit-run.py | 5 +++-- 3 files changed, 37 insertions(+), 4 deletions(-) diff --git a/framework/core.py b/framework/core.py index c8dc4bc..28a1ded 100644

[Piglit] [PATCH 01/12] *.tests: set __all__ = ['profile']

2013-12-23 Thread Dylan Baker
This makes the only publicly declared object in the .tests files the profile object. This is groundwork for importing the profile rather than running it via execfile(). Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- tests/all.tests| 2 ++ tests/all_cl.tests | 2 ++ tests

[Piglit] [PATCH 09/12] tests/gpu.py: Don't use execfile

2013-12-23 Thread Dylan Baker
This uses import rather than exefile. It requires a few additional changes since gpu.py uses some hacky behavior to remove shader_tests XXX: This isn't ready to be pushed --- framework/core.py | 9 + tests/gpu.py | 20 ++-- 2 files changed, 15 insertions(+), 14

[Piglit] Import test profiles instead of calling execfile

2013-12-23 Thread Dylan Baker
This series reworks the way piglit loads TestProfile instances from .tests files. The goal is to do away with calls to execfile(), which has two primary benefits. First, its bad coding practice according to the python community. Second, execfile is not supported in python3, and the work around is

[Piglit] [PATCH 12/12] core.py: rewrie loadTestProfile to remove execfile()

2013-12-23 Thread Dylan Baker
This patch removes execfile, replaceing it with import instead. This isn't a prefect solution, but it provides feature parity with the execfile() aproach, while being python3 safe. --- framework/core.py | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git

[Piglit] [PATCH 04/12] tests/all.py: load glean glsl, frag, and vert tests internally

2013-12-23 Thread Dylan Baker
they will not be importable. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- tests/all.tests | 394 tests/glean-fragProg1.tests | 52 -- tests/glean-glsl1.tests | 255 tests/glean-vertProg1.tests | 42

[Piglit] [PATCH 03/12] all.tests: Remove execfile(es3conform.tests)

2013-12-23 Thread Dylan Baker
This option is now redundant, since it can be given explicitely at the commandline. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- tests/all.tests | 5 - 1 file changed, 5 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index b09340d..38c0f5d 100644 --- a/tests/all.tests

[Piglit] [PATCH 05/12] Rename all tests files from .tests to .py

2013-12-23 Thread Dylan Baker
This patch renames the .tests files to .py files; which is required for the python interpreter to allow importing them. --- CMakeLists.txt| 2 +- README| 25 +++-- tests/{all.tests = all.py} | 0

[Piglit] [PATCH 07/12] tests/sanity.tests: Make sanity.tests importable

2013-12-23 Thread Dylan Baker
This allows sanity.py to export a profile instance, meaning it can be used as an import instead of an execfile. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- tests/sanity.py | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/sanity.py b/tests/sanity.py

[Piglit] [PATCH 11/12] tests/r500.py use import instead of execfile

2013-12-23 Thread Dylan Baker
Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- tests/r500.py | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/r500.py b/tests/r500.py index 57b80ce..a47cb8e 100644 --- a/tests/r500.py +++ b/tests/r500.py @@ -2,14 +2,10 @@ # Testing the r500 DRI driver

[Piglit] [PATCH 08/12] quick.tests: Make quick.tests import all.tests

2013-12-23 Thread Dylan Baker
Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- tests/quick.py | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/quick.py b/tests/quick.py index 0f8c7f3..939aded 100644 --- a/tests/quick.py +++ b/tests/quick.py @@ -1,15 +1,11 @@ # -*- coding: utf-8

[Piglit] [PATCH] piglit-resume.py: Fix bug in resume

2013-12-23 Thread Dylan Baker
-off-by: Dylan Baker baker.dyla...@gmail.com --- piglit-resume.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/piglit-resume.py b/piglit-resume.py index ae5de9b..a15cc77 100755 --- a/piglit-resume.py +++ b/piglit-resume.py @@ -66,7 +66,6 @@ def main(): for key, value

[Piglit] [PATCH] Fix concurrency bug.

2013-12-24 Thread Dylan Baker
. bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=73018 CC: v...@freedesktop.org Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/core.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/framework/core.py b/framework/core.py index c8dc4bc..559bce6 100644

[Piglit] [PATCH] cmake: Suppress warning on cmake 2.8.12+

2013-12-28 Thread Dylan Baker
cmake 2.8.12 Introduced a new policy (CMP0022). Because there are two policy options and piglit doesn't explicitly ask for one it defaults to the OLD setting, but spews warnings. By setting OLD explicitly this warning goes away. Signed-off-by: Dylan Baker baker.dyla...@gmail.com

Re: [Piglit] [PATCH] Simplify piglit threading

2014-01-08 Thread Dylan Baker
On Tue, Jan 7, 2014 at 5:01 PM, Kenneth Graunke kenn...@whitecape.orgwrote: On 01/03/2014 06:07 AM, Dylan Baker wrote: This patch simplifies threading in piglit by removing the hand-rolled threadpool, and instead using the Pool class from multiprocessing.dummy. This provides a map

[Piglit] [Patch V2] Simplify piglit threading

2014-01-08 Thread Dylan Baker
of processes. V2: - Renamed run() helper to test() - use multiprocessing.dummy.Pool() default thread count value, which is equal to multiproccessing.cpu_count(), instead of cpu_count() explicitly cc: Kenneth Graunke kenn...@whitecape.org Signed-off-by: Dylan Baker baker.dyla

Re: [Piglit] [PATCH] Simplify piglit threading

2014-01-08 Thread Dylan Baker
On Wednesday, January 08, 2014 02:16:39 PM Dylan Baker wrote: On Tue, Jan 7, 2014 at 5:01 PM, Kenneth Graunke kenn...@whitecape.orgwrote: On 01/03/2014 06:07 AM, Dylan Baker wrote: This patch simplifies threading in piglit by removing the hand-rolled threadpool, and instead using

[Piglit] [Patch v2 06/13] Rename all tests files from .tests to .py

2014-01-08 Thread Dylan Baker
This patch renames the .tests files to .py files; which is required for the python interpreter to allow importing them. --- CMakeLists.txt| 2 +- README| 25 +++-- tests/{all.tests = all.py} | 0

[Piglit] [Patch v2 12/13] tests/r500.py use import instead of execfile

2014-01-08 Thread Dylan Baker
Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- tests/r500.py | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/r500.py b/tests/r500.py index 57b80ce..a47cb8e 100644 --- a/tests/r500.py +++ b/tests/r500.py @@ -2,14 +2,10 @@ # Testing the r500 DRI driver

[Piglit] [Patch v2 05/13] tests/all.py: load glean glsl, frag, and vert tests internally

2014-01-08 Thread Dylan Baker
they will not be importable. V2: - rename glean_glsl1_tests to glean_glsl_tests - rename glean_frag_tests to glean_fp_tests - rename glean_vert_Tests to glean_vp_tests - split removal of blacklist out of this patch Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- tests/all.tests

[Piglit] [Patch v2 02/13] Add support to load multiple test profiles

2014-01-08 Thread Dylan Baker
-by: Dylan Baker baker.dyla...@gmail.com --- framework/core.py | 32 piglit-resume.py | 2 +- piglit-run.py | 5 +++-- 3 files changed, 36 insertions(+), 3 deletions(-) diff --git a/framework/core.py b/framework/core.py index 8bcda5b..390474e 100644

[Piglit] [Patch v2 04/13] tests/all.tests: Remove unused blacklist feature

2014-01-08 Thread Dylan Baker
This feature is never used (nor does it seem like it should ever have been used), so lets get rid of it. V2: - split this out of the next patch --- tests/all.tests | 9 - 1 file changed, 9 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 38c0f5d..51bff5e 100644 ---

[Piglit] [Patch v2 01/13] *.tests: set __all__ = ['profile']

2014-01-08 Thread Dylan Baker
This makes the only publicly declared object in the .tests files the profile object. This is groundwork for importing the profile rather than running it via execfile(). Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- tests/all.tests| 2 ++ tests/all_cl.tests | 2 ++ tests

[Piglit] [Patch v2 11/13] tests/r300.py: use import instead of execfile

2014-01-08 Thread Dylan Baker
Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- tests/r300.py | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/r300.py b/tests/r300.py index e7c2209..32f940e 100644 --- a/tests/r300.py +++ b/tests/r300.py @@ -2,14 +2,10 @@ # Testing the r300 DRI driver

[Piglit] [Patch v2 03/13] all.tests: Remove execfile(es3conform.tests)

2014-01-08 Thread Dylan Baker
This option is now redundant, since it can be given explicitely at the commandline. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- tests/all.tests | 5 - 1 file changed, 5 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index b09340d..38c0f5d 100644 --- a/tests/all.tests

[Piglit] [Patch v2 13/13] core.py: rewrite loadTestProfile to remove execfile()

2014-01-08 Thread Dylan Baker
. Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/core.py | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/framework/core.py b/framework/core.py index b06c841..ee650e1 100644 --- a/framework/core.py +++ b/framework/core.py @@ -38,6 +38,7

[Piglit] [PATCH] log: Replace console output with a simpler output

2014-01-09 Thread Dylan Baker
system 295% cpu 8:06.35 total With this patch: ./piglit-run.py -c tests/quick.tests foo 1045.33s user 353.20s system 315% cpu 7:23.56 total Signed-off-by: Dylan Baker baker.dyla...@gmail.com --- framework/core.py | 23 +++-- framework/log.py | 78

[Piglit] [Patch V3] Simplify piglit threading

2014-01-09 Thread Dylan Baker
-by: Dylan Baker baker.dyla...@gmail.com --- framework/core.py | 54 +-- framework/threadpool.py | 67 - 2 files changed, 30 insertions(+), 91 deletions(-) delete mode 100644 framework/threadpool.py diff --git

<    1   2   3   4   5   6   7   8   9   10   >