[Piglit] [PATCH 10/10] MSAA/formats: fix testing A, L, LA, and I integer formats

2014-03-15 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/spec/ext_framebuffer_multisample/formats.cpp | 14 +++- tests/util/piglit-util-gl-common.h | 1 + tests/util/piglit-util-gl.c| 87 ++ 3 files changed, 100 insertions(+), 2 deletions

[Piglit] [PATCH 08/10] fbo-generatemipmap-3d: new test for 3D mipmap generation

2014-03-15 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.py | 2 + tests/fbo/CMakeLists.gl.txt | 1 + tests/fbo/fbo-generatemipmap-3d.c | 308 ++ 3 files changed, 311 insertions(+) create mode 100644 tests/fbo/fbo-generatemipmap-3d.c

[Piglit] [PATCH 07/10] fbo-generatemipmap-1d: new test for mipmap generation of 1D textures

2014-03-15 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.py | 2 + tests/fbo/CMakeLists.gl.txt | 1 + tests/fbo/fbo-generatemipmap-1d.c | 244 ++ 3 files changed, 247 insertions(+) create mode 100644 tests/fbo/fbo-generatemipmap-1d.c

[Piglit] [PATCH 01/10] Remove asmparsertest/shaders/ARBvp1.0/address-06.txt

2014-03-15 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com This test cannot pass with Mesa because Mesa allows greater relative offsets, because some apps use them and proprietary drivers allow them too. --- tests/all.py| 1 - tests/asmparsertest/shaders/ARBvp1.0/address-06

[Piglit] [PATCH 09/10] all.py: remove colorbuffer tests for GL_RGB9_E5

2014-03-15 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com The format is not color-renderable according to GL4.4 and EXT_texture_shared_exponent. --- tests/all.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/all.py b/tests/all.py index 6082c0a..76e2760 100644 --- a/tests/all.py +++ b

[Piglit] [PATCH 03/10] arb_vertex_program/minmax: fix fragment program limit checking

2014-03-15 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/spec/arb_vertex_program/minmax.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/spec/arb_vertex_program/minmax.c b/tests/spec/arb_vertex_program/minmax.c index ce87cf9..4244122 100644 --- a/tests/spec

[Piglit] [PATCH 06/10] fbo-generatemipmap-cubemap: new test for cubemaps and cube arrays

2014-03-15 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.py | 6 + tests/fbo/CMakeLists.gl.txt| 1 + tests/fbo/fbo-generatemipmap-cubemap.c | 499 + 3 files changed, 506 insertions(+) create mode 100644 tests/fbo/fbo

[Piglit] [PATCH 04/10] arb_internalformat_query/api-errors: SNORM is color-renderable, RGB9_E5 isn't

2014-03-15 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/spec/arb_internalformat_query/api-errors.c | 25 +--- 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/tests/spec/arb_internalformat_query/api-errors.c b/tests/spec/arb_internalformat_query/api-errors.c index

[Piglit] [PATCH 05/10] fbo-generatemipmap-array: test a non-renderable and a compressed format

2014-03-15 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com This extends the test to test _mesa_generate_mipmap (software fallback). --- tests/all.py | 4 +- tests/fbo/fbo-generatemipmap-array.c | 129 ++- 2 files changed, 116 insertions(+), 17 deletions

[Piglit] [PATCH 2/2] edgeflag-const: test constant (zero-stride) edge flag

2014-03-05 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.py| 1 + tests/spec/gl-1.0/CMakeLists.gl.txt | 1 + tests/spec/gl-1.0/edgeflag-const.c | 87 + 3 files changed, 89 insertions(+) create mode 100644 tests/spec/gl-1.0/edgeflag

[Piglit] [PATCH] glsl-resource-not-bound: test rendering with unbound resources

2014-02-06 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.py| 13 +++ tests/spec/gl-3.2/CMakeLists.gl.txt | 1 + tests/spec/gl-3.2/glsl-resource-not-bound.c | 152 3 files changed, 166 insertions(+) create mode 100644 tests/spec

[Piglit] [PATCH] bufferstorage-persistent: new test for ARB_buffer_storage

2014-01-29 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com I hacked up the glapi support, because spec files with this extension don't exist. --- glapi/enumext.spec | 5 + glapi/gl.spec | 19 ++ tests/all.py| 11

Re: [Piglit] How to use Piglit ?

2014-01-26 Thread Marek Olšák
./piglit-run.py tests/quick.tests results/first-run If your X is crashing like mine, you can exclude some GLX tests using the -x option: ./piglit-run.py -x makeCurrent -x GLX_EXT_import_context tests/quick.tests results/first-run Once it's done, create an html summary: ./piglit-summary-html.py

Re: [Piglit] [PATCH 1/2] max-samplers: Specify a RGBA color rather than RGB.

2014-01-19 Thread Marek Olšák
in and of itself, but will allow me to use the unique color for the border color in the next patch. Cc: Marek Olšák mar...@gmail.com Cc: Chris Forbes chr...@ijw.co.nz Cc: Ian Romanick i...@freedesktop.org Signed-off-by: Kenneth Graunke kenn...@whitecape.org --- tests/texturing/max-samplers.c | 5 +++-- 1

Re: [Piglit] [PATCH 2/2] max-samplers: Add a mode that samples the border color.

2014-01-19 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Sun, Jan 19, 2014 at 4:54 AM, Kenneth Graunke kenn...@whitecape.org wrote: Intel hardware has an awkward limit where the index into the sampler state table is represented by a 4-bit value, so the only possible indices

[Piglit] [PATCH] fbo-drawbuffers-none: test drawbuffer configurations with GL_NONE

2014-01-08 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.tests| 8 + .../spec/arb_framebuffer_object/CMakeLists.gl.txt | 1 + .../arb_framebuffer_object/fbo-drawbuffers-none.c | 444 + 3 files changed, 453 insertions(+) create mode 100644

Re: [Piglit] [PATCH] gl-3.2-depth-tex-sampling: fix the test to expect red depth samples

2013-12-22 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Sun, Dec 22, 2013 at 2:56 PM, Brian Paul bri...@vmware.com wrote: I missed the language in section 3.8.7 about depth texture sampling. Thanks, Marek. --- tests/spec/gl-3.2/depth-tex-sampling.c | 28 +++- 1 file

Re: [Piglit] [PATCH] gl-3.2-depth-tex-sampling: test OpenGL 3.2 core depth texture sampling

2013-12-21 Thread Marek Olšák
This test is wrong. The section 3.8.7 (page 160) of the GL 3.2 core specification says: Depth textures and the depth components of depth/stencil textures can be treated as RED textures during texture filtering and application (see section 3.8.15). The initial state for depth and depth/stencil

[Piglit] glBlitFramebuffer and sRGB vs piglit

2013-12-15 Thread Marek Olšák
Hi everybody, There is an inconsistence in the piglit glBlitFramebuffer tests. If both src and dst are sRGB, piglit expects this from glBlitFramebuffer: if (dst.num_samples == 1 src.num_samples 1) { enable the sRGB-linear conversion for src reads and the linear-sRGB conversion for dst

Re: [Piglit] [PATCH 14/16] msaa: Verify accuracy of sRGB MSAA resolves.

2013-12-09 Thread Marek Olšák
On Fri, Jun 15, 2012 at 5:32 PM, Paul Berry stereotype...@gmail.com wrote: From the GL spec, version 4.2, section 4.1.11 (Additional Multisample Fragment Operations): If a framebuffer object is not bound, after all operations have been completed on the multisample buffer, the sample

[Piglit] [PATCH] ext_framebuffer_multisample: fix sRGB MSAA resolve tests

2013-12-07 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com When measuring accuracy, converting the values to the linear colorspace increased the RMS error. Tested on Radeon with both shader-based and hardware-based resolve operations. --- tests/spec/ext_framebuffer_multisample/common.cpp | 21

Re: [Piglit] [PATCH] Test that sRGB-related blits are allowed and do not do encoding/decoding.

2013-12-07 Thread Marek Olšák
On Tue, Sep 25, 2012 at 1:35 AM, Paul Berry stereotype...@gmail.com wrote: The behaviour specified by OpenGL for blits involving sRGB is self-contradictory--it is unclear whether blits should perform sRGB encoding/decoding, and if so, whether this encoding/decoding should be dependent upon the

[Piglit] [PATCH 1/3] clearbuffer-display-lists: GL_BACK_is not allowed as drawbuffer

2013-12-05 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com Only 0 to MAX_DRAW_BUFFERS-1 is allowed. If you want to clear GL_BACK, call glDrawBuffers(GL_BACK) and then glClearBuffer(GL_COLOR, 0, ..). --- tests/spec/gl-3.0/api/clearbuffer-display-lists.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[Piglit] [PATCH 2/3] gl30basic: test glClearBuffer(GL_COLOR), use piglit API

2013-12-05 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com This adds testing of GL_FRONT, GL_BACK, and GL_FRONT_AND_BACK. --- tests/general/gl30basic.c | 84 ++- 1 file changed, 54 insertions(+), 30 deletions(-) diff --git a/tests/general/gl30basic.c b/tests/general

Re: [Piglit] [00/16] Enable concurrency for a lot of tests

2013-11-27 Thread Marek Olšák
It's here: http://cgit.freedesktop.org/~mareko/piglit Marek On Wed, Nov 27, 2013 at 11:07 PM, Dylan Baker baker.dyla...@gmail.com wrote: Is this on a public branch somewhere? I'd like to test this so we can land it. On Monday, November 25, 2013 12:52:19 AM Marek Olšák wrote: This series

[Piglit] [PATCH 08/16] all.tests: make some shader tests concurrent

2013-11-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.tests | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index f8e19d3..34f1705 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -265,21 +265,14

[Piglit] [PATCH 07/16] all.tests: make glsl-getactiveuniform-count tests concurrent

2013-11-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.tests | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 4ff7f29..f8e19d3 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -215,10 +215,8 @@ shaders = Group() def

[Piglit] [PATCH 01/16] fbo-clear-formats: fix the stencil clear test

2013-11-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com glBlitFramebuffer generates a GL error, good old glCopyPixels doesn't. --- tests/fbo/fbo-clear-formats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/fbo/fbo-clear-formats.c b/tests/fbo/fbo-clear-formats.c index 7a68f23

[Piglit] [PATCH 05/16] all.tests: make fbo-rg tests concurrent

2013-11-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.tests| 2 +- tests/fbo/fbo-rg.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 6959ea7..cb5a6b2 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -204,7 +204,7 @@ def

[Piglit] [00/16] Enable concurrency for a lot of tests

2013-11-24 Thread Marek Olšák
This series enables concurrency for about one half of non-concurrent tests. The time it takes to run all of quick.tests improved from 14.5 minutes to 11.7 minutes on my Core i5 quad-core. The tests which examine a specific behavior of the window framebuffer are not changed, because concurrency

[Piglit] [PATCH 12/16] all.tests: cleanups

2013-11-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.tests | 110 ++-- 1 file changed, 43 insertions(+), 67 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 5b5e562..8cee978 100644 --- a/tests/all.tests +++ b/tests/all.tests

[Piglit] [PATCH 02/16] all.tests: make fbo-depthstencil tests concurrent

2013-11-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.tests | 24 +--- tests/fbo/fbo-depthstencil.c | 1 + 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index c4ebfa7..9f0971e 100644 --- a/tests/all.tests +++ b

[Piglit] [PATCH 04/16] all.tests: make fbo format tests concurrent

2013-11-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.tests | 31 +++ tests/fbo/fbo-alphatest-formats.c | 3 ++- tests/fbo/fbo-blending-formats.c | 3 ++- tests/fbo/fbo-clear-formats.c | 10 -- tests/fbo/fbo-colormask-formats.c | 3

[Piglit] [PATCH 06/16] all.tests: make multisample-formats tests concurrent

2013-11-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.tests | 5 ++--- tests/spec/ext_framebuffer_multisample/common.cpp | 8 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index cb5a6b2..4ff7f29 100644

[Piglit] [PATCH 16/16] all.tests: make FBO tests concurrent

2013-11-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.tests | 134 +++ tests/fbo/fbo-1d.c | 1 + tests/fbo/fbo-3d.c | 1 + tests/fbo/fbo-alphatest-nocolor-ff.c | 1 + tests/fbo/fbo-alphatest

[Piglit] [PATCH 11/16] all.tests: make MSAA accuracy tests concurrent

2013-11-24 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/all.tests | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 777cb52..5b5e562 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -1832,9 +1832,9 @@ for num_samples

Re: [Piglit] [PATCH 1/2] summary: fix regression and fixes summaries

2013-11-20 Thread Marek Olšák
On Thu, Nov 21, 2013 at 12:04 AM, Dylan Baker baker.dyla...@gmail.com wrote: On Monday, November 18, 2013 03:33:33 PM Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com Somebody broke this. --- framework/status.py| 48 + framework/summary.py

Re: [Piglit] [PATCH 2/2] core: don't report warn if stderr is not empty

2013-11-19 Thread Marek Olšák
, November 19, 2013 02:57:33 AM Marek Olšák wrote: I don't understand your argument. This patch makes stderr to have no effect on test results, that is the only way to get warn is to have a test which actually returns PIGLIT_WARN. Marek On Tue, Nov 19, 2013 at 12:02 AM, Dylan Baker baker.dyla

[Piglit] [PATCH 2/2] core: don't report warn if stderr is not empty

2013-11-18 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com The usefulness of this is questionable to say the least. --- framework/core.py | 72 --- framework/exectest.py | 2 -- 2 files changed, 74 deletions(-) diff --git a/framework/core.py b/framework/core.py

[Piglit] [PATCH 1/2] summary: fix regression and fixes summaries

2013-11-18 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com Somebody broke this. --- framework/status.py| 48 + framework/summary.py | 6 ++--- framework/tests/summary.py | 66 -- 3 files changed, 44 insertions(+), 76 deletions

Re: [Piglit] [PATCH 2/2] core: don't report warn if stderr is not empty

2013-11-18 Thread Marek Olšák
:33:34 PM Marek Olšák wrote: From: Marek Olšák marek.ol...@amd.com The usefulness of this is questionable to say the least. --- framework/core.py | 72 --- framework/exectest.py | 2 -- 2 files changed, 74 deletions(-) diff --git

Re: [Piglit] [PATCH 3/6] dmesg: setup dmesg to be able to mark a test warn or fail

2013-11-15 Thread Marek Olšák
I'll gladly type --dmesg=radeon. I have my own script for running piglit anyway, which calls piglit-run and piglit-summary-html, and the result and summary directories are named $(date)_$(time)_$(GLrenderer)_$(test_filters), and it can do a couple of other things. Marek On Fri, Nov 15, 2013 at

Re: [Piglit] [PATCH 3/6] dmesg: setup dmesg to be able to mark a test warn or fail

2013-11-15 Thread Marek Olšák
Why not to have both? Marek On Fri, Nov 15, 2013 at 7:33 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Friday, November 15, 2013 06:28:41 PM Marek Olšák wrote: I'll gladly type --dmesg=radeon. I have my own script for running piglit anyway, which calls piglit-run and piglit-summary-html

Re: [Piglit] [PATCH 3/6] dmesg: setup dmesg to be able to mark a test warn or fail

2013-11-15 Thread Marek Olšák
with the effects of synchronization. On Fri, Nov 15, 2013 at 12:42 PM, Marek Olšák mar...@gmail.com wrote: Why not to have both? Marek On Fri, Nov 15, 2013 at 7:33 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Friday, November 15, 2013 06:28:41 PM Marek Olšák wrote: I'll gladly

Re: [Piglit] RFC enhance dmesg handling in piglit

2013-11-12 Thread Marek Olšák
Hi Dylan, I'd like to keep the dmesg-warn and dmesg-fail statuses. I use them to distinguish between failures caused by VM protection faults or lockups and failures reported by piglit tests. Marek On Tue, Nov 12, 2013 at 4:53 PM, Dylan Baker baker.dyla...@gmail.com wrote: This series cleans up

Re: [Piglit] RFC enhance dmesg handling in piglit

2013-11-12 Thread Marek Olšák
Do I have to define my own regexp? What if I don't want to filter anything, i.e. '.*'? Marek On Tue, Nov 12, 2013 at 8:07 PM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, Nov 12, 2013 at 7:53 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Tuesday, November 12, 2013 07:21:50 PM Daniel Vetter

Re: [Piglit] RFC enhance dmesg handling in piglit

2013-11-12 Thread Marek Olšák
Sounds good. Marek On Tue, Nov 12, 2013 at 10:55 PM, Daniel Vetter dan...@ffwll.ch wrote: On Tue, Nov 12, 2013 at 10:32:21PM +0100, Marek Olšák wrote: Do I have to define my own regexp? What if I don't want to filter anything, i.e. '.*'? I was more talking about the filtering out of debug

Re: [Piglit] [PATCH] GL_ARB_base_instance: Verify that the baseinstance setting does not affect the value of gl_InstanceID.

2013-11-06 Thread Marek Olšák
Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Tue, Nov 5, 2013 at 1:27 AM, Nicholas Mack nichm...@gmail.com wrote: --- tests/all.tests| 4 + tests/spec/CMakeLists.txt | 1 + tests/spec/arb_base_instance

[Piglit] [PATCH] gl-3.1/minmax: require at least 0 in GL_NUM_COMPRESSED_TEXTURE_FORMATS

2013-11-01 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/spec/gl-3.1/minmax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/spec/gl-3.1/minmax.c b/tests/spec/gl-3.1/minmax.c index 1128939..ea8c3a6 100644 --- a/tests/spec/gl-3.1/minmax.c +++ b/tests/spec/gl-3.1/minmax.c

[Piglit] [PATCH] gl-3.1/minmax: require at least 0 in GL_NUM_COMPRESSED_TEXTURE_FORMATS

2013-11-01 Thread Marek Olšák
From: Marek Olšák marek.ol...@amd.com --- tests/spec/gl-3.1/minmax.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/spec/gl-3.1/minmax.c b/tests/spec/gl-3.1/minmax.c index 1128939..c965ebe 100644 --- a/tests/spec/gl-3.1/minmax.c +++ b/tests/spec/gl-3.1/minmax.c

Re: [Piglit] [PATCH] Optionally capture dmesg changes for each test and report them in a summary

2013-09-20 Thread Marek Olšák
log. Marek On Wed, Sep 18, 2013 at 11:17 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Wednesday 18 September 2013 14:16:11 you wrote: From: Marek Olšák mar...@gmail.com The Radeon driver writes GPU page faults to dmesg and we need to know which test caused them. If there is any change

Re: [Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

2013-09-20 Thread Marek Olšák
I'll send a new patch, stay tuned. Marek On Fri, Sep 20, 2013 at 10:32 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Wednesday 18 September 2013 01:21:59 Marek Olšák wrote: On Wed, Sep 18, 2013 at 1:04 AM, Dylan Baker baker.dyla...@gmail.com wrote: On Wednesday 18 September 2013 00:48

[Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

2013-09-20 Thread Marek Olšák
The Radeon driver writes GPU page faults to dmesg and we need to know which tests caused them. If there is any change in dmesg during a test run, the test result is changed as follows: * pass - dmesg-warn * warn - dmesg-warn * fail - dmesg-fail Dmesg is captured before and after each test and the

[Piglit] [PATCH] texelFetch: test various texture dimensions

2013-09-19 Thread Marek Olšák
This is the ultimate test for validating texture allocation in the driver. texelFetch is a perfect test for it: it supports various texture targets, NPOT textures, and mipmapping. It's also our only test for NPOT 3D mipmapped textures. This commit adds support for testing various texture

Re: [Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

2013-09-17 Thread Marek Olšák
On Wed, Sep 18, 2013 at 1:04 AM, Dylan Baker baker.dyla...@gmail.com wrote: On Wednesday 18 September 2013 00:48:45 Marek Olšák wrote: On Tue, Sep 17, 2013 at 6:43 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Monday 16 September 2013 20:08:35 Marek Olšák wrote: The Radeon driver writes

Re: [Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

2013-09-17 Thread Marek Olšák
On Tue, Sep 17, 2013 at 6:43 PM, Dylan Baker baker.dyla...@gmail.com wrote: On Monday 16 September 2013 20:08:35 Marek Olšák wrote: The Radeon driver writes GPU page faults to dmesg and we need to know which test caused them. If there is any change in dmesg during a test run, the test result

[Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

2013-09-16 Thread Marek Olšák
The Radeon driver writes GPU page faults to dmesg and we need to know which test caused them. If there is any change in dmesg during a test run, the test result is changed as follows: * pass - dmesg-warn * warn - dmesg-warn * fail - dmesg-fail Dmesg is captured before and after the test and the

[Piglit] [PATCH 1/3] piglit-run: add back -c0

2013-09-16 Thread Marek Olšák
--- piglit-run.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/piglit-run.py b/piglit-run.py index e8e11b7..7945b21 100755 --- a/piglit-run.py +++ b/piglit-run.py @@ -62,7 +62,7 @@ def main(): action = append, metavar =

[Piglit] [PATCH 2/3] Merge quick-driver.tests to quick.tests

2013-09-16 Thread Marek Olšák
--- tests/quick-driver.tests | 14 -- tests/quick.tests| 6 ++ 2 files changed, 6 insertions(+), 14 deletions(-) delete mode 100644 tests/quick-driver.tests diff --git a/tests/quick-driver.tests b/tests/quick-driver.tests deleted file mode 100644 index f7c1a0f..000

Re: [Piglit] [PATCH 3/3] Optionally capture dmesg changes for each test and report them in a summary

2013-09-16 Thread Marek Olšák
... Will this throw ?false? positives as a result of DPM performance level changes on kernel 3.11+ (assuming dpm is enabled)? Is there any way to filter these messages out besides disabling DPM? --Aaron On Sep 16, 2013, at 1:08 PM, Marek Olšák mar...@gmail.com wrote: The Radeon driver writes

Re: [Piglit] [PATCH 1/2] texture-integer: fix issue with GL_RGB_INTEGER_EXT swizzle

2013-09-06 Thread Marek Olšák
Pushed, thanks. Marek On Wed, Sep 4, 2013 at 8:46 PM, Martin Andersson g02ma...@gmail.com wrote: Hi Marek, If there are no objections, maybe you could commit these patches? //Martin On Wed, Aug 28, 2013 at 12:25 PM, Marek Olšák mar...@gmail.com wrote: For the series: Reviewed-by: Marek

Re: [Piglit] [PATCH 1/2] texture-integer: fix issue with GL_RGB_INTEGER_EXT swizzle

2013-08-28 Thread Marek Olšák
For the series: Reviewed-by: Marek Olšák marek.ol...@amd.com Marek On Tue, Aug 13, 2013 at 11:24 PM, Martin Andersson g02ma...@gmail.com wrote: The expected alpha was set to zero instead of the random alpha value. The test passed for all random alpha values greater than zero, because

Re: [Piglit] Testing against undefined behaviour in asmparsertest/shaders/ARBvp1.0/address-06

2013-06-10 Thread Marek Olšák
If I'm reading the grammar correctly, the constant offset must be in the range [-64, 63]: addrRegRelOffset ::= | + addrRegPosOffset | - addrRegNegOffset addrRegPosOffset ::= integer from 0 to 63 addrRegNegOffset

[Piglit] [PATCH 3/5] Add -samples=n command-line argument forcing MSAA visuals

2013-06-01 Thread Marek Olšák
--- tests/util/piglit-framework-gl.c | 20 +++- tests/util/piglit-framework-gl.h |1 + .../piglit-framework-gl/piglit_fbo_framework.c |5 + .../piglit-framework-gl/piglit_glut_framework.c|5 +

[Piglit] [PATCH 5/5] all.tests: enable testing of MSAA visuals for a few selected tests

2013-06-01 Thread Marek Olšák
These tests have proved to be useful for implementing and fixing MSAA visuals. I also recommend the mesa/demos tests reflect and copypixrate to test front buffer MSAA rendering. --- tests/all.tests | 64 ++- 1 file changed, 40 insertions(+),

Re: [Piglit] [PATCH 2/5] read-front: modify the test to reproduce an MSAA front buffer bug in st/dri

2013-06-01 Thread Marek Olšák
Yes, that would reproduce the bug too. Marek On Sat, Jun 1, 2013 at 4:31 PM, Paul Berry stereotype...@gmail.com wrote: On 1 June 2013 05:38, Marek Olšák mar...@gmail.com wrote: --- tests/all.tests|1 + tests/general/read-front.c | 15 ++- 2 files changed, 15

Re: [Piglit] [PATCH 5/5] fbo-clear-formats: Return texture name as uint.

2013-05-09 Thread Marek Olšák
Thanks. I went ahead and pushed this commit. Marek On Fri, May 3, 2013 at 9:18 AM, Fabian Bieler fabianbie...@fastmail.fm wrote: --- tests/fbo/fbo-clear-formats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fbo/fbo-clear-formats.c

[Piglit] [PATCH] max-samplers: use the maximum number of textures in every shader

2013-05-08 Thread Marek Olšák
HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Authors: + * Marek Olšák mar...@gmail.com

Re: [Piglit] [PATCH] max-samplers: use the maximum number of textures in every shader

2013-05-08 Thread Marek Olšák
On Thu, May 9, 2013 at 1:16 AM, Brian Paul bri...@vmware.com wrote: +static const char *vs_source = + #define NUM %i \n + uniform sampler2D vertex_tex[NUM]; \n + uniform int vertex_index; + varying vec3 vertex_tex_color; \n + void main() \n + { \n +

Re: [Piglit] [PATCH] Rework the PIGLIT_GL_VISUAL flags, fix RGB vs RGBA vs ALPHA confusion

2013-04-12 Thread Marek Olšák
On Tue, Apr 2, 2013 at 7:16 PM, Chad Versace chad.vers...@linux.intel.comwrote: On Tue, Mar 26, 2013 at 06:13:59PM +0100, Marek Olšák wrote: Hi, would anyone like to comment on this? Or is it still stuck in the moderation queue? The hunk below will break Piglit on Windows and Mac. Comments

Re: [Piglit] [PATCH] Rework the PIGLIT_GL_VISUAL flags, fix RGB vs RGBA vs ALPHA confusion

2013-03-27 Thread Marek Olšák
The patch seems to be too large for a mailing list. It's here: http://cgit.freedesktop.org/~mareko/piglit/commit/?id=8fa85790a3e5a3caba3a6eba912e7858c893363b Marek On Wed, Mar 27, 2013 at 11:39 PM, Brian Paul bri...@vmware.com wrote: On 03/26/2013 11:13 AM, Marek Olšák wrote: Hi, would

[Piglit] [PATCH] fbo-blit: test BlitFramebuffer with GL_TEXTURE_RECTANGLE

2013-02-26 Thread Marek Olšák
--- tests/all.tests |1 + tests/fbo/fbo-blit.c | 22 +- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 2278026..9595070 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -1140,6 +1140,7 @@

Re: [Piglit] [PATCH] getteximage-formats: test GetTexImage after rendering to textures

2013-02-07 Thread Marek Olšák
On Thu, Feb 7, 2013 at 4:10 PM, Brian Paul bri...@vmware.com wrote: On 02/06/2013 05:06 PM, Marek Olšák wrote: This tests whether our GetTexImage doesn't actually rely on TexImage being called first. In this test, TexImage is not used to store data. --- tests/all.tests

[Piglit] [PATCH] getteximage-formats: test GetTexImage after rendering to textures

2013-02-06 Thread Marek Olšák
This tests whether our GetTexImage doesn't actually rely on TexImage being called first. In this test, TexImage is not used to store data. --- tests/all.tests |1 + tests/texturing/getteximage-formats.c | 75 + 2 files changed, 58

Re: [Piglit] [Mesa-dev] [PATCH] ext_framebuffer_multisample: check for num_samples=1

2013-01-28 Thread Marek Olšák
On Mon, Jan 28, 2013 at 4:54 PM, Brian Paul bri...@vmware.com wrote: [cross-posting this reply to the mesa-dev list] On 01/27/2013 09:07 AM, Brian Paul wrote: On Sun, Jan 27, 2013 at 2:51 AM, Eric Anholte...@anholt.net wrote: Brian Paulbri...@vmware.com writes: Even if

Re: [Piglit] [PATCH 5/3] fbo-alphatest-formats: Skip testing for ALPHA-only formats

2013-01-23 Thread Marek Olšák
I think it would be better to change the visual and the probes to RGBA and test alpha formats instead of skipping them. That said, I'm okay with committing this patch. Marek On Tue, Jan 22, 2013 at 10:59 PM, Carl Worth cwo...@cworth.org wrote: The test uses an RGB probe to determine whether a

Re: [Piglit] [PATCH 2/6] MSAA tests: port all GLSL shaders to GLSL 1.20

2013-01-15 Thread Marek Olšák
On Wed, Jan 9, 2013 at 8:57 PM, Paul Berry stereotype...@gmail.com wrote: On 6 January 2013 06:12, Marek Olšák mar...@gmail.com wrote: --- tests/spec/ext_framebuffer_multisample/common.cpp | 126 .../draw-buffers-common.cpp| 52

Re: [Piglit] [PATCH 1/3] fbo-blending-formats: Enable testing for channels with 0 bits of data.

2013-01-15 Thread Marek Olšák
On Wed, Jan 16, 2013 at 12:07 AM, Carl Worth cwo...@cworth.org wrote: Marek Olšák mar...@gmail.com writes: The series is: Reviewed-by: Marek Olšák mar...@gmail.com Thanks for the review, Marek. I hope other tests are not broken by this change in the util code. That's a good point. I do

[Piglit] [PATCH 1/3] all.tests: split a plain test name into an array of arguments

2013-01-14 Thread Marek Olšák
--- tests/all.tests |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 7053989..2a99fc8 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -37,8 +37,8 @@ def add_single_param_test_set(group, name, *params): for param in

[Piglit] [PATCH 2/3] fbo-drawbuffers: test masked clear

2013-01-14 Thread Marek Olšák
--- tests/all.tests |1 + tests/fbo/fbo-drawbuffers.c | 40 +--- 2 files changed, 34 insertions(+), 7 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index 2a99fc8..f719f7c 100644 --- a/tests/all.tests +++ b/tests/all.tests @@

[Piglit] [PATCH 3/3] fbo-drawbuffers2-color: test masked clear

2013-01-14 Thread Marek Olšák
--- tests/all.tests|1 + tests/fbo/fbo-drawbuffers2-colormask.c | 19 +-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/tests/all.tests b/tests/all.tests index f719f7c..514b1cb 100644 --- a/tests/all.tests +++ b/tests/all.tests @@

Re: [Piglit] [PATCH 1/3] fbo-blending-formats: Enable testing for channels with 0 bits of data.

2013-01-14 Thread Marek Olšák
The series is: Reviewed-by: Marek Olšák mar...@gmail.com I hope other tests are not broken by this change in the util code. Marek On Mon, Jan 14, 2013 at 11:30 PM, Carl Worth cwo...@cworth.org wrote: The existing code is intentionally disabling testing for channels with 1 bit of data, (since

[Piglit] [PATCH 1/6] all.tests: test 6x MSAA

2013-01-06 Thread Marek Olšák
This mode is supported by R300-R500 GPUs. --- tests/all.tests |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/all.tests b/tests/all.tests index 7053989..19c9002 100644 --- a/tests/all.tests +++ b/tests/all.tests @@ -68,7 +68,7 @@ except SystemExit: pass #

[Piglit] [PATCH 3/6] MSAA tests: don't use glClearBuffer

2013-01-06 Thread Marek Olšák
--- tests/spec/ext_framebuffer_multisample/common.cpp |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/spec/ext_framebuffer_multisample/common.cpp b/tests/spec/ext_framebuffer_multisample/common.cpp index 9109b86..b467c27 100644 ---

[Piglit] [PATCH 4/6] ext_framebuffer_multisample/formats: only create GLSL 1.30 shaders with GL3

2013-01-06 Thread Marek Olšák
--- tests/spec/ext_framebuffer_multisample/formats.cpp | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tests/spec/ext_framebuffer_multisample/formats.cpp b/tests/spec/ext_framebuffer_multisample/formats.cpp index 1947c48..13840e1 100644 ---

[Piglit] [PATCH 5/6] ext_framebuffer_multisample/formats: don't try invalid renderbuffer formats

2013-01-06 Thread Marek Olšák
--- tests/spec/ext_framebuffer_multisample/formats.cpp |5 + 1 file changed, 5 insertions(+) diff --git a/tests/spec/ext_framebuffer_multisample/formats.cpp b/tests/spec/ext_framebuffer_multisample/formats.cpp index 13840e1..8ef6c7f 100644 ---

[Piglit] [PATCH 0/6] Porting MSAA tests to GL 2.1

2013-01-06 Thread Marek Olšák
Since we now have a GL 2.1 driver with MSAA support - r300g, I had to port most MSAA tests to GL 2.1, while not affecting the tests that *really* need GL 3. I have verified that the expected and reported precision of the accuracy tests wasn't changed, even though I had to rewrite some GLSL code

Re: [Piglit] Deleting ~20% of glean/no more directory spam

2013-01-01 Thread Marek Olšák
These tests aren't sufficiently covered by piglit tests and should be kept: - fragProg1 (our main test for ARB_fragment_program, the piglit tests aren't so useful as this one) - paths (the only test for polygon stippling apart from pbo?) - pbo - stencil2 (tests glStencilMaskSeparate) - vertProg1

[Piglit] [PATCH] getteximage-targets: test glGetTexImage with all texture targets (v2)

2013-01-01 Thread Marek Olšák
-targets.c @@ -0,0 +1,221 @@ +/* + * Copyright © 2012 Marek Olšák mar...@gmail.com + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the Software), + * to deal in the Software without restriction, including without

Re: [Piglit] [PATCH 1/2] getteximage-targets: test glGetTexImage with all texture targets

2012-12-22 Thread Marek Olšák
On Sat, Dec 22, 2012 at 9:25 AM, Eric Anholt e...@anholt.net wrote: Marek Olšák mar...@gmail.com writes: The subject says all texture targets, but how about texture rectangles? (Not that they're really different from the getteximage implementation perspective) Ah, I forgot about texture

[Piglit] [PATCH 1/2] getteximage-targets: test glGetTexImage with all texture targets

2012-12-21 Thread Marek Olšák
/getteximage-targets.c b/tests/texturing/getteximage-targets.c new file mode 100644 index 000..64b7e78 --- /dev/null +++ b/tests/texturing/getteximage-targets.c @@ -0,0 +1,220 @@ +/* + * Copyright © 2012 Marek Olšák mar...@gmail.com + * + * Permission is hereby granted, free of charge, to any

[Piglit] [PATCH 2/2] copyteximage: test packed depth stencil formats

2012-12-21 Thread Marek Olšák
--- tests/texturing/copyteximage.c | 35 ++- 1 file changed, 30 insertions(+), 5 deletions(-) diff --git a/tests/texturing/copyteximage.c b/tests/texturing/copyteximage.c index f388ed2..43b8daa 100644 --- a/tests/texturing/copyteximage.c +++

[Piglit] [PATCH] ext_framebuffer_multisample: report SKIP if the FBO is unsupported

2012-12-21 Thread Marek Olšák
Why it reports FAIL in that case is beyond me. R6xx doesn't support integer formats and R11G11B10 for MSAA rendering. --- tests/spec/ext_framebuffer_multisample/common.cpp | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git

[Piglit] [PATCH] glean/pointAtten: test fewer combinations, don't call glFinish

2012-12-12 Thread Marek Olšák
Before: PASS: 87750 antialiased combinations tested. PASS: 87750 aliased combinations tested. real 0m16.731s user 0m4.988s sys0m8.632s After: PASS: 17550 antialiased combinations tested. PASS: 17550 aliased combinations tested. real 0m2.910s user 0m0.880s sys

Re: [Piglit] [ANNOUNCE] waffle-1.2.2

2012-11-28 Thread Marek Olšák
On Wed, Nov 28, 2012 at 7:26 PM, Chad Versace chad.vers...@linux.intel.com wrote: On 11/27/2012 07:47 PM, Marek Olšák wrote: HI Chad, FYI, the core GL support in the GLX backend of waffle and/or piglit seems to be broken. All piglit tests that specify the core GL version and are run

Re: [Piglit] [ANNOUNCE] waffle-1.2.2

2012-11-28 Thread Marek Olšák
On Wed, Nov 28, 2012 at 8:42 PM, Chad Versace chad.vers...@linux.intel.com wrote: On 11/28/2012 10:40 AM, Marek Olšák wrote: On Wed, Nov 28, 2012 at 7:26 PM, Chad Versace chad.vers...@linux.intel.com wrote: On 11/27/2012 07:47 PM, Marek Olšák wrote: HI Chad, FYI, the core GL support

Re: [Piglit] [PATCH 5/5] textureSize: Add support for running with core GL.

2012-11-23 Thread Marek Olšák
Hi Eric, this patch breaks textureSize on drivers which fail to create a 3.1 core context. The test fails with the GLXBadFBConfig error. I'm using waffle. Marek On Thu, Nov 1, 2012 at 7:36 PM, Eric Anholt e...@anholt.net wrote: This lets the textureSize tests for TBOs run on i965. ---

Re: [Piglit] [PATCH] texture-integer-glsl130: Expect 1 for alpha in R, RG, RGB cases.

2012-11-22 Thread Marek Olšák
On Thu, Nov 22, 2012 at 2:57 PM, Marek Olšák mar...@gmail.com wrote: The test fails because it's wrong. The expected integer alpha is 1, but the bias is a large negative value, therefore (a - bias) is always = 0, so the test always fails. Correction: bias is a negative value, therefore (alpha

Re: [Piglit] [PATCH 2/2] glx: Replace glFlush calls with glFinish

2012-11-19 Thread Marek Olšák
I think glFenceSync+glFlush in one context and glWaitSync (server-side synchronization) in the other context would be the best solution. It shouldn't block the CPU, but it should set the right ordering of commands. glFinish seems to be overkill. Marek On Mon, Nov 19, 2012 at 10:27 PM, Eric

Re: [Piglit] [PATCH] util: Fix visual selection when using waffle

2012-11-05 Thread Marek Olšák
-texelFetchOffest-2D. Reported-by: Marek Olšák mar...@gmail.com Signed-off-by: Chad Versace chad.vers...@linux.intel.com --- tests/util/piglit-framework-gl.h | 8 tests/util/piglit-framework-gl/piglit_winsys_framework.c | 11 +-- 2 files changed, 13

<    1   2   3   4   5   6   >