Re: [Piglit] [PATCH] arb_program_interface_query: fix array of arrays case

Hi, > On 21/08/18 21:38, asimiklit.w...@gmail.com wrote: > > From: Andrii Simiklit > > > According to spec: >"For an active variable declared as an array of an aggregate data type > (structures or arrays), a separate entry will be generated for each > active array element, unless

Re: [Piglit] [PATCH] Add a test for instanced GS inputs.

Hello, Thanks for review) Regards, Andrii. On Wed, Jun 27, 2018 at 6:18 AM, Timothy Arceri wrote: > On 22/06/18 18:36, andrii.simiklit wrote: > >> Hello, >> >> It would be great If somebody could take a look this test) >> This test against following bug: >>

Re: [Piglit] [PATCH] egl: doesn't allow egl to create a forward-compatible context with req ver < 3

Hello, Thanks for reviewing. Please find my comments below: (I will be on vacation from 13.10.2018 till 20.10.2018. I can't say for sure that I will have a time to finish it today :-) ) On Thu, Oct 11, 2018 at 7:55 PM Matt Turner wrote: > Hello, > > Thanks for the patch. > > I notice that

Re: [Piglit] [PATCH] glsl/frexp: fix the incorrect expected values

Hello, Thanks a lot for reviewing. Regards, Andrii. On Fri, Oct 26, 2018 at 3:23 PM Haehnle, Nicolai wrote: > On 24.10.18 14:52, asimiklit.w...@gmail.com wrote: > > From: Andrii Simiklit > > > > I guess that this test has the incorrect expected values. > > For instance the test expects that

Re: [Piglit] [PATCH] glsl/frexp: fix the incorrect expected values

Hello, Could you please help me with a push. Thanks, Andrii. On Fri, Oct 26, 2018 at 5:50 PM andrey simiklit wrote: > Hello, > > Thanks a lot for reviewing. > > Regards, > Andrii. > > On Fri, Oct 26, 2018 at 3:23 PM Haehnle, Nicolai > wrote: > >> On 24.1

Re: [Piglit] [PATCH] miptree: test ability to use upside down miptree

Hi all, Have somebody some suggestions for this test? This patch is needed to test an issue (assertion in mesa) which will be fixed by this mesa patch: https://patchwork.freedesktop.org/patch/254397/ Regards, Andrii. On Tue, Oct 23, 2018 at 4:44 PM wrote: > From: Andrii Simiklit > > Test

Re: [Piglit] [PATCH] glsl/frexp: fix the incorrect expected values

Hello, Thanks a lot Andrii. On Mon, Nov 5, 2018 at 11:03 PM Marek Olšák wrote: > Pushed, thanks! > > Marek > > On Wed, Oct 31, 2018 at 7:35 AM andrey simiklit > wrote: > >> Hello, >> >> Could you please help me with a push. >> >> Thank

Re: [Piglit] [PATCH v2] egl: doesn't allow egl to create a forward-compatible context with req ver < 3

Hello, Any updates here? :-) This test is needed to check issue which should be fixed by the following mesa patch: https://patchwork.freedesktop.org/patch/256063/ This issue mentioned in this bug by Ian Romanick : https://bugzilla.freedesktop.org/show_bug.cgi?id=92552#c9 Regards, Andrii. On

Re: [Piglit] [PATCH] i965/glsl: don't add unused aoa elements to the program resource list

Hi all, Sorry wrong mailing list. Just ignore this message. Regards, Andrii. On Fri, Aug 31, 2018 at 5:08 PM wrote: > From: Andrii Simiklit > > It fixes a bit incorrectly implemented ARB_program_interface_query. > If input aoa element is unused in shader program > the

Re: [Piglit] [PATCH v2] miptree: test ability to use upside down miptree

Hello, I will fix it. Thanks for review. Regards, Andrii. On Tue, Dec 11, 2018 at 5:04 PM Emil Velikov wrote: > Hi Andrii, > > Pardon for joining so late. The patch looks ok, although a few bits I'm > unsure > about - see the "Note" below. > > There's a bunch of cosmetic suggestions as well -

Re: [Piglit] [PATCH v2] miptree: test ability to use upside down miptree

ubsequent mesa patch is pushed, we track the > resolution. The process gives us artifacts in git that help to analyze > driver differences between stable releases. > > -Mark > > andrey simiklit writes: > > > Hello, > > > > If this patch is acceptable by

Re: [Piglit] [PATCH] miptree: test ability to use upside down miptree

Hello, Thanks for review. I will fix all these issues and provide v2 shortly :) Thanks, Andrii. On Mon, Dec 3, 2018 at 12:37 PM Erik Faye-Lund wrote: > Just a few nits, do with them as you like. The test itself looks good > to me :) > > Reviewed-by: Erik Faye-Lund > > On Tue, 2018-10-23 at

Re: [Piglit] [PATCH] miptree: test ability to use upside down miptree

On Mon, Dec 3, 2018 at 1:50 PM Erik Faye-Lund wrote: > On Mon, 2018-12-03 at 13:31 +0200, andrey simiklit wrote: > > Hello, > > > > Thanks for review. > > I will fix all these issues and provide v2 shortly :) > > > > Thanks, > > Andrii. > >

Re: [Piglit] [PATCH] miptree: test ability to use upside down miptree

Hello, I think that I found one more issue (small but anyway issue) in my patch. The texture which is created in 'setup_texture' function is never released ( I would like to delete it at end of the 'piglit_display'. Regards, Andrii. On Mon, Dec 3, 2018 at 4:14 PM andrey simiklit wrote

Re: [Piglit] [PATCH v2] miptree: test ability to use upside down miptree

Hello, If this patch is acceptable by everybody then I guess that we need to push the following mesa patch before this one to avoid errors from Intel CI because the fix for an issue which is tested by this test is still there. https://patchwork.freedesktop.org/patch/254397/ One of the last

Re: [Piglit] [PATCH v2] miptree: test ability to use upside down miptree

ch. When the subsequent mesa patch is pushed, we track the > resolution. The process gives us artifacts in git that help to analyze > driver differences between stable releases. > > -Mark > > andrey simiklit writes: > > > Hello, > > > > If this patch is

Re: [Piglit] [PATCH] miptree: test ability to use upside down miptree

Hello, Could somebody take a look at this patch? Thanks a lot, Andrii. On Tue, Nov 6, 2018 at 12:33 PM andrey simiklit wrote: > Hi all, > > Have somebody some suggestions for this test? > This patch is needed to test an issue (assertion in mesa) which will be > fixed by

Re: [Piglit] [PATCH] program_interface_query: don't expect a valid location for TCS output

Hello, Thanks a lot for review. Regards, Andrii. On Tue, Nov 27, 2018 at 11:23 AM Tapani Pälli wrote: > Hi; > > On 10/31/18 5:05 PM, asimiklit.w...@gmail.com wrote: > > From: Andrii Simiklit > > > > I guess we should not expect a valid location for: > > "patch out vec4 tcs_patch;" > >

Re: [Piglit] [PATCH v3] miptree: test ability to use upside down miptree

Hello, Thanks for review. Could somebody help me with a push? @Emil: Yes, you are right about missing 'in-' in 'git send-email --in-reply-to='. So v3 wasn't added to the patchwork( Hope it isn't really mandatory and the push can be performed) Thanks, Andrii. On Fri, Jan 11, 2019 at 3:14 PM

Re: [Piglit] [PATCH v3] miptree: test ability to use upside down miptree

Hi all, Could somebody help me with a push if it is acceptable for everyone? Thanks, Andrii. On Wed, Dec 12, 2018 at 1:11 PM wrote: > From: Andrii Simiklit > > Test that usage of upside down miptree doesn't cause assertion > > The miptree: > > level 0 = 1x1 > level 1 = 2x2 > level 2 = 4x4 >

Re: [Piglit] [PATCH v3] miptree: test ability to use upside down miptree

On Mon, Jan 14, 2019 at 1:35 PM Emil Velikov wrote: > On Fri, 11 Jan 2019 at 15:28, andrey simiklit > wrote: > > > > Hello, > > > > Thanks for review. > > Could somebody help me with a push? > > > Done. > Thanks a lot. > > @Emil: > &g

Re: [Piglit] [PATCH] ARB_shader_storage_buffer_object: check ssbo array optimizations

Thanks for reviewing and push) Andrii. On Fri, Feb 22, 2019 at 8:25 PM Ian Romanick wrote: > I made a couple small adjustments to the tests and pushed them. > > Thanks! > > On 2/15/19 5:43 AM, asimiklit.w...@gmail.com wrote: > > From: Andrii Simiklit > > > > The tests for a compiler which

Re: [Piglit] [PATCH] primitive-restart: extend the test to catch regressions of bug-109451

ping On Fri, Feb 1, 2019 at 11:27 AM wrote: > From: Andrii Simiklit > > Looks like this test should be able to catch this kind of the regressions > os I add it here. > This test should draw green rectangle if everything is ok. > But in case of bug which makes us unable to disable > the

Re: [Piglit] [PATCH v2] primitive-restart: extend the test to catch regressions of bug-109451

Yes, it would be great. Thanks, Andrii. On Mon, Feb 18, 2019 at 4:03 PM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Do you need me to push this change? > > -Lionel > > On 18/02/2019 14:00, asimiklit.w...@gmail.com wrote: > > From: Andrii Simiklit > > > > Looks like this test

Re: [Piglit] [PATCH v2] primitive-restart: extend the test to catch regressions of bug-109451

I added the link. Thanks a lot for review) On Mon, Feb 18, 2019 at 4:00 PM wrote: > From: Andrii Simiklit > > Looks like this test should be able to catch this kind of the regressions > os I add it here. > This test should draw green rectangle if everything is ok. > But in case of bug which

Re: [Piglit] [PATCH v2] primitive-restart: extend the test to catch regressions of bug-109451

Thanks. On Mon, Feb 18, 2019 at 5:33 PM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Pushed. > > On 18/02/2019 14:05, andrey simiklit wrote: > > Yes, it would be great. > > Thanks, > Andrii. > > On Mon, Feb 18, 2019 at 4:03 PM Lionel Landwerl